overlookmotel
f3baa49662
feat(semantic): add SemanticBuilder::with_stats ( #5757 )
...
Add `SemanticBuilder::with_stats` method to optionally pass in a `Stats` object. If `Stats` are provided, `SemanticBuilder` skips the AST traversal.
2024-09-13 12:19:55 +00:00
overlookmotel
4b896f1494
refactor(semantic): make Stats Copy ( #5756 )
...
`Stats` type is small. Make it `Copy`.
2024-09-13 12:19:54 +00:00
overlookmotel
7fa0cb3861
feat(semantic): expose Stats ( #5755 )
...
Expose `Stats` type, and provide a method `Semantic::Stats` to obtain them.
Note: If we move counting into parser later, parser can use this same `Stats` type (we'd need to move it into `oxc_parser` or `oxc_ast` crate, but `oxc_semantic` can still re-export it.
2024-09-13 12:19:54 +00:00
overlookmotel
b4b460f425
refactor(semantic): Stats store counts as u32 ( #5754 )
...
These counts can never exceed `u32`, so reduce size of these fields.
2024-09-13 12:19:54 +00:00
overlookmotel
667170cbfc
refactor(semantic): rename Counts to Stats ( #5753 )
...
Pure refactor. Just rename the type.
2024-09-13 12:19:54 +00:00
Boshen
cc0408b5d4
refactor(semantic): s/AstNodeId/NodeId ( #5740 )
...
part of #5689
2024-09-13 03:00:00 +00:00
overlookmotel
7dfcdfced6
refactor(semantic): remove more-asserts dependency ( #5739 )
...
Remove `more-asserts` dependency which was added in #5710 .
As suggested by @Boshen in https://github.com/oxc-project/oxc/pull/5710#pullrequestreview-2299016692 .
2024-09-13 02:53:00 +00:00
IWANABETHATGUY
805fbac44c
feat(oxc_cfg): better control flow graph dot dot repr ( #5731 )
...
1. add basic block index for each basicblock, so there should no basic block display empty string
2. use `shape` box, since it is basic **block**
## Before
## After
2024-09-12 18:39:01 +00:00
overlookmotel
6436524ff1
refactor(semantic): fix dead code warning in release mode ( #5728 )
...
`Counts::assert_accurate` is only used in debug mode. Silence the dead code warning in release mode.
2024-09-12 13:33:57 +00:00
Boshen
4bdc202325
refactor(rust): remove some #[allow(unused)] ( #5716 )
2024-09-12 02:19:01 +00:00
overlookmotel
e02621d2d1
refactor(semantic): re-order use statements ( #5712 )
...
Pure refactor. Re-order `use` statements in `oxc_semantic` to follow this order:
1. `std`
2. External crates.
3. `oxc_*` crates.
4. Local crate.
5. `super`
6. `mod`
This is intended to be in order from "furthest above" to "furthest below".
2024-09-11 20:41:49 +00:00
overlookmotel
ac6203c891
refactor(semantic): move Counts code into counter module ( #5710 )
...
Pure refactor. Move code for counting nodes etc, and verifying counts, into `counter` module.
2024-09-11 20:41:48 +00:00
overlookmotel
339fcfc8be
refactor(semantic): rename Counts in transform checker ( #5709 )
...
Pure refactor. Just renaming.
2024-09-11 20:41:48 +00:00
overlookmotel
d8ec78192e
refactor(semantic): remove record_ast_node call for Program ( #5701 )
...
Remove a tiny bit of dead code from `SemanticBuilder`.
`record_ast_node` does nothing if `ast_node_records` is empty. It is always empty when visiting `Program`, so is a no-op.
2024-09-11 11:31:20 +00:00
overlookmotel
1857ff09eb
style(semantic): rename vars for node IDs ( #5699 )
...
`test_node_id` not `test_node` to better describe what these vars contain.
2024-09-11 10:55:42 +00:00
oxc-bot
a727ee8aca
release(oxc): crates v0.28.0 ( #5696 )
...
## [0.28.0] - 2024-09-11
- afc4548#5679 ) (Boshen)
- 7415e85#5678 ) (Boshen)
- ee4fb42#5677 ) (Boshen)
- 1fa3e56#5621 ) (overlookmotel)
- 96a1552#5620 ) (overlookmotel)
- 4a8aec1#5606 ) (Boshen)
- 603817b#5557 ) (Boshen)
- b060525#5553 ) (Boshen)
### Features
- 2da5ad1#5556 )
(overlookmotel)
- 2016bae#5676 )
(Boshen)
- 68c3cf5#5670 ) (Boshen)
- c6bbf94#5669 ) (Boshen)
- 86256ea#5666 ) (Boshen)
- e698418#5657 ) (Boshen)
- aba9194#5533 )
(underfin)
- 642295c#5558 ) (overlookmotel)
- b3cbd56#5610 ) (overlookmotel)
- 95a6d99#5630 ) (Dunqing)
- 7b543df#5638 ) (Dunqing)
- 17226dd#5559 )
(overlookmotel)
### Bug Fixes
- d62defb#5551 ) (Boshen)
- 1bc08e2#5579 ) (Boshen)
- 28b934c#5555 ) (Boshen)
- b9bf544#5681 ) (Dunqing)
- 6e8409a#5680 ) (Dunqing)
- b8f8dd6#5691 ) (Boshen)
- 304ce25#5692 ) (leaysgur)
- 0511d55#5661 ) (leaysgur)
- 41582ea#5635 ) (leaysgur)
- 28aad28#5631 ) (leaysgur)
- f9e3a41#5673 ) (Boshen)
- f49e6eb#5612 ) (Boshen)
- 919d17f#5589 ) (Boshen)
- 505d064#5560 ) (overlookmotel)
- 9b7ecc7#5508 ) (overlookmotel)
- d1ece19#5501 ) (overlookmotel)
- a1afd48#5695 ) (Dunqing)
- f2f5e5a#5693 ) (Dunqing)
- a891c31#5656 ) (Dunqing)
- 3e8b96f#5655 ) (Dunqing)
- 0739b5f#5642 ) (Dunqing)
- 3bf6aaf#5629 ) (Dunqing)
- 36d864a#5528 ) (Dunqing)
### Performance
- e8013d2#5626 )
(overlookmotel)
- 4996874#5611 )
(overlookmotel)
### Documentation
- fefbbc1#5539 )
(overlookmotel)
- 9282647#5514 ) (overlookmotel)
- 1c051ae#5607 ) (overlookmotel)
- 2e24a15#5604 ) (overlookmotel)
### Refactor
- 14ee086#5547 ) (overlookmotel)
- 2de6ea0#5650 )
(overlookmotel)
- 0ac420d#5564 )
(Don Isaac)
- 2da42ef#5665 ) (leaysgur)
- dec1395#5543 ) (leaysgur)
- 731ffaa#5686 )
(overlookmotel)
- 067f9b5#5672 ) (Boshen)
- d22a9b7#5622 )
(overlookmotel)
- 3d190a5#5609 )
(overlookmotel)
- 5532628ce71982#5554 )
(overlookmotel)
- 758a10c#5527 )
(overlookmotel)
- fad0a05#5504 )
(overlookmotel)
- 19cdcc5#5652 ) (overlookmotel)-
26d9235#5577 ) (夕舞八弦)
### Styling
- e52d006#5651 )
(overlookmotel)
- 97e99bd#5603 ) (overlookmotel)-
694f032#5542 )
(overlookmotel)
### Testing
- 2e367c9#5625 )
(overlookmotel)- dc92489#5541 ) (overlookmotel)
---------
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-09-11 17:57:55 +08:00
Dunqing
36d864a0c3
fix(transformer/react): don't transform if the variable does not have a value reference ( #5528 )
...
close : #4746
Solved the last two tests, but it's a coincidence. I've added a test to cover it.
2024-09-11 07:10:55 +00:00
overlookmotel
731ffaa00e
refactor(semantic): compare nodes by pointer equality ( #5686 )
...
Follow up after #5673 .
It's safer to compare nodes by pointer equality than by equality of `Span`s. Transformer can create multiple nodes of same type with same span.
Once nodes have node IDs, we can use them for comparison instead.
That said, `ptr::eq` is much cheaper, as it doesn't have to follow the pointers to check equality. https://godbolt.org/z/hsqaeKr5M
2024-09-11 02:12:12 +00:00
Boshen
f9e3a41dd2
fix(semantic): bind SymbolId to function name in if (foo) function id() {} ( #5673 )
2024-09-10 11:05:26 +00:00
Boshen
067f9b5a6f
refactor(semantic): introduce IsGlobalReference trait ( #5672 )
2024-09-10 10:12:08 +00:00
Boshen
86256ea238
feat(minifier): constant fold typeof ( #5666 )
...
closes #5628
2024-09-10 04:43:00 +00:00
overlookmotel
d22a9b72e0
refactor(semantic): SymbolTable::is_empty use is_empty ( #5622 )
...
Nit. `is_empty()` is sometimes more performant than `len() == 0`.
2024-09-09 01:07:34 +00:00
overlookmotel
1fa3e5687a
refactor(semantic)!: rename SymbolTable::iter to symbol_ids ( #5621 )
...
`symbol_ids` is a more descriptive name.
2024-09-09 01:07:33 +00:00
overlookmotel
96a15526aa
refactor(semantic)!: remove SymbolTable::iter_rev ( #5620 )
...
#5615 removed the only usage of this method, so it's now dead code.
2024-09-09 01:07:33 +00:00
Boshen
4a8aec1605
feat(span)!: change SourceType::js to SourceType::cjs and SourceType::mjs ( #5606 )
2024-09-08 14:11:02 +00:00
Boshen
63a830e08c
chore(dprint): format toml files ( #5599 )
...
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-09-08 14:26:16 +08:00
Boshen
603817bef9
feat(oxc)!: add SourceType::Unambiguous; parse .js as unambiguous ( #5557 )
...
See https://babel.dev/docs/options#misc-options for background on `unambiguous`
Once `SourceType::Unambiguous` is parsed, it will correctly set the returned `Program::source_type` to either `module` or `script`.
2024-09-07 10:48:58 +00:00
overlookmotel
642295c15a
feat(semantic): add SymbolTable::delete_resolved_reference method ( #5558 )
...
Add `SymbolTable::delete_resolved_reference` method to delete a reference for a symbol.
2024-09-07 03:51:35 +00:00
Don Isaac
0ac420d6f9
refactor(linter): use meaningful names for diagnostic parameters ( #5564 )
...
Also add `pending` fix labels to many rules.
2024-09-06 18:14:56 -04:00
Boshen
b06052501a
refactor(semantic)!: remove source_type argument from SemanticBuilder::new ( #5553 )
...
Realized we can get the source type from the AST.
The next PR will introduce `unambiguous` to `SourceType` and directly set `Program::source_type` to either `script` or `module`.
2024-09-06 16:40:10 +00:00
overlookmotel
dc924892cc
test: add trailing line breaks to conformance fixtures ( #5541 )
...
Continuation of #5537 . Ensure all conformance fixture files have a trailing line break.
2024-09-06 12:55:17 +00:00
oxc-bot
64eb2cccb7
release: crates v0.27.0 ( #5538 )
...
## [0.27.0] - 2024-09-06
- bd820f9#5480 ) (overlookmotel)
- cba93f5#5466 ) (overlookmotel)
- 87c5df2#5448 ) (overlookmotel)
### Features
- e8bdd12#5515 ) (overlookmotel)
- 90facd3#5451 ) (rzvxa)
- 23285f4#5427 ) (rzvxa)
- 59abf27#5256 ) (rzvxa)
- 68a1c01#5278 ) (rzvxa)
- c782916#5438 ) (Dunqing)
- 4cb63fe#5421 )
(IWANABETHATGUY)
- ba4b68c#5439 )
(Boshen)
- ed8ab6d#5524 )
(IWANABETHATGUY)
- 91b39c4#5474 )
(IWANABETHATGUY)
- 10279f5#5440 ) (Boshen)
- 0f50b1e#5463 ) (DonIsaac)
- 62f7fff#5461 ) (DonIsaac)
- 5407143#5460 ) (DonIsaac)
- 052e94c#5459 ) (DonIsaac)
- 32d4bbb#5495 )
(Boshen)
- c59d8b3#5387 ) (Dunqing)
- cedf7a4#5491 )
(IWANABETHATGUY)
### Bug Fixes
- 0df1d9d#5431 ) (rzvxa)
- fce549e#5526 ) (Boshen)
- ea7a52f9b984b3#5469 ) (rzvxa)
- 88b7ddb#5523 ) (leaysgur)
- 7a797ac#5525 ) (Dunqing)
- d8b9909#5441 ) (Dunqing)
- 8f9627d#5494 ) (overlookmotel)
- 2060efc#5486 ) (overlookmotel)
- cfe5497#5414 ) (overlookmotel)
- 0617249#5408 ) (Dunqing)
- 0eb32a6#5407 ) (Dunqing)- b96bea4#5507 ) (IWANABETHATGUY)
### Performance
- bfabd8f#5426 )
(overlookmotel)
- aeda84f#5425 ) (overlookmotel)
- ed8937e#5518 ) (Dunqing)
- bfab091#5484 )
(overlookmotel)
- b4765af#5483 ) (overlookmotel)
- 182ab91#5482 ) (overlookmotel)
### Documentation
- 64db1b4#5497 ) (overlookmotel)
- 3f204a9#5478 ) (overlookmotel)- 00511fd#5423 ) (IWANABETHATGUY)
### Refactor
- 9f6e0ed#5468 ) (rzvxa)
- a43e951#5447 ) (overlookmotel)
- 2224cc4#5464 ) (overlookmotel)
- a952c47#5449 ) (overlookmotel)
- d9d7e7c#5327 )
(overlookmotel)
- ccc8a27#5462 ) (rzvxa)
- fdb8857#5417 )
(rzvxa)
- e7bd49d#5429 ) (overlookmotel)
- e4ed41d#5444 ) (Dunqing)
- 94a6ac6#5476 ) (overlookmotel)
- b47aca0#5280 ) (rzvxa)
- a96866d#5499 ) (overlookmotel)
- 6abde0a#5498 )
(overlookmotel)
- 09c522a#5496 ) (overlookmotel)
- dd19823#5492 ) (overlookmotel)
- 2514cc9#5473 ) (Dunqing)
- c984219#5422 ) (Dunqing)
### Styling
- 2a43fa4#5491 and reduce
the if nesting (#5512 ) (dalaoshu)
### Testing
- 340b535#5510 ) (Don Isaac)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-09-06 19:06:29 +08:00
Dunqing
7a797ac635
fix(semantic): incorrect reference when MemberExpression used in TSPropertySignature ( #5525 )
...
close: https://github.com/oxc-project/oxc/issues/5435#issuecomment-2333032168
2024-09-06 06:24:45 +00:00
Boshen
1bed5ce2a5
chore: run cargo +nightly fmt to sort imports ( #5503 )
...
They are never going to be stable are they ... cedf7a4daa/.rustfmt.toml (L8-L16)
2024-09-06 04:04:26 +00:00
dalaoshu
2a43fa4efd
style(linter): introduce the writing style from PR #5491 and reduce the if nesting ( #5512 )
...
Related to #5491
2024-09-06 11:19:48 +08:00
Don Isaac
340b535715
test(linter/no-unused-vars): arrow functions in tagged templates ( #5510 )
...
Closes #5391
2024-09-05 14:55:39 -04:00
overlookmotel
bd820f9c16
refactor(semantic)!: remove SymbolTable::get_symbol_id_from_name and SymbolTable::get_scope_id_from_name ( #5480 )
...
Close #5456 .
2024-09-05 13:57:55 +00:00
Dunqing
e4ed41d4fa
refactor(semantic): change the reference flag to ReferenceFlags::Type if it is used within a TSTypeQuery ( #5444 )
...
So far, the `ReferenceFlags::TSTypeQuery` only used indicates it is referenced by `TSTypeQuery` that we can confirm the reference should be regarded as a type reference, namely `ReferenceFlags::Type`.
This PR adds a `ReferenceFlags::ValueAsType` instead of `ReferenceFlags::TSTypeQuery`. The new flag has the same behavior as the previous one. But it looks more general and is not only used in `TSTypeQuery`. But now it is a temporary flag. We use it to resolve the symbol correctly and replace `ReferenceFlags::ValueAsTyoe` with `ReferenceFlags::Type` after resolved.
Also, this change eliminates the inconsistency in behavior between the `Reference::is_type` and `ReferenceFlags::is_type` methods.
2024-09-05 01:50:20 +00:00
Dunqing
d8b9909bd8
fix(semantic): IdentifierReference within TSPropertySignature cannot reference type-only import binding ( #5441 )
...
close : #5435
The behavior of `IdentifierReference` in `TSPropertySignature` is the same as in `TSTypeQuery`, both allow only reference value bindings and type-only import bindings.
I still use `ReferenceFlags::TSTypeQuery` here because I want to avoid producing many changes unrelated to the bug in this PR. I will refactor it in the follow-up PR soon
2024-09-05 01:50:18 +00:00
DonIsaac
0f50b1ed6d
feat(semantic): check for initializers in ambient VariableDeclarations ( #5463 )
2024-09-05 01:33:11 +00:00
DonIsaac
62f7fff88f
feat(semantic): check for non-declared, non-abstract object accessors without bodies ( #5461 )
2024-09-05 01:33:10 +00:00
DonIsaac
540714393a
feat(semantic): check for non-declared, non-abstract class accessors without bodies ( #5460 )
...
This should be causing more negative tests to fail than it actually is. This is
because our typescript coverage tests use the "declarations" option to change
the source type to `.d.ts`, which is incorrect. This setting enables `.d.ts`
emits, it does not mean that input files should be treated as `.d.ts`
themselves.
2024-09-05 01:33:09 +00:00
DonIsaac
052e94c94e
feat(semantic): check for parameter properties in constructor overloads ( #5459 )
...
Adds checks for
```
A parameter property is only allowed in a constructor implementation.ts(2369)
```
2024-09-05 01:33:07 +00:00
oxc-bot
be1a6d4c84
Release crates v0.26.0 ( #5418 )
...
## [0.26.0] - 2024-09-03
- 1aa49af#5358 ) (Dunqing)
- 01cc2ce#5403 ) (Boshen)
- b1d0075#5398 ) (Boshen)
- 32f7300#5223 ) (Dunqing)
- 23e8456#5294 ) (overlookmotel)
- 582ce9e#5286 ) (overlookmotel)
- 234a24c#5270 ) (Kevin Deng 三咲智子)
- c100826#5110 ) (overlookmotel)
- d304d6f#5109 ) (overlookmotel)
### Features
- 180b1a1#5361 ) (DonIsaac)
- 5505749#5290 )
(Dunqing)
- 49cd5db#5182 ) (DonIsaac)
- c2fa725#5179 ) (DonIsaac)
- 292d162#5291 )
(Dunqing)
- 72740b3#5170 )
(dalaoshu)
- f81e8a1#5364 )
(DonIsaac)
- 9c22ce9#5318 )
(DonIsaac)
- d22bd20#5184 ) (Kevin Deng 三咲智子)
- 7dfd51a#5181 ) (DonIsaac)
- a563968#5180 )
(DonIsaac)
- 46b641b#5218 )
(leaysgur)
- be4642f#5410 )
(overlookmotel)
- 6e969f9#5305 ) (overlookmotel)
- 1b20ceb#5385 )
(Boshen)
- 5a137f0#5242 )
(DonIsaac)
- f5e05db#5240 ) (DonIsaac)
- d04857b#5336 )
(Dunqing)
- 3d4a64c#5335 ) (Dunqing)
- 0eb7602#5323 ) (Dunqing)
- 08dc0ad#3133 ) (magic-akari)
- 01c0c3e#5169 ) (Boshen)
- 056c667#5188 ) (Dunqing)
- 0abfc50#5399 ) (Dunqing)
### Bug Fixes
- 8ebc23f#5199 )
(Kevin Deng 三咲智子)
- 5c4c001#5303 ) (Boshen)
- 7b1546bff7fa98#5120 ) (Boshen)
- 8a17807#5343 ) (overlookmotel)
- d4c06ef#5297 ) (overlookmotel)
- e1d8b92e6fd52e#5285 ) (Boshen)
- 1686920#5225 ) (leaysgur)
- cffce11#5282 )
(leaysgur)
- 293413f#5161 ) (Dunqing)
- a6bb3b1#5239 ) (DonIsaac)
- 35f03db#5366 ) (Dunqing)
- 8d6b05c#5298 ) (Boshen)
- 47e69a8#5066 ) (Dunqing)
- 94ff94c#5356 ) (Dunqing)
- f8bb022#5190 ) (Dunqing)
- d9ba5ad#5189 )
(Dunqing)
- 3acb3f6#5255 ) (Dunqing)
- 5754c89#5292 ) (Dunqing)
- d594818#5409 ) (overlookmotel)
- 25d6e20#5118 ) (overlookmotel)
### Performance
- 292f217#5344 )
(overlookmotel)
- 12a7607#5221 ) (overlookmotel)
- fb847bd#5192 ) (Boshen)
- a1523c6#5412 ) (overlookmotel)
### Documentation
- 8334bd4#5337 ) (Dunqing)
- d51a954#5186 ) (Dunqing)
### Refactor
- c2d8c9e#5367 ) (overlookmotel)
- 946c867#5325 ) (overlookmotel)
- 960e1d5#5157 ) (overlookmotel)
- f63b568#5130 )
(overlookmotel)
- d4c3778#5222 ) (overlookmotel)
- 543cad6cd63336#5317 )
(DonIsaac)
- d236554#5345 ) (overlookmotel)
- bc59dd2#5234 )
(overlookmotel)
- a3ddfdd#5233 ) (overlookmotel)
- 3ae94b805d25e2#5262 ) (overlookmotel)
- fdedc0f#5261 ) (overlookmotel)
- 1086109#5260 ) (overlookmotel)
- af5713e#5259 ) (overlookmotel)
- 943454f#5252 ) (overlookmotel)
- 892a7fa#5253 ) (overlookmotel)
- cbb4725#5250 )
(overlookmotel)
- a17cf33#5232 ) (Boshen)
- d5a4940#5138 )
(Boshen)
- 94f60e7#5241 )
(DonIsaac)
- 0de844d#5339 ) (overlookmotel)
- 5136f01#5131 )
(overlookmotel)
- 260c9d2#5187 ) (Dunqing)
- 1645115#5319 ) (Dunqing)
- d2666fe#5320 ) (Dunqing)
- 7e2a7af#5289 ) (Dunqing)
- b43a394#5293 ) (overlookmotel)
- d71f0ed#5279 )
(overlookmotel)
- 188ce07#5277 )
(overlookmotel)
- 0f4a8b3#5272 )
(overlookmotel)
- 341e42a#5269 )
(overlookmotel)
- eba5033#5119 )
(overlookmotel)
- f771d7c#5116 ) (overlookmotel)
- c6590ae#5115 )
(overlookmotel)
- fc2e9ad#5114 )
(overlookmotel)
- 1ba11a3#5112 )
(overlookmotel)
- 40e2f6e#5111 ) (overlookmotel)
- b39c0d6#5217 ) (Kevin Deng 三咲智子)
### Testing
- 7009177be7b8c6#5224 )
(Dunqing)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-09-03 10:36:02 +08:00
overlookmotel
be4642fc02
feat(semantic): transform checker check child scope IDs ( #5410 )
...
Transform checker check child scope IDs. If we have to track child scope IDs, we should make sure they're correct!
2024-09-03 00:57:13 +00:00
overlookmotel
d594818701
fix(traverse): insert_scope_below update child scopes records ( #5409 )
...
Follow on after #5403 . Make `Traverse` update child scope IDs when inserting new scope. These lines were removed in #5232 , but not reinstated in #5403 .
2024-09-03 00:57:12 +00:00
Boshen
01cc2ceac0
feat(semantic)!: add ScopeTree:get_child_ids API behind a runtime flag ( #5403 )
...
The runtime API for enabling `get_child_ids` is `SemanticBuilder::with_scope_tree_child_ids`.
I've tested this PR in Rolldown to ensure correctness.
2024-09-02 16:22:26 +00:00
Dunqing
be7b8c6845
test(semantic): add JSXIdentifierReference-related tests ( #5224 )
...
These tests demonstrate what kind of JSX will have references.
2024-08-30 17:43:34 +00:00
Dunqing
32f730085c
feat(ast)!: add JSXElementName::IdentifierReference and JSXMemberExpressionObject::IdentifierReference ( #5223 )
...
close : #3528
part of #4746
2024-08-30 11:11:04 +00:00
Boshen
3ae94b8801
refactor(semantic): change build_module_record to accept &Path instead of PathBuf
2024-08-30 12:24:49 +08:00
overlookmotel
6e969f9fa4
feat(semantic): add ScopeTree::delete_root_unresolved_reference ( #5305 )
...
Add an API to `ScopeTree` to delete an unresolved reference.
2024-08-29 08:39:09 +00:00
Kevin Deng 三咲智子
234a24c14d
fix(ast)!: merge UsingDeclaration into VariableDeclaration ( #5270 )
...
relate #2854
2024-08-28 11:26:05 +08:00
overlookmotel
05d25e2aa3
refactor(semantic): combine add scope methods ( #5262 )
...
#5232 removed `ScopeTree::child_ids`, so it's no longer necessary to have separate `add_scope` and `add_root_scope` methods.
2024-08-27 13:00:21 +00:00
overlookmotel
fdedc0f8b1
refactor(semantic): transform checker: rename SemanticData to Scoping ( #5261 )
...
Pure refactor. Rename type and vars with a more descriptive name.
2024-08-27 11:58:21 +00:00
overlookmotel
10861096e0
refactor(semantic): transform checker do not output spans in errors ( #5260 )
...
Transform checker don't output spans in errors. They're inaccurate because (a) spans refer to the source text pre-transform, and (b) most errors relate to scopes/symbols/references newly created in transformer, which have no span.
2024-08-27 11:58:21 +00:00
overlookmotel
af5713e411
refactor(semantic): transform checker continue checks if missing IDs ( #5259 )
...
Transform checker don't bail out if some IDs missing from AST. Continue to check for other problems.
Also simplify iterating over pairs of IDs.
2024-08-27 11:58:20 +00:00
overlookmotel
943454fa5e
refactor(semantic): update transform checker for no conditional scopes ( #5252 )
...
All scopes are now unconditional (#5008 ). Update transform checker to reflect this.
2024-08-27 08:57:15 +00:00
overlookmotel
892a7fab60
refactor(semantic): replace ref syntax ( #5253 )
...
Pure code style refactor. Prefer `if let Some(y) = &x.y` over `if let Some(ref y) = x.y`.
2024-08-27 08:13:14 +00:00
overlookmotel
cbb47252ba
refactor(semantic): add comment to transform checker ( #5250 )
...
Add back a doc comment which was accidentally removed in #5232 .
2024-08-27 07:38:52 +00:00
Boshen
a17cf33dc3
refactor(semantic): remove ScopeTree::child_ids ( #5232 )
...
closes https://github.com/oxc-project/oxc/issues/5244
2024-08-27 01:49:47 +00:00
Dunqing
293413fe71
fix(semantic): implicit return UpdateExpression in ArrowFunctionExpression does not as read reference ( #5161 )
...
close : #5158
close : #5156
2024-08-26 03:30:16 +00:00
Dunqing
f8bb0222b3
fix(transformer/arrow-functions): remove SymbolFlags::ArrowFunction ( #5190 )
...
`ArrowFunction` has been transforming to `FunctionExpression`, So we should remove `SymbolFlags::ArrowFunction`
2024-08-25 10:27:00 +00:00
DonIsaac
c2fa72571f
feat(ast,parser): parse TSTypeAnnotations on AccessorProperty ( #5179 )
...
Closes #5177
While making this, I noticed an uncaught parse error for accessors: accessors cannot be optional. I'll add a fix for this in an up-stack PR.
2024-08-25 01:02:48 +00:00
Dunqing
e3561127fe
chore(semantic): remove accidentally left comment ( #5162 )
2024-08-24 00:41:01 -04:00
Boshen
d5a494023e
refactor(semantic): rewrite handling of label statement errors ( #5138 )
...
This reverts the previous changes to handling labels so that all tests can pass.
This passes all false postivies found in `monitor-oxc` (node_modules/flow-parser/flow_parser.js)
As it turns out this requires less code and produces better diagnostics.
2024-08-24 02:37:49 +00:00
Boshen
7cc2bbd293
chore(semantic): print errors from examples/simple.rs
2024-08-23 22:57:26 +08:00
overlookmotel
c100826b42
refactor(semantic)!: always create a scope for for statements ( #5110 )
...
Part of #5008 . Make scopes for `ForStatement`, `ForInStatement` and `ForOfStatement` unconditional. i.e. always create a scope, even if there is no lexical binding (e.g. `for (i of a) {}`).
2024-08-23 09:28:13 +00:00
overlookmotel
d304d6f973
refactor(semantic)!: always create a scope for CatchClause ( #5109 )
...
Part of #5008 . Make scope for `CatchClause` unconditional. i.e. always create a scope, even if there is no catch parameter.
2024-08-23 08:30:27 +00:00
overlookmotel
91343913ca
fix(semantic): transform checker check unresolved references ( #5096 )
...
Transform checker check root unresolved references.
The transform checker is now checking pretty much everything it can.
Only fields of `ScopeTree` and `SymbolTable` that it's *not* checking are those which contain `AstNodeId`s, because transformer does not create node IDs at present:
* `ScopeTree::node_ids`
* `SymbolTable::declarations`
* `Reference::node_id`
Checking also only proceeds in "from AST" direction.
i.e. for each `SymbolId` which appears in the AST, we check everything about that symbol. But we *don't* go through all the "rows" in `SymbolTable` and check if there are any extra symbols in the table which aren't in the AST.
Presumably transformer will leave a lot of old symbols lying around in `SymbolTable` (ditto scopes and references). We'd need to add `ScopeFlags::Deleted`, `SymbolFlags::Deleted` and `ReferenceFlags::Deleted` for the transformer to be able to "delete" existing symbols.
2024-08-23 07:52:30 +00:00
overlookmotel
13c961c492
refactor(semantic): clean up transform checker ( #5094 )
...
Remove some defunct code and clean up a few bits in transform checker.
2024-08-23 08:37:48 +01:00
overlookmotel
c57e078c71
fix(semantic): transform checker check unbound references ( #5093 )
2024-08-23 08:37:48 +01:00
oxc-bot
0b900110a2
Release crates v0.25.0 ( #5107 )
...
## [0.25.0] - 2024-08-23
- 78f135d#5077 ) (Boshen)
- f2b8d82#5058 ) (overlookmotel)
- 5f4c9ab#5030 ) (overlookmotel)
- 58bf215#5025 ) (overlookmotel)
- c4c08a7#5024 ) (overlookmotel)
- d262a58#5023 ) (overlookmotel)
- c30e2e9#5019 ) (overlookmotel)
- ce4d469#5001 )
(Boshen)
- b2ff2df#5000 ) (Boshen)
- f88970b#4859 ) (Burlin)
### Features
- 714373d#5005 )
(overlookmotel)
- 6800e69#4954 ) (Boshen)
- 2b21be3#4979 )
(IWANABETHATGUY)
- afe728a#4998 )
(Boshen)
- 4b49cf8#5087 )
(Boshen)
- f51d3f9#4975 ) (Dunqing)
- f794870#4974 ) (Dunqing)
- 72ff2c6#4972 ) (Dunqing)
- 6b885fe#4965 )
(Dunqing)
### Bug Fixes
- 7f3129e#5004 ) (overlookmotel)
- 1bd9365#5035 ) (Boshen)
- 185eb20#4935 ) (michaelm)
- 2a5e15defbdced#5069 )
(Boshen)
- ad2be97#5041 ) (heygsc)
- d5de97d#5092 )
(overlookmotel)
- 90c74ee#5090 )
(overlookmotel)
- a8005b9#5089 ) (overlookmotel)
- 205bff7#5088 )
(overlookmotel)
- 4a57086#5078 )
(overlookmotel)
- ea7d216#5076 )
(overlookmotel)
- 1b6b27a#5074 )
(overlookmotel)
- 6d87b0f#5071 )
(Boshen)
- 05fff16#5057 )
(overlookmotel)
- f187b71#5056 )
(overlookmotel)
- b52c6a4#5055 )
(overlookmotel)
- da64014#5054 ) (overlookmotel)
- 67d1a96#5052 )
(overlookmotel)
- 863b9cb#5040 )
(overlookmotel)
- 47029c4#5038 ) (overlookmotel)
- 6ffbd78#4987 ) (overlookmotel)
- a8dfdda#4986 ) (overlookmotel)
- 1467eb3#4985 ) (overlookmotel)
- 1365feb#4984 ) (overlookmotel)
- edacf93#4983 )
(overlookmotel)
- 3b35332#5047 ) (Dunqing)- b7db235#5003 )
(IWANABETHATGUY)
### Documentation
- 178d1bd#5084 ) (Dunqing)
- d50eb72#5064 ) (Dunqing)
- 4425b17#5012 ) (Dunqing)
- 1bd5853#4993 )
(overlookmotel)
### Refactor
- a4247e9#5034 )
(overlookmotel)
- cca7440#4988 ) (overlookmotel)
- 4012260#4977 ) (overlookmotel)
- 96422b6#4925 ) (DonIsaac)
- ca70cc7#5028 ) (overlookmotel)
- 0f64d10#5007 ) (IWANABETHATGUY)
- cd9cf5eb4407c49da6a21#5091 ) (overlookmotel)
- fb46eaf#5082 )
(overlookmotel)
- a00bf18#5079 )
(overlookmotel)
- b14a302#5075 ) (overlookmotel)
- b8c6ce5#5072 )
(overlookmotel)
- 7156fd2#5053 )
(overlookmotel)
- 0ba6f50#5051 )
(overlookmotel)
- ee7ac8b#5050 ) (overlookmotel)
- 4e1f4ab#5048 )
(overlookmotel)
- c1da574#5045 )
(overlookmotel)
- 8cded08#5044 ) (overlookmotel)
- 602244f#5043 )
(overlookmotel)
- ae94b9a#5042 ) (overlookmotel)
- 586e15c#5039 )
(overlookmotel)
- d69e34e#5037 ) (overlookmotel)
- 4336a32#5032 ) (overlookmotel)
- 83dfb14#5031 )
(overlookmotel)
- 3b7de18#5027 ) (overlookmotel)
- 0bacdd8#5026 )
(overlookmotel)
- 896b92f#5009 ) (overlookmotel)
- d677b8e#4962 ) (overlookmotel)
- a7ef30d#4960 ) (overlookmotel)
- 59d15c7#4959 ) (overlookmotel)
- 7706523#4978 )
(overlookmotel)
- 4fdf26d#4969 ) (Boshen)
- 8d15e65#5006 )
(overlookmotel)
- 4796ece#4982 ) (overlookmotel)
- a9fcf29#5085 ) (Dunqing)
- deda6ac#5065 ) (Dunqing)
- 9df2f80#4973 ) (Dunqing)
- 3f9433c#5013 ) (Dunqing)
- c60a50d#5086 ) (Dunqing)
- bcc8da9#5014 ) (Dunqing)
- 38d4434#4996 ) (Dunqing)
### Testing
- 0df1a94
2024-08-23 15:37:36 +08:00
Dunqing
8cf8f7a58a
feat(traverse): add is_static method to TraverseCtx, which is moves out from SymbolTable ( #5067 )
...
The [scope.isStatic](419644f27c/packages/babel-traverse/src/scope/index.ts (L557)
2024-08-23 07:14:08 +00:00
heygsc
ad2be97078
fix(semantic): incorrect semantic check for label has same name ( #5041 )
...
fix : #5036
---------
Co-authored-by: Boshen <boshenc@gmail.com>
2024-08-23 10:36:12 +08:00
overlookmotel
d5de97d6fe
fix(semantic): transform checker check reference flags ( #5092 )
2024-08-23 00:21:21 +00:00
overlookmotel
9da6a21e40
refactor(semantic): rename transform checker output for reference symbol mismatches ( #5091 )
2024-08-22 23:40:27 +00:00
overlookmotel
90c74ee449
fix(semantic): transform checker check reference symbol IDs ( #5090 )
...
Previously was checking that references point to symbols with same name, but not necessarily the same symbol (there could be 2 different symbols with same name).
2024-08-22 23:40:26 +00:00
overlookmotel
a8005b9914
fix(semantic): transform checker check symbol redeclarations ( #5089 )
2024-08-22 23:40:26 +00:00
overlookmotel
205bff7ea9
fix(semantic): transform checker check symbol references ( #5088 )
2024-08-22 23:40:25 +00:00
overlookmotel
fb46eafab6
refactor(semantic): add remap functions to transform checker ( #5082 )
...
Move remapping into separate functions.
2024-08-22 23:40:24 +00:00
overlookmotel
a00bf18b9f
refactor(semantic): add IdMapping to transform checker ( #5079 )
...
`IdMapping<Id>` wraps `FxHashMap<Id, Id>` for ease in dealing with ID types which are `Copy`.
2024-08-22 15:08:49 +00:00
overlookmotel
4a57086d79
fix(semantic): transform checker check symbol IDs ( #5078 )
2024-08-22 15:08:48 +00:00
overlookmotel
ea7d2163e3
fix(semantic): transform checker check symbol spans ( #5076 )
2024-08-22 15:08:47 +00:00
overlookmotel
b14a302ed0
refactor(semantic): transform checker: change symbol name mismatch error ( #5075 )
2024-08-22 15:08:46 +00:00
overlookmotel
1b6b27a6de
fix(semantic): transform checker check symbol flags ( #5074 )
2024-08-22 15:08:45 +00:00
overlookmotel
b8c6ce5317
refactor(semantic): rename vars in transform checker ( #5072 )
...
Pure refactor. Just rename some vars for consistency.
2024-08-22 13:41:35 +00:00
Boshen
6d87b0f1f2
fix(semantic): fix error message for duplicated label ( #5071 )
2024-08-22 12:30:04 +00:00
overlookmotel
f2b8d82499
refactor(semantic)!: ScopeTree::get_child_ids + get_child_ids_mut return value not Option ( #5058 )
...
Previously `ScopeTree::get_child_ids` and `ScopeTree::get_child_ids_mut` returned an `Option`. Instead return the unwrapped value, in line with other methods e.g. `get_flags`.
2024-08-22 05:57:55 +00:00
overlookmotel
05fff16d55
fix(semantic): transform checker compare binding symbol IDs ( #5057 )
2024-08-22 02:34:44 +00:00
overlookmotel
f187b71877
fix(semantic): transform checker compare scope children ( #5056 )
2024-08-22 02:34:44 +00:00
overlookmotel
b52c6a4269
fix(semantic): transform checker compare scope parents ( #5055 )
2024-08-22 02:34:43 +00:00
overlookmotel
da64014a6c
fix(semantic): transform checker catch more scope flags mismatches ( #5054 )
...
There was a bug previously where scope flags were only checked if there was also a bindings mismatch.
2024-08-22 02:34:43 +00:00
overlookmotel
7156fd2f91
refactor(semantic): transform checker Pair structure ( #5053 )
...
Introduce `Pair` structure containing a pair values from the "after transform" and "rebuilt" semantics, to reduce repetitive code.
2024-08-22 02:34:42 +00:00
overlookmotel
67d1a96391
fix(semantic): transform checker compare scope flags ( #5052 )
2024-08-22 02:34:41 +00:00
overlookmotel
0ba6f50f00
refactor(semantic): simplify raising errors in transform checker ( #5051 )
...
Simplify creating errors in transformer checker.
2024-08-22 02:34:41 +00:00
overlookmotel
ee7ac8b0b7
refactor(semantic): store all data in PostTransformChecker in transform checker ( #5050 )
...
Pure refactor of transform checker. Store all scope data in `PostTransformChecker` so it doesn't need to be passed around. `SemanticData` contains a full set of all semantic data for semantic pass, so we have 2 instances of it for 1. after transform and 2. rebuilt semantic.
2024-08-21 17:04:48 +00:00
overlookmotel
4e1f4abf89
refactor(semantic): add SemanticIds to transformer checker ( #5048 )
...
Transformer checker use `SemanticIds` to store collected IDs. `SemanticIds` only contains the IDs, without the `Vec` of errors which is only used temporarily.
2024-08-21 15:49:07 +00:00
overlookmotel
c1da5741f4
refactor(semantic): add comments to transformer checker ( #5045 )
...
Just add comments.
2024-08-21 15:22:08 +00:00
overlookmotel
8cded08eb8
refactor(semantic): rename error labels in transformer checker snapshots ( #5044 )
...
Rename labels in transformer checker snapshots "after transform" vs "rebuilt".
2024-08-21 14:33:19 +00:00
overlookmotel
602244f440
refactor(semantic): rename vars in transformer checker ( #5043 )
...
Pure refactor. Rename vars in transformer checker - "transformer"/"rebuild" instead of "previous"/"current".
2024-08-21 13:47:37 +00:00
overlookmotel
ae94b9a890
refactor(semantic): remove unused function params in transformer checker ( #5042 )
...
Pure refactor, just tidying code.
2024-08-21 13:05:43 +00:00
overlookmotel
863b9cb921
fix(semantic): transform checker handle conditional scopes ( #5040 )
...
Some scopes are conditional e.g. `ForStatement` only gets a scope when initializer has a binding (`for (let i = 0; ...)` vs `for (i = 0; ...)`).
Make transform compare this between post-transform and fresh semantics.
2024-08-21 12:07:14 +00:00
overlookmotel
586e15c814
refactor(semantic): reformat transform checker errors ( #5039 )
...
Reformat transform checker error output - shorter and consistent capitalization.
2024-08-21 12:07:11 +00:00
overlookmotel
47029c4d45
fix(semantic): transform checker output symbol names in errors ( #5038 )
...
Transform checker: For symbol mismatch errors, output symbol names.
2024-08-21 12:07:09 +00:00
overlookmotel
d69e34e983
refactor(semantic): fix indentation ( #5037 )
...
Small follow-on after #5035 . Not sure why rustfmt didn't correct indentation here.
2024-08-21 09:48:43 +00:00
Boshen
1bd9365bd0
fix(coverage): correctly check semantic data after transform ( #5035 )
...
closes #4999
2024-08-21 09:35:04 +00:00
overlookmotel
4336a3275c
refactor(semantic): rename fields in snapshots from flag to flags ( #5032 )
...
Part of #4991 .
2024-08-21 00:19:59 +00:00
overlookmotel
83dfb1484e
refactor(semantic): rename vars from flag to flags ( #5031 )
...
Part of #4991 .
2024-08-21 00:19:59 +00:00
overlookmotel
5f4c9ab38e
refactor(semantic)!: rename SymbolTable::get_flag to get_flags ( #5030 )
...
Part of #4991 .
2024-08-21 00:19:58 +00:00
overlookmotel
ca70cc7c03
refactor(linter, mangler, parser, semantic, transformer, traverse, wasm): rename various flag vars to flags ( #5028 )
...
Part of #4991 .
2024-08-21 00:19:58 +00:00
overlookmotel
3b7de18eb2
refactor(semantic): rename SemanticBuilder::current_reference_flags field ( #5027 )
...
Part of #4991 .
2024-08-21 00:19:58 +00:00
overlookmotel
0bacdd8102
refactor(semantic): rename Reference::flag field to flags ( #5026 )
...
Part of #4991 .
2024-08-21 00:19:57 +00:00
overlookmotel
58bf21531e
refactor(semantic)!: rename Reference::flag and flag_mut methods to plural ( #5025 )
...
Part of #4991 .
2024-08-21 00:19:57 +00:00
overlookmotel
d262a58eb5
refactor(syntax)!: rename ReferenceFlag to ReferenceFlags ( #5023 )
...
Part of #4991 .
2024-08-21 00:19:56 +00:00
overlookmotel
c30e2e9cce
refactor(semantic)!: Reference::flag method return ReferenceFlag ( #5019 )
...
Closes #4992 .
2024-08-20 22:02:08 +00:00
overlookmotel
896b92f272
refactor(semantic): correct typo in doc comment ( #5009 )
...
Correct a typo in doc comment, and capitalize "ID" in couple of places.
2024-08-20 15:27:51 +00:00
Burlin
f88970bc79
refactor(ast)!: Change order of fields in CallExpression ( #4859 )
...
fix : #4821
---------
Co-authored-by: Dunqing <dengqing0821@gmail.com>
2024-08-20 09:47:12 +08:00
Boshen
0df1a94a1b
test(semantic): add more symbol and reference checks to PostTransformChecker
2024-08-19 15:44:17 +08:00
Boshen
3f6014a042
chore(semantic): add PostTransformChecker ( #4967 )
2024-08-19 05:38:27 +00:00
overlookmotel
d677b8e0ab
refactor(semantic): do not reserve space in resolved_references ( #4962 )
...
While resolving references in `SemanticBuilder`, there is little benefit to reserving space in advance in `resolved_references` as it is not possible to avoid growing the `Vec`. The comment here says "Reserve space for all references to avoid reallocations", but `reserve()` itself may cause a reallocation.
2024-08-19 01:32:05 +00:00
overlookmotel
a7ef30dcf9
refactor(semantic): UnresolvedReferencesStack contain only ReferenceId ( #4960 )
...
Remove `ReferenceFlag` from `UnresolvedReferencesStack` to align with `root_unresolved_references`.
2024-08-19 01:32:04 +00:00
overlookmotel
59d15c7086
refactor(semantic): root_unresolved_references contain only ReferenceId ( #4959 )
...
`ScopeTree::root_unresolved_references` does not need to record `ReferenceFlag` as well as `ReferenceId` - it's never read.
2024-08-19 01:32:04 +00:00
oxc-bot
5d0fb979cb
Release crates v0.24.3 ( #4950 )
...
## [0.24.3] - 2024-08-18
### Features
- d49fb16#4898 )
(IWANABETHATGUY)
- 80d0d1f#4928 )
(DonIsaac)
- 48821c0#4946 )
(DonIsaac)
- f1fcdde#4587 ) (Dunqing)
- 0d79122#4890 ) (Dunqing)
- ab1d08c#4885 )
(Dunqing)
- 69da9fd#4884 ) (Dunqing)
- 3a66e58#4876 )
(Dunqing)
- f88cbcd#4903 ) (overlookmotel)
- 1e6d0fe#4897 )
(overlookmotel)
- fd34640#4940 ) (Dunqing)
- 72a37fc#4880 ) (Dunqing)
### Bug Fixes
- c0b26f4#4858 )
(overlookmotel)
- bbf9ec0#4937 )
(Boshen)
- f210cf7#4936 ) (Boshen)
- 21f5762#4889 ) (Boshen)
- e8de4bd#4886 ) (Boshen)
- a226962#4869 ) (Boshen)
- 3da33d3#4865 )
(Boshen)
- 1808529#4862 )
(IWANABETHATGUY)
- d3bbc62#4941 ) (Dunqing)
- 8e80f59#4934 ) (michaelm)
- b3ec9e5#4919 ) (michaelm)
- 0fb0b71#4911 )
(michaelm)
- 4a16916#4910 )
(michaelm)
- 508644a#4932 ) (mysteryven)
- 46cb1c1#4933 ) (Boshen)
- 81fd637#4878 ) (Boshen)
- 879a271#4875 ) (Boshen)
- 1bdde2c#4861 ) (Boshen)
- 2476dce#4913 ) (overlookmotel)
- 248a757#4920 ) (Dunqing)
### Documentation
- 47c9552#4856 ) (rzvxa)
- 0a01a47#4850 ) (DonIsaac)
- 9c700ed#4899 )
(overlookmotel)
### Refactor
- a6967b3#4904 ) (overlookmotel)
- 90d0b2b#4900 ) (overlookmotel)
- 1eb59d2#4907 ) (overlookmotel)
- 8e8fcd0#4846 ) (rzvxa)
- 786bf07#4905 )
(overlookmotel)
- ea1e64a#4851 ) (DonIsaac)
- 5fd1701#4873 ) (rzvxa)
- 48a1c32#4877 )
(overlookmotel)
- 452187a#4902 ) (overlookmotel)
- 707a01f#4896 )
(overlookmotel)
- 117dff2#4895 ) (overlookmotel)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-08-18 14:16:25 +08:00
DonIsaac
48821c0110
feat(semantic,syntax): add SymbolFlags::ArrowFunction ( #4946 )
...
There are many cases in lint rules where we want to see if a symbol is a
function by checking its SymbolFlags. This is currently not fully possible,
since variables assigned to arrow functions are not distinguished from any other
kind of variable. This PR adds `SymbolFlags::ArrowFunction` for variables that
are initialized to arrow functions. Symbols that are re-assigned to arrow
functions will not have this flag, but this is acceptable for lint rules.
2024-08-18 05:54:23 +00:00
DonIsaac
80d0d1f0c4
feat(semantic): check for invalid interface heritage clauses ( #4928 )
2024-08-16 02:30:09 +00:00
DonIsaac
ea1e64a1f3
refactor(semantic): make SemanticBuilder opaque ( #4851 )
...
change visibility of building-related methods and properties of SemanticBuilder
from `pub` to `pub(crate)`.
2024-08-14 08:15:20 +00:00
DonIsaac
0a01a4729a
docs(semantic): improve documentation ( #4850 )
2024-08-13 02:14:07 +00:00
oxc-bot
977b74af2d
Release crates v0.24.2 ( #4841 )
...
## [0.24.2] - 2024-08-12
### Features
- 8e10e25#4810 ) (overlookmotel)
### Bug Fixes
- 62f759c#4808 ) (Dunqing)
### Performance
- 504ac0b#4803 ) (overlookmotel)
- 35f2742#4802 ) (overlookmotel)
### Documentation
- 8827659#4830 ) (DonIsaac)
- 559baa50ea697b#4819 ) (rzvxa)
- ecfa124#4829 )
(overlookmotel)
- 096ac7b#4831 ) (DonIsaac)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-08-12 16:02:07 +08:00
oxc-bot
857bc73302
Release crates v0.24.1 ( #4798 )
...
## [0.24.1] - 2024-08-10
### Features
- b3c3125#4791 ) (DonIsaac)
- c519295#4759 ) (Boshen)
### Bug Fixes
- fff9da3#4747 ) (rzvxa)
- f5eeebd#4766 ) (rzvxa)
- 4d0b40adaa0b2e#4773 ) (overlookmotel)
- d4a3be8#4781 ) (overlookmotel)
- dbb5f4c#4774 ) (overlookmotel)
- 7ea058d#4769 ) (overlookmotel)
- 2dea0ca#4761 ) (overlookmotel)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-08-10 15:26:40 +08:00
oxc-bot
69dc6c9cb1
Release crates v0.24.0 ( #4749 )
...
## [0.24.0] - 2024-08-08
- 75f2207#4693 ) (overlookmotel)
- 506709f#4692 ) (overlookmotel)
### Features
- 23b0040#4726 ) (rzvxa)
- 51c1ca0#4732 ) (rzvxa)
- e12bd1e#4711 ) (DonIsaac)
- fd2d9da#4553 ) (DonIsaac)
- b3b7028#4552 ) (DonIsaac)
- 54047e0#4609 ) (overlookmotel)
- eae401c#4373 ) (rzvxa)
- ec0b4cb#4731 ) (rzvxa)
- 2e91ad6#4728 )
(rzvxa)
- 82e2f6b#4694 )
(rzvxa)
- 0c52c0d#4615 ) (rzvxa)
- 07607d3#4703 )
(overlookmotel)
- 125c5fd#4696 ) (rzvxa)
- eaddc8f#4714 ) (DonIsaac)
- 229a0e9#3959 )
(camc314)
- 33f1312#4717 ) (DonIsaac)
- e42ac3a#4639 ) (overlookmotel)
- 2e63618#4729 )
(rzvxa)
- 6a36616#4730 )
(rzvxa)
### Bug Fixes
- 4a56954#4676 )
(Boshen)
- 94d3c31#4722 ) (Boshen)
- bf43148bf48c7f#4680 ) (Boshen)
- 9be29af#4678 ) (Boshen)
- e8b662a#4667 )
(Boshen)
- 01d85def290191a40a217#4610 )
(Boshen)
- 03c643a#4659 ) (Dunqing)
- 6c612d1#4642 ) (leaysgur)
- 0d2c41a#4632 )
(rzvxa)
- 9f8f299#4675 )
(overlookmotel)
- 4797eaa#4686 ) (overlookmotel)
- 5327acd#4658 ) (Dunqing)
- 3987665#4660 ) (Dunqing)
- 4efd54b#4549 ) (Dunqing)
### Performance
- 8dd76e4#4643 )
(overlookmotel)
- b8e6753#4641 ) (overlookmotel)
- 6ff200d#4603 ) (DonIsaac)
- 0f5e982#4677 ) (Boshen)
- ff43dff#4633 ) (overlookmotel)
- a330773#4638 ) (overlookmotel)
- 372316b#4634 ) (overlookmotel)
- c7f1d48#4596 ) (overlookmotel)
- 590d795#4586 )
(overlookmotel)
### Documentation
- c69ada4#4051 ) (Rintaro Itokawa)
### Refactor
- 579b797#4738 ) (rzvxa)
- 475266d#4712 )
(DonIsaac)
- 83b6ca9#4689 ) (rzvxa)
- ba70001#4621 )
(rzvxa)
- 3f53b6f#4614 ) (rzvxa)
- 452e0ee#4599 ) (overlookmotel)
- 2218340#4735 ) (rzvxa)
- fbfd852#4734 ) (Boshen)
- e0832f8#4725 ) (Boshen)
- 17602db3289477#4724 ) (Boshen)
- e78cba6#4625 ) (Boshen)
- d25dea7#4612 ) (rzvxa)
- 09d9822#4674 ) (overlookmotel)
- 6e453db#4664 ) (Dunqing)
- e1429e5#4702 )
(overlookmotel)
- e24fb5b#4691 ) (rzvxa)
- 3f3cb62#4698 ) (overlookmotel)
- 54f9897#4685 ) (overlookmotel)
- 83546d3#4684 )
(overlookmotel)- 9b51e04#4592 )
(DonIsaac)
### Testing
- 49d5196#4620 ) (rzvxa)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-08-08 14:00:57 +08:00
DonIsaac
33f1312a8c
feat(semantic): impl GetSpan for AstNode ( #4717 )
2024-08-07 03:59:38 +00:00
oxc-bot
61337613da
Release crates v0.23.1 ( #4681 )
...
## [0.23.1] - 2024-08-06
### Features
- fd2d9da#4553 ) (DonIsaac)
- b3b7028#4552 ) (DonIsaac)
- 54047e0#4609 ) (overlookmotel)
- eae401c#4373 ) (rzvxa)
- 0c52c0d#4615 ) (rzvxa)
- 229a0e9#3959 )
(camc314)
- e42ac3a#4639 ) (overlookmotel)
### Bug Fixes
- 4a56954#4676 )
(Boshen)
- bf48c7f#4680 ) (Boshen)
- 9be29af#4678 ) (Boshen)
- e8b662a#4667 )
(Boshen)
- a40a217#4610 )
(Boshen)
- 03c643a#4659 ) (Dunqing)
- 6c612d1#4642 ) (leaysgur)
- 0d2c41a#4632 )
(rzvxa)
- 9f8f299#4675 )
(overlookmotel)
- 5327acd#4658 ) (Dunqing)
- 3987665#4660 ) (Dunqing)
- 4efd54b#4549 ) (Dunqing)
### Performance
- 8dd76e4#4643 )
(overlookmotel)
- b8e6753#4641 ) (overlookmotel)
- 6ff200d#4603 ) (DonIsaac)
- 0f5e982#4677 ) (Boshen)
- ff43dff#4633 ) (overlookmotel)
- a330773#4638 ) (overlookmotel)
- 372316b#4634 ) (overlookmotel)
- c7f1d48#4596 ) (overlookmotel)
- 590d795#4586 )
(overlookmotel)
### Documentation
- c69ada4#4051 ) (Rintaro Itokawa)
### Refactor
- ba70001#4621 )
(rzvxa)
- 3f53b6f#4614 ) (rzvxa)
- 452e0ee#4599 ) (overlookmotel)
- e78cba6#4625 ) (Boshen)
- d25dea7#4612 ) (rzvxa)
- 09d9822#4674 ) (overlookmotel)
- 6e453db#4664 ) (Dunqing)- 9b51e04#4592 )
(DonIsaac)
### Testing
- 49d5196#4620 ) (rzvxa)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-08-06 16:37:29 +08:00
Dunqing
03c643a8af
fix(semantic): incorrect scope_id for catch parameter symbols ( #4659 )
...
When we move all the bindings in the CatchClause scope to its child scope (BlockStatement), we also need to replace the scope_id in the symbol with the scope_id of the new scope.
2024-08-06 02:57:18 +00:00
overlookmotel
09d982224f
refactor(semantic): simplify setting scope flags ( #4674 )
2024-08-06 06:47:43 +08:00
Dunqing
6e453db3f7
refactor(semantic): simplify inherit scope flags from parent scope ( #4664 )
...
close : #3862
This is reaming last part of close #3862
2024-08-05 22:27:07 +00:00
leaysgur
6c612d141c
fix(semantic/jsdoc): Handle whitespace absence ( #4642 )
...
Follow up for #4632
2024-08-05 02:25:13 +00:00
rzvxa
0d2c41a2cb
fix(semantic/jsdoc): panic on parsing type_name_comment. ( #4632 )
...
fixes #4627
2024-08-05 01:17:53 +00:00
DonIsaac
fd2d9dafcd
feat(ast): improve AstKind::debug_name ( #4553 )
...
> Part of #4445
Improve `debug_name` to show identifier names for more AST kinds.
2024-08-03 21:22:05 +00:00
oxc-bot
e02bac357a
Release crates v0.23.0 ( #4595 )
...
## [0.23.0] - 2024-08-01
- 27fd062#4541 )
(overlookmotel)
### Features
- a558492#4548 ) (Boshen)
- 7446e98#4510 ) (Boshen)
- 35654e6#4509 )
(Boshen)
- b952942⭐ attempt 3.2) (#4445 )
(DonIsaac)
- 85e8418#3949 ) (Don Isaac)
- cf1854b#4511 ) (Dunqing)
### Bug Fixes
- b58ed80#4585 ) (Boshen)
- 6a94e3f#4503 ) (Boshen)
- d5c4b19#4543 ) (DonIsaac)
### Performance
- 4c6d19d#4584 ) (Luca Bruno)
- 7585e16#4570 )
(DonIsaac)
- 55a8763#4579 )
(overlookmotel)
- ae1d38f#4577 ) (overlookmotel)
- 56ae615#4576 ) (overlookmotel)
- 25679e6#4572 ) (overlookmotel)
- bb33bcc#4571 )
(overlookmotel)
- ab8509e#4561 ) (overlookmotel)
- c9c38a1#4304 ) (lucab)
- 0870ee1#4534 ) (lucab)
- d00014e#4583 )
(overlookmotel)
- 1fd9dd0#4487 )
(Brooooooklyn)
### Documentation
- 0914e47#4551 ) (DonIsaac)
- c6a11be#4471 )
(DonIsaac)
### Refactor
- e68ed62#4575 ) (overlookmotel)
- bba824b#4574 )
(overlookmotel)
- ef5418a#4573 ) (overlookmotel)
- 9e5be78#4569 ) (overlookmotel)
- 649913e#4568 ) (overlookmotel)
- 59f00c0#4566 ) (overlookmotel)
- 8e3e910#4565 ) (overlookmotel)
- 0c0601f#4564 ) (overlookmotel)
- 0acc4a7#4563 )
(overlookmotel)
- 565eccf#4562 ) (overlookmotel)
- 148bdb5#4530 ) (overlookmotel)
- 16c7b98#4505 ) (Dunqing)
- d6974d4#4533 )
(overlookmotel)
- d914b14#4529 ) (Dunqing)
- 7b5e1f5#4532 )
(overlookmotel)
- 9db4259#4531 ) (overlookmotel)
- 7c42ffc#4535 ) (overlookmotel)
- 96602bf#4513 ) (Dunqing)
- e6a8af6#4538 ) (overlookmotel)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-08-01 16:55:41 +08:00
Dunqing
16c7b98962
refactor(semantic): move CatchClause scope binding logic to visit_block_statement ( #4505 )
...
This logic only needs to run in the BlockStatement
2024-07-31 03:52:22 +00:00
DonIsaac
b952942993
feat(linter): add eslint/no-unused-vars ( ⭐ attempt 3.2) ( #4445 )
...
> Re-creation of #4427 due to rebasing issues. Original attempt: #642
-----
Third time's the charm?
Each time I attempt this rule, I find a bunch of bugs in `Semantic`, and I expect this attempt to be no different. Expect sidecar issues+PRs stemming from this PR here.
## Not Supported
These are cases supported in the original eslint rule, but that I'm intentionally deciding not to support
- export comments in scripts
```js
/* exported a */ var a;
```
- global comments
```js
/* global a */ var a;
```
## Behavior Changes
These are intentional deviations from the original rule's behavior:
- logical re-assignments are not considered usages
```js
// passes in eslint/no-unused-vars, fails in this implementation
let a = 0; a ||= 1;
let b = 0; b &&= 2;
let c = undefined; c ??= []
```
## Known Limitations
- Lint rules do not have babel or tsconfig information, meaning we can't determine if `React` imports are being used or not. The relevant tsconfig settings here are `jsx`, `jsxPragma`, and `jsxFragmentName`. To accommodate this, all imports to symbols named `React` or `h` are ignored in JSX files.
- References to symbols used in JSDoc `{@link}` tags are not created, so symbols that are only used in doc comments will be reported as unused. See: #4443
- `.vue` files are skipped completely, since variables can be used in templates in ways we cannot detect
> note: `.d.ts` files are skipped as well.
## Todo
- [x] Skip unused TS enum members on used enums
- [x] Skip unused parameters followed by used variables in object/array spreads
- [x] Re-assignments to array/object spreads do not respect `destructuredArrayIgnorePattern` (related to: https://github.com/oxc-project/oxc/issues/4435 )
- [x] #4493
- [x] References inside a nested scope are not considered usages (#4447 )
- [x] Port over typescript-eslint test cases _(wip, they've been copied and I'm slowly enabling them)_
- [x] Handle constructor properties
```ts
class Foo {
constructor(public a) {} // `a` should be allowed
}
```
- [x] Read references in sequence expressions (that are not in the last position) should not count as a usage
```js
let a = 0; let b = (a++, 0); console.log(b)
```
> Honestly, is anyone even writing code like this?
- [x] function overload signatures should not be reported
- [x] Named functions returned from other functions get incorrectly reported as unused (found by @camc314)
```js
function foo() {
return function bar() { }
}
Foo()()
```
- [x] false positive for TS modules within ambient modules
```ts
declare global {
// incorrectly marked as unused
namespace jest { }
}
```
## Blockers
- https://github.com/oxc-project/oxc/issues/4436
- https://github.com/oxc-project/oxc/issues/4437
- #4446
- #4447
- #4494
- #4495
## Non-Blocking Issues
- #4443
- #4475 (prevents checks on exported symbols from namespaces)
2024-07-31 03:22:16 +00:00
DonIsaac
d5c4b190aa
fix(parser): fix enum member parsing ( #4543 )
...
Closes #4449
2024-07-30 10:43:09 +00:00
overlookmotel
d6974d4ff7
refactor(semantic): AstNodeParentIter fetch nodes lazily ( #4533 )
...
Refactor `AstNodeParentIter`, which is used to iterate down node ancestry chain. Fetch `AstNode` objects lazily, only when they're required by a `next()` call. If caller doesn't iterate all the way down the chain, likely this will result in 1 less array lookup.
2024-07-29 18:27:38 +00:00
Dunqing
d914b14275
refactor(semantic): reusing the same reference ( #4529 )
...
A minor improvement
2024-07-29 16:16:27 +00:00
overlookmotel
7b5e1f5ac8
refactor(semantic): use is_empty() instead of len() == 0 ( #4532 )
...
It's preferred to use `is_empty` where possible. `is_empty` is sometimes slightly more optimized than `len() == 0`.
2024-07-29 15:42:05 +00:00
overlookmotel
9db42592af
refactor(semantic): inline trivial methods ( #4531 )
...
Add `#[inline]` to trivial methods `ScopeTree` etc. Hopefully compiler is already inlining them all, but just to make sure.
2024-07-29 15:42:03 +00:00
Dunqing
cf1854be7c
feat(semantic): remove ReferenceFlags::Value from non-type-only exports that referenced type binding ( #4511 )
...
```ts
type T = 0;
export { T }
^ ReferenceFlags::Type | ReferenceFlags::Read
```
The export `T` only referenced type binding. We should remove `ReferenceFlags::Read` for it.
2024-07-29 03:39:18 +00:00
oxc-bot
80118cbf3b
Release crates v0.22.1 ( #4508 )
...
## [0.22.1] - 2024-07-27
### Features
- 2477330#4501 ) (Dunqing)
- aaee07e#4456 ) (Dunqing)
- fd363d1#4450 ) (DonIsaac)
- e2735ca#4491 ) (DonIsaac)
### Bug Fixes
- 368112c#4497 )
(Dunqing)
- 36bb680#4502 ) (Dunqing)
- cb2fa49#4500 ) (Dunqing)
- ef0e953#4499 ) (Dunqing)
- 40cafb8#4480 ) (Dunqing)
- 2e01a45#4493 ) (Don Isaac)
- e4ca06a#4458 ) (Dunqing)
- 77bd5f1#4448 ) (Don
Isaac)
- 5db7bed#4490 ) (overlookmotel)
- 1667491#4484 ) (Ethan Goh)
- 82ba2a0#4466 )
(overlookmotel)
- c04b9aa#4460 ) (overlookmotel)
- ecdee88#4507 ) (Dunqing)
### Performance
- 963a2d1#4498 ) (Dunqing)
- 868fc87#4298 )
(lucab)
- 24beaeb#4469 ) (overlookmotel)
- 348c1ad#4464 )
(overlookmotel)
- 6a9f4db#4463 ) (overlookmotel)
- 705e19f#4489 )
(overlookmotel)
- 4d10c6c#4476 )
(Brooooooklyn)
### Documentation
- f5f0ba8#4413 ) (Don Isaac)
- 871b3d6#4433 ) (DonIsaac)
### Refactor
- 9c5d2f9#4428 )
(overlookmotel)
- ccb1835#4470 )
(overlookmotel)
- f17254a#4461 ) (overlookmotel)
- a49f491#4459 )
(overlookmotel)
- 7cd53f3#4379 ) (Dunqing)
- 4f5a7cb#4430 ) (DonIsaac)
- c958a55#4486 )
(overlookmotel)
- c99b3eb#4468 ) (overlookmotel)
- 96fc94f#4467 ) (overlookmotel)
### Testing
- 4b274a8#4429 )
(DonIsaac)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-07-28 09:58:29 +08:00
Dunqing
36bb6805c6
fix(semantic): TSExportAssignment cannot reference type binding ( #4502 )
...
close : #4488
2024-07-27 04:55:03 +00:00
Dunqing
2477330440
feat(ast): add AstKind::TSExportAssignment ( #4501 )
...
part of #4488
2024-07-27 04:55:02 +00:00
