dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 20:28:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(transformer/typescript): incorrect eliminate exports when the referenced symbol is both value and type (#4507)

Browse source
This commit is contained in:
Dunqing 2024-07-28 00:11:29 +08:00 committed by GitHub
parent 963a2d1b85
commit ecdee88cfb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_transformer/src/typescript/annotations.rs
View file

@ -87,7 +87,7 @@ impl<'a> TypeScriptAnnotations<'a> {
ident.reference_id.get().is_some_and(|id| {
ctx.symbols().references[id].symbol_id().is_some_and(
|symbol_id| {
ctx.symbols().get_flag(symbol_id).is_type()
!ctx.symbols().get_flag(symbol_id).is_value()
},
)
})

8
tasks/transform_conformance/tests/babel-plugin-transform-typescript/test/fixtures/class-export/input.ts → tasks/transform_conformance/tests/babel-plugin-transform-typescript/test/fixtures/export-elimination/input.ts vendored
View file

@ -8,4 +8,10 @@ namespace Name {
export const Q = 0;
}
export { Im, Ok, Foo, Bar, Func, Baz, Baq, Name };
export { Im, Ok, Foo, Bar, Func, Baz, Baq, Name };
type T = number;
function T(): T {
return 123;
}
export { T }

6
tasks/transform_conformance/tests/babel-plugin-transform-typescript/test/fixtures/class-export/output.ts → tasks/transform_conformance/tests/babel-plugin-transform-typescript/test/fixtures/export-elimination/output.ts vendored
View file

@ -6,4 +6,10 @@ let Name;
(function(_Name) {
const Q = _Name.Q = 0;
})(Name || (Name = {}));
export { Im, Ok, Foo, Bar, Func, Name };
function T() {
return 123;
}
export { T }