dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(ast): use loop not recursion (#5449)

Browse source 
`Expression::get_inner_expression` and `Expression::get_inner_expression_mut` use a loop rather than recursive function calls. Loops are usually cheaper.
This commit is contained in:
overlookmotel 2024-09-04 20:24:45 +00:00
parent 1d3e973f10
commit a952c47265
1 changed files with 24 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
crates/oxc_ast/src/ast_impl/js.rs
View file

@ -203,29 +203,35 @@ impl<'a> Expression<'a> {
}
pub fn get_inner_expression(&self) -> &Expression<'a> {
match self {
Expression::ParenthesizedExpression(expr) => expr.expression.get_inner_expression(),
Expression::TSAsExpression(expr) => expr.expression.get_inner_expression(),
Expression::TSSatisfiesExpression(expr) => expr.expression.get_inner_expression(),
Expression::TSInstantiationExpression(expr) => expr.expression.get_inner_expression(),
Expression::TSNonNullExpression(expr) => expr.expression.get_inner_expression(),
Expression::TSTypeAssertion(expr) => expr.expression.get_inner_expression(),
_ => self,
let mut expr = self;
loop {
expr = match expr {
Expression::ParenthesizedExpression(e) => &e.expression,
Expression::TSAsExpression(e) => &e.expression,
Expression::TSSatisfiesExpression(e) => &e.expression,
Expression::TSInstantiationExpression(e) => &e.expression,
Expression::TSNonNullExpression(e) => &e.expression,
Expression::TSTypeAssertion(e) => &e.expression,
_ => break,
};
}
expr
}
pub fn get_inner_expression_mut(&mut self) -> &mut Expression<'a> {
match self {
Expression::ParenthesizedExpression(expr) => expr.expression.get_inner_expression_mut(),
Expression::TSAsExpression(expr) => expr.expression.get_inner_expression_mut(),
Expression::TSSatisfiesExpression(expr) => expr.expression.get_inner_expression_mut(),
Expression::TSInstantiationExpression(expr) => {
expr.expression.get_inner_expression_mut()
}
Expression::TSNonNullExpression(expr) => expr.expression.get_inner_expression_mut(),
Expression::TSTypeAssertion(expr) => expr.expression.get_inner_expression_mut(),
_ => self,
let mut expr = self;
loop {
expr = match expr {
Expression::ParenthesizedExpression(e) => &mut e.expression,
Expression::TSAsExpression(e) => &mut e.expression,
Expression::TSSatisfiesExpression(e) => &mut e.expression,
Expression::TSInstantiationExpression(e) => &mut e.expression,
Expression::TSNonNullExpression(e) => &mut e.expression,
Expression::TSTypeAssertion(e) => &mut e.expression,
_ => break,
};
}
expr
}
pub fn is_identifier_reference(&self) -> bool {