dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(semantic): methods take Span as param, not &Span (#4470)

Browse source 
`Span` is `Copy` and 8 bytes. So better to pass `Span` to functions, rather than `&Span` (which is also 8 bytes, but involves the indirection of a reference).
This commit is contained in:
overlookmotel 2024-07-26 00:14:56 +00:00
parent 24beaeb4ee
commit ccb1835a45
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_linter/src/rules/import/namespace.rs
View file

@ -99,7 +99,7 @@ impl Rule for Namespace {
}
let Some(symbol_id) =
ctx.semantic().symbols().get_symbol_id_from_span(&entry.local_name.span())
ctx.semantic().symbols().get_symbol_id_from_span(entry.local_name.span())
else {
return;
};

2
crates/oxc_linter/src/rules/import/no_named_as_default_member.rs
View file

@ -71,7 +71,7 @@ impl Rule for NoNamedAsDefaultMember {
if !remote_module_record_ref.exported_bindings.is_empty() {
has_members_map.insert(
ctx.symbols().get_symbol_id_from_span(&import_entry.local_name.span()).unwrap(),
ctx.symbols().get_symbol_id_from_span(import_entry.local_name.span()).unwrap(),
(remote_module_record_ref, import_entry.module_request.name().clone()),
);
}

6
crates/oxc_semantic/src/symbol.rs
View file

@ -64,10 +64,10 @@ impl SymbolTable {
self.spans.iter_enumerated().rev().map(|(symbol_id, _)| symbol_id)
}
pub fn get_symbol_id_from_span(&self, span: &Span) -> Option<SymbolId> {
pub fn get_symbol_id_from_span(&self, span: Span) -> Option<SymbolId> {
self.spans
.iter_enumerated()
.find_map(|(symbol, inner_span)| if inner_span == span { Some(symbol) } else { None })
.find_map(|(symbol, &inner_span)| if inner_span == span { Some(symbol) } else { None })
}
pub fn get_symbol_id_from_name(&self, name: &str) -> Option<SymbolId> {
@ -113,7 +113,7 @@ impl SymbolTable {
self.scope_ids[symbol_id]
}
pub fn get_scope_id_from_span(&self, span: &Span) -> Option<ScopeId> {
pub fn get_scope_id_from_span(&self, span: Span) -> Option<ScopeId> {
self.get_symbol_id_from_span(span).map(|symbol_id| self.get_scope_id(symbol_id))
}