dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(transformer): RegExp transform only set span on final expression (#5508)

Browse source
This commit is contained in:
overlookmotel 2024-09-06 12:02:43 +00:00
parent bb9d9d1481
commit 9b7ecc7ee7
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
crates/oxc_transformer/src/regexp/mod.rs
View file

@ -48,7 +48,7 @@ use oxc_regular_expression::ast::{
CharacterClass, CharacterClassContents, LookAroundAssertionKind, Pattern, Term,
};
use oxc_semantic::ReferenceFlags;
use oxc_span::Atom;
use oxc_span::{Atom, SPAN};
use oxc_traverse::{Traverse, TraverseCtx};
use crate::context::Ctx;
@ -164,7 +164,7 @@ impl<'a> Traverse<'a> for RegExp<'a> {
let callee = {
let symbol_id = ctx.scopes().find_binding(ctx.current_scope_id(), "RegExp");
let ident = ctx.create_reference_id(
regexp.span,
SPAN,
Atom::from("RegExp"),
symbol_id,
ReferenceFlags::read(),
@ -174,14 +174,11 @@ impl<'a> Traverse<'a> for RegExp<'a> {
let mut arguments = ctx.ast.vec_with_capacity(2);
arguments.push(
ctx.ast.argument_expression(
ctx.ast.expression_string_literal(regexp.span, pattern_source),
),
ctx.ast.argument_expression(ctx.ast.expression_string_literal(SPAN, pattern_source)),
);
let flags = regexp.regex.flags.to_string();
let flags =
ctx.ast.argument_expression(ctx.ast.expression_string_literal(regexp.span, flags));
let flags = ctx.ast.argument_expression(ctx.ast.expression_string_literal(SPAN, flags));
arguments.push(flags);
*expr = ctx.ast.expression_new(