dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(transformer): pre-calculate unsupported flags in RegExp transform (#5482)

Browse source 
Calculate unsupported RegExp flags at start, to make checking flags on each RegExp during traversal cheaper (a single OR operation). i.e. do work once at the start, rather than over and over each time you find a `RegExp`.
This commit is contained in:
overlookmotel 2024-09-05 12:47:34 +00:00
parent 2514cc92e5
commit 182ab91570
1 changed files with 22 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
crates/oxc_transformer/src/regexp/mod.rs
View file

@ -60,12 +60,31 @@ use crate::context::Ctx;
pub struct RegExp<'a> {
_ctx: Ctx<'a>,
unsupported_flags: RegExpFlags,
options: RegExpOptions,
}
impl<'a> RegExp<'a> {
pub fn new(options: RegExpOptions, ctx: Ctx<'a>) -> Self {
Self { _ctx: ctx, options }
// Get unsupported flags
let mut unsupported_flags = RegExpFlags::empty();
if options.dot_all_flag {
unsupported_flags |= RegExpFlags::S;
}
if options.sticky_flag {
unsupported_flags |= RegExpFlags::Y;
}
if options.unicode_flag {
unsupported_flags |= RegExpFlags::U;
}
if options.match_indices {
unsupported_flags |= RegExpFlags::D;
}
if options.set_notation {
unsupported_flags |= RegExpFlags::V;
}
Self { _ctx: ctx, unsupported_flags, options }
}
}
@ -79,9 +98,8 @@ impl<'a> Traverse<'a> for RegExp<'a> {
return;
};
if !self.has_unsupported_regular_expression_flags(regexp.regex.flags)
&& self.requires_pattern_analysis()
{
let has_unsupported_flags = regexp.regex.flags.intersects(self.unsupported_flags);
if !has_unsupported_flags && self.requires_pattern_analysis() {
match try_parse_pattern(regexp, ctx) {
Ok(pattern) => {
let is_unsupported = self.has_unsupported_regular_expression_pattern(&pattern);
@ -141,18 +159,6 @@ impl<'a> RegExp<'a> {
|| self.options.look_behind_assertions
}
/// Check if the regular expression contains any unsupported flags.
fn has_unsupported_regular_expression_flags(&self, flags: RegExpFlags) -> bool {
flags.iter().any(|f| match f {
RegExpFlags::S if self.options.dot_all_flag => true,
RegExpFlags::Y if self.options.sticky_flag => true,
RegExpFlags::U if self.options.unicode_flag => true,
RegExpFlags::D if self.options.match_indices => true,
RegExpFlags::V if self.options.set_notation => true,
_ => false,
})
}
/// Check if the regular expression contains any unsupported syntax.
///
/// Based on parsed regular expression pattern.