dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(transformer): store needed options only on RegExp (#5484)

Browse source 
#5482 makes most of the `RegExpOptions` not be needed outside `new` method. So only store the remaining options which are actually needed on `RegExp`. This reduces size of `RegExp`.

(this is micro-optimization, and unlikely to make a measurable difference, but why not?)
This commit is contained in:
overlookmotel 2024-09-05 12:47:36 +00:00
parent b4765af82a
commit bfab0914fa
1 changed files with 24 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
crates/oxc_transformer/src/regexp/mod.rs
View file

@ -62,7 +62,9 @@ pub struct RegExp<'a> {
_ctx: Ctx<'a>,
unsupported_flags: RegExpFlags,
some_unsupported_patterns: bool,
options: RegExpOptions,
look_behind_assertions: bool,
named_capture_groups: bool,
unicode_property_escapes: bool,
}
impl<'a> RegExp<'a> {
@ -86,11 +88,24 @@ impl<'a> RegExp<'a> {
}
// Get if some unsupported patterns
let some_unsupported_patterns = options.named_capture_groups
|| options.unicode_property_escapes
|| options.look_behind_assertions;
let RegExpOptions {
look_behind_assertions,
named_capture_groups,
unicode_property_escapes,
..
} = options;
Self { _ctx: ctx, unsupported_flags, some_unsupported_patterns, options }
let some_unsupported_patterns =
look_behind_assertions || named_capture_groups || unicode_property_escapes;
Self {
_ctx: ctx,
unsupported_flags,
some_unsupported_patterns,
look_behind_assertions,
named_capture_groups,
unicode_property_escapes,
}
}
}
@ -165,13 +180,13 @@ impl<'a> RegExp<'a> {
fn has_unsupported_regular_expression_pattern(&self, pattern: &Pattern<'a>) -> bool {
let check_terms = |terms: &Vec<'a, Term>| {
terms.iter().any(|element| match element {
Term::CapturingGroup(_) if self.options.named_capture_groups => true,
Term::UnicodePropertyEscape(_) if self.options.unicode_property_escapes => true,
Term::CharacterClass(character_class) if self.options.unicode_property_escapes => {
Term::CapturingGroup(_) if self.named_capture_groups => true,
Term::UnicodePropertyEscape(_) if self.unicode_property_escapes => true,
Term::CharacterClass(character_class) if self.unicode_property_escapes => {
has_unicode_property_escape_character_class(character_class)
}
Term::LookAroundAssertion(assertion)
if self.options.look_behind_assertions
if self.look_behind_assertions
&& matches!(
assertion.kind,
LookAroundAssertionKind::Lookbehind