dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(minifier): InjectGlobalVariables only add to replaced_dot_defines once for each (#4803)

Browse source 
`InjectGlobalVariables` minifier plugin was previously adding an entry to `replaced_dot_defines` each time it made a replacement, resulting in many duplicate entries if a single dot define gets replaced multiple times. Only add once for each dot define.
This commit is contained in:
overlookmotel 2024-08-10 13:46:15 +00:00
parent 35f27420b9
commit 504ac0b178
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
crates/oxc_minifier/src/plugins/inject_global_variables.rs
View file

@ -222,16 +222,18 @@ impl<'a> InjectGlobalVariables<'a> {
if let Expression::StaticMemberExpression(member) = expr {
for DotDefineState { dot_define, value_atom } in &mut self.dot_defines {
if ReplaceGlobalDefines::is_dot_define(dot_define, member) {
// Create `Atom` for replacement lazily on first replacement
// If this is first replacement made for this dot define,
// create `Atom` for replacement, and record in `replaced_dot_defines`
if value_atom.is_none() {
*value_atom = Some(self.ast.atom(dot_define.value.as_str()));
self.replaced_dot_defines
.push((dot_define.parts[0].clone(), dot_define.value.clone()));
}
let value_atom = value_atom.as_ref().unwrap().clone();
let value = self.ast.expression_identifier_reference(SPAN, value_atom);
*expr = value;
self.replaced_dot_defines
.push((dot_define.parts[0].clone(), dot_define.value.clone()));
break;
}
}