dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(codegen): print TSSatisfiesExpression and TSInstantiationExpression (#4936)

Browse source 
I can't figure out the precedence so printing extra parentheses instead ...
This commit is contained in:
Boshen 2024-08-16 09:53:17 +00:00
parent 61cdfef5c7
commit f210cf7873
2 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
crates/oxc_codegen/src/gen.rs
View file

@ -2098,7 +2098,7 @@ impl<'a, const MINIFY: bool> GenExpr<MINIFY> for TSAsExpression<'a> {
fn gen_expr(&self, p: &mut Codegen<{ MINIFY }>, precedence: Precedence, ctx: Context) {
p.print_char(b'(');
p.print_char(b'(');
self.expression.gen_expr(p, precedence, ctx);
self.expression.gen_expr(p, precedence, Context::default());
p.print_char(b')');
p.print_str(" as ");
self.type_annotation.gen(p, ctx);
@ -2108,8 +2108,13 @@ impl<'a, const MINIFY: bool> GenExpr<MINIFY> for TSAsExpression<'a> {
impl<'a, const MINIFY: bool> GenExpr<MINIFY> for TSSatisfiesExpression<'a> {
fn gen_expr(&self, p: &mut Codegen<{ MINIFY }>, precedence: Precedence, ctx: Context) {
// TODO: print properly
self.expression.gen_expr(p, precedence, ctx);
p.print_char(b'(');
p.print_char(b'(');
self.expression.gen_expr(p, precedence, Context::default());
p.print_char(b')');
p.print_str(" satisfies ");
self.type_annotation.gen(p, ctx);
p.print_char(b')');
}
}
@ -2127,8 +2132,11 @@ impl<'a, const MINIFY: bool> GenExpr<MINIFY> for TSNonNullExpression<'a> {
impl<'a, const MINIFY: bool> GenExpr<MINIFY> for TSInstantiationExpression<'a> {
fn gen_expr(&self, p: &mut Codegen<{ MINIFY }>, precedence: Precedence, ctx: Context) {
// TODO: print properly
self.expression.gen_expr(p, precedence, ctx);
self.type_parameters.gen(p, ctx);
if MINIFY {
p.print_hard_space();
}
}
}

4
crates/oxc_codegen/tests/integration/snapshots/ts.snap
View file

@ -102,7 +102,7 @@ b = (x as y);
b = ((x) as y);
c = foo<string>;
c = foo;
c = foo<string>;
d = x satisfies y;
d = x;
d = ((x) satisfies y);