dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(semantic): transform checker check reference symbol IDs (#5090)

Browse source 
Previously was checking that references point to symbols with same name, but not necessarily the same symbol (there could be 2 different symbols with same name).
This commit is contained in:
overlookmotel 2024-08-22 23:40:26 +00:00
parent a8005b9914
commit 90c74ee449
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
crates/oxc_semantic/src/post_transform_checker.rs
View file

@ -499,7 +499,6 @@ impl<'s> PostTransformChecker<'s> {
return;
}
// Check whether symbols match
for reference_ids in self
.after_transform
.ids
@ -509,13 +508,18 @@ impl<'s> PostTransformChecker<'s> {
.zip(self.rebuilt.ids.reference_ids.iter().copied())
.map(Pair::from_tuple)
{
// Check symbol IDs match
let symbol_ids = self.get_pair(reference_ids, |data, reference_id| {
data.symbols.references[reference_id].symbol_id()
});
let symbol_names = self.get_pair(symbol_ids, |data, symbol_id| {
symbol_id.map(|symbol_id| data.symbols.names[symbol_id].clone())
});
if symbol_names.is_mismatch() {
let symbol_ids_remapped = Pair::new(
symbol_ids.after_transform.map(|symbol_id| self.symbol_ids_map.get(symbol_id)),
symbol_ids.rebuilt.map(Option::Some),
);
if symbol_ids_remapped.is_mismatch() {
let symbol_names = self.get_pair(symbol_ids, |data, symbol_id| {
symbol_id.map(|symbol_id| data.symbols.names[symbol_id].clone())
});
self.errors.push_mismatch("Reference mismatch", reference_ids, symbol_names);
}
}

3
tasks/coverage/semantic_typescript.snap
View file

@ -21348,6 +21348,9 @@ rebuilt : SymbolId(0): [ReferenceId(6)]
Symbol reference IDs mismatch:
after transform: SymbolId(3): [ReferenceId(1), ReferenceId(2), ReferenceId(3), ReferenceId(4), ReferenceId(5)]
rebuilt : SymbolId(1): [ReferenceId(0), ReferenceId(1), ReferenceId(2), ReferenceId(3), ReferenceId(4), ReferenceId(5)]
Reference mismatch:
after transform: ReferenceId(0): Some("E")
rebuilt : ReferenceId(4): Some("E")
tasks/coverage/typescript/tests/cases/compiler/underscoreMapFirst.ts
semantic error: Bindings mismatch: