dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

docs(span): update docs about ContentEq Vec comparison speed (#5478)

Browse source 
Update the docs for `impl ContentEq for Vec` to state in what circumstances `PartialEq` is faster. See https://github.com/oxc-project/oxc/pull/5427#discussion_r1744290058.
This commit is contained in:
overlookmotel 2024-09-05 15:34:17 +00:00
parent 94a6ac63cf
commit 3f204a9af5
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
crates/oxc_span/src/cmp.rs
View file

@ -59,10 +59,10 @@ impl<'a, T: ContentEq> ContentEq for oxc_allocator::Box<'a, T> {
/// Blanket implementation for [oxc_allocator::Vec] types
///
/// # WARNING
///
/// This implementation is slow compared to `[PartialEq]`, Consider comparing the 2 vectors using
/// that when one is implemented. This implementation takes triple the time the `PartialEq` would take.
/// # Warning
/// This implementation is slow compared to [PartialEq] for native types which are [Copy] (e.g. `u32`).
/// Prefer comparing the 2 vectors using `==` if they contain such native types (e.g. `Vec<u32>`).
/// <https://godbolt.org/z/54on5sMWc>
impl<'a, T: ContentEq> ContentEq for oxc_allocator::Vec<'a, T> {
#[inline]
fn content_eq(&self, other: &Self) -> bool {