dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(diagnostic): change how diagnostic codes are rendered (#5317)

Browse source 
Preparation for upstack PRs. Graphical reporter diagnostics look exactly the same. This does, however, change `to_string()` to only show diagnostic messages, and not error codes + messages.
This commit is contained in:
DonIsaac 2024-08-29 05:50:03 +00:00
parent 53ff3493ef
commit cd63336c7e
3 changed files with 14 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
crates/oxc_diagnostics/src/graphic_reporter.rs
View file

@ -188,7 +188,7 @@ impl GraphicalReportHandler {
f: &mut impl fmt::Write,
diagnostic: &(dyn Diagnostic),
) -> fmt::Result {
self.render_header(f, diagnostic)?;
// self.render_header(f, diagnostic)?;
writeln!(f)?;
self.render_causes(f, diagnostic)?;
let src = diagnostic.source_code();
@ -271,7 +271,12 @@ impl GraphicalReportHandler {
opts = opts.word_splitter(word_splitter);
}
let title = format!("{}", diagnostic.to_string().style(severity_style));
let title = if let Some(code) = diagnostic.code() {
format!("{code}: {diagnostic}")
} else {
diagnostic.to_string()
};
let title = format!("{}", title.style(severity_style));
let title = textwrap::fill(&title, opts);
writeln!(f, "{}", title)?;

6
crates/oxc_diagnostics/src/lib.rs
View file

@ -75,9 +75,6 @@ pub struct OxcDiagnosticInner {
impl fmt::Display for OxcDiagnostic {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> std::fmt::Result {
if self.code.is_some() {
write!(f, "{}: ", &self.code)?;
}
write!(f, "{}", &self.message)
}
}
@ -102,8 +99,7 @@ impl Diagnostic for OxcDiagnostic {
}
fn code<'a>(&'a self) -> Option<Box<dyn Display + 'a>> {
// self.code.is_some().then(|| Box::new(&self.code) as Box<dyn Display>)
None
self.code.is_some().then(|| Box::new(&self.code) as Box<dyn Display>)
}
}

10
tasks/transform_conformance/babel.snap.md
View file

@ -2146,8 +2146,9 @@ failed to resolve query: failed to parse the rest of input: ...''
* class/accessor-allowDeclareFields-false/input.ts
x TS(18010): An accessibility modifier cannot be used with a private
| identifier.
TS(18010)
x An accessibility modifier cannot be used with a private identifier.
,-[tasks/coverage/babel/packages/babel-plugin-transform-typescript/test/fixtures/class/accessor-allowDeclareFields-false/input.ts:8:3]
7 | abstract accessor prop6: number;
8 | private accessor #p: any;
@ -2157,8 +2158,9 @@ failed to resolve query: failed to parse the rest of input: ...''
* class/accessor-allowDeclareFields-true/input.ts
x TS(18010): An accessibility modifier cannot be used with a private
| identifier.
TS(18010)
x An accessibility modifier cannot be used with a private identifier.
,-[tasks/coverage/babel/packages/babel-plugin-transform-typescript/test/fixtures/class/accessor-allowDeclareFields-true/input.ts:8:3]
7 | abstract accessor prop6: number;
8 | private accessor #p: any;