dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(parser): convert Lexer::read_left_angle to a single match (#4573)

Browse source 
`Lexer::read_left_angle` was a series of disparate `next_ascii_byte_eq` and `peek_byte` calls. Convert it to a single match on `peek_byte`. This I think will remove a couple of bounds checks.
This commit is contained in:
overlookmotel 2024-07-31 03:32:54 +00:00
parent 25679e6277
commit ef5418a917
1 changed files with 16 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
crates/oxc_parser/src/lexer/punctuation.rs
View file

@ -16,22 +16,23 @@ impl<'a> Lexer<'a> {
/// returns None for `SingleLineHTMLOpenComment` `<!--` in script mode
pub(super) fn read_left_angle(&mut self) -> Option<Kind> {
if self.next_ascii_byte_eq(b'<') {
if self.next_ascii_byte_eq(b'=') {
Some(Kind::ShiftLeftEq)
} else {
Some(Kind::ShiftLeft)
match self.peek_byte() {
Some(b'<') => {
self.consume_char();
if self.next_ascii_byte_eq(b'=') {
Some(Kind::ShiftLeftEq)
} else {
Some(Kind::ShiftLeft)
}
}
} else if self.next_ascii_byte_eq(b'=') {
Some(Kind::LtEq)
} else if self.peek_byte() == Some(b'!')
// SingleLineHTMLOpenComment `<!--` in script mode
&& self.source_type.is_script()
&& self.remaining().starts_with("!--")
{
None
} else {
Some(Kind::LAngle)
Some(b'=') => {
self.consume_char();
Some(Kind::LtEq)
}
Some(b'!') if self.source_type.is_script() && self.remaining().starts_with("!--") => {
None
}
_ => Some(Kind::LAngle),
}
}