dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(ast): remove #[visit(ignore)] from ExportDefaultDeclarationKind's TSInterfaceDeclaration (#4497)

Browse source 
I can't find any reason to add `#[visit(ignore)]` there
This commit is contained in:
Dunqing 2024-07-27 02:11:53 +00:00
parent f5f0ba8c33
commit 368112c9ac
5 changed files with 22 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
crates/oxc_ast/src/ast/js.rs
View file

@ -2312,7 +2312,6 @@ pub enum ExportDefaultDeclarationKind<'a> {
FunctionDeclaration(Box<'a, Function<'a>>) = 64,
ClassDeclaration(Box<'a, Class<'a>>) = 65,
#[visit(ignore)]
TSInterfaceDeclaration(Box<'a, TSInterfaceDeclaration<'a>>) = 66,
// `Expression` variants added here by `inherit_variants!` macro

4
crates/oxc_ast/src/generated/visit.rs
View file

@ -4154,10 +4154,12 @@ pub mod walk {
visitor.visit_function(it, flags)
}
ExportDefaultDeclarationKind::ClassDeclaration(it) => visitor.visit_class(it),
ExportDefaultDeclarationKind::TSInterfaceDeclaration(it) => {
visitor.visit_ts_interface_declaration(it)
}
match_expression!(ExportDefaultDeclarationKind) => {
visitor.visit_expression(it.to_expression())
}
_ => {}
}
}

4
crates/oxc_ast/src/generated/visit_mut.rs
View file

@ -4396,10 +4396,12 @@ pub mod walk_mut {
visitor.visit_function(it, flags)
}
ExportDefaultDeclarationKind::ClassDeclaration(it) => visitor.visit_class(it),
ExportDefaultDeclarationKind::TSInterfaceDeclaration(it) => {
visitor.visit_ts_interface_declaration(it)
}
match_expression!(ExportDefaultDeclarationKind) => {
visitor.visit_expression(it.to_expression_mut())
}
_ => {}
}
}

9
crates/oxc_linter/src/snapshots/consistent_type_definitions.snap
View file

@ -120,6 +120,15 @@ source: crates/oxc_linter/src/tester.rs
╰────
help: Use an `type` instead of a `interface`
⚠ typescript-eslint(consistent-type-definitions): Use an `type` instead of a `interface`
╭─[consistent_type_definitions.tsx:2:19]
1 │
2 │ export default interface Test {
· ─────────
3 │ bar(): string;
╰────
help: Use an `type` instead of a `interface`
⚠ typescript-eslint(consistent-type-definitions): Use an `interface` instead of a `type`
╭─[consistent_type_definitions.tsx:2:19]
1 │

7
crates/oxc_linter/src/snapshots/prefer_function_type.snap
View file

@ -15,6 +15,13 @@ source: crates/oxc_linter/src/tester.rs
╰────
help: The function type form `() => string` is generally preferred when possible for being more succinct.
⚠ typescript-eslint(prefer-function-type): Enforce using function types instead of interfaces with call signatures.
╭─[prefer_function_type.tsx:1:47]
1 │ export default interface Foo { /** comment */ (): string; }
· ───────────
╰────
help: The function type form `() => string` is generally preferred when possible for being more succinct.
⚠ typescript-eslint(prefer-function-type): Enforce using function types instead of interfaces with call signatures.
╭─[prefer_function_type.tsx:4:11]
3 │ // comment