dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(transformer): remove an AstBuilder::copy call from TS module transform (#4986)

Browse source 
Remove an unsafe `AstBuilder::copy` call from TS module transform. `IdentifierReference` is `Clone`, so we can just clone it rather than copy. Same result, but safe.

Also shorten the surrounding code a bit, using `.unwrap()` instead of an `unreachable!()` branch.
This commit is contained in:
overlookmotel 2024-08-19 21:09:11 +00:00
parent 1467eb306c
commit a8dfddaeab
1 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
crates/oxc_transformer/src/typescript/module.rs
View file

@ -85,15 +85,12 @@ impl<'a> TypeScript<'a> {
) -> Expression<'a> {
match type_name {
TSTypeName::IdentifierReference(ident) => {
let mut ident = ident.clone();
ident.reference_flag = ReferenceFlag::Read;
if let Some(reference_id) = ident.reference_id.get() {
let reference = ctx.symbols_mut().get_reference_mut(reference_id);
*reference.flag_mut() = ReferenceFlag::Read;
} else {
unreachable!()
}
// SAFETY: `ast.copy` is unsound! We need to fix.
self.ctx.ast.expression_from_identifier_reference(unsafe { ctx.ast.copy(ident) })
let reference_id = ident.reference_id.get().unwrap();
let reference = ctx.symbols_mut().get_reference_mut(reference_id);
*reference.flag_mut() = ReferenceFlag::Read;
self.ctx.ast.expression_from_identifier_reference(ident)
}
TSTypeName::QualifiedName(qualified_name) => self
.ctx