dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(transformer/react): incorrect scope_id for var hoisted in fast refresh plugin (#5695)

Browse source 
Fix the last one semantic error in the fast react plugin
This commit is contained in:
Dunqing 2024-09-11 09:02:28 +00:00
parent f2f5e5aaf5
commit a1afd48c68
2 changed files with 10 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
crates/oxc_transformer/src/react/refresh.rs
View file

@ -685,8 +685,14 @@ impl<'a> ReactRefresh<'a> {
.push(self.ctx.ast.argument_expression(ctx.ast.expression_from_function(function)));
}
let symbol_id =
ctx.generate_uid("s", ctx.current_scope_id(), SymbolFlags::FunctionScopedVariable);
// TODO: Handle var hoisted in ctx API
let target_scope_id = ctx
.scopes()
.ancestors(ctx.current_scope_id())
.find(|scope_id| ctx.scopes().get_flags(*scope_id).is_var())
.unwrap_or_else(|| ctx.current_scope_id());
let symbol_id = ctx.generate_uid("s", target_scope_id, SymbolFlags::FunctionScopedVariable);
let symbol_name = ctx.ast.atom(ctx.symbols().get_name(symbol_id));

15
tasks/transform_conformance/oxc.snap.md
View file

@ -1,6 +1,6 @@
commit: 3bcfee23
Passed: 40/52
Passed: 41/52
# All Passed:
* babel-plugin-transform-nullish-coalescing-operator
@ -167,18 +167,7 @@ rebuilt : SymbolId(2): []
x Output mismatch
# babel-plugin-transform-react-jsx (26/30)
* refresh/does-not-get-tripped-by-iifes/input.jsx
Bindings mismatch:
after transform: ScopeId(0): []
rebuilt : ScopeId(0): ["_s"]
Bindings mismatch:
after transform: ScopeId(1): ["_s"]
rebuilt : ScopeId(1): []
Symbol scope ID mismatch:
after transform: SymbolId(1): ScopeId(1)
rebuilt : SymbolId(0): ScopeId(0)
# babel-plugin-transform-react-jsx (27/30)
* refresh/does-not-transform-it-because-it-is-not-used-in-the-AST/input.jsx
x Output mismatch