dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

test(semantic): add more symbol and reference checks to PostTransformChecker

Browse source
This commit is contained in:
Boshen 2024-08-19 15:44:17 +08:00
parent 4fdf26dac8
commit 0df1a94a1b
No known key found for this signature in database
GPG key ID: 67715A371E534061
1 changed files with 31 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
crates/oxc_semantic/src/post_transform_checker.rs
View file

@ -109,8 +109,23 @@ current scope {cur_scope_id:?}: {current_bindings:?}
_previous_scopes: &ScopeTree,
current_collect: &SemanticCollector,
current_symbols: &SymbolTable,
_current_scopes: &ScopeTree,
current_scopes: &ScopeTree,
) {
// Check whether symbols are valid
for symbol_id in current_collect.symbol_ids.iter().copied() {
if current_symbols.get_flag(symbol_id).is_empty() {
let name = current_symbols.get_name(symbol_id);
self.errors.push(OxcDiagnostic::error(format!(
"Expect non-empty SymbolFlags for BindingIdentifier({name})"
)));
if !current_scopes.has_binding(current_symbols.get_scope_id(symbol_id), name) {
self.errors.push(OxcDiagnostic::error(
format!("Cannot find BindingIdentifier({name}) in the Scope corresponding to the Symbol"),
));
}
}
}
if self.previous_collect.symbol_ids.len() != current_collect.symbol_ids.len() {
self.errors.push(OxcDiagnostic::error("Symbols mismatch after transform"));
return;
@ -143,6 +158,16 @@ current symbol {cur_symbol_id:?}: {cur_symbol_id:?}
current_symbols: &SymbolTable,
_current_scopes: &ScopeTree,
) {
// Check whether references are valid
for reference_id in current_collect.reference_ids.iter().copied() {
let reference = current_symbols.get_reference(reference_id);
if reference.flag().is_empty() {
self.errors.push(OxcDiagnostic::error(format!(
"Expect ReferenceFlags for IdentifierReference({reference_id:?}) to not be empty",
)));
}
}
if self.previous_collect.reference_ids.len() != current_collect.reference_ids.len() {
self.errors.push(OxcDiagnostic::error("ReferenceId mismatch after transform"));
return;
@ -175,8 +200,8 @@ struct SemanticCollector {
scope_ids: Vec<ScopeId>,
symbol_ids: Vec<SymbolId>,
reference_ids: Vec<ReferenceId>,
missing_references: Vec<Span>,
missing_symbols: Vec<Span>,
errors: Vec<OxcDiagnostic>,
}
impl<'a> Visit<'a> for SemanticCollector {
@ -190,7 +215,7 @@ impl<'a> Visit<'a> for SemanticCollector {
if let Some(reference_id) = ident.reference_id.get() {
self.reference_ids.push(reference_id);
} else {
self.missing_references.push(ident.span);
self.errors.push(OxcDiagnostic::error("Missing ReferenceId").with_label(ident.span));
}
}
@ -198,7 +223,7 @@ impl<'a> Visit<'a> for SemanticCollector {
if let Some(symbol_id) = ident.symbol_id.get() {
self.symbol_ids.push(symbol_id);
} else {
self.missing_symbols.push(ident.span);
self.errors.push(OxcDiagnostic::error("Missing SymbolId").with_label(ident.span));
}
}
@ -248,17 +273,6 @@ impl SemanticCollector {
fn check_ast(&mut self, program: &Program<'_>) -> Option<Vec<OxcDiagnostic>> {
self.visit_program(program);
let diagnostics = self
.missing_references
.iter()
.map(|span| OxcDiagnostic::error("Missing ReferenceId").with_label(*span))
.chain(
self.missing_symbols
.iter()
.map(|span| OxcDiagnostic::error("Missing SymbolId").with_label(*span)),
)
.collect::<Vec<_>>();
(!diagnostics.is_empty()).then_some(diagnostics)
(!self.errors.is_empty()).then(|| mem::take(&mut self.errors))
}
}