Boshen
f99528d3c2
refactor(coverage): remove unused run_sync_v8_test262_status ( #6704 )
2024-10-20 16:02:26 +00:00
DonIsaac
6a76ea8d3d
perf(linter/no-unused-vars): use default IgnorePattern when /^_/ is provided as a pattern ( #6697 )
...
Use `IgnorePattern::Default` even when `/^_/` is explicitly provided as a regex. This gives better diagnostic messages and lets us use `starts_with('_')` in more cases.
2024-10-20 15:49:56 +00:00
Boshen
8b25131d11
refactor(minifier): binary operations use ConstantEvaluation ( #6700 )
2024-10-20 15:13:27 +00:00
Boshen
3711c32f22
chore(coverage): bump test262, babel and TypeScript ( #6702 )
...
closes #6692
2024-10-20 15:02:26 +00:00
Tapan Prakash
5095f027e5
feat(linter): Added fixer for duplicate prefix in valid title jest rule ( #6699 )
2024-10-20 10:46:49 -04:00
DonIsaac
01a35bb446
feat(linter/eslint): show ignore patterns in eslint/no-unused-vars diagnostic messages ( #6696 )
...
Inform users what pattern an unused variable must match in diagnostic help messages.
```
⚠ eslint(no-unused-vars): Variable 'a' is declared but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:5]
1 │ var a=10
· ┬
· ╰── 'a' is declared here
╰────
help: Consider removing this declaration.
```
2024-10-20 04:24:53 +00:00
Tapan Prakash
e9976d46d4
feat(linter): Add title whitespace fixer for jest valid title rule ( #6669 )
...
Supported fixer for white space in title for valid title rule.
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-10-19 23:56:51 -04:00
Brian Liu
45f02d5a41
feat(linter): add unicorn/consistent-empty-array-spread ( #6695 )
...
[unicorn/consistent-empty-array-spread](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v56.0.0/docs/rules/consistent-empty-array-spread.md )
of #684
---------
Co-authored-by: Brian Liu <brian@redflagsdating.com>
Co-authored-by: Don Isaac <donald.isaac@gmail.com>
2024-10-19 23:40:11 -04:00
DonIsaac
a5de2309bc
fix(linter/import): import/no-duplicates handles namespace imports correctly ( #6694 )
...
Closes #6660
- Value (i.e. not `import type`) namespace imports are now grouped correctly
- When grouping, consider _all_ import entries, not just the first one. Fixes a false negative when inlined `type` imports are used, e.g. `import { a, type b } from 'foo'`
2024-10-20 00:21:00 +00:00
DonIsaac
23f88b3e18
refactor(linter/import): better diagnostic messages for import/no-duplicates ( #6693 )
...
## What This PR Does
- Include the offending module in the diagnostic's message
- Add a help message
- Add label text to the first module request
It also includes these minor refactors:
- Move `check_request` closure into a separate function
- Move diagnostics creation to a separate function (same as every other rule)
2024-10-20 00:20:59 +00:00
overlookmotel
85e69a11ef
refactor(ast_tools): add line breaks to generated code for ESTree derive ( #6680 )
...
Follow-on after #6404 . Style nit. Add line breaks to generated code, to make it easier to read.
2024-10-19 19:50:13 +00:00
overlookmotel
ad8e293197
refactor(ast_tools): shorten generated code for impl Serialize ( #6684 )
...
Follow-on after #6404 . Shorten generated code for `impl Serialize`.
2024-10-19 19:50:12 +00:00
overlookmotel
9ba2b0e3a3
refactor(ast_tools): move #[allow] attrs to top of generated files ( #6679 )
...
Follow-on after #6404 . Shorten generated code for `impl Serialize` by moving `#[allow]` attrs to top of file.
2024-10-19 19:50:12 +00:00
overlookmotel
f0dd19a48f
refactor(ast_tools): shorten code ( #6678 )
...
Follow-on after #6404 . Pure refactor. Shorten code for deriving `ESTree` by reducing repetition.
2024-10-19 19:50:11 +00:00
overlookmotel
59dd061cea
refactor(ast_tools): rename var ( #6676 )
...
Follow-on after #6404 . Pure refactor. Rename `type_def` to `ts_type_def` to clarify that it's not an instance of `TypeDef` type.
2024-10-19 19:50:11 +00:00
overlookmotel
11458a5bfd
refactor(ast_tools): shorten generated code by avoiding ref in matches ( #6675 )
...
Follow-on after #6404 .
Shorten generated code for deriving `ESTree` by avoiding `ref` in matches.
2024-10-19 19:50:10 +00:00
camchenry
2eb984ab05
refactor(linter): add missing should_run implementations ( #6666 )
...
Added some `should_run` implementations that probably should exist but didn't previously.
2024-10-19 17:54:25 +00:00
7086cmd
34fe7c00a3
feat(minifier): dce meaningless labeled statements ( #6688 )
2024-10-19 15:48:54 +00:00
overlookmotel
e1c2d30d44
fix(allocator)!: make Vec non-drop ( #6623 )
...
`oxc_allocator::Vec` is intended for storing AST types in the arena. `Vec` is intended to be non-drop, because all AST types are non-drop. If they were not, it would be a memory leak, because those types will not have `drop` called on them when the allocator is dropped.
However, `oxc_allocator::Vec` is currently a wrapper around `allocator_api2::vec::Vec`, which *is* drop. That unintentionally makes `oxc_allocator::Vec` drop too.
This PR fixes this by wrapping the inner `allocator_api2::vec::Vec` in `ManuallyDrop`. This makes `oxc_allocator::Vec` non-drop.
The wider consequence of this change is that the compiler is now able to see that loads of other types which contain `oxc_allocator::Vec` are also non-drop. Once it can prove that, it can remove a load of code which handles dropping these types in the event of a panic. This probably also then allows it to make many further optimizations on that simplified code.
Strictly speaking, this PR is a breaking change. If `oxc_allocator::Vec` is abused to store drop types, then in some circumstances this change could produce a memory leak where there was none before. However, we've always been clear that only non-drop types should be stored in the arena, so such usage was always a bug.
#6622 fixes the only place in Oxc where we mistakenly stored non-drop types in `Vec`.
The change to `oxc_prettier` is because compiler can now deduce that `Doc` is non-drop, which causes clippy to raise a warning about using `then` instead of `then_some`.
As follow-up, we should:
1. Wrap other `allocator_api2` types (e.g. `IntoIter`) in `ManuallyDrop` too, so compiler can prove they are non-drop too (or reimplement `Vec` ourselves - #6488 ).
2. Introduce static checks to prevent non-drop types being used in `Box` and `Vec`, to make memory leaks impossible, and detect them at compile time.
2024-10-19 15:43:54 +00:00
oxc-bot
de99391032
release(crates): v0.32.0 ( #6691 )
...
## [0.32.0] - 2024-10-19
- c0e9d7e#6539 ) (overlookmotel)
- 782f0a7#6512 ) (overlookmotel)
- 91c87dd#6452 ) (Boshen)
- 7645e5c#6451 )
(Boshen)
- 5200960#6446 )
(Boshen)
- 2808973#6445 ) (Boshen)
### Features
- 5ee1ef3#6195 ) (DonIsaac)
- d9718ad#6350 ) (DonIsaac)
- e5ed6a5#6624 ) (Boshen)
- 15c04e5d11770d#6576 ) (Boshen)
- e561880#6550 ) (Boshen)
- 3556062#6549 ) (Boshen)
- 39c2e66#6508 )
(Boshen)
- 6f22538#6502 )
(Boshen)
- 15dfc1d#6372 )
(DonIsaac)
- 071e564#6586 ) (camc314)
- 590925a#6575 ) (camc314)
- ef237cf#6566 )
(camc314)
- 97c8a36#6464 )
(dalaoshu)
- 096e590#6436 )
(camc314)
- e5a6f5d#6486 ) (camc314)
- 14d0590#6484 ) (camc314)
- 7fbc7b6#6483 ) (camc314)
- a4f57a4#6435 ) (camc314)
- 3677ef8#6457 )
(7086cmd)
- 06ea121#6450 ) (7086cmd)
- a9544ae#6424 ) (camc314)
- 9dc4ee9#6422 ) (camc314)
- ebbf77d#6419 )
(7086cmd)
- 97ac179#6332 )
(7086cmd)
- 13b0b0b#6379 )
(dalaoshu)
- e310e52#6404 )
(ottomated)
- 58467a5#6482 )
(DonIsaac)
- 8ea6b72#6478 ) (DonIsaac)
- b5b0af9#6410 )
(leaysgur)
- a01a5df#6633 ) (Dunqing)
- a9260cf#5590 ) (Ethan Goh)
- 8fe1b0a#6162 ) (Dunqing)
- ab51c2a#6434 ) (Dunqing)
- a3dea9c#6640 ) (Dunqing)
- 41c8675#6449 )
(Dunqing)
### Bug Fixes
- ba385fc#6593 ) (Dunqing)
- 02bfbfe#6430 )
(Dunqing)
- 2ade16e#6431 ) (camc314)
- 6896efc#6428 )
(camc314)
- 7cc05f1#6526 ) (overlookmotel)
- 2ce3e5f#6662 )
(Boshen)
- 2673397#6622 )
(overlookmotel)
- 389d261#6598 )
(Boshen)
- 16bea12#6597 ) (Boshen)
- a71e8a0#6551 ) (magic-akari)
- 721cf0f#6588 ) (Dunqing)
- b1bf12c#6442 ) (Boshen)
- 9f9057b#6524 )
(Tapan Prakash)
- c822b48#6415 ) (leaysgur)
- 384d5be#6396 )
(ottomated)
- 834ee2a#6351 ) (DonIsaac)
- 1d3d256#6639 ) (magic-akari)
- c6f2b5f#6569 ) (overlookmotel)
- 85d93ed#6386 ) (overlookmotel)
### Performance
- 77f3a1a#6509 )
(overlookmotel)
- 18b68ff#6516 )
(overlookmotel)
- 4d8bc8c#6443 ) (Boshen)
- 7c20056#6528 )
(DonIsaac)
- f70a413#6570 ) (overlookmotel)
- ac77c87#6663 ) (overlookmotel)
### Documentation
- 9f555d7#6625 ) (overlookmotel)
- 06e75b0#6613 ) (DonIsaac)
- 7e909a7#6535 ) (overlookmotel)
- 235d357#6511 )
(overlookmotel)
- c8fa2eb#6504 ) (overlookmotel)
- 40d1ee4#6499 )
(overlookmotel)
- de22b81#6612 ) (DonIsaac)
- 9e9fa9e#6617 )
(overlookmotel)
- 6a194f9#6423 )
(Boshen)
- 335b7f2#6611 ) (DonIsaac)
- f3451d7#6642 ) (overlookmotel)
- 448388a#6574 )
(Dunqing)
### Refactor
- 073b02a#6391 ) (overlookmotel)
- 458f8f3#6664 )
(overlookmotel)
- 51fc63d#6517 ) (overlookmotel)
- 05a2ebd#6514 )
(overlookmotel)
- e7f3e28#6510 ) (overlookmotel)
- 1bbd383#6507 )
(overlookmotel)
- cd9fe9e#6506 )
(overlookmotel)
- fc536a5#6501 ) (overlookmotel)
- 7420620#6498 )
(overlookmotel)
- 8ae174b#6496 ) (overlookmotel)
- 5843e01#6495 )
(overlookmotel)
- 951def6#6494 )
(overlookmotel)
- 84a51ee#6493 ) (overlookmotel)
- 05bd616#6492 ) (overlookmotel)
- 204bf55#6148 )
(DonIsaac)
- 702b574#6429 ) (Dunqing)
- aa6ba24#6577 )
(magic-akari)
- 6d041fb#6519 ) (Boshen)
- 856cab5#6471 ) (Boshen)
- 1ba2a24#6470 ) (Boshen)
- a504f96#6374 ) (DonIsaac)
- f4cdc56#6647 ) (Boshen)
- 67ad08a#6545 ) (Boshen)
- bbca743#6472 )
(Boshen)
- 702c049#6468 ) (7086cmd)
- 46a38c6#6441 ) (Boshen)
- 994b60b#6335 ) (7086cmd)
- 435a89c#6571 )
(Boshen)
- c45723b#6500 ) (overlookmotel)
- 1a90ec4#6690 )
(Boshen)
- 3faee66#6609 )
(DonIsaac)
- 9281234#6643 ) (overlookmotel)
- 3af0840#6601 )
(overlookmotel)
- f81aa7f#6599 )
(overlookmotel)
- 679cc68#6596 ) (overlookmotel)
- c346ebb#6595 ) (overlookmotel)
- 7a028b3#6585 )
(overlookmotel)
- 8c6afe0#6582 ) (overlookmotel)
- 779ff46#6568 ) (overlookmotel)
- bc24a24#6567 ) (overlookmotel)
- 9f02fc7#6565 ) (overlookmotel)
- 50ecade#6564 ) (overlookmotel)
- 1c1e9fc#6563 ) (overlookmotel)
- c9054c8#6561 )
(overlookmotel)
- 9542c4e#6560 ) (overlookmotel)
- 7e57a1d#6559 )
(overlookmotel)
- 602df9d#6562 ) (overlookmotel)
- 390abca#6634 )
(Dunqing)
- 2ff917f#6632 ) (Dunqing)
### Styling
- fb916b2#6672 ) (overlookmotel)
- 9d43a11#6659 ) (overlookmotel)
### Testing
- e7c89a5#6589 ) (Dunqing)
- d816b0b#6497 ) (overlookmotel)
- c5deb32#6420 ) (7086cmd)
- e59da61#6421 ) (dalaoshu)
- 73d6a4a#6418 )
(7086cmd)
---------
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-10-19 23:09:35 +08:00
Boshen
1a90ec4b85
refactor(rust): backport v1.82.0 changes to main branch first ( #6690 )
2024-10-19 14:30:55 +00:00
dalaoshu
ce25c450fc
fix(linter): panic in disable-directives ( #6677 )
...
closes #6670
2024-10-19 22:09:37 +08:00
overlookmotel
002289b4b1
style(ast_tools): do not use ref in matches ( #6674 )
...
Style nit.
2024-10-19 08:57:06 +00:00
overlookmotel
a47b38ff1a
style(ast_tools): fix formatting ( #6673 )
2024-10-19 08:50:05 +00:00
overlookmotel
fb916b2532
style(regular_expression): re-order dependencies in Cargo.toml ( #6672 )
...
Follow-on after #6404 . Nit. Group optional dependencies together.
2024-10-19 08:50:04 +00:00
ottomated
e310e52ca2
feat(parser): Generate Serialize impls in ast_tools ( #6404 )
...
Beginning of #6347 . Instead of using serde-derive, we generate
`Serialize` impls manually.
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: overlookmotel <theoverlookmotel@gmail.com>
2024-10-19 09:38:44 +01:00
camchenry
b0b6ac71e7
fix(linter/no-cond-assign): false positive when assignment is in body statement ( #6665 )
...
- fixes https://github.com/oxc-project/oxc/issues/6656
rather than reporting any assignment inside of `if`, `while`, etc. when the `always` option is enabled, we only check if the assignment resides in specific areas that assignment should not be. for example, inside the test of an `if`, or the test of a `for` loop.
incidentally, this also fixes an issue (seen in snapshot file) where the same assignment was reported twice.
2024-10-19 03:17:08 +00:00
oxc-bot
70c6f24a08
release(oxlint): v0.10.0 ( #6661 )
...
## [0.10.0] - 2024-10-18
- 7f6b219#6630 ) (DonIsaac)
- 782f0a7#6512 ) (overlookmotel)
- 7645e5c#6451 )
(Boshen)
- 5200960#6446 )
(Boshen)
- 80266d8#6088 ) (DonIsaac)
### Features
- 6f22538#6502 )
(Boshen)
- 1e7fab3#6157 ) (dalaoshu)
- c56343d#6491 ) (Boshen)
- 454874a#6383 ) (Radu
Baston)
- c8174e2#6376 ) (camchenry)
- 6e3224d#6120 )
(DonIsaac)
- c5e66e1#6557 ) (DonIsaac)
- 8c78f97#6165 ) (Jelle van der
Waa)
### Bug Fixes
- cf92730#6629 )
(DonIsaac)
- d9159a2#6628 ) (DonIsaac)
- b9c94bb#6384 ) (dalaoshu)
- e340424#6650 ) (Dmitry Zakharov)
- a668397#6648 ) (dalaoshu)
- 41dc8e3#6614 ) (DonIsaac)
- d07a9b0#6607 ) (dalaoshu)
- d6a0d2e#6463 ) (camchenry)
- 0784e74#6474 ) (dalaoshu)
- e811812#6455 ) (dalaoshu)
- f71c91e#6377 )
(DonIsaac)
- 2b86de9#6531 ) (DonIsaac)
- 685a590#6530 )
(DonIsaac)
- 6d5a9f2#6529 ) (DonIsaac)
- ba53bc9#6397 ) (DonIsaac)
- d3e59c6#6395 ) (DonIsaac)
- e08f956#6394 ) (DonIsaac)
- b9d7c5f#6553 ) (Brian Donovan)
### Performance
- 0cbd4d0#6606 )
(DonIsaac)
- 725f9f6#6467 ) (camchenry)
- c00f669#6439 ) (DonIsaac)
- a1a2721#6407 ) (camchenry)
- c5c69d6#6406 ) (camchenry)
- d66e826#6405 )
(camchenry)
- 889400c#6403 ) (camchenry)
- 9906849#6402 )
(camchenry)
- c382ec4#6401 ) (camchenry)
- 24a5d9b#6400 )
(camchenry)
- 71dbdad#6399 ) (camchenry)
- f5f00a1#6398 ) (camchenry)
- 62afaa9#6534 ) (camchenry)
- b3d0cce#6594 ) (camchenry)
- ee73f56#6590 ) (camchenry)
- 77ddab8#6546 ) (camchenry)
- 8f47cd0#6536 ) (camchenry)
### Documentation
- 557f941#6558 )
(DonIsaac)
### Refactor
- ecce5c5#6513 ) (no-yan)
- f960e9e#6465 ) (camchenry)
- 7240ee2#6461 )
(Alexander S.)
- b48c368#6460 )
(overlookmotel)
- 2566ce7#6098 ) (DonIsaac)
- 002078a#6440 ) (DonIsaac)
- 6a0a533#6438 )
(DonIsaac)
- c18c6e9#6437 )
(DonIsaac)
- 5ea9ef7#6389 ) (DonIsaac)
- 2c32dac#6527 )
(DonIsaac)
- 435a89c#6571 )
(Boshen)
- f70e93b#6075 ) (dalaoshu)
### Testing
- a6cae98#6378 ) (DonIsaac)
- 06b09b2#6556 )
(DonIsaac)
- badd11c#6555 )
(DonIsaac)
- 84aa2a2#6390 ) (DonIsaac)
---------
Co-authored-by: DonIsaac <22823424+DonIsaac@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-10-18 20:34:15 -04:00
Boshen
2ce3e5fefc
fix(identifier): add ZWSP to is_irregular_whitespace ( #6662 )
...
closes #6646
2024-10-18 22:20:02 +00:00
overlookmotel
458f8f3822
refactor(ast_tools): consistent comments on AstBuilder methods ( #6664 )
...
Affects comment style only. Use "Build" consistently, not "Builds" in some places, and correct use of "a" / "an".
2024-10-18 15:57:36 +00:00
overlookmotel
ac77c87cec
perf(traverse): optimize TraverseScoping::generate_uid_name ( #6663 )
...
Tiny optimization. Move initializing `self.uid_names` to just before `self.uid_names.as_mut().unwrap()` so compiler can see that the `unwrap` is infallible and elide it, even if `get_uid_names` isn't inlined.
2024-10-18 15:43:47 +00:00
overlookmotel
9d43a1124d
style(transformer): re-order dependencies ( #6659 )
...
Nit. Move `oxc_*` dependencies to first in list.
2024-10-18 14:41:36 +00:00
overlookmotel
683c3443c0
chore(semantic, wasm): re-order dependencies in Cargo.toml files ( #6657 )
...
Nit. Move `serde` dependency into more natural place in the list.
2024-10-18 13:40:37 +00:00
Dmitry Zakharov
e3404249a2
fix(linter): support import type with namespaced import in import/no-duplicates ( #6650 )
...
got false positive cases, and looks like that not fixed in import lib
too (issue is open).
Also I fix cases for imports without types. But can't fix it due to lack
of understanding that functional style code.
P. S. just installed pre-commit hook for fmt, sorry
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-10-17 20:32:42 -04:00
dalaoshu
a66839752a
fix(linter): panic in no-else-return ( #6648 )
...
closes #6636
2024-10-17 20:30:55 -04:00
Boshen
f4cdc56577
refactor(minifier): use constant folding unary expression from oxc_ecmascript ( #6647 )
2024-10-17 15:30:38 +00:00
magic-akari
1d3d256db3
fix(transformer): Correctly trim JSX ( #6639 )
...
- Closes : #6638
2024-10-17 14:41:02 +00:00
overlookmotel
92812349e5
refactor(transformer): shorten imports ( #6643 )
...
Style nit. Shorten `use` statements in transformer.
2024-10-17 09:16:01 +00:00
overlookmotel
f3451d7ec4
docs(transformer/async-to-generator): remove empty lines from doc comment ( #6642 )
...
Style nit.
2024-10-17 09:16:00 +00:00
Dunqing
a3dea9c542
feat(transformer/async-to-generator): handle arrow-function correctly ( #6640 )
2024-10-17 08:47:28 +00:00
Dunqing
390abca29a
refactor(transformer/async-to-generator): use helper_call_expr ( #6634 )
2024-10-17 08:37:05 +00:00
Dunqing
a01a5dfdaf
feat(transformer): pass TransformerCtx to async-to-generator plugin ( #6633 )
2024-10-17 08:25:58 +00:00
Dunqing
2ff917fdac
refactor(transformer/async-to-generator): move internal methods below entry points ( #6632 )
2024-10-17 08:14:29 +00:00
Dunqing
673b66620b
chore(transform_conformance): do not extend plugins if current options has plugins ( #6627 )
...
I saw many tests were ignored even if they don't contain any unsupported plugins
2024-10-17 02:07:03 +00:00
Boshen
e5ed6a56a8
feat(codegen): print negative numbers ( #6624 )
2024-10-16 22:38:54 +00:00
DonIsaac
7f6b21925d
feat(editor/vscode)!: unify configuration logic ( #6630 )
...
> Closes https://github.com/oxc-project/backlog/issues/132
Unify configuration logic into `ConfigService`. This allows for type-checked
config settings. It also lets us make sure config values are synced with what
the user has set in their vscode settings.
This PR is a breaking change since it also unifies config key prefixes (`oxc`
and `oxc_language_server` -> `oxc` only)
2024-10-16 22:31:29 +00:00
DonIsaac
cf9273090a
fix(editor): use human-readable output channel names ( #6629 )
...
Changes the names of output channels our editor uses to make them friendlier.
2024-10-16 22:31:29 +00:00
DonIsaac
d9159a2445
fix(editor): misaligned command prefixes ( #6628 )
...
In the client code, we were registering commands under the `oxc` prefix, but in our `package.json` we were advertising a `oxc_language_server` prefix.
2024-10-16 22:31:28 +00:00
Dmitry Zakharov
25a49a5700
feat(rulegen): add import to rulegen ( #6631 )
...
Added for fast rule creation
2024-10-16 17:05:40 -04:00
DonIsaac
87f3b8dc55
refactor(macros): clean up declare_oxc_secret ( #5937 )
2024-10-16 20:10:10 +00:00
