dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 20:28:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(linter): use CompactStr in no-console (#6399)

Browse source
This commit is contained in:
camchenry 2024-10-10 01:15:21 +00:00
parent 384d5be40b
commit 71dbdad1e3
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
crates/oxc_linter/src/rules/eslint/no_console.rs
View file

@ -1,7 +1,7 @@
use oxc_ast::{ast::Expression, AstKind};
use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint;
use oxc_span::Span;
use oxc_span::{CompactStr, Span};
use crate::{context::LintContext, rule::Rule, AstNode};
@ -21,7 +21,7 @@ pub struct NoConsoleConfig {
/// console.log('foo'); // will error
/// console.info('bar'); // will not error
/// ```
pub allow: Vec<String>,
pub allow: Vec<CompactStr>,
}
impl std::ops::Deref for NoConsole {
@ -58,10 +58,7 @@ impl Rule for NoConsole {
.and_then(|v| v.get("allow"))
.and_then(serde_json::Value::as_array)
.map(|v| {
v.iter()
.filter_map(serde_json::Value::as_str)
.map(ToString::to_string)
.collect()
v.iter().filter_map(serde_json::Value::as_str).map(CompactStr::from).collect()
})
.unwrap_or_default(),
}))