dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(transformer): object spread transform: do not lookup Object binding if not needed (#6570)

Browse source 
If `set_spread_properties` option is not set, skip looking up binding for `Object`, as it's not used.
This commit is contained in:
overlookmotel 2024-10-15 01:20:38 +00:00
parent c6f2b5f0a1
commit f70a413536
1 changed files with 23 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
crates/oxc_transformer/src/es2018/object_rest_spread/object_spread.rs
View file

@ -79,8 +79,7 @@ impl<'a, 'ctx> Traverse<'a> for ObjectSpread<'a, 'ctx> {
arguments.push(Argument::from(ctx.ast.move_expression(expr)));
arguments.push(Argument::from(ctx.ast.move_expression(&mut spread_prop.argument)));
let object_id = ctx.scopes().find_binding(ctx.current_scope_id(), "Object");
let object_id = self.get_object_symbol_id(ctx);
let callee = self.get_extend_object_callee(object_id, ctx);
// ({ ...x }) => _objectSpread({}, x)
@ -101,6 +100,28 @@ impl<'a, 'ctx> Traverse<'a> for ObjectSpread<'a, 'ctx> {
}
impl<'a, 'ctx> ObjectSpread<'a, 'ctx> {
#[expect(clippy::option_option)]
fn get_object_symbol_id(&self, ctx: &mut TraverseCtx<'a>) -> Option<Option<SymbolId>> {
if self.options.set_spread_properties {
Some(ctx.scopes().find_binding(ctx.current_scope_id(), "Object"))
} else {
None
}
}
#[expect(clippy::option_option)]
fn get_extend_object_callee(
&mut self,
object_id: Option<Option<SymbolId>>,
ctx: &mut TraverseCtx<'a>,
) -> Expression<'a> {
if let Some(object_id) = object_id {
Self::object_assign(object_id, ctx)
} else {
self.babel_external_helper(ctx)
}
}
fn object_assign(symbol_id: Option<SymbolId>, ctx: &mut TraverseCtx<'a>) -> Expression<'a> {
let ident =
ctx.create_reference_id(SPAN, Atom::from("Object"), symbol_id, ReferenceFlags::Read);
@ -113,16 +134,4 @@ impl<'a, 'ctx> ObjectSpread<'a, 'ctx> {
fn babel_external_helper(&self, ctx: &mut TraverseCtx<'a>) -> Expression<'a> {
self.ctx.helper_loader.load(Atom::from("objectSpread2"), ctx)
}
fn get_extend_object_callee(
&mut self,
object_id: Option<SymbolId>,
ctx: &mut TraverseCtx<'a>,
) -> Expression<'a> {
if self.options.set_spread_properties {
Self::object_assign(object_id, ctx)
} else {
self.babel_external_helper(ctx)
}
}
}