dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(codegen): fix in in sequence expr in for loops (#6428)

Browse source 
not sure if this is right, but it doesn't break any existing tests so hopefully?
This commit is contained in:
camc314 2024-10-13 06:47:09 +00:00
parent 096e590483
commit 6896efc00c
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/oxc_codegen/src/gen.rs
View file

@ -1948,9 +1948,9 @@ impl<'a> Gen for AssignmentTargetRest<'a> {
}
impl<'a> GenExpr for SequenceExpression<'a> {
fn gen_expr(&self, p: &mut Codegen, precedence: Precedence, _ctx: Context) {
fn gen_expr(&self, p: &mut Codegen, precedence: Precedence, ctx: Context) {
p.wrap(precedence >= self.precedence(), |p| {
p.print_expressions(&self.expressions, Precedence::Lowest, Context::empty());
p.print_expressions(&self.expressions, Precedence::Lowest, ctx);
});
}
}

9
crates/oxc_codegen/tests/integration/unit.rs
View file

@ -271,3 +271,12 @@ fn vite_special_comments() {
"import(\n\t/* @vite-ignore */\n\tmodule1Url\n).then((module1) => {\n\tself.postMessage(module.default + module1.msg1 + import.meta.env.BASE_URL);\n});\n",
);
}
// followup from https://github.com/oxc-project/oxc/pull/6422
#[test]
fn in_expr_in_sequence_in_for_loop_init() {
test(
"for (l = ('foo' in bar), i; i < 10; i += 1) {}",
"for (l = (\"foo\" in bar), i; i < 10; i += 1) {}\n",
);
}