dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): panic in no-zero-fractions (#6607)

Browse source 
closes #6584 

Only fixed character index errors on the linter side.
This commit is contained in:
dalaoshu 2024-10-16 04:48:11 +08:00 committed by GitHub
parent 5213ba7fb4
commit d07a9b0fb3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
crates/oxc_linter/src/rules/unicorn/no_zero_fractions.rs
View file

@ -88,9 +88,8 @@ impl Rule for NoZeroFractions {
// Handle special cases where a space is needed after certain keywords
// to prevent the number from being interpreted as a property access
let start = number_literal.span.start.saturating_sub(6);
let end = number_literal.span.start;
let token = ctx.source_range(oxc_span::Span::new(start, end)).to_string();
let token = ctx.source_range(oxc_span::Span::new(0, end));
if token.ends_with("return")
|| token.ends_with("throw")
|| token.ends_with("typeof")
@ -173,6 +172,7 @@ fn test() {
r"function foo(){return.0}",
r"function foo(){return.0.toString()}",
r"function foo(){return.0+.1}",
"ôTest(0.)",
];
let fix = vec![
@ -210,6 +210,7 @@ fn test() {
(r"void.0", r"void 0"),
(r"function foo(){void.0.toString()}", r"function foo(){void (0).toString()}"),
(r"function foo(){void.0+.1;}", r"function foo(){void 0+.1;}"),
("ôTest(0.)", "ôTest(0)"),
];
Tester::new(NoZeroFractions::NAME, pass, fail).expect_fix(fix).test_and_snapshot();

7
crates/oxc_linter/src/snapshots/no_zero_fractions.snap
View file

@ -168,3 +168,10 @@ source: crates/oxc_linter/src/tester.rs
· ──
╰────
help: Replace the number literal with `0`
⚠ eslint-plugin-unicorn(no-zero-fractions): Don't use a dangling dot in the number.
╭─[no_zero_fractions.tsx:1:8]
1 │ ôTest(0.)
· ──
╰────
help: Replace the number literal with `0`