dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(linter): use CompactStr in no-hooks (#6401)

Browse source
This commit is contained in:
camchenry 2024-10-10 01:15:22 +00:00
parent 24a5d9b98f
commit c382ec4f32
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
crates/oxc_linter/src/rules/jest/no_hooks.rs
View file

@ -1,7 +1,7 @@
use oxc_ast::{ast::Expression, AstKind};
use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint;
use oxc_span::{GetSpan, Span};
use oxc_span::{CompactStr, GetSpan, Span};
use crate::{
context::LintContext,
@ -21,7 +21,7 @@ pub struct NoHooks(Box<NoHooksConfig>);
#[derive(Debug, Default, Clone)]
pub struct NoHooksConfig {
allow: Vec<String>,
allow: Vec<CompactStr>,
}
impl std::ops::Deref for NoHooks {
@ -90,9 +90,7 @@ impl Rule for NoHooks {
.get(0)
.and_then(|config| config.get("allow"))
.and_then(serde_json::Value::as_array)
.map(|v| {
v.iter().filter_map(serde_json::Value::as_str).map(ToString::to_string).collect()
})
.map(|v| v.iter().filter_map(serde_json::Value::as_str).map(CompactStr::from).collect())
.unwrap_or_default();
Self(Box::new(NoHooksConfig { allow }))
@ -121,7 +119,8 @@ impl NoHooks {
}
if let Expression::Identifier(ident) = &call_expr.callee {
if !self.allow.contains(&ident.name.to_string()) {
let name = CompactStr::from(ident.name.as_str());
if !self.allow.contains(&name) {
ctx.diagnostic(unexpected_hook_diagonsitc(call_expr.callee.span()));
}
}