dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

test(linter/no-useless-constructor): add cases for initializers in subclass constructors (#6390)

Browse source
This commit is contained in:
DonIsaac 2024-10-09 22:05:54 +00:00
parent 5ea9ef7af7
commit 84aa2a237c
1 changed files with 41 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
crates/oxc_linter/src/rules/eslint/no_useless_constructor.rs
View file

@ -287,6 +287,47 @@ fn test() {
"class A { constructor(readonly x: number) {} }",
"class A { constructor(private readonly x: number) {} }",
"class A extends B { constructor(override x: number) { super(x); } }",
"
class A {
protected foo: number | undefined;
constructor(foo?: number) {
this.foo = foo;
}
}
class B extends A {
protected foo: number;
constructor(foo: number = 0) {
super(foo);
}
}
",
"
class A {
protected foo: number | undefined;
constructor(foo?: number) {
this.foo = foo;
}
}
class B extends A {
constructor(foo?: number) {
super(foo ?? 0);
}
}
",
// TODO: type aware linting :(
// "
// class A {
// protected foo: string;
// constructor(foo: string) {
// this.foo = foo;
// }
// }
// class B extends A {
// constructor(foo: 'a' | 'b') {
// super(foo);
// }
// }
// ",
];
let fail = vec![