Boshen
6bc13f6cd4
feat(minifier): add MinimizeConditions pass ( #5747 )
...
I expect small performance regression.
But managed to improve the following case from react.developmement.js
```
oxc main ❯ diff before.js after.js
670c670
< if (!(dispatcher !== null)) throw Error("Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:\n1. You might have mismatching versions of React and the renderer (such as React DOM)\n2. You might be breaking the Rules of Hooks\n3. You might have more than one copy of React in the same app\nSee https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.");
---
> if (dispatcher === null) throw Error("Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:\n1. You might have mismatching versions of React and the renderer (such as React DOM)\n2. You might be breaking the Rules of Hooks\n3. You might have more than one copy of React in the same app\nSee https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.");
```
2024-09-13 08:31:45 +00:00
Dunqing
b4ed564a35
fix(linter/no-unused-vars): writes to members triggering false positive ( #5744 )
...
close : #5246
similar to #5722
2024-09-13 06:00:48 +00:00
heygsc
19790dbc9c
chore(docs): add mako on readme ( #5742 )
...
Co-authored-by: Boshen <boshenc@gmail.com>
2024-09-13 13:06:29 +08:00
Boshen
cc0408b5d4
refactor(semantic): s/AstNodeId/NodeId ( #5740 )
...
part of #5689
2024-09-13 03:00:00 +00:00
overlookmotel
7dfcdfced6
refactor(semantic): remove more-asserts dependency ( #5739 )
...
Remove `more-asserts` dependency which was added in #5710 .
As suggested by @Boshen in https://github.com/oxc-project/oxc/pull/5710#pullrequestreview-2299016692 .
2024-09-13 02:53:00 +00:00
overlookmotel
333e2e04c4
perf(index): remove Idx bounds-checks from first + last methods ( #5726 )
...
The following methods of `IndexVec` call `Idx::from_usize` which performs a bounds check, with a panicking branch:
* `first`
* `first_mut`
* `last`
* `last_mut`
These bounds checks are unnecessary. Remove them by delegating to the underlying `Vec`'s methods.
2024-09-13 02:46:57 +00:00
overlookmotel
953fe17f0e
feat(ast): provide NONE type for AST builder calls ( #5737 )
...
Closes #5736 .
Introduce a `NONE` type which can be used for any `AstBuilder` method call param which expects an `IntoIn<'a, Something<'a>>`, where otherwise you have to provide a verbose type annotation.
Before:
```rs
ast.arrow_function_expression(
SPAN,
is_expression,
is_async,
None::<TSTypeParameterDeclaration>,
params,
None::<TSTypeAnnotation>,
body,
)
```
After:
```rs
ast.arrow_function_expression(SPAN, is_expression, is_async, NONE, params, NONE, body)
```
2024-09-13 02:42:01 +00:00
overlookmotel
71116a1cbd
feat(index)!: remove ability to index IndexVec with usize ( #5733 )
...
`IndexVec` should only be indexed into with its associated `Idx` type. The implementation taken from `index_vec` crate however also includes the ability to index into the `Vec` with a `usize` "as an ergonomic concession, it's too painful without":
https://docs.rs/index_vec/0.1.4/src/index_vec/indexing.rs.html#112-134
I think we want to be stricter than this, so remove this ability.
2024-09-13 02:37:34 +00:00
overlookmotel
20a7861838
refactor(linter): shorten Option syntax ( #5735 )
...
Use `Some` instead of `Option::Some`.
2024-09-12 18:42:51 +00:00
IWANABETHATGUY
805fbac44c
feat(oxc_cfg): better control flow graph dot dot repr ( #5731 )
...
1. add basic block index for each basicblock, so there should no basic block display empty string
2. use `shape` box, since it is basic **block**
## Before
## After
2024-09-12 18:39:01 +00:00
IWANABETHATGUY
d8b612c038
refactor(oxc_linter): prefer pass Enum instead of str no_plus_plus ( #5730 )
...
1. remove redundant branch.
2024-09-12 11:43:24 -04:00
overlookmotel
6436524ff1
refactor(semantic): fix dead code warning in release mode ( #5728 )
...
`Counts::assert_accurate` is only used in debug mode. Silence the dead code warning in release mode.
2024-09-12 13:33:57 +00:00
overlookmotel
3ce8546393
ci(benchmarks): NeverGrowInPlaceAllocator not pub ( #5727 )
...
Global allocator used in benchmarks `NeverGrowInPlaceAllocator` doesn't need to be `pub`.
2024-09-12 12:58:13 +00:00
Dunqing
e9c084a705
fix(linter/no-unused-vars): false positive when a variable used as a computed member property ( #5722 )
...
close : #5671
2024-09-12 11:23:01 +00:00
Boshen
748e6f80fe
chore(minsize): update minsize.snap
2024-09-12 19:02:46 +08:00
oxc-bot
1dad9fa301
release(oxlint): v0.9.5 ( #5724 )
...
## [0.9.5] - 2024-09-12
### Features
- 4b04f65#5570 ) (Cam McHenry)
---------
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-09-12 16:59:25 +08:00
Cam McHenry
4b04f65275
feat(linter): implement no-plusplus rule ( #5570 )
...
- part of https://github.com/oxc-project/oxc/issues/479
This PR implements the `no-plusplus` rule and is more-or-less a direct
port of the ESLint version of the rule.
---------
Co-authored-by: Don Isaac <donald.isaac@gmail.com>
2024-09-12 16:50:19 +08:00
Boshen
2b8369fb8c
ci(oxlint): pnpm publish need to declare binary as executable
2024-09-12 16:38:56 +08:00
Boshen
f14a534777
ci: fix oxlint publish
2024-09-12 14:53:45 +08:00
oxc-bot
d06bab6260
release(oxlint): v0.9.4 ( #5718 )
...
## [0.9.4] - 2024-09-12
### Features
- 9ca2593#4845 ) (Na'aman Hirschfeld)
- 023c160#5594 ) (DonIsaac)
- 24d6a47#5443 ) (Boshen)
### Bug Fixes
- af6d240#5613 )
(DonIsaac)
- 54e2e76#5615 ) (overlookmotel)
- 3b87ac4#5582 ) (Boshen)
### Performance
- bfe9186#5643 )
(dalaoshu)
- e3ae5db#5637 ) (heygsc)
- a0370bf#5633 ) (heygsc)
- 37e922c#5618 ) (overlookmotel)
- 0b7fccf#5616 ) (overlookmotel)
- 2c3f3fe#5585 ) (Boshen)
- cd81d12#5584 ) (Boshen)
- d18c896#5664 ) (dalaoshu)
### Documentation
- 64f95758c9179d#5591 ) (Brian Donovan)
### Refactor
- 9e9435f#5685 ) (DonIsaac)
- 4f70fe5#5660 ) (DonIsaac)
- 5ae9b48#5659 ) (DonIsaac)
- c8bc6f0#5649 ) (overlookmotel)
- a37c064#5648 ) (Boshen)
- 0b3c1d7#5595 ) (DonIsaac)
- 89bdf55#5619 )
(overlookmotel)
- afea8d5#5617 )
(overlookmotel)
- 4e748b5#5602 ) (dalaoshu)
- bac03e3#5593 )
(DonIsaac)
- 2661d8b#5588 ) (IWANABETHATGUY)
- 20d0068#5139 )
(DonIsaac)
- 067f9b5#5672 )
(Boshen)- 26d9235#5577 ) (夕舞八弦)
### Testing
- 8e79f8d#5550 ) (DonIsaac)
- 38351893b87ac45f27551#5580 ) (Boshen)
---------
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-09-12 13:56:38 +08:00
Boshen
746f7b3a02
refactor(minifier): align code with closure compiler ( #5717 )
...
also fixes #4341
2024-09-12 04:18:41 +00:00
Boshen
4bdc202325
refactor(rust): remove some #[allow(unused)] ( #5716 )
2024-09-12 02:19:01 +00:00
overlookmotel
c3dd2a048d
perf(ast)!: revert: reduce byte size of TaggedTemplateExpression::quasi by Boxing it ( #5679 ) ( #5715 )
...
As discussed in #5601 , there is little benefit to reducing type sizes for the sake of it. In this case, the `quasi` field in not in an `Option`, so putting it in a `Box` does not save data, only moves where that data is stored, and introduces pointer-indirection.
2024-09-12 00:53:20 +00:00
overlookmotel
a362f51523
feat(index): add IndexVec::shrink_to ( #5713 )
...
Add `IndexVec::shrink_to` to match `std::vec::Vec::shrink_to`.
2024-09-11 22:57:58 +00:00
overlookmotel
e02621d2d1
refactor(semantic): re-order use statements ( #5712 )
...
Pure refactor. Re-order `use` statements in `oxc_semantic` to follow this order:
1. `std`
2. External crates.
3. `oxc_*` crates.
4. Local crate.
5. `super`
6. `mod`
This is intended to be in order from "furthest above" to "furthest below".
2024-09-11 20:41:49 +00:00
overlookmotel
ac6203c891
refactor(semantic): move Counts code into counter module ( #5710 )
...
Pure refactor. Move code for counting nodes etc, and verifying counts, into `counter` module.
2024-09-11 20:41:48 +00:00
overlookmotel
339fcfc8be
refactor(semantic): rename Counts in transform checker ( #5709 )
...
Pure refactor. Just renaming.
2024-09-11 20:41:48 +00:00
Na'aman Hirschfeld
9ca2593aaa
feat(linter): eslint/sort-keys ( #4845 )
...
This PR adds the `eslint/sort-keys` implementation as part of #479
Note: two tests are commented out. I was not able to model this behavior
properly. I would be happy to have some assistance there.
2024-09-11 13:10:55 -04:00
Boshen
21e2df57a0
refactor(minifier): replace VisitMut with Traverse for inject and define plugins ( #5705 )
...
closes #5704
2024-09-11 16:13:10 +00:00
Boshen
945d2744ae
chore(linter: fix snapshot
2024-09-11 21:07:23 +08:00
Boshen
64f9575ed5
docs(linter): add plugin usage to example with configuration
...
closes #5400
2024-09-11 20:58:29 +08:00
Dunqing
608b7d37d6
fix(napi/transformer): refresh plugin doesn't work even after passing the refresh option ( #5702 )
2024-09-11 12:39:51 +00:00
renovate[bot]
c2997f1775
chore(deps): update vscode npm packages ( #5697 )
2024-09-11 19:45:31 +08:00
heygsc
a79c5535e3
chore(clippy): fix typo ( #5700 )
2024-09-11 19:42:41 +08:00
overlookmotel
d8ec78192e
refactor(semantic): remove record_ast_node call for Program ( #5701 )
...
Remove a tiny bit of dead code from `SemanticBuilder`.
`record_ast_node` does nothing if `ast_node_records` is empty. It is always empty when visiting `Program`, so is a no-op.
2024-09-11 11:31:20 +00:00
overlookmotel
1857ff09eb
style(semantic): rename vars for node IDs ( #5699 )
...
`test_node_id` not `test_node` to better describe what these vars contain.
2024-09-11 10:55:42 +00:00
dalaoshu
d18c896a2c
perf(rust): use cow_utils instead ( #5664 )
...
Related to #5586 and #5662
---------
Co-authored-by: Boshen <boshenc@gmail.com>
2024-09-11 18:39:30 +08:00
Boshen
a729b64380
ci: add a scope to release PR title
...
For passing PR title checker
2024-09-11 18:33:00 +08:00
Boshen
1ed4ccdcae
ci: fix failed to napi publish without --no-git-checks
...
We generate all the files so they are not commited to the repo
2024-09-11 18:30:15 +08:00
renovate[bot]
f475bba644
chore(deps): update peter-evans/create-pull-request action to v7 ( #5698 )
2024-09-11 18:26:33 +08:00
heygsc
5482e73189
feat(prettier): add assignment/sequence ( #5694 )
...
test:
https://github.com/prettier/prettier/blob/main/tests/format/js/assignment/sequence.js
snap:https://github.com/prettier/prettier/blob/main/tests/format/js/assignment/__snapshots__/format.test.js.snap#L870-L888
code:
https://github.com/prettier/prettier/blob/main/src/language-js/needs-parens.js#L790-L796
2024-09-11 18:19:09 +08:00
oxc-bot
a727ee8aca
release(oxc): crates v0.28.0 ( #5696 )
...
## [0.28.0] - 2024-09-11
- afc4548#5679 ) (Boshen)
- 7415e85#5678 ) (Boshen)
- ee4fb42#5677 ) (Boshen)
- 1fa3e56#5621 ) (overlookmotel)
- 96a1552#5620 ) (overlookmotel)
- 4a8aec1#5606 ) (Boshen)
- 603817b#5557 ) (Boshen)
- b060525#5553 ) (Boshen)
### Features
- 2da5ad1#5556 )
(overlookmotel)
- 2016bae#5676 )
(Boshen)
- 68c3cf5#5670 ) (Boshen)
- c6bbf94#5669 ) (Boshen)
- 86256ea#5666 ) (Boshen)
- e698418#5657 ) (Boshen)
- aba9194#5533 )
(underfin)
- 642295c#5558 ) (overlookmotel)
- b3cbd56#5610 ) (overlookmotel)
- 95a6d99#5630 ) (Dunqing)
- 7b543df#5638 ) (Dunqing)
- 17226dd#5559 )
(overlookmotel)
### Bug Fixes
- d62defb#5551 ) (Boshen)
- 1bc08e2#5579 ) (Boshen)
- 28b934c#5555 ) (Boshen)
- b9bf544#5681 ) (Dunqing)
- 6e8409a#5680 ) (Dunqing)
- b8f8dd6#5691 ) (Boshen)
- 304ce25#5692 ) (leaysgur)
- 0511d55#5661 ) (leaysgur)
- 41582ea#5635 ) (leaysgur)
- 28aad28#5631 ) (leaysgur)
- f9e3a41#5673 ) (Boshen)
- f49e6eb#5612 ) (Boshen)
- 919d17f#5589 ) (Boshen)
- 505d064#5560 ) (overlookmotel)
- 9b7ecc7#5508 ) (overlookmotel)
- d1ece19#5501 ) (overlookmotel)
- a1afd48#5695 ) (Dunqing)
- f2f5e5a#5693 ) (Dunqing)
- a891c31#5656 ) (Dunqing)
- 3e8b96f#5655 ) (Dunqing)
- 0739b5f#5642 ) (Dunqing)
- 3bf6aaf#5629 ) (Dunqing)
- 36d864a#5528 ) (Dunqing)
### Performance
- e8013d2#5626 )
(overlookmotel)
- 4996874#5611 )
(overlookmotel)
### Documentation
- fefbbc1#5539 )
(overlookmotel)
- 9282647#5514 ) (overlookmotel)
- 1c051ae#5607 ) (overlookmotel)
- 2e24a15#5604 ) (overlookmotel)
### Refactor
- 14ee086#5547 ) (overlookmotel)
- 2de6ea0#5650 )
(overlookmotel)
- 0ac420d#5564 )
(Don Isaac)
- 2da42ef#5665 ) (leaysgur)
- dec1395#5543 ) (leaysgur)
- 731ffaa#5686 )
(overlookmotel)
- 067f9b5#5672 ) (Boshen)
- d22a9b7#5622 )
(overlookmotel)
- 3d190a5#5609 )
(overlookmotel)
- 5532628ce71982#5554 )
(overlookmotel)
- 758a10c#5527 )
(overlookmotel)
- fad0a05#5504 )
(overlookmotel)
- 19cdcc5#5652 ) (overlookmotel)-
26d9235#5577 ) (夕舞八弦)
### Styling
- e52d006#5651 )
(overlookmotel)
- 97e99bd#5603 ) (overlookmotel)-
694f032#5542 )
(overlookmotel)
### Testing
- 2e367c9#5625 )
(overlookmotel)- dc92489#5541 ) (overlookmotel)
---------
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-09-11 17:57:55 +08:00
Dunqing
a1afd48c68
fix(transformer/react): incorrect scope_id for var hoisted in fast refresh plugin ( #5695 )
...
Fix the last one semantic error in the fast react plugin
2024-09-11 09:02:29 +00:00
Dunqing
f2f5e5aaf5
fix(transformer/react): missing scope_id for function in fast refresh plugin ( #5693 )
...
Fix semantic error in the fast react plugin
2024-09-11 09:02:28 +00:00
Dunqing
a891c31889
fix(transformer/react): refresh plugin has incorrect reference flags ( #5656 )
...
As you see the diff
2024-09-11 07:57:17 +00:00
Dunqing
ffbc4625b4
chore(transformer): treat all React Refresh tests as ESM syntax ( #5644 )
...
related: #5612
2024-09-11 07:57:17 +00:00
Dunqing
95a6d9984c
feat(transformer): enable the react refresh plugin in enable_all ( #5630 )
2024-09-11 07:57:16 +00:00
Dunqing
3e8b96f165
fix(transformer/react): the refresh plugin cannot handle member expressions with React hooks ( #5655 )
...
The previous implementation doesn't handle nested StaticMemberExpression. For example: `A.B.C.useHook`.
2024-09-11 07:57:16 +00:00
Dunqing
0739b5f1e3
fix(transformer/react): don't transform declaration of function overloads ( #5642 )
...
Found a bug in https://github.com/oxc-project/oxc/actions/runs/10768809028/job/29858692560 ; We don't need to transform typescript-syntax-only function
2024-09-11 07:57:15 +00:00
Dunqing
7b543dffd9
feat(transformer/react): handle refresh_sig and refresh_reg options correctly ( #5638 )
...
In previous implementations, even if pass `import.meta.xxxx` into these options this plugin still treats them as `IdentifierReference`
2024-09-11 07:57:15 +00:00
