dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(linter): make jsx_key slightly faster (#5585)

Browse source
This commit is contained in:
Boshen 2024-09-07 14:03:26 +00:00
parent cd81d12624
commit 2c3f3fe9e4
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
crates/oxc_linter/src/rules/react/jsx_key.rs
View file

@ -91,8 +91,9 @@ pub fn import_matcher<'a>(
actual_local_name: &'a str,
expected_module_name: &'a str,
) -> bool {
let expected_module_name = expected_module_name.to_lowercase();
ctx.semantic().module_record().import_entries.iter().any(|import| {
import.module_request.name().as_str() == expected_module_name.to_lowercase()
import.module_request.name().as_str() == expected_module_name
&& import.local_name.name().as_str() == actual_local_name
})
}
@ -103,10 +104,9 @@ pub fn is_import<'a>(
expected_local_name: &'a str,
expected_module_name: &'a str,
) -> bool {
let total_imports = ctx.semantic().module_record().requested_modules.len();
let total_variables = ctx.scopes().get_bindings(ctx.scopes().root_scope_id()).len();
if total_variables == 0 && total_imports == 0 {
if ctx.semantic().module_record().requested_modules.is_empty()
&& ctx.scopes().get_bindings(ctx.scopes().root_scope_id()).is_empty()
{
return actual_local_name == expected_local_name;
}
@ -486,10 +486,10 @@ fn test() {
</div>
);}))}
",
r#"import { Children } from "react";
r#"import { Children } from "react";
Children.toArray([1, 2 ,3].map(x => <App />));
"#,
r#"import React from "react";
r#"import React from "react";
React.Children.toArray([1, 2 ,3].map(x => <App />));
"#,
r"React.Children.toArray([1, 2 ,3].map(x => <App />));",