dan/discord.js
1
0
Fork 0
mirror of https://github.com/danbulant/discord.js synced 2026-06-03 06:41:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
3840 commits 8 branches 50 tags 70 MiB
Commit graph

2153 commits

Author SHA1 Message Date
Amish Shah
fe8ece0192
voice state fixes 2018-08-10 15:15:52 +01:00
Amish Shah
df54d11dce
Merge branch 'master' of https://github.com/hydrabolt/discord.js 2018-08-10 14:45:07 +01:00
Amish Shah
be5efea461
rewrite voice state handling 2018-08-10 14:44:59 +01:00
NbOpposite
ea4375bf90 Fixed splitting messages with codeblocks (#2720) 2018-08-10 15:44:32 +02:00
Kyra
0f63c50c06 fix: Util.basename being unreliable (#2679) 
* fix: Util.basename being unreliable

new URL for WHATWG parsing was not chosen because it only works for URLs and threw in local pathes, path.basename is unreliable (according to the devs' note), and path.parse seems to work well.

* docs: Update Util.basename's description
 2018-08-10 11:23:22 +02:00
Isabella
2c8e15e31c docs fix: RoleResolvable typedef missing and incorrecty documented methods (#2640) 
* docs fix: RoleResolvable typedef missing and incorrecty documented methods

* requested changes???

* REAL requested changes

* shhh
 2018-08-10 11:08:48 +02:00
Alex Hîncu
ce8a679a14 fix(Collection): use Symbol.species for creating derived collections (#2715) 2018-08-10 10:57:33 +02:00
Souji
0a21280990 add Collection as possible param to GuildChannel#overwritePermissions + wording port from 11.3-dev (#2719) 
* add Collection as possible param to GuildChannel#overwritePermissions

* change PermissionoverwriteOptions desc. default to unset

* fix eslint hiccup

* fix spelling of snowflake
 2018-08-10 10:57:05 +02:00
Yukine
147488df89 use null for getters (#2723) 2018-08-10 10:56:07 +02:00
Amish Shah
be56087c23
lint error 2018-08-09 14:00:33 +01:00
Amish Shah
ee6c19ca7e
voice: rewrite GuildMember#speaking tracking (#2540) 2018-08-09 13:59:52 +01:00
Isabella
f3d7f7c3bd refactor: move Message#cleanContent function to Util (#2703) 
* refactor: move Message#cleanContent function to Util

* suggested changes
 2018-08-09 14:27:05 +02:00
1Computer1
8e0ea9aa16 Collection debug methods, remove deleteAll (#2577) 2018-08-09 14:25:07 +02:00
Amish Shah
55863efa15
voice: don't clear reject timeout until connection fully resolved (#2421, #2578) 2018-08-09 13:00:46 +01:00
Lewdcario
9dfcb61a90
Revert "fix: Shards not receiving regular messages" 
This reverts commit 88616eaf3e.
 2018-08-08 13:03:29 -05:00
Amish Shah
8152841bab
Try to cache members from data in message payloads 2018-08-08 12:45:49 +01:00
Crawl
5980d04f2b
docs: implement #2707 on master 2018-08-08 12:48:34 +02:00
DennisV2809
47d405e70c Small typo in documentation of Message.js (#2704) 
* Update Message.js

message.reply() example fix

* Update Message.js
 2018-08-08 12:41:35 +02:00
Amish Shah
98dc2df6d4 Revert "fix(Collection): use new this.constructor instead of new Collection (#2709)" 
This reverts commit c10b4feeeb.
 2018-08-07 19:08:51 +01:00
Amish Shah
46fa9603c2
voice: delete receive stream immediately to prevent it being written to after end (#2678) 2018-08-07 17:34:01 +01:00
Alex Hîncu
c10b4feeeb fix(Collection): use new this.constructor instead of new Collection (#2709) 2018-08-07 18:08:49 +02:00
Yukine
b38f537da8 feat: Add new Permission PRIORITY_SPEAKER (#2698) 2018-08-03 20:19:19 -04:00
Frangu Vlad
4ae58f66f4 fix: Wrong _patch call from GuildEmoji#edit and other issues (#2673) 
* Fix bugs

* Make the data.roles be undefined before API call

* Suggested changes

* Handle edit properly
 2018-07-31 12:43:17 -04:00
Lewdcario
88616eaf3e
fix: Shards not receiving regular messages 2018-07-31 09:55:32 -06:00
Isabella
ba32eec7e8 feat(Message): add url getter (#2594) 
* feat(Message): add jumpToURL getter

* fix url

* url syntax update

* name to url
 2018-07-26 04:38:11 +02:00
bdistin
5afd77ab73 refactor: remove user bot methods (#2559) 
* [WIP] Remove user bots

* more backend userbot removal

* Add mfaEnabled back

* revert client presences store removal

* partially revert getAuth changes

* remove more no longer used children of ClientUserGuildSettings

* fix a bug with this pr and TextBasedChannel.applyToClass

* remove a syncGuilds reference

* more user bot data handling

* various guildSync cleanup

* bots can't call logout

Had the user/bot portions of the code mixed up. Though, does this need to be a promise anymore?

* make ClientManager#destroy() sync

It nolonger needs to be a promise, and nothing depended on it being a promise that I can tell.

* requested change

* Fix massive error

* no longer used as it's userbot only
 2018-07-25 22:14:23 -04:00
Yukine
f963621ef1 fix(GuildEmoji): added a check for managed emojis in fetchAuthor (#2645) 2018-07-25 21:11:38 -04:00
PLASMAchicken
c46cbbfd84 docs: added sizes 16, 32, 64 (#2666) 
* documented sizes 16, 32, 64

* Removed space

* Added typedef

* The options to provide => Options for the Image URL

* fixed
 2018-07-25 21:04:47 -04:00
Isabella
3a7a7d730b
fix(MessageReaction): only delete reaction if cache and count is empty (#2661) 2018-07-23 16:32:51 -04:00
Gymnophoria
717e7f094a
docs(Client): clarify messageReactionRemove event's user description (#2657) 
* Clarify messageReactionRemove user description

* Update MessageReactionRemove.js

* wait one more word difference lol
 2018-07-18 11:41:05 +02:00
SpaceEEC
36806612bf
fix(Invite): support for group dm invites (#2603) 
* fix(Invite): support group dm invites

* refactor(Invite): mark all optional properties as nullable and default them to null
 2018-07-18 11:39:34 +02:00
Kyra
e0378cf350 refactor(Webhook): make token not enumerable (#2566) 
* Hide Webhook#token (consistency with Client#token)

* Make `Webhook#token` writable

* fix: devsnek's requested change

Webhook#token must be both writable and configurable.
 2018-07-18 11:37:57 +02:00
Lewdcario
f67d682223
fix(ShardingManager): respawnAll shard iteration 2018-07-10 21:39:58 -05:00
SpaceEEC
526832058e
fix(Message): keep reply option when using an embed or attachment 
See #2651
 2018-07-08 21:12:30 +02:00
Souji
95b2dd3fe6 feat: Add support for Guild#setDefaultMessageNotifications (#2624) 
* Feat: Guild#setDefaultMessageNotifications

* fix typo
 2018-07-01 11:03:47 -05:00
Lewdcario
077d41fbca
fix(Webhook): import Channel correctly 2018-07-01 10:19:44 -05:00
Lewdcario
938d87d5d6
fix(Shard): actually remove default execArgv 2018-07-01 10:17:20 -05:00
Lewdcario
2694c0d442
fix(RequestHandler): provide proper route and method 2018-06-29 15:13:03 -05:00
Lewdcario
93f8c8547b
fix(Shard): allow node to default to process.execArgv 2018-06-29 15:13:01 -05:00
Lewdcario
92e2c3c7fd
fix: instantiate constructors before using those properties 2018-06-29 15:12:52 -05:00
Lewdcario
41a1dee533
fix(Util): circular reference 2018-06-29 13:02:38 -05:00
bdistin
f711aa35ac fix: typo in src/errors/messages.js (#2631) 
fixes #2630
 2018-06-26 19:07:09 +02:00
Lewdcario
6b3bfdd7de
fix(Shard): fix default args 2018-06-25 16:10:50 -05:00
FireController1847
ac0c15f7f1 Change ytdl example (#2619) 2018-06-24 15:47:54 +02:00
Isabella
bfbb723f42
feat(ShardingManager): add execArgv option (#2585) 2018-06-23 16:09:03 -05:00
bdistin
58e5017159 fix: ratelimits (#2615) 
* Add timeDifference calcs back into ratelimits

And fix x-ratelimit-reset is in seconds, not ms: https://puu.sh/AIXxY/9b3989b248.png

* mutate reset time with date header instead

* fix defaulting of reset and remaining

if the reset header is not available, then the reset time should be Date.now() instead of the difference between the date header and Date.now()

If the date header is null, fall back to Date.now() since it's the best we can do (this should never happen, but safer to handle it just in case)

if remaining is 0 we don't want to default it back to 1 since 0 is falsy
 2018-06-23 16:08:40 -05:00
Souji
de408d735b docs(Guild): memberCount is not as of ready (#2621) 
but updated every guild member add or remove
 2018-06-23 15:22:57 +02:00
Mikhail
bf738b34de fix(BasePlayer): incorrectly mutating FFMPEG_ARGUMENTS when using seek (#2622) 
Because args was not a copy of FFMPEG_ARGIMENTS, but a reference to it, pushing 'ss' argument pushed it to FFMPEG_ARGUMENTS, making it persistent.
 2018-06-23 15:20:59 +02:00
Amish Shah
18646b72f9
voice: use getters where possible 2018-06-22 18:46:51 +01:00
Amish Shah
08bbbe9301
voice: handle new client_connect and client_disconnect packets 2018-06-22 18:38:33 +01:00
Amish Shah
9296a30148
voice: account for speaking now being a bitmask 2018-06-22 17:47:00 +01:00
Amish Shah
1f7c1ddaa2
voice: start update to v4, fix heartbeats 2018-06-22 17:42:04 +01:00
Amish Shah
3d41748a38
voice: fix not passing volume to transform constructor 2018-06-21 21:50:54 +01:00
Camzure
9997a67ab6 Docs: Wording Improvements (#2607) 
* wording improvement

* wording improvement for docs

* docs: wording

* wording

* user account only: docs

* Edited

* Edited
 2018-06-21 21:35:52 +02:00
Will Nelson
594363a05e fix response parsing (#2614) 
* fix response parsing

* rfc: better parseResponse function
 2018-06-21 00:11:47 +02:00
Kyra
270a278a6e feat(Guild): add support to edit defaultMessageNotifications level (#2592) 
* Added support for `defaultMessageNotifications`

* Requested changes

* docs: Change type for GuildEditData.defaultMessageNotifications
 2018-06-19 21:16:05 +02:00
Will Nelson
5e011dbc11 switch to node-fetch (#2587) 
* switch to node-fetch

* remove useless var declaration

* remove method uppercasing

* rework concurrency

* Revert "rework concurrency"

This reverts commit ef6aa2697e07277ae9f561f72558f38f358d2e08.

* fix headers
 2018-06-19 20:10:55 +02:00
Souji
791f58e130 docs: add video to MessageAttachment properties (#2608) 2018-06-19 20:09:55 +02:00
RumbleFrog
c5fea45f30
fix(ShardClientUtil): send method erroneously rejecting (#2604) 2018-06-17 19:47:42 +02:00
Schuyler Cebulskie
d97af9d2e0 Improveder 2018-06-17 00:51:32 -04:00
Schuyler Cebulskie
f91747a764 Improve Shard#kill description 2018-06-17 00:50:38 -04:00
reeeeeeeeeeeeeeeeeeeeeeeeeeeeeee
e7eab427e5
docs: document lastMessageID for TextChannel and (Group)DMChannel (#2602) 
* Adds JSDocs for TextChannel.lastMessageID

* oops

* docs: document lastMessageID in (Group)DMChannel as well
 2018-06-16 22:28:12 +02:00
bdistin
037e8cf969 fix(Messages): undeleting themselves (#2570) 
when a _patch() is queued
 2018-06-16 21:16:57 +02:00
Kyra
e8ab049a67 refactor(MessageMentions): make client, guild, and _content non enumerable 2018-06-16 17:14:10 +02:00
Amish Shah
1cdee7b48a
voice: reimplement seek option (#2572) 2018-06-13 21:16:14 +01:00
Amish Shah
04618f554f
voice: fix _writeCallback being called multiple times (#2567) 2018-06-13 21:06:50 +01:00
Amish Shah
3bfc1ff61c
voice: fix write after end (#2567) 2018-06-13 21:02:19 +01:00
Amish Shah
d69e906027
voice: fix voice receive after enabling suffix and lite encryption modes 2018-06-13 20:43:18 +01:00
Lewdcario
ba9a93b0bf
docs: last english fix for now 2018-06-12 18:54:51 -05:00
Lewdcario
eb4607c8ad
docs: fix english because english is difficult 2018-06-11 21:18:15 -05:00
Lewdcario
5eff360a4d
docs: wording improvements 2018-06-11 16:37:34 -05:00
iDroid
bce9a8af1b feat(User): add locale property (#2571) 2018-06-10 10:58:00 -05:00
bdistin
99bd355522 refactor: RESTManager handlers to use collection (#2539) 2018-06-10 05:45:34 +02:00
Lewdcario
5071477172
fix(GuildMember): account for joinedTimestamp as well 2018-06-05 20:14:34 -05:00
Lewdcario
13bfceb83c
fix(GuildMember): mark joined as nullable and fix fetching for these cases 2018-06-05 19:50:36 -05:00
Lewdcario
c8ecbe6585
docs: GuildMember#speaking 
and consistency improvements
 2018-06-05 00:33:54 -05:00
Lewdcario
09708482f6
fix(ReactionUserStore): fetch inconsistency 
It should be consistent with MessageStore#fetch now
 2018-06-05 00:33:52 -05:00
Lewdcario
dfbd4bdde1
docs: add examples & improve notices 2018-06-05 00:33:43 -05:00
Lewdcario
512af54e5d
fix(Shard): erroneously returning false 
The node documentation fails to correctly document when the backlog of unsent messages exceeds a certain threshhold the function will return false. This does not mean it will refuse to send- simply that it will take time. Issue in point: https://github.com/nodejs/node/issues/7657#issuecomment-240581726
 2018-06-04 18:01:10 -05:00
Lewdcario
0be0d2542d
fix(VoiceChannel): deletable erroneously returning true 2018-06-04 17:16:35 -05:00
Lewdcario
46b19bbbdb
fix(GuildMember): Invalid Date 2018-06-04 16:24:42 -05:00
Kyra
d02c303afd fix(Guild): equals method modifying features array of guild (#2544) 
* Fixed a bug where Guild#equals would cause the given guild to lose its features

* Fix Util.arraysEqual

* Fixed docs for Util.arraysEqual

* Remove Util.arraysEqual
 2018-05-29 11:15:19 +02:00
Kyra
30c7d6d1b1 feat(Guild#defaultMessageNotifications) (#2538) 
* feat(Guild#defaultMessageNotifications)

* boolean -> DefaultMessageNotifications

* Space's requested change
 2018-05-28 17:44:04 -05:00
Braxton
f0c4d0e834 feat: Add "deleted" property to multiple structures. (#2556) 
* Add "deleted" property to "Message" structure

* Add "deleted" property to Multiple structures

Structures edited:
- Channel
- Emoji
- Guild
- Guild Member
- Role

* Update "deletable" getter

* Fix ESLint "no-trailing-spaces" errors

* Requested Change: Mark w/ bulkDelete
 2018-05-28 17:42:51 -05:00
Adrien Brignon
27fcb64187 docs(Guild): handle error in example of fetchInvites correctly (#2568) 2018-05-27 20:57:50 +02:00
Dim
5494f8e3bd Fix: Incorrect NSFW Status on Channels (#2499) 
* Fix #2498

* wow this code seems familiar

* please be the last iteration
 2018-05-27 03:57:33 -05:00
Will Nelson
fc81924724 feat: Shard#kill method (#2454) 
* add shard#kill method

* docs consistency
 2018-05-27 03:26:18 -05:00
SpaceEEC
14aab1be38
fix(RequestHandler): only retry once on 5xx (#2471) 2018-05-25 17:33:17 +02:00
SpaceEEC
56a9d1ba3c
docs(Collection): make findKey method show up in docs 
Solved by moving the eslint-enable line below the method header.
 2018-05-19 08:50:39 +02:00
bdistin
25b654d494 consistency is king (#2554) 2018-05-18 03:30:19 +02:00
Lewdcario
75747f5b18
fix: RequestManager getting stuck on global ratelimit 
fixes #2550
 2018-05-14 22:55:50 -05:00
1Computer1
a732402c95 refactor: remove unnecessary Collection methods and add Collection#partition (#2511) 
* Rework collection

* Fix docs

* Remove (prop, value) behavior

* Add back thisArg

* Put examples on same line

* Revert map to return array

* Make examples less specific

* Add thisArg to sweep and partition
 2018-05-14 01:15:43 -05:00
Amish Shah
43c92c13e2
voice: support xsalsa20_poly1305_lite and xsalsa20_poly1305_suffix 2018-05-10 12:11:22 +01:00
Amish Shah
685814aa61
voice: make sure speaking is false when paused 2018-05-09 18:44:46 +01:00
Amish Shah
841b9de918
voice: mark speaking as false when paused, prevent repeated pausing 2018-05-09 14:33:23 +01:00
SpaceEEC
6cde6decee
fix(GuildEmoji): verify MANAGE_EMOJIS permission from Guild#me 2018-05-08 11:29:36 +02:00
Kyra
fca6d3be56 feat(GuildEmoji): add deletable getter (#2535) 
* feat(GuildEmoji#deletable)

* Update: Discord API returns 50001

When you try to get or delete a managed emoji from the API, you get a 50001 (Missing Access) error code.
 2018-05-06 21:12:16 +02:00
SpaceEEC
90312952d9
revert: "Improved TextBasedChannel#send (#2537)" 
This reverts commit 556e679bdb,
which broke resolving of non object literal message options.
 2018-05-04 16:44:06 +02:00
Kyra
556e679bdb Improved TextBasedChannel#send (#2537) 2018-05-04 14:56:22 +02:00
bdistin
7a3a4d1388 feat: add Collection#sweep() (#2528) 2018-05-04 02:27:59 -05:00
Will Nelson
32369f3bdd fix: prevent max listener problems with collectors (#2521) 2018-05-04 02:11:52 -05:00
1Computer1
9f918199d2 feat: add Collection#tap (#2507) 
* Add Collection#inspect

* No u

* Rename to tap

* Rename variable

* Do it here too
 2018-05-04 02:08:32 -05:00
SpaceEEC
ddab8096cf
feat(DataResolver): account for discord.gg/invite/<code> invites 2018-05-03 21:09:55 +02:00
Kyra
42ce4f8bc0 Removed usage of (deprecated) new Buffer (#2531) 2018-05-03 19:07:16 +02:00
Kyra
62605c4470 feat(DiscordAPIError): add method property (#2530) 2018-05-03 08:01:27 +02:00
bdistin
17d2c2efb8 docs(Collection): fix spelling of 'behavior' (#2529) 2018-05-03 08:00:56 +02:00
Lewdcario
f293dddc29 fix: Webhook#edit attempting to use client.channels always 2018-05-02 21:19:00 -05:00
Amish Shah
bd83bb9fd6
refactor: improve sweep performance 2018-05-02 18:09:51 +01:00
Amish Shah
27a0f48441
refactor: tidy up _inactive check 2018-05-02 18:04:47 +01:00
Amish Shah
b5f37728a7
feature: allow sweeping of inactive request buckets 2018-05-02 17:57:48 +01:00
Lewdcario
745669a7c9
docs: consistency 2018-04-29 13:28:12 -05:00
Frangu Vlad
5acf4061e8 fix: GuildMember#toJSON not having roles (#2520) 2018-04-29 11:28:45 -05:00
Kyra
934e90b921 fix: Added everyone role to GuildMemberRoleStore#_filtered (#2514) 
* Added everyone role to GuildMemberRoleStore#_filtered

* Changed to Guild#defaultRole
 2018-04-28 13:40:24 -05:00
Amish Shah
299fc001d5
voice: start using provided IP rather than manually resolving 2018-04-27 15:11:37 +01:00
Lewdcario
64caa33594
fix: GuildEmoji#clone 2018-04-25 18:42:51 -05:00
Lewdcario
30d43efa54
fix: GuildMemberRoleStore#remove 2018-04-25 18:01:28 -05:00
Daniel Odendahl Jr
95b531742a fix: TypeError in mixin function (#2506) 2018-04-24 18:35:07 -05:00
Isabella
8b83553462
refactor: role stores (#2478) 
* refactor: reduced duplication in role stores

* fix docs

* fix: typo

* most of requested changes

* rest of changes

* ACTUAL rest of changes

* docs

* doooocs

* reason
 2018-04-24 15:52:00 -05:00
Jacz
e12ab7428f fix(MessageEmbed): correct docs, default to array, resolve MessageAttachments (#2492) 
* Fix(MessageEmbed): Remove useless for...of & change this.files to be out of the data.files check...

* Requested changes
 2018-04-23 19:38:56 +02:00
Kyra
b186472785 Added a note in userUpdate event (#2479) 2018-04-21 21:45:15 +02:00
Lewdcario
b8a9a76cf6
docs: inconsistencies 2018-04-20 21:10:21 -05:00
Faith
c9c2d66971 feat(GuildChannelStore): add topic to create options (#2488) 
The API provides the ability to send the topic, or description, of the channel within the creation post. Discord.js will now send it if its provided.
 2018-04-20 19:11:46 +02:00
Lewdcario
8d065fa043
fix: Client#generateInvite resolving permissions incorrectly 2018-04-18 20:25:49 -05:00
Lewdcario
ec9211c3ce
docs: inconsistencies 2018-04-18 20:21:17 -05:00
Suvan
2dd7fd2739 docs(GroupDMChannel): fix grammar an user -> a user (#2482) 2018-04-17 18:24:48 +02:00
SpaceEEC
f6216f3905 feat(SnowflakeUtil): allow snowflakes to be generated dynamically (#2459) 2018-04-17 09:00:18 -05:00
bdistin
8551b8936c docs: fix a number of spelling mistakes (#2469) 2018-04-13 20:50:47 +02:00
Frangu Vlad
61ad9475de fix(ClientManager): patch ClientUser's presence with ClientOption's one (#2458) 2018-04-13 08:27:53 +02:00
Amish Shah
cb69102e5e
voice: allow for changing volume with webm/ogg streams 2018-04-10 21:19:29 +01:00
Jérémie N'gadi
e845758037 fix(StreamDispatcher): only update speaking for non broadcasts (#2437) 
If the player is a BroadcastAudioPlayer it has no VoiceConnection directly associated with it.
 2018-04-09 21:17:16 +02:00
Schuyler Cebulskie
952a7123f3
Add missing word in Shard#respawn docblock 2018-04-09 14:35:49 -04:00
Pascal
b955a514f6
fix(Guild): remove member's voice state on guildMemberRemove 
fixes #2430
 2018-04-09 17:43:07 +02:00
bdistin
b3ff7c728e feat(Guild): add mfaLevel property (#2451) 2018-04-09 09:56:48 +02:00
bdistin
2bf68dcdfb docs(GuildStore): correct warning for create method (#2453) 
Bots may create guilds if they are in less than 10 guilds.
 2018-04-09 09:56:25 +02:00
Frangu Vlad
f985b6bef3 fix(Role): allow edit method to null the color (#2447) 2018-04-09 09:54:40 +02:00
Amish Shah
ef138fd3e9
voice: fix #2380 (voiceSessionID null after changing server region) 2018-04-07 15:29:38 +01:00
Amish Shah
fa886eaae9
voice: fix bug where no audio could be heard if voice region changed 2018-04-07 15:19:18 +01:00
Amish Shah
384fdf8f17
voice: properly cleanup after disconnect (#2443, #2435, #2421, #2406 #2359) 2018-04-07 14:40:05 +01:00
Amish Shah
41d0f25d0f
voice: fix heartbeat issue (#2443) 2018-04-05 16:38:35 +01:00
Pascal
e431ccdad2
fix(GuildChannel): always return a boolean from the manageable getter 
Overlooked the comment pointing that out in #2439
 2018-04-02 20:52:12 +02:00
Favna
ef4bd92c8a feat(GuildChannel): add manageable getter (#2439) 
* Adds GuildChannel.manageable

* Resolve requested changes

* fix eslint max-len error

* Fix for nullable permissionsFor()

* Indent fixes
 2018-04-02 20:00:47 +02:00
Amish Shah
a5e8f05d01
voice: add end param to describe how a voice receive stream should end 2018-03-31 11:52:48 +01:00
Will Nelson
b5b436f9cb Revert "fix message embed json serialization (#2420)" 
This reverts commit c40488eb54.
 2018-03-24 18:47:15 -06:00
Will Nelson
c40488eb54 fix message embed json serialization (#2420) 
* fix message embed json serialization

remove the toJSON method on message embeds so the raw data is exposed
for JSON seralization. this removes the hexColor property, but it
probably should not have been there in the first place. fixes #2419

* change api transform to tojson
 2018-03-24 19:43:56 -05:00
Lewdcario
4e0e64d8a1
fix(MessageReaction): inaccurate count 
also works towards async rewrite goal
fixes #2404
 2018-03-24 15:22:21 -06:00
Pascal
d041cb2460
fix(GuildEmojiRoleStore): do not prematurely patch roles 
Issue is the same as in #2312 and #2381, but for the GuildEmojiRoleStore.
Thanks to @KingDGrizzle for pointing this out.
 2018-03-16 20:01:43 +01:00
bdistin
acd1740f0b docs: fix missing parameter type/description from #2193 (#2396) 
* docs: Fix missing parameter type/description from #2193

* requested changes
 2018-03-15 06:52:23 +01:00
Amish Shah
ef8366d189
voice: properly null-check udp socket first (#2317) 2018-03-13 09:48:18 +00:00
Pascal
513dbf2f68
fix(MessageReaction): do not increment count twice for own user 
Fixes #2389
 2018-03-10 14:11:33 +01:00
Pascal
0f7ce3f720
fix(GuildemojiStore): allow resolving of external ReactionEmoji 2018-03-10 14:08:59 +01:00
bdistin
630009f3cf fix: Convert lastMessage to getters (#2384) 
* convert lastMessage to getters

* fix bug in pr

* requested changes
 2018-03-08 10:19:43 -06:00
bdistin
799eea957e consistency: getters return null instead of undefined (#2385) 2018-03-08 10:15:06 -06:00
Lewdcario
a68f14500d
fix: GuildMemberStore: unban returns user 
fixes #2388
 2018-03-08 10:08:59 -06:00
Pascal
85413481ed
fix(DataResolver): always resolve with buffer when resolving urls 
Fixes: #2379
 2018-03-06 21:48:34 +01:00
Amish Shah
79b02dd35f
voice: resolve "cb is not a function" error (#2317) 2018-03-06 10:36:05 +00:00
Amish Shah
8289b70e2c
voice: resolve issue where dispatcher tried to send packets to null socket (#2317) 2018-03-06 10:21:44 +00:00
Amish Shah
835bff74cd
lint: remove unused import 2018-03-05 20:17:38 +00:00
Amish Shah
ff825cd8b8
voice: fix #2331 (speaking not set back to false on stream ending) 2018-03-05 19:41:35 +00:00
Amish Shah
399d179ebc
Merge branch 'master' of https://github.com/hydrabolt/discord.js 2018-03-05 19:30:21 +00:00
Amish Shah
e263063ba6
voice: update prism and fix framesize to work for opusscript 2018-03-05 19:30:18 +00:00
Pascal
3e6c3107c2
fix(GuildMemberRoleStore): make remove role remove roles again 2018-03-05 14:50:59 +01:00
Pascal
3f6a0e4de1
fix(GuildMemberRoleStore): only update roles after successful request 
Fixes #2381
 2018-03-05 11:32:03 +01:00
Jonah Snider
8b679913a4 docs: Change 'the this' to this (typo) (#2377) 2018-03-04 08:16:12 +00:00
Isabella
0a951cfc0f
docs: TextChannel Webhooks fix&improvement 2018-03-03 18:55:54 -06:00
Isabella
b637c9c220
feat: allow multiple permission overwrites when editing channel (#2370) 
* feat: allow multiple permission overwrites when editing channel

* undo Permissions#resolve change
 2018-03-03 11:18:58 -06:00
Frangu Vlad
069dccfa3b docs: document the messages property for all TextBasedChannels (#2373) 
* Document TextChannel#messages

* Same for DMChannels

* And GroupDMChannels
 2018-03-03 11:04:33 +01:00
Will Nelson
cf7dcba1a5 Add toJSON methods (#1859) 
* tojson things

* fix client

* ignore private properties

* remove extra property descriptors

* handle primitive flattening

* remove unused import

* add toJSON to collections

* reduce stateful props

* state

* allow custom prop names when flattening

* fix client

* fix build

* fix flatten docs

* remove guild.available, cleanup permissions, remove arbitrary id reduction

* fix util import

* add valueOf as needed, update member props

* fix incorrect merge

* update permissionoverwrites and permissions

remove serialization of permissions in PermissionOverwrites#toJSON.
change Permissions#toJSON to serialize permissions, by default excluding
admin checks.

* change Permissions#toJSON to return the primitive

* Permissions#toJSON explicitly return bitfield
 2018-03-01 23:00:21 -06:00
Lewdcario
24571e465b
docs: examples & improvements 2018-03-01 22:50:45 -06:00
Lewdcario
9b41a6a8a6
fix: re-add highest property to RoleStore and GuildMemberRoleStore 
closes #2302
 2018-03-01 11:52:29 -06:00
Will Nelson
2a9fdef9e5 add valueOf method to permissions (#2363) 2018-02-28 16:48:06 +01:00
Pascal
464fc14edd
fix(Activity): ensure that timestamps are actually numbers 
Fixes #2364
Discord sends those timestamps packed as SMALL_BIG_EXT, which get converted to strings in js.
~~Maybe they are already preparing their timestamps for 2038.~~
 2018-02-28 09:31:42 +01:00
rei2hu
35babc706d Fix: discord sort method (#2355) 2018-02-23 21:18:42 -06:00
nekobako
c25ea45866 fix(StreamDispatcher): emit volumeChange event when the volume changes (#2349) 2018-02-21 22:21:13 +01:00
Ecstabis
3a3ca96b0d Added 2 basic role colors PINKISH_PURPLE and DARK_PINKISH_PURPLE (#2303) 
* Added 2 basic role colors PINKISH_PURPLE and DARK_PINKISH_PURPLE

* Added documentation for added Colors PINKISH_PURPLE and DARK_PINKISH_PURPLE

* fix colour names

* docs
 2018-02-20 16:51:03 -06:00
Pascal
05c5bdc476
fix(StreamDispatcher): do nothing when resume is called when not paused 
Fixes #2324
 2018-02-19 18:17:51 +01:00
Kyra
a8172951d3 perf(Collection): Performance improvements (#2342) 
* Update Collection.js

* ESLint
 2018-02-16 10:19:30 +01:00
SpaceEEC
47bc0fc51e
feat(GuildChannel): add fetchInvites method (#2339) 
* feat(GuildChannel): add fetchInvites method

* fix: actually use the 'channels' endpoint
 2018-02-13 17:29:42 +01:00
Isabella
66c0512de2 feat(ShardClientUtil#broadcastEval): allow promise resolve (#2328) 2018-02-07 11:07:59 -05:00
Sanctuary
87e5a45659 feat(ClientOptions): add support for setting an initial presence (#2320) 
* docs/feat(WebsocketOptions): Parse ws options presence

Allow the `presence` property in `WebsocketOptions` to be used the same way
as `ClientUser#setPresence`.

* Move presence options to top level
 2018-02-04 21:32:45 +01:00
Snazzah
43363172c2 docs: Add TypeDef for MessageActivity (#2321) 2018-02-04 20:44:13 +01:00
Frangu Vlad
e0cbf0bb60 feature: add GuildEmoji#fetchAuthor (#2315) 
* Make the base code

* Fxi lint
 2018-02-02 20:34:21 +01:00
Gus Caplan
bd1bf11ed0 spotify stuff (#2314) 2018-02-02 12:45:18 -06:00
Lewdcario
234648bd2a
fix(ClientApplication): createAsset incorrectly resolving image and posting 2018-02-02 11:41:08 -06:00
SpaceEEC
016526486c enhancement(Activity): add toString method (#2313) 2018-02-01 18:41:05 -06:00
Lasse Niermann
31873eb3a5 docs(ClientUser): mark email field as user account only property (#2306) 
* Store Mail - User Account Only

Added that info

* docs(ClientUser): mark email field as nullable
 2018-02-01 20:29:20 +01:00
Pascal
32e2dd212e
fix: add clone methods to GuildMember and GuildMemberRoleStore 
Fixes #2312
This adds clone method to both classes to achieve the expected behaviour when cloning a GuildMember, also cloning their roles store
 2018-01-31 21:04:15 +01:00
Isabella
9810bdbc5f
fix(MessageEmbed): remove length checks (#2304) 
* fix(MessageEmbed): remove length checks

* update error messages
 2018-01-29 10:56:55 -06:00
Lewdcario
d46eec4da4
fix(resolveColor): not interpreting DEFAULT correctly 2018-01-28 22:34:50 -06:00
Lewdcario
2e0048add1
docs: doc changes 2018-01-27 23:41:25 -06:00
Lewdcario
d93d628f19
make Message#member a getter 2018-01-27 17:04:03 -06:00
Dim
10f98d8e57 use String#padStart for Role#hexColor (#2294) 2018-01-27 07:42:49 +01:00
Lewdcario
bd154bdd9e
fix: nullable activity 2018-01-25 02:06:28 -06:00
Alex
e58ff642f5 Make Util#splitMessage handle edge cases properly (#2212) 
* Make Util#splitMessage handle edge cases properly

* Restart Travis

* Set maxLength to 2000 + small tweak
 2018-01-24 23:41:50 -06:00
Faith
58d85282b4 Fix Destructuring Errors in Util (#2171) 
* Fix Destructuring

* Fix another one
 2018-01-24 17:37:41 -06:00
Lewdcario
7e0e457334
fix(ClientUser#setStatus): resetting activity 
The method would pass in null if no activity was passed, so this takes the current client presence instead of deleting it.
 2018-01-24 15:09:40 -06:00
Frangu Vlad
a832b56469 GuildEmoji: Move all role related functions to a separate store (#2271) 
* Prepare to work on moving all role functions to a Store

And yes, this is *another* patch branch cause I messed up my master branch to hell

* Move all emoji role related functions to its own store
Tested everything and it works! (With a reload of the client)
Also had to change a value in DataStore#holds
holds.name for GuildEmojis would return the emoji name instead of the class name

* New Line

* Thanks JS for circular dependency!
Because we can't have nice things...

* Do space's request

* Fix equals

* Fix space's point.

Raw API data has the role property as an array of IDs
 2018-01-24 20:47:20 +01:00
Dragon Fire
16b5de5d52 fix(Role) Update usages of highestRole#comparePositionTo to use GuildMemberRoleStore (#2289) 2018-01-24 13:34:11 +01:00
Pascal
048e147497
fix(RoleStore): create method is supposed to take an options object 2018-01-24 09:02:37 +01:00
FireController1847
92c9f8864c Specify that Client#uptime is "in milliseconds" (#2288) 2018-01-24 08:24:24 +01:00
Frangu Vlad
00172e6c7d refactor: Move member role-related functions to a special store (#2242) 
* Ignore this I need a patch branch for Git

* Move all member role related stuff to a new DataStore
GuildMemberRoleStore is a new store that holds all member role related stuffs
Because its consistent!

* Minorest doc fix ever
To whoever did this object, they forgot a `{`

* Fix the spacing in the docs

* Resue the stores resolve rather than copy paste
Cause I'm dum and it overwrite resolve to the guild role stores resolve soo

* Fix some requests
- Removed the bs private functions
- Set the roles in the constructor

But, I need feedback. There is no way, that I saw, to make a member have roles whenever GuildMmber#_patch is called,
due to the roles being null on the guild. So the only way might be the for loop and getter.

* Fix an issue that I caused in #add
I was testing some other things, and changed that to test. Forgot to change it back

* Actually make the store generate just once when the member is created by first initializing the roles in the guild
Also replaces GuildMember#_roles with GuildMemberRoleStore#_roles
Tested all functions to make sure the expected result happens.

* I missed this from moving remove from GuildMember to GuildMemberRoleStore

* Fix RoleStore#create docs
For real this time

* Do all the requested changes
- Rename all `somethingRole` to `something` (hoistRole => hoist)
- Refactor add and remove to be cleaner and re-use set

* Fix a bug where the store would loose some roles due to null roles that can throw an error in the for loop after they've been deleted

* Remove the `role.id || role` part of the add and remove functions as Appel suggested

* Replace roles.resolve with roles.resolveID for GuildMemberRoleStore#remove

* Don't use Array.isArray in checks
Use instanceof instead

* Woops, I forgot to change this
Renamed colorRole to color

* The docs have dots, so we place the dots back
 2018-01-24 08:12:58 +01:00
Pascal
07c48a6845
fix: require discordjserror to throw meaningful errors where necessary 2018-01-22 20:23:36 +01:00
Cat
8a2ace45d8 docs: fix VoiceBroadcast documentation (#2277) 2018-01-21 18:23:23 +01:00
Michel Nguyen
edc4e2b751 docs: fix streamdispatcher documentation (#2275) 
* docs change

* fix streamdispatcher documentation

Signed-off-by: Michel Nguyen <modzongaming@gmail.com>

* fucks sake

Signed-off-by: Michel Nguyen <modzongaming@gmail.com>

* typings

Signed-off-by: Michel Nguyen <modzongaming@gmail.com>

* typings again 👀

Signed-off-by: Michel Nguyen <modzongaming@gmail.com>
 2018-01-21 18:23:00 +01:00
Amish Shah
83de7c0d4c
Fix error messages 2018-01-21 15:52:32 +00:00
Amish Shah
76891a1e00
try fix 2018-01-21 10:34:14 +00:00
Amish Shah
aa09490724
whoops 2018-01-21 10:31:12 +00:00
Amish Shah
b2708a6fa8
Merge branch 'master' of https://github.com/hydrabolt/discord.js 2018-01-21 10:29:06 +00:00
Amish Shah
0e262ea8d7
More informative stream errors 2018-01-21 10:29:03 +00:00
Pascal
93e083da4f
fix(Guild): memberCount not decrementing when an uncached member leaves 
This leads to GuildMemberStore#_fetchMany to always reject
because it expects more member than possible.

Also no longer call the GuildMemberRemove handler locally
to not decrement twice.
 2018-01-21 07:30:59 +01:00
Kyra
986e6da196 Fix(GuildChannel#clone) options.parent not accepting (falsy) null. (#2262) 
* Fixed (falsy) options not being set correctly

* Requested changes.

As a side note, I also default `options.withPermissions` for simplicity, and because it gets ignored in [`GuildChannelStore#create()`](https://discord.js.org/#/docs/main/master/class/GuildChannelStore?scrollTo=create).

* Fixed the overwrites option
 2018-01-20 19:30:30 +01:00
Amish Shah
b16e6f8262
Fix VoiceBroadcast#play documentation 2018-01-20 16:57:27 +00:00
Amish Shah
f588b3fd20
Merge branch 'master' into voice-rewrite 2018-01-20 13:50:34 +00:00
Amish Shah
c63bdb5fb1
Remove redundant doc tag descriptions 2018-01-20 13:47:35 +00:00
Amish Shah
ca96e1478a
Make docs technically correct 2018-01-20 13:45:22 +00:00
Amish Shah
791740220e
Improve docs, allow for webm/opus demuxing and playing broadcasts without specifying a type 2018-01-20 13:01:48 +00:00
Amish Shah
f14193b93a
Document examples 2018-01-20 12:48:28 +00:00
Pascal
fbd25f8677
fix(GuildMember): make edit method only modify a copy of the voice state 
This is to fix stale members in voice channels.
 2018-01-20 12:44:27 +01:00
Pascal
a22b856494
fix(WebSocketConnection): make errors in event handlers throw again 
The error from something like client.on('ready', () => undefined.f);
would just be emitted as debug event instead of being thrown.

Simply moving the emitting part out of the try catch again solves this.
 2018-01-20 09:05:07 +01:00
Yukine
bf0a68dbac Mark DataStores as public to directly display them in the docs. (#2268) 
* make EmojiStore not Private anymore.

because why have something private if there is priority functionality on that class? also that causes that the docs wont show it directly

* make GuildChannelStore not private anymore

because why have something private if there is priority functionality on that class? also that causes that the docs wont show it directly

* make RoleStore not private anymore

because why have something private if there is priority functionality on that class? also that causes that the docs wont show it directly

* make ReactionStore not private anymore

because why have something private if there is priority functionality on that class? also that causes that the docs wont show it directly

* make all non private to stay consistent

* fix merge conflicts because of other PRs.
 2018-01-20 08:00:44 +01:00
Amish Shah
ef02bd2935
Add stubs for docs 2018-01-20 00:05:37 +00:00
Amish Shah
2b5fc77a67
Rudimentary support for unified audio playing! 🎉 2018-01-19 23:55:59 +00:00
Amish Shah
8e5e1ad8fe
Document Receiver 2018-01-19 23:03:01 +00:00
Amish Shah
c57c2889b7
Fix import errors for networking classes 2018-01-19 22:54:54 +00:00
Amish Shah
066fbfe330
Move voice UDP client and Websocket client to networking folder 2018-01-19 22:53:55 +00:00
Amish Shah
60c5c1486b
Remove dead files 2018-01-19 22:51:53 +00:00
Amish Shah
c6c9c0918a
Fix PacketHandler runtime error (EventEmitter not imported) 2018-01-19 22:51:26 +00:00
Amish Shah
cb161a8a40
Implement Receiver debug events 2018-01-19 22:47:01 +00:00
Amish Shah
83140f11b7
Fix ESLint and inline the voice readable stream 2018-01-19 22:41:31 +00:00
Amish Shah
dd618584d0
Simplify VolumeInterface constructor 2018-01-19 22:38:39 +00:00
Amish Shah
4a1b55d145
Receiver#createStream should take options 2018-01-19 22:38:10 +00:00
Amish Shah
2c1a302eea
Redesign voice receiving, still needs cleaning up 2018-01-19 21:14:03 +00:00
Amish Shah
6058ea4888
Start voice receive rewrite 2018-01-19 17:45:37 +00:00
Amish Shah
580bda46ea
Fix documentation for VoiceBroadcast (play methods return BroadcastDispatcher not StreamDispatcher) 2018-01-19 14:40:58 +00:00
Amish Shah
3b1c5d3494
Expose VoiceBroadcast#dispatcher so that the broadcast can be controlled 2018-01-19 14:39:51 +00:00
Amish Shah
e7375aa0fd
Reimplement broadcast (un)subscribe events 2018-01-19 14:32:51 +00:00
Schuyler Cebulskie
f649610c26 Merge branch 'master' into voice-rewrite 2018-01-18 19:49:23 -05:00
SpaceEEC
aa3407f705 Base Emoji class for ReactionEmoji and renamed GuildEmoji classes (#2230) 
* feat: create base Emoji class for ReactionEmoji and new GuildEmoji

* rename EmojiStore to GuildEmojiStore to account for the new class' name
 2018-01-18 02:38:45 -06:00
bdistin
b846cbd2b3 GuildChannel.permissionsFor(role) (#2254) 
* GuildChannel.permissionsFor(role)

* 1Comp's requested changes
 2018-01-18 02:28:14 -06:00
John Leuenhagen
d5b0cf9ffb Permissions improvements (#2126) 
* add Permissions.toArray()

* accept Permissions objects to Permissions.missing()

* accept Permissions as parameter to Permissions.has()

* style fixes

* remove redundant line, update JSDoc for Permission.resolve()

* JSDoc, style, and checkAdmin fixes

* add Permissions.resolveToObject()

* accept PermissionResolvable to Permissions.missing()

* remove `resolveToObject`, fix constructor JSDoc

* remove redundant parameter type

* fix `Permissions.missing()`

* fix checkAdmin

* update Permissions.toArray() description

* eliminate ambiguity in Permissions.toArray() description

* add backticks to permission example

* remove irrelevant type in Permission ctor description

* use this.constructor to properly support OOP

* use simplified approach for Permissions.toArray()

* fix return type on Permissions.toArray()

* move `Permissions#toArray` to more suitable position

* bitwise approach to `Permissions#missing`

* allow `Permissions` to be iterated over

* don't checkAdmin on return array

* remove unnecessary conditional

* fix JSDoc indentation

* use simpler & more reliable approach for missing()

* update PermissionResolvable typedef
 2018-01-18 02:17:50 -06:00
Artful
1db0906483 Client method examples. (#2264) 
* Client method examples.

* Consistency

* As per hydras request 🙇

* Thanks kya
 2018-01-18 07:47:05 +01:00
Michel Nguyen
19591b0bb1 docs: fix attachFiles() docs (#2267) 
* docs change

* fix attachFiles docs

* why was this still here
 2018-01-18 07:42:05 +01:00
Amish Shah
b94d60d2ab
Merge branch 'master' into voice-rewrite 2018-01-16 17:24:07 +00:00
Alex
e576387fea Fix ReactionCollector#remove and make Collector interface more consistent (#2221) 
* Fix ReactionCollector#remove and make Collector interface more consistent

* Move those below the doc

* Remove object spread

* Only emit event arguments

* Forgot to delete this line

* Update docs

* Also fix this

* More edits to docs

* Snowflake|string
 2018-01-16 01:33:58 +01:00
Isabella
36555c1cea refactor(GuildMember#manageable): refactored kickable and bannable (#2211) 
* refactor(GuildMember#manageable): merged kickable and bannable code

* hydar suggestion
 2018-01-16 01:32:40 +01:00
bdistin
4122db0275 Return undefined from Collection.find() / findKey() (#2260) 
To be compliant with Array.find() / findIndex()
 2018-01-16 01:24:19 +01:00
bdistin
3d32dea5e1 remove pointless function from GuildEmojisUpdate (#2256) 2018-01-16 01:20:51 +01:00
bdistin
3038d4b2c7 Address missing application docs in setPresence (#2257) 
fixes #2103 according to how crawl says it should be fixed in #2104
 2018-01-16 01:20:36 +01:00
bdistin
4fb7e64a39 Add parent, nsfw, bitrate, and userLimit options to GuildChannel.clone() (#2259) 
* Add parent, nsfw, bitrate, and userLimit options to GuildChannel.clone()

* fix lint
 2018-01-16 01:20:09 +01:00
iCrawl
f61b57ce10
Merge branch 'master' into voice-rewrite 2018-01-15 04:45:48 +01:00
pedall
42c0e50c92 Fix ShardClientUtil#broadcastEval - now really accepting functions (#2248) 
* small fix to broadcastEval accepting functions

* dont ignore idea anymore (separate PR then)
 2018-01-14 20:46:08 +01:00