dan/discord.js
1
0
Fork 0
mirror of https://github.com/danbulant/discord.js synced 2026-05-27 22:11:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Return undefined from Collection.find() / findKey() (#2260)

Browse source 
To be compliant with Array.find() / findIndex()
This commit is contained in:
bdistin 2018-01-15 18:24:19 -06:00 committed by Crawl
parent 3d32dea5e1
commit 4122db0275
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/util/Collection.js
View file

@ -192,12 +192,12 @@ class Collection extends Map {
for (const item of this.values()) {
if (item[propOrFn] === value) return item;
}
return null;
return undefined;
} else if (typeof propOrFn === 'function') {
for (const [key, val] of this) {
if (propOrFn(val, key, this)) return val;
}
return null;
return undefined;
} else {
throw new Error('First argument must be a property string or a function.');
}
@ -223,12 +223,12 @@ class Collection extends Map {
for (const [key, val] of this) {
if (val[propOrFn] === value) return key;
}
return null;
return undefined;
} else if (typeof propOrFn === 'function') {
for (const [key, val] of this) {
if (propOrFn(val, key, this)) return key;
}
return null;
return undefined;
} else {
throw new Error('First argument must be a property string or a function.');
}