dan/discord.js
1
0
Fork 0
mirror of https://github.com/danbulant/discord.js synced 2026-05-27 22:11:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(GuildMemberRoleStore): only update roles after successful request

Browse source 
Fixes #2381
This commit is contained in:
Pascal 2018-03-05 11:32:03 +01:00
parent 8b679913a4
commit 3f6a0e4de1
No known key found for this signature in database
GPG key ID: 8C8A2E338661B871
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/stores/GuildMemberRoleStore.js
View file

@ -29,11 +29,9 @@ class GuildMemberRoleStore extends DataStore {
if (roleOrRoles.includes(null)) {
return Promise.reject(new TypeError('INVALID_TYPE', 'roles',
'Array or Collection of Roles or Snowflakes', true));
} else {
for (const role of roleOrRoles) super.set(role.id, role);
}
return this.set(this, reason);
const newRoles = [...new Set(roleOrRoles.concat(this.array()))];
return this.set(newRoles, reason);
}
/**
@ -71,11 +69,9 @@ class GuildMemberRoleStore extends DataStore {
if (roleOrRoles.includes(null)) {
return Promise.reject(new TypeError('INVALID_TYPE', 'roles',
'Array or Collection of Roles or Snowflakes', true));
} else {
for (const role of roleOrRoles) super.remove(role);
}
return this.set(this, reason);
const newRoles = [...new Set(roleOrRoles.concat(this.array()))];
return this.set(newRoles, reason);
}
/**