dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 20:32:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
oxc/tasks/transform_conformance/snapshots/oxc.snap.md
Dunqing 06ccb51fae fix(transformer/async-to-generator): move parameters to the inner generator function when they could throw errors (#8500) 
The new implementation port from [esbuild](df815ac27b/internal/js_parser/js_parser_lower.go (L355-L467)), before from `Babel`.

Babel's transform implementation for the async method is incorrect because the async method should return a rejecting promise when it throws an error. Everything is good if the errors are thrown in the async method body, but the following case will throw an error in the parameters which causes the whole program crushed not a rejecting promise. So we should move the parameters to the inner generator function when the parameters could throw an error.

Input:
```js
class Cls {
  // ReferenceError: Cannot access 'b' before initialization
  async method(a = b, b = 0) {}
}
```

Before output
```js
class Cls {
  method(a = b, b = 0) {
    return babelHelpers.asyncToGenerator(function* () {})();
  }
}
```

After output:
```js
class Cls {
  method() {
     // ReferenceError: Cannot access 'b' before initialization
    return babelHelpers.asyncToGenerator(function* (a = b, b = 0) {}).apply(this, arguments);
  }
}
```

No override tests because Babel doesn't cover this case.
2025-01-16 00:18:05 +00:00

11 KiB
Raw Blame History

commit: acbc09a8

Passed: 132/154

All Passed:

  • babel-plugin-transform-class-static-block
  • babel-plugin-transform-private-methods
  • babel-plugin-transform-logical-assignment-operators
  • babel-plugin-transform-nullish-coalescing-operator
  • babel-plugin-transform-optional-catch-binding
  • babel-plugin-transform-async-generator-functions
  • babel-plugin-transform-object-rest-spread
  • babel-plugin-transform-async-to-generator
  • babel-plugin-transform-exponentiation-operator
  • babel-plugin-transform-arrow-functions
  • babel-preset-typescript
  • babel-plugin-transform-react-jsx-source
  • regexp

babel-plugin-transform-class-properties (20/27)

  • private-field-resolve-to-method/input.js x Output mismatch

  • private-field-resolve-to-method-in-computed-key/input.js x Output mismatch

  • static-block-this-and-class-name/input.js Symbol flags mismatch for "inner": after transform: SymbolId(8): SymbolFlags(BlockScopedVariable | Function) rebuilt : SymbolId(14): SymbolFlags(FunctionScopedVariable)

  • static-super-assignment-target/input.js x Output mismatch

  • static-super-tagged-template/input.js x Output mismatch

  • typescript/optional-call/input.ts Symbol reference IDs mismatch for "X": after transform: SymbolId(0): [ReferenceId(0), ReferenceId(2), ReferenceId(6), ReferenceId(11), ReferenceId(16)] rebuilt : SymbolId(0): [ReferenceId(0), ReferenceId(2), ReferenceId(8), ReferenceId(14)]

  • typescript/optional-member/input.ts Symbol reference IDs mismatch for "X": after transform: SymbolId(0): [ReferenceId(0), ReferenceId(2), ReferenceId(6), ReferenceId(9), ReferenceId(12)] rebuilt : SymbolId(0): [ReferenceId(0), ReferenceId(2), ReferenceId(6), ReferenceId(10)]

babel-plugin-transform-typescript (2/14)

  • class-property-definition/input.ts Unresolved references mismatch: after transform: ["const"] rebuilt : []

  • computed-constant-value/input.ts Bindings mismatch: after transform: ScopeId(1): ["A", "a", "b", "c", "d", "e"] rebuilt : ScopeId(1): ["A"] Scope flags mismatch: after transform: ScopeId(1): ScopeFlags(0x0) rebuilt : ScopeId(1): ScopeFlags(Function) Bindings mismatch: after transform: ScopeId(2): ["B", "a", "b", "c", "d", "e"] rebuilt : ScopeId(2): ["B"] Scope flags mismatch: after transform: ScopeId(2): ScopeFlags(0x0) rebuilt : ScopeId(2): ScopeFlags(Function) Bindings mismatch: after transform: ScopeId(3): ["C", "a", "b", "c"] rebuilt : ScopeId(3): ["C"] Scope flags mismatch: after transform: ScopeId(3): ScopeFlags(0x0) rebuilt : ScopeId(3): ScopeFlags(Function) Bindings mismatch: after transform: ScopeId(4): ["D", "a", "b", "c"] rebuilt : ScopeId(4): ["D"] Scope flags mismatch: after transform: ScopeId(4): ScopeFlags(0x0) rebuilt : ScopeId(4): ScopeFlags(Function) Symbol flags mismatch for "A": after transform: SymbolId(0): SymbolFlags(RegularEnum) rebuilt : SymbolId(0): SymbolFlags(FunctionScopedVariable) Symbol flags mismatch for "B": after transform: SymbolId(6): SymbolFlags(RegularEnum) rebuilt : SymbolId(2): SymbolFlags(FunctionScopedVariable) Symbol flags mismatch for "C": after transform: SymbolId(12): SymbolFlags(RegularEnum) rebuilt : SymbolId(4): SymbolFlags(FunctionScopedVariable) Symbol flags mismatch for "D": after transform: SymbolId(16): SymbolFlags(RegularEnum) rebuilt : SymbolId(6): SymbolFlags(FunctionScopedVariable) Unresolved references mismatch: after transform: ["Infinity", "NaN"] rebuilt : ["Infinity"] Unresolved reference IDs mismatch for "Infinity": after transform: [ReferenceId(0), ReferenceId(1), ReferenceId(2), ReferenceId(3), ReferenceId(8), ReferenceId(11), ReferenceId(14), ReferenceId(18)] rebuilt : [ReferenceId(2), ReferenceId(5), ReferenceId(8), ReferenceId(12)]

  • elimination-declare/input.ts Bindings mismatch: after transform: ScopeId(0): ["A", "ReactiveMarkerSymbol"] rebuilt : ScopeId(0): [] Scope children mismatch: after transform: ScopeId(0): [ScopeId(1)] rebuilt : ScopeId(0): []

  • enum-member-reference/input.ts Missing ReferenceId: "Foo" Bindings mismatch: after transform: ScopeId(1): ["Foo", "a", "b", "c"] rebuilt : ScopeId(1): ["Foo"] Scope flags mismatch: after transform: ScopeId(1): ScopeFlags(0x0) rebuilt : ScopeId(1): ScopeFlags(Function) Symbol flags mismatch for "Foo": after transform: SymbolId(1): SymbolFlags(RegularEnum) rebuilt : SymbolId(1): SymbolFlags(FunctionScopedVariable) Symbol reference IDs mismatch for "Foo": after transform: SymbolId(5): [ReferenceId(3), ReferenceId(4), ReferenceId(5), ReferenceId(6), ReferenceId(7), ReferenceId(8), ReferenceId(9)] rebuilt : SymbolId(2): [ReferenceId(0), ReferenceId(1), ReferenceId(2), ReferenceId(3), ReferenceId(4), ReferenceId(5), ReferenceId(6), ReferenceId(8)]

  • export-elimination/input.ts Bindings mismatch: after transform: ScopeId(0): ["Bar", "Foo", "Func", "Im", "Name", "Ok"] rebuilt : ScopeId(0): ["Bar", "Foo", "Func", "Im", "Name", "Ok", "T"] Scope children mismatch: after transform: ScopeId(0): [ScopeId(1), ScopeId(2), ScopeId(3), ScopeId(4), ScopeId(5), ScopeId(6), ScopeId(7)] rebuilt : ScopeId(0): [ScopeId(1), ScopeId(2), ScopeId(3), ScopeId(4)] Scope flags mismatch: after transform: ScopeId(5): ScopeFlags(StrictMode | Function) rebuilt : ScopeId(3): ScopeFlags(Function) Symbol flags mismatch for "Name": after transform: SymbolId(7): SymbolFlags(NameSpaceModule | ValueModule) rebuilt : SymbolId(5): SymbolFlags(BlockScopedVariable) Symbol span mismatch for "Name": after transform: SymbolId(7): Span { start: 116, end: 120 } rebuilt : SymbolId(5): Span { start: 0, end: 0 } Symbol flags mismatch for "T": after transform: SymbolId(9): SymbolFlags(FunctionScopedVariable | TypeAlias) rebuilt : SymbolId(8): SymbolFlags(FunctionScopedVariable) Symbol span mismatch for "T": after transform: SymbolId(9): Span { start: 205, end: 206 } rebuilt : SymbolId(8): Span { start: 226, end: 227 } Symbol reference IDs mismatch for "T": after transform: SymbolId(9): [ReferenceId(8), ReferenceId(9)] rebuilt : SymbolId(8): [ReferenceId(9)] Symbol redeclarations mismatch for "T": after transform: SymbolId(9): [Span { start: 226, end: 227 }] rebuilt : SymbolId(8): []

  • exports/type-and-non-type/input.ts Scope children mismatch: after transform: ScopeId(0): [ScopeId(1)] rebuilt : ScopeId(0): []

  • namespace/export-import-=/input.ts Scope flags mismatch: after transform: ScopeId(1): ScopeFlags(StrictMode | Function) rebuilt : ScopeId(1): ScopeFlags(Function) Symbol flags mismatch for "N1": after transform: SymbolId(1): SymbolFlags(NameSpaceModule) rebuilt : SymbolId(1): SymbolFlags(BlockScopedVariable) Symbol span mismatch for "N1": after transform: SymbolId(1): Span { start: 31, end: 33 } rebuilt : SymbolId(1): Span { start: 0, end: 0 }

  • namespace/import-=/input.ts Bindings mismatch: after transform: ScopeId(1): ["V", "X", "_N"] rebuilt : ScopeId(1): ["V", "_N"] Scope flags mismatch: after transform: ScopeId(1): ScopeFlags(StrictMode | Function) rebuilt : ScopeId(1): ScopeFlags(Function) Scope flags mismatch: after transform: ScopeId(2): ScopeFlags(StrictMode | Function) rebuilt : ScopeId(2): ScopeFlags(Function) Symbol reference IDs mismatch for "A": after transform: SymbolId(0): [ReferenceId(0), ReferenceId(1)] rebuilt : SymbolId(0): [ReferenceId(2)] Symbol flags mismatch for "N1": after transform: SymbolId(1): SymbolFlags(NameSpaceModule | ValueModule) rebuilt : SymbolId(1): SymbolFlags(BlockScopedVariable) Symbol span mismatch for "N1": after transform: SymbolId(1): Span { start: 31, end: 33 } rebuilt : SymbolId(1): Span { start: 0, end: 0 } Symbol flags mismatch for "N2": after transform: SymbolId(4): SymbolFlags(NameSpaceModule | ValueModule) rebuilt : SymbolId(4): SymbolFlags(BlockScopedVariable) Symbol span mismatch for "N2": after transform: SymbolId(4): Span { start: 130, end: 132 } rebuilt : SymbolId(4): Span { start: 0, end: 0 }

  • namespace/preserve-import-=/input.ts Scope flags mismatch: after transform: ScopeId(1): ScopeFlags(StrictMode | Function) rebuilt : ScopeId(1): ScopeFlags(Function) Scope flags mismatch: after transform: ScopeId(2): ScopeFlags(StrictMode | Function) rebuilt : ScopeId(2): ScopeFlags(Function) Symbol flags mismatch for "N1": after transform: SymbolId(1): SymbolFlags(NameSpaceModule | ValueModule) rebuilt : SymbolId(1): SymbolFlags(BlockScopedVariable) Symbol span mismatch for "N1": after transform: SymbolId(1): Span { start: 34, end: 36 } rebuilt : SymbolId(1): Span { start: 0, end: 0 } Symbol flags mismatch for "N2": after transform: SymbolId(4): SymbolFlags(NameSpaceModule | ValueModule) rebuilt : SymbolId(5): SymbolFlags(BlockScopedVariable) Symbol span mismatch for "N2": after transform: SymbolId(4): Span { start: 145, end: 147 } rebuilt : SymbolId(5): Span { start: 0, end: 0 } Symbol reference IDs mismatch for "Foo": after transform: SymbolId(5): [ReferenceId(2)] rebuilt : SymbolId(7): []

  • preserve-import-=/input.js Symbol reference IDs mismatch for "Foo": after transform: SymbolId(1): [ReferenceId(1)] rebuilt : SymbolId(1): []

  • redeclarations/input.ts Bindings mismatch: after transform: ScopeId(0): ["A"] rebuilt : ScopeId(0): ["A", "B", "T"] Scope children mismatch: after transform: ScopeId(0): [ScopeId(1), ScopeId(2)] rebuilt : ScopeId(0): [] Symbol flags mismatch for "A": after transform: SymbolId(0): SymbolFlags(BlockScopedVariable | ConstVariable | Import) rebuilt : SymbolId(0): SymbolFlags(BlockScopedVariable | ConstVariable) Symbol span mismatch for "A": after transform: SymbolId(0): Span { start: 57, end: 58 } rebuilt : SymbolId(0): Span { start: 79, end: 83 } Symbol reference IDs mismatch for "A": after transform: SymbolId(0): [ReferenceId(0), ReferenceId(1)] rebuilt : SymbolId(0): [ReferenceId(0)] Symbol redeclarations mismatch for "A": after transform: SymbolId(0): [Span { start: 79, end: 83 }] rebuilt : SymbolId(0): [] Symbol flags mismatch for "T": after transform: SymbolId(1): SymbolFlags(Import | TypeAlias) rebuilt : SymbolId(1): SymbolFlags(Import) Symbol redeclarations mismatch for "T": after transform: SymbolId(1): [Span { start: 170, end: 171 }] rebuilt : SymbolId(1): [] Symbol flags mismatch for "B": after transform: SymbolId(2): SymbolFlags(BlockScopedVariable | ConstVariable | Import | TypeAlias) rebuilt : SymbolId(2): SymbolFlags(BlockScopedVariable | ConstVariable) Symbol span mismatch for "B": after transform: SymbolId(2): Span { start: 267, end: 268 } rebuilt : SymbolId(2): Span { start: 289, end: 293 } Symbol reference IDs mismatch for "B": after transform: SymbolId(2): [ReferenceId(3), ReferenceId(4)] rebuilt : SymbolId(2): [ReferenceId(2)] Symbol redeclarations mismatch for "B": after transform: SymbolId(2): [Span { start: 289, end: 293 }, Span { start: 304, end: 305 }] rebuilt : SymbolId(2): []

  • ts-declaration-empty-output/input.d.ts x Output mismatch

babel-plugin-transform-react-jsx (34/37)

  • refresh/does-not-transform-it-because-it-is-not-used-in-the-AST/input.jsx x Output mismatch

  • refresh/react-refresh/includes-custom-hooks-into-the-signatures-when-commonjs-target-is-used/input.jsx x Output mismatch

  • refresh/react-refresh/supports-typescript-namespace-syntax/input.tsx x Output mismatch