dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 20:32:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(ast): update scope attrs (#3494)

Browse source 
Update scope attrs used by `oxc_traverse` codegen on `MethodDefinition` and `Function` types. These attrs are currently ignored by the codegen anyway, so causes no change in generated code, but bringing them up to date in preparation for #3392.
This commit is contained in:
overlookmotel 2024-05-31 17:58:01 +00:00
parent 3967a15b60
commit ff7e8c7448
1 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
crates/oxc_ast/src/ast/js.rs
View file

@ -2288,11 +2288,8 @@ pub struct BindingRestElement<'a> {
/// Function Definitions /// Function Definitions
#[visited_node( #[visited_node(
// TODO: `ScopeFlags::Function` is not correct if this is a `MethodDefinition`
scope(ScopeFlags::Function), scope(ScopeFlags::Function),
// Don't create scope if this is a method - `MethodDefinition` already created one.
// `ctx.ancestor(2).unwrap()` not `ctx.parent()` because this code is inserted
// into `walk_function` *after* `Function` is added to stack.
scope_if(!matches!(ctx.ancestor(2).unwrap(), Ancestor::MethodDefinitionValue(_))),
strict_if(self.body.as_ref().is_some_and(|body| body.has_use_strict_directive())) strict_if(self.body.as_ref().is_some_and(|body| body.has_use_strict_directive()))
)] )]
#[derive(Debug)] #[derive(Debug)]
@ -2784,11 +2781,7 @@ impl<'a> ClassElement<'a> {
} }
} }
#[visited_node( #[visited_node]
scope(self.kind.scope_flags()),
strict_if(self.value.is_strict()),
enter_scope_before(value)
)]
#[derive(Debug, Hash)] #[derive(Debug, Hash)]
#[cfg_attr(feature = "serialize", derive(Serialize, Tsify))] #[cfg_attr(feature = "serialize", derive(Serialize, Tsify))]
#[cfg_attr(feature = "serialize", serde(rename_all = "camelCase"))] #[cfg_attr(feature = "serialize", serde(rename_all = "camelCase"))]