From ff7e8c7448b3c781166b4634b06491b37fdc8535 Mon Sep 17 00:00:00 2001
From: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Date: Fri, 31 May 2024 17:58:01 +0000
Subject: [PATCH] refactor(ast): update scope attrs (#3494)

Update scope attrs used by `oxc_traverse` codegen on `MethodDefinition` and `Function` types. These attrs are currently ignored by the codegen anyway, so causes no change in generated code, but bringing them up to date in preparation for #3392.
---
 crates/oxc_ast/src/ast/js.rs | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/crates/oxc_ast/src/ast/js.rs b/crates/oxc_ast/src/ast/js.rs
index 012b1c51c..407cae74f 100644
--- a/crates/oxc_ast/src/ast/js.rs
+++ b/crates/oxc_ast/src/ast/js.rs
@@ -2288,11 +2288,8 @@ pub struct BindingRestElement<'a> {
 
 /// Function Definitions
 #[visited_node(
+    // TODO: `ScopeFlags::Function` is not correct if this is a `MethodDefinition`
     scope(ScopeFlags::Function),
-    // Don't create scope if this is a method - `MethodDefinition` already created one.
-    // `ctx.ancestor(2).unwrap()` not `ctx.parent()` because this code is inserted
-    // into `walk_function` *after* `Function` is added to stack.
-    scope_if(!matches!(ctx.ancestor(2).unwrap(), Ancestor::MethodDefinitionValue(_))),
     strict_if(self.body.as_ref().is_some_and(|body| body.has_use_strict_directive()))
 )]
 #[derive(Debug)]
@@ -2784,11 +2781,7 @@ impl<'a> ClassElement<'a> {
     }
 }
 
-#[visited_node(
-    scope(self.kind.scope_flags()),
-    strict_if(self.value.is_strict()),
-    enter_scope_before(value)
-)]
+#[visited_node]
 #[derive(Debug, Hash)]
 #[cfg_attr(feature = "serialize", derive(Serialize, Tsify))]
 #[cfg_attr(feature = "serialize", serde(rename_all = "camelCase"))]