dan/node-x11
1
0
Fork 0
mirror of https://github.com/danbulant/node-x11 synced 2026-05-24 12:35:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

TODO comment: values-set list values are actually of variable size, need to refactor

Browse source
This commit is contained in:
Andrey Sidorov 2011-07-22 09:41:14 +10:00
parent d694000bd0
commit 4ac7010e45
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/x11/corereqs.js
View file

@ -123,7 +123,7 @@ module.exports = {
// TODO: the code is a little bit mess // TODO: the code is a little bit mess
// additional values need to be packed in the following way: // additional values need to be packed in the following way:
// bitmask (bytes #24 to #31 in the packet) - 32 bit indicating what adittional arguments we supply // bitmask (bytes #24 to #31 in the packet) - 32 bit indicating what adittional arguments we supply
// values list (bytes #32 .. #32+4*num_values) in order of corresponding bits // values list (bytes #32 .. #32+4*num_values) in order of corresponding bits TODO: it's actually not 4*num. Some values are 4b ytes, some - 1 byte
// TODO: replace with packValueMask // TODO: replace with packValueMask
@ -137,7 +137,7 @@ module.exports = {
} }
masksList.push(valueBit); masksList.push(valueBit);
bitmask |= valueBit; bitmask |= valueBit;
format += 'L'; format += 'L'; // TODO: not all values are 4 bytes CARD32!!!
} }
// values packed in order of corresponding bit // values packed in order of corresponding bit
masksList.sort(); masksList.sort();