From 4ac7010e45e983fca455eecc4d21d3881bc21ee3 Mon Sep 17 00:00:00 2001
From: Andrey Sidorov <sidorares@yandex.ru>
Date: Fri, 22 Jul 2011 09:41:14 +1000
Subject: [PATCH] TODO comment: values-set list values are actually of variable
 size, need to refactor

---
 lib/x11/corereqs.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/x11/corereqs.js b/lib/x11/corereqs.js
index e0f0842..2840903 100644
--- a/lib/x11/corereqs.js
+++ b/lib/x11/corereqs.js
@@ -123,7 +123,7 @@ module.exports = {
            // TODO: the code is a little bit mess
            // additional values need to be packed in the following way:
            // bitmask (bytes #24 to #31 in the packet) - 32 bit indicating what adittional arguments we supply
-           // values list (bytes #32 .. #32+4*num_values) in order of corresponding bits
+           // values list (bytes #32 .. #32+4*num_values) in order of corresponding bits TODO: it's actually not 4*num. Some values are 4b ytes, some - 1 byte
          
 
            // TODO: replace with packValueMask
@@ -137,7 +137,7 @@ module.exports = {
                }
                masksList.push(valueBit);
                bitmask |= valueBit;
-               format += 'L';
+               format += 'L'; // TODO: not all values are 4 bytes CARD32!!!
            }
            // values packed in order of corresponding bit
            masksList.sort();