dan/gpui-component
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: Avoid cx.prevent_default when ListItem or other click (#381)

Browse source
This commit is contained in:
Jason Lee 2024-10-29 16:54:08 +08:00 committed by GitHub
parent db041fea88
commit 0b0fc61c2f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
crates/ui/src/link.rs
View file

@ -69,7 +69,6 @@ impl RenderOnce for Link {
.text_decoration_1() .text_decoration_1()
}) })
.on_mouse_down(MouseButton::Left, |_, cx| { .on_mouse_down(MouseButton::Left, |_, cx| {
cx.prevent_default();
cx.stop_propagation(); cx.stop_propagation();
}) })
.on_click({ .on_click({

1
crates/ui/src/list/list.rs
View file

@ -343,7 +343,6 @@ where
.on_mouse_down( .on_mouse_down(
MouseButton::Left, MouseButton::Left,
cx.listener(move |this, _, cx| { cx.listener(move |this, _, cx| {
cx.stop_propagation();
this.right_clicked_index = None; this.right_clicked_index = None;
this.selected_index = Some(ix); this.selected_index = Some(ix);
this.on_action_confirm(&Confirm, cx); this.on_action_confirm(&Confirm, cx);

1
crates/ui/src/list/list_item.rs
View file

@ -128,7 +128,6 @@ impl RenderOnce for ListItem {
this.cursor_pointer() this.cursor_pointer()
.on_mouse_down(MouseButton::Left, move |_, cx| { .on_mouse_down(MouseButton::Left, move |_, cx| {
cx.stop_propagation(); cx.stop_propagation();
cx.prevent_default();
}) })
.on_click(on_click) .on_click(on_click)
} else { } else {