From 0b0fc61c2fb883d84cecd3ec50e1fdbb5ace6438 Mon Sep 17 00:00:00 2001 From: Jason Lee Date: Tue, 29 Oct 2024 16:54:08 +0800 Subject: [PATCH] chore: Avoid cx.prevent_default when ListItem or other click (#381) --- crates/ui/src/link.rs | 1 - crates/ui/src/list/list.rs | 1 - crates/ui/src/list/list_item.rs | 1 - 3 files changed, 3 deletions(-) diff --git a/crates/ui/src/link.rs b/crates/ui/src/link.rs index 793c25ef..fcd1bc3f 100644 --- a/crates/ui/src/link.rs +++ b/crates/ui/src/link.rs @@ -69,7 +69,6 @@ impl RenderOnce for Link { .text_decoration_1() }) .on_mouse_down(MouseButton::Left, |_, cx| { - cx.prevent_default(); cx.stop_propagation(); }) .on_click({ diff --git a/crates/ui/src/list/list.rs b/crates/ui/src/list/list.rs index 586daa00..fd6d9652 100644 --- a/crates/ui/src/list/list.rs +++ b/crates/ui/src/list/list.rs @@ -343,7 +343,6 @@ where .on_mouse_down( MouseButton::Left, cx.listener(move |this, _, cx| { - cx.stop_propagation(); this.right_clicked_index = None; this.selected_index = Some(ix); this.on_action_confirm(&Confirm, cx); diff --git a/crates/ui/src/list/list_item.rs b/crates/ui/src/list/list_item.rs index 443907d9..a35a291a 100644 --- a/crates/ui/src/list/list_item.rs +++ b/crates/ui/src/list/list_item.rs @@ -128,7 +128,6 @@ impl RenderOnce for ListItem { this.cursor_pointer() .on_mouse_down(MouseButton::Left, move |_, cx| { cx.stop_propagation(); - cx.prevent_default(); }) .on_click(on_click) } else {