From 1183e25413f4e58cd75343cf4ce9a496c3433761 Mon Sep 17 00:00:00 2001 From: Luke Page Date: Mon, 3 Aug 2015 23:08:50 +0100 Subject: [PATCH] lint --- .eslintrc | 182 +++++++++++++++++++++++++++++++++++++++++++++++ lib/bitmapper.js | 31 ++++---- package.json | 4 +- 3 files changed, 201 insertions(+), 16 deletions(-) create mode 100644 .eslintrc diff --git a/.eslintrc b/.eslintrc new file mode 100644 index 0000000..31c8e16 --- /dev/null +++ b/.eslintrc @@ -0,0 +1,182 @@ +{ + "ecmaFeatures": {}, + "rules": { + "no-alert": 1, + "no-array-constructor": 1, + "no-bitwise": 0, + "no-caller": 2, + "no-catch-shadow": 1, + "no-class-assign": 2, + "no-cond-assign": 2, + "no-console": 2, + "no-const-assign": 2, + "no-constant-condition": 2, + "no-continue": 0, + "no-control-regex": 2, + "no-debugger": 2, + "no-delete-var": 2, + "no-div-regex": 0, + "no-dupe-keys": 2, + "no-dupe-args": 2, + "no-duplicate-case": 2, + "no-else-return": 1, + "no-empty": 2, + "no-empty-character-class": 2, + "no-empty-label": 1, + "no-eq-null": 1, + "no-eval": 2, + "no-ex-assign": 2, + "no-extend-native": 0, + "no-extra-bind": 1, + "no-extra-boolean-cast": 2, + "no-extra-parens": 0, + "no-extra-semi": 2, + "no-fallthrough": 2, + "no-floating-decimal": 0, + "no-func-assign": 2, + "no-implicit-coercion": 0, + "no-implied-eval": 1, + "no-inline-comments": 1, + "no-inner-declarations": [2, "functions"], + "no-invalid-regexp": 2, + "no-invalid-this": 1, + "no-irregular-whitespace": 2, + "no-iterator": 1, + "no-label-var": 1, + "no-labels": 1, + "no-lone-blocks": 1, + "no-lonely-if": 0, + "no-loop-func": 1, + "no-mixed-requires": [0, false], + "no-mixed-spaces-and-tabs": [2, false], + "linebreak-style": [0, "unix"], + "no-multi-spaces": 1, + "no-multi-str": 0, + "no-multiple-empty-lines": [0, {"max": 2}], + "no-native-reassign": 0, + "no-negated-in-lhs": 2, + "no-nested-ternary": 0, + "no-new": 0, + "no-new-func": 0, + "no-new-object": 0, + "no-new-require": 0, + "no-new-wrappers": 0, + "no-obj-calls": 2, + "no-octal": 2, + "no-octal-escape": 0, + "no-param-reassign": 0, + "no-path-concat": 0, + "no-plusplus": 0, + "no-process-env": 0, + "no-process-exit": 0, + "no-proto": 0, + "no-redeclare": 2, + "no-regex-spaces": 2, + "no-restricted-modules": 0, + "no-return-assign": 0, + "no-script-url": 0, + "no-self-compare": 0, + "no-sequences": 0, + "no-shadow": 1, + "no-shadow-restricted-names": 0, + "no-spaced-func": 1, + "no-sparse-arrays": 2, + "no-sync": 0, + "no-ternary": 0, + "no-trailing-spaces": 1, + "no-this-before-super": 0, + "no-throw-literal": 0, + "no-undef": 2, + "no-undef-init": 0, + "no-undefined": 0, + "no-unexpected-multiline": 0, + "no-underscore-dangle": 0, + "no-unneeded-ternary": 0, + "no-unreachable": 2, + "no-unused-expressions": 1, + "no-unused-vars": [2, {"vars": "all", "args": "after-used"}], + "no-use-before-define": 2, + "no-useless-call": 2, + "no-void": 0, + "no-var": 0, + "no-warning-comments": [0, { "terms": ["todo", "fixme", "xxx"], "location": "start" }], + "no-with": 0, + + "array-bracket-spacing": [0, "never"], + "arrow-parens": 0, + "arrow-spacing": 0, + "accessor-pairs": 0, + "block-scoped-var": 0, + "brace-style": [0, "1tbs"], + "callback-return": 0, + "camelcase": 0, + "comma-dangle": [2, "never"], + "comma-spacing": 0, + "comma-style": 0, + "complexity": [0, 11], + "computed-property-spacing": [0, "never"], + "consistent-return": 0, + "consistent-this": [0, "that"], + "constructor-super": 0, + "curly": [0, "all"], + "default-case": 0, + "dot-location": 0, + "dot-notation": [0, { "allowKeywords": true }], + "eol-last": 0, + "eqeqeq": 0, + "func-names": 0, + "func-style": [0, "declaration"], + "generator-star-spacing": 0, + "guard-for-in": 0, + "handle-callback-err": 0, + "id-length": 0, + "indent": 0, + "init-declarations": 0, + "key-spacing": [0, { "beforeColon": false, "afterColon": true }], + "lines-around-comment": 0, + "max-depth": [0, 4], + "max-len": [0, 80, 4], + "max-nested-callbacks": [0, 2], + "max-params": [0, 3], + "max-statements": [0, 10], + "new-cap": 0, + "new-parens": 0, + "newline-after-var": 0, + "object-curly-spacing": [0, "never"], + "object-shorthand": 0, + "one-var": 0, + "operator-assignment": [0, "always"], + "operator-linebreak": 0, + "padded-blocks": 0, + "prefer-const": 0, + "prefer-spread": 0, + "prefer-reflect": 0, + "quote-props": 0, + "quotes": [0, "double"], + "radix": 0, + "id-match": 0, + "require-yield": 0, + "semi": 0, + "semi-spacing": [0, {"before": false, "after": true}], + "sort-vars": 0, + "space-after-keywords": [0, "always"], + "space-before-blocks": [0, "always"], + "space-before-function-paren": [0, "always"], + "space-in-parens": [0, "never"], + "space-infix-ops": 0, + "space-return-throw-case": 0, + "space-unary-ops": [0, { "words": true, "nonwords": false }], + "spaced-comment": 0, + "strict": [2, "global"], + "use-isnan": 2, + "valid-jsdoc": 0, + "valid-typeof": 2, + "vars-on-top": 0, + "wrap-iife": 0, + "wrap-regex": 0, + "yoda": [0, "never"] + }, + "env": { + "node": true + } +} \ No newline at end of file diff --git a/lib/bitmapper.js b/lib/bitmapper.js index a55c715..0c45f0d 100644 --- a/lib/bitmapper.js +++ b/lib/bitmapper.js @@ -10,36 +10,37 @@ function bitRetriever(data, depth) { } var byte = data[i]; i++; + var byte8, byte7, byte6, byte5, byte4, byte3, byte2, byte1 switch(depth) { default: throw new Error("unrecognised depth"); break; case 16: - var byte2 = data[i]; + byte2 = data[i]; i++; leftOver.push(((byte << 8) + byte2)); break; case 4: - var byte2 = byte & 0x0f; - var byte1 = byte >> 4; + byte2 = byte & 0x0f; + byte1 = byte >> 4; leftOver.push(byte1, byte2); break; case 2: - var byte4 = byte & 3; - var byte3 = byte >> 2 & 3; - var byte2 = byte >> 4 & 3; - var byte1 = byte >> 6 & 3; + byte4 = byte & 3; + byte3 = byte >> 2 & 3; + byte2 = byte >> 4 & 3; + byte1 = byte >> 6 & 3; leftOver.push(byte1, byte2, byte3, byte4); break; case 1: - var byte8 = byte & 1; - var byte7 = byte >> 1 & 1; - var byte6 = byte >> 2 & 1; - var byte5 = byte >> 3 & 1; - var byte4 = byte >> 4 & 1; - var byte3 = byte >> 5 & 1; - var byte2 = byte >> 6 & 1; - var byte1 = byte >> 7 & 1; + byte8 = byte & 1; + byte7 = byte >> 1 & 1; + byte6 = byte >> 2 & 1; + byte5 = byte >> 3 & 1; + byte4 = byte >> 4 & 1; + byte3 = byte >> 5 & 1; + byte2 = byte >> 6 & 1; + byte1 = byte >> 7 & 1; leftOver.push(byte1, byte2, byte3, byte4, byte5, byte6, byte7, byte8); break; } diff --git a/package.json b/package.json index a176d7f..665b8ee 100644 --- a/package.json +++ b/package.json @@ -34,7 +34,8 @@ "scripts": { "coverage": "istanbul -- cover ./test nolarge", "coverage-report": "npm run coverage && istanbul report html", - "test": "node test" + "test": "node test", + "lint": "eslint lib" }, "repository": { "type": "git", @@ -47,6 +48,7 @@ "devDependencies": { "connect": "^3.4.0", "coveralls": "^2.11.3", + "eslint": "^1.0.0", "istanbul": "^0.3.17", "phantomjs": "^1.9.17", "serve-static": "^1.10.0"