dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
oxc/crates/oxc_prettier
History
branchseer f159f60084
Make ast types covariant over the allocator lifetime. (#2943) 
## Why

Due to the usage of `&'alloc mut T` in `oxc_allocator::Box`, and
`bumpalo::collections::Vec` in `oxc_allocator::Vec`, ast types are
currently invariant over their allocator lifetime `'a`. This prevents
`ouroboros` from generating `borrow_*` on ast type fields, leading to
the unfriendly `with_*` api:
c250b288ef/crates/oxc_parser/examples/multi-thread.rs (L82-L84)

## How

- For `oxc_allocator::Vec`, switch to `allocator_api2::vec::Vec`, which
has a covariant relationship with the allocator lifetime.
- For `oxc_allocator::Box`, use `std::ptr::NonNull` which is
specifically designed to be covariant. I don't use
`allocator_api2::boxed::Box` because it holds the allocator for
dropping, so the size is bigger.

## Downside

Now that `oxc_allocator::Box` uses the unsafe `NonNull`. It has to be a
private field to be safe. This make it impossible to do `Box(....)`
pattern matching.
2024-04-12 18:12:18 +08:00
..
examples refactor(ast): refactor Trivias API - have less noise around it (#2692) 2024-03-12 20:16:36 +08:00
src Make ast types covariant over the allocator lifetime. (#2943) 2024-04-12 18:12:18 +08:00
Cargo.toml feat(prettier): add --no-semi to prettier example (#1588) 2023-11-29 23:33:35 +08:00
README.md Update README 2024-01-19 18:39:07 +08:00

README.md

Getting started

Create a test.js and run the example just example prettier from crates/oxc_prettier/examples/prettier.rs, follow the code structure and read the references documented at the top of the files.

Tasks