oxc/crates/oxc_parser/examples
overlookmotel 2c7bb9f6c8 refactor(ast): pass final ScopeFlags into visit_function (#4283)
We have a strange workaround for `visit_function` where we pass in `ScopeFlags`, to support creating the scope inside `Function`, but setting different flags for `MethodDefinition`s.

Previously `visit_function` took `Option<ScopeFlags>` and then did `flags.unwrap_or(ScopeFlags::empty()) | ScopeFlags::Function` to it. Personally, I found this confusing. When I was looking at `MethodDefinition`, I was wondering "It's a function, why doesn't it set Function flag too?"

This changes makes it more explicit and clear what `ScopeFlags` everything has.
2024-07-16 07:22:07 +00:00
..
multi-thread.rs chore: remove unsafe_code = "warn" rust lint 2024-07-15 10:39:08 +08:00
parser.rs refactor(ast)!: store span details inside comment struct (#4132) 2024-07-09 23:23:43 +08:00
visitor.rs refactor(ast): pass final ScopeFlags into visit_function (#4283) 2024-07-16 07:22:07 +00:00