mirror of
https://github.com/danbulant/oxc
synced 2026-05-22 13:48:55 +00:00
0d0bb17ad9
In this PR, most of the async functions have transformed correctly. But the async arrow functions don't fully transform correctly yet, it is related to we need to transform the arrow function to the generator function. For example:
Input:
```js
function declaration() {
const asy = async () => {
console.log(this.name)
}
}
```
Output:
```js
function declaration() {
const asy = babelHelpers.asyncToGenerator(function* () {
console.log(this.name);
});
}
```
Expected Output:
```js
function declaration() {
var _this = this;
const asy = /*#__PURE__*/function () {
var _ref = babelHelpers.asyncToGenerator(function* () {
console.log(_this.name);
});
return function asy() {
return _ref.apply(this, arguments);
};
}();
}
```
From the expected output, we haven't handled `this` correctly, which means even if the `arrow-function` plugin doesn't enable, we still need to handle this correctly as the `arrow-function` plugin does, and further question if `arrow-function` plugin is enabled, how to avoid these making conflict?
I thought we may move out the implementation of `arrow-function` and as a common helper, this way every plugin can handle this well
|
||
|---|---|---|
| .. | ||
| babel-plugin-transform-arrow-functions/test/fixtures | ||
| babel-plugin-transform-async-to-generator/test/fixtures | ||
| babel-plugin-transform-class-static-block/test/fixtures | ||
| babel-plugin-transform-exponentiation-operator/test/fixtures | ||
| babel-plugin-transform-nullish-coalescing-operator/test/fixtures | ||
| babel-plugin-transform-optional-catch-binding/test/fixtures | ||
| babel-plugin-transform-react-jsx/test/fixtures | ||
| babel-plugin-transform-react-jsx-source/test/fixtures/react-source | ||
| babel-plugin-transform-typescript/test/fixtures | ||
| babel-preset-typescript/test/fixtures/removeImportExtensions | ||
| regexp/test/fixtures | ||