mirror of
https://github.com/danbulant/oxc
synced 2026-05-25 04:42:10 +00:00
f8e1907c4f
Preparation for #6141
`oxc_regular_expression` can already parse and validate both `/regexp-literal/` and `new RegExp("string-literal")`.
But one thing that is not well-supported was reporting `Span` for the `RegExp("string-literal-with-\\escape")` case.
For example, these two cases produce the same `RegExp` instances in JavaScript:
- `/\d+/`
- `new RegExp("\\d+")`
For now, mainly in `oxc_linter`, the latter case is parsed with `oxc_parser` -> `ast::literal::StringLiteral` AST node -> `value` property.
At this point, escape sequences are resolved(!), `oxc_regular_expression` can handle aligned `&str` as an argument without any problem in both cases.
However, in terms of `Span` representation, these cases should be handled differently because of the `\\` in string literals...
As a result, the parsed AST's `Span` for `new RegExp("string-literal")` is not accurate if it contains escape sequences.
e.g. a01a5dfdaf/crates/oxc_linter/src/snapshots/no_invalid_regexp.snap (L118-L122)
Each time the `\` appears, the subsequent position is shifted. `_` should be placed under `*` in this case.
So... to resolve this issue, we need to implement `string_literal_parser` first, and use them as reading units of `oxc_regular_expression`.
7 lines
270 B
Rust
7 lines
270 B
Rust
#[derive(Clone, Copy, Debug, Default)]
|
|
pub struct Options {
|
|
/// Used to adjust `Span` positions to fit the global source code.
|
|
pub pattern_span_offset: u32,
|
|
/// Used to adjust `Span` positions to fit the global source code.
|
|
pub flags_span_offset: u32,
|
|
}
|