mirror of
https://github.com/danbulant/oxc
synced 2026-05-24 12:21:58 +00:00
8f2a566f9f
Adds tests for rule documentation by 1. Compiling doc markdown into HTML, which ensures docs use valid markdown syntax 2. Converts the generated HTML into JSX and parses the results with the parser, ensuring the generated HTML is valid Has the added benefit of adding a lot of JSX test cases to the parser. I've also fixed all violations for these tests in this PR.
72 lines
2.5 KiB
Rust
72 lines
2.5 KiB
Rust
use oxc_diagnostics::OxcDiagnostic;
|
|
use oxc_macros::declare_oxc_lint;
|
|
use oxc_semantic::SymbolId;
|
|
use oxc_span::Span;
|
|
|
|
use crate::{context::LintContext, rule::Rule};
|
|
|
|
fn no_ex_assign_diagnostic(span0: Span) -> OxcDiagnostic {
|
|
OxcDiagnostic::warn("Do not assign to the exception parameter.").with_help("If a catch clause in a try statement accidentally (or purposely) assigns another value to the exception parameter, it is impossible to refer to the error from that point on. Since there is no arguments object to offer alternative access to this data, assignment of the parameter is absolutely destructive.").with_label(span0)
|
|
}
|
|
|
|
#[derive(Debug, Default, Clone)]
|
|
pub struct NoExAssign;
|
|
|
|
declare_oxc_lint!(
|
|
/// ### What it does
|
|
/// Disallow reassigning exceptions in catch clauses
|
|
///
|
|
/// ### Why is this bad?
|
|
/// If a catch clause in a try statement accidentally
|
|
/// (or purposely) assigns another value to the exception parameter,
|
|
/// it is impossible to refer to the error from that point on.
|
|
/// Since there is no arguments object to offer alternative access to this data,
|
|
/// assignment of the parameter is absolutely destructive.
|
|
///
|
|
/// ### Example
|
|
/// ```javascript
|
|
/// try {
|
|
/// // code
|
|
/// } catch (e) {
|
|
/// e = 10;
|
|
/// }
|
|
/// ```
|
|
NoExAssign,
|
|
correctness
|
|
);
|
|
|
|
impl Rule for NoExAssign {
|
|
fn run_on_symbol(&self, symbol_id: SymbolId, ctx: &LintContext<'_>) {
|
|
let symbol_table = ctx.semantic().symbols();
|
|
if symbol_table.get_flag(symbol_id).is_catch_variable() {
|
|
for reference in symbol_table.get_resolved_references(symbol_id) {
|
|
if reference.is_write() {
|
|
ctx.diagnostic(no_ex_assign_diagnostic(
|
|
ctx.semantic().reference_span(reference),
|
|
));
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn test() {
|
|
use crate::tester::Tester;
|
|
|
|
let pass = vec![
|
|
("try { } catch (e) { three = 2 + 1; }", None),
|
|
("try { } catch ({e}) { this.something = 2; }", None),
|
|
("function foo() { try { } catch (e) { return false; } }", None),
|
|
];
|
|
|
|
let fail = vec![
|
|
("try { } catch (e) { e = 10; }", None),
|
|
("try { } catch (ex) { ex = 10; }", None),
|
|
("try { } catch (ex) { [ex] = []; }", None),
|
|
("try { } catch (ex) { ({x: ex = 0} = {}); }", None),
|
|
("try { } catch ({message}) { message = 10; }", None),
|
|
];
|
|
|
|
Tester::new(NoExAssign::NAME, pass, fail).test_and_snapshot();
|
|
}
|