dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 04:42:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
oxc/crates/oxc_semantic/src
History
camc314 79af10070d fix(semantic): reference flags not correctly resolved when after an export stmt (#8134) 
fixes https://github.com/oxc-project/oxc/issues/7879#issuecomment-2562574889

TLDR is curently here:

cdd121bfa4/crates/oxc_semantic/src/builder.rs (L2130-L2135)

`self.current_reference_flags.is_empty()` is not empty, which causes the current ref flags to be used (this is incorrect, we should be using a fresh version of reference flags). Buy setting ref flags to `None` on exit export node, this issue is avoided

`export` **BEFORE** the reference ( incorrect reference flags)

https://playground.oxc.rs/#eNpVjjuOwzAMRK8isElj7A/YxtttkVOkkR3aECCJBskkdgzdPZISG0ilGc3DcFbooQUXJmI1q/m3bJIZmII5fHx2lg9/p4hzTXWZsCL3N+RekB3qvRUxRyKDs2I8S61cEzRA0K7Al1geWaLaGVrlCzbgXdRNS08T7mYJHfnNKdsoA3GAdrBeMDUwWRbk3Jh1adn0jtYPUMsj5hOA8vP1/QuZ6OmMI5Yx2QQX3eCebLBx9K8FlYvK5I+ebiW9InckOX4uSOkBCrdvkw==

`export` **AFTER** the reference ( correct reference flags)

https://playground.oxc.rs/#eNpVjj2uwjAQhK9ibZMmen/Sa0JHwSlonLCJLNm70a6BhMh3xzEEQeUZz6fZWaCDBlwYWaJZzN6KSaYXDqb6+m6tVLsjHQmnknfeqpoDs8EpIp208Et6Q+I8Yum5ffTcqh3UwNAsIGdaH50p2gmaKGeswTuKm9aOR3yZObTsNxfFkvYsAZreesVUw2hFUXJj1mvLpl9o+YBoZcB8AlD/fn7/IRMdn3DAdUw2wZHr3YMNlgb/XFA4isL+4Pm6pheUljXHjwUp3QEtmnBd

this PR fixes this issue by resetting the reference flags after exising an export stmt
2024-12-27 14:20:17 +00:00
..
checker fix(semantic): report errors for missing class method impls (#8082) 2024-12-25 12:24:33 +00:00
class refactor(global): sort imports (#7883) 2024-12-14 15:07:21 +00:00
jsdoc refactor(global): sort imports (#7883) 2024-12-14 15:07:21 +00:00
binder.rs perf(semantic): allocate Bindings in allocator (#8021) 2024-12-19 15:16:03 +00:00
builder.rs fix(semantic): reference flags not correctly resolved when after an export stmt (#8134) 2024-12-27 14:20:17 +00:00
diagnostics.rs
dot.rs chore: Rust v1.83.0 changes (#7535) 2024-11-29 11:59:45 +08:00
label.rs refactor(semantic): import flags and ID types from oxc_syntax (#7887) 2024-12-14 14:48:28 +00:00
lib.rs chore(semantic): use assert_eq! instead of assert! (crates/oxc_semantic/src/lib.rs) (#8127) 2024-12-26 13:54:21 +00:00
node.rs refactor(semantic): import flags and ID types from oxc_syntax (#7887) 2024-12-14 14:48:28 +00:00
scope.rs chore(semantic): use assert_eq! instead of assert! (crates/oxc_semantic/src/scope.rs) (#8128) 2024-12-26 22:14:33 +08:00
stats.rs feat(ast)!: remove invalid expressions from TSEnumMemberName (#7219) 2024-11-09 08:48:14 +00:00
symbol.rs perf(semantic): allocate symbol data in Allocator (#8012) 2024-12-20 14:13:41 +00:00
unresolved_stack.rs refactor(global): sort imports (#7883) 2024-12-14 15:07:21 +00:00