overlookmotel 6996948825 refactor(parser): remove extraneous code from regex parsing (#2008) ... This PR removes some code in parsing regexp flags which is extraneous: ```rs if !ch.is_ascii_lowercase() { self.error(diagnostics::RegExpFlag(ch, self.current_offset())); continue; } ``` Which is followed by: ```rs let flag = if let Ok(flag) = RegExpFlags::try_from(ch) { flag } else { self.error(diagnostics::RegExpFlag(ch, self.current_offset())); continue; }; ``` `!ch.is_ascii_lowercase()` is equivalent to `ch < 'a' || ch > 'z'`. The compiler implements `RegExpFlags::try_from(ch)` as `ch < 'd' || ch > 'y'` and then a jump table. So `ch.is_ascii_lowercase()` does nothing that `RegExpFlags::try_from(ch)` doesn't do already. https://godbolt.org/z/51GPPY9nx (this PR built on top of #2007 for ease)		2024-01-13 02:34:05 +00:00
..
examples	chore(clippy): enable undocumented_unsafe_blocks	2023-10-16 15:18:14 +08:00
src	refactor(parser): remove extraneous code from regex parsing (#2008)	2024-01-13 02:34:05 +00:00
Cargo.toml	Publish crates v0.5.0	2024-01-12 23:33:47 +08:00