oxc/tasks
overlookmotel 2c7bb9f6c8 refactor(ast): pass final ScopeFlags into visit_function (#4283)
We have a strange workaround for `visit_function` where we pass in `ScopeFlags`, to support creating the scope inside `Function`, but setting different flags for `MethodDefinition`s.

Previously `visit_function` took `Option<ScopeFlags>` and then did `flags.unwrap_or(ScopeFlags::empty()) | ScopeFlags::Function` to it. Personally, I found this confusing. When I was looking at `MethodDefinition`, I was wondering "It's a function, why doesn't it set Function flag too?"

This changes makes it more explicit and clear what `ScopeFlags` everything has.
2024-07-16 07:22:07 +00:00
..
ast_codegen refactor(ast): pass final ScopeFlags into visit_function (#4283) 2024-07-16 07:22:07 +00:00
benchmark chore(benchmark): add codegen benchmark (#4207) 2024-07-11 23:58:37 +08:00
common refactor(tasks): clean up test files and remove libs.txt (#4172) 2024-07-10 17:38:06 +00:00
coverage feat(coverage): run multi-file typescript tests (#4256) 2024-07-16 06:15:04 +00:00
javascript_globals chore: turn off doctest for all [[bin]] 2024-07-14 16:55:19 +08:00
lint_rules chore(ci): now we mark both ts alias and eslint rules. (#3813) 2024-06-22 04:55:34 +00:00
minsize chore: turn off doctest for all [[bin]] 2024-07-14 16:55:19 +08:00
prettier_conformance chore: turn off doctest for all [[bin]] 2024-07-14 16:55:19 +08:00
rulegen chore: turn off doctest for all [[bin]] 2024-07-14 16:55:19 +08:00
transform_conformance chore: turn off doctest for all [[bin]] 2024-07-14 16:55:19 +08:00
website chore: turn off doctest for all [[bin]] 2024-07-14 16:55:19 +08:00