mirror of
https://github.com/danbulant/oxc
synced 2026-05-25 12:51:57 +00:00
312 lines
12 KiB
Rust
312 lines
12 KiB
Rust
#[allow(clippy::wildcard_imports)]
|
|
use oxc_ast::{ast::*, AstKind, Atom, Span};
|
|
use oxc_diagnostics::{
|
|
miette::{self, Diagnostic},
|
|
thiserror::Error,
|
|
};
|
|
|
|
use crate::{context::LintContext, rule::Rule, AstNode};
|
|
|
|
#[derive(Debug, Default, Clone)]
|
|
pub struct EarlyErrorJavaScript;
|
|
|
|
impl Rule for EarlyErrorJavaScript {
|
|
#[allow(clippy::single_match)]
|
|
fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
|
|
match node.get().kind() {
|
|
AstKind::PrivateIdentifier(ident) => check_private_identifier(ident, node, ctx),
|
|
AstKind::NumberLiteral(lit) => check_number_literal(lit, node, ctx),
|
|
AstKind::StringLiteral(lit) => check_string_literal(lit, node, ctx),
|
|
AstKind::RegExpLiteral(lit) => check_regexp_literal(lit, ctx),
|
|
AstKind::BreakStatement(stmt) => check_break_statement(stmt, node, ctx),
|
|
AstKind::ContinueStatement(stmt) => check_continue_statement(stmt, node, ctx),
|
|
AstKind::LabeledStatement(stmt) => check_labeled_statement(stmt, node, ctx),
|
|
_ => {}
|
|
}
|
|
}
|
|
}
|
|
|
|
#[derive(Debug, Error, Diagnostic)]
|
|
#[error("Identifier `{0:?}` has already been declared")]
|
|
#[diagnostic()]
|
|
struct Redeclaration(
|
|
Atom,
|
|
#[label("`{0}` has already been declared here")] Span,
|
|
#[label("It can not be redeclared here")] Span,
|
|
);
|
|
|
|
fn check_private_identifier<'a>(
|
|
ident: &PrivateIdentifier,
|
|
node: &AstNode<'a>,
|
|
ctx: &LintContext<'a>,
|
|
) {
|
|
// Ignore private identifier declaration inside class
|
|
if matches!(ctx.parent_kind(node), AstKind::PropertyKey(_)) {
|
|
return;
|
|
}
|
|
|
|
// Find enclosing classes
|
|
let mut classes = vec![];
|
|
for node_id in ctx.ancestors(node).skip(1) {
|
|
let kind = ctx.kind(node_id);
|
|
if let AstKind::Class(class) = kind {
|
|
classes.push(class);
|
|
}
|
|
// stop lookup when the class is a heritage, e.g.
|
|
// `class C extends class extends class { x = this.#foo; } {} { #foo }`
|
|
// `class C extends function() { x = this.#foo; } { #foo }`
|
|
if matches!(kind, AstKind::ClassHeritage(_)) {
|
|
break;
|
|
}
|
|
}
|
|
|
|
if classes.is_empty() {
|
|
#[derive(Debug, Error, Diagnostic)]
|
|
#[error("Private identifier '#{0:?}' is not allowed outside class bodies")]
|
|
#[diagnostic()]
|
|
struct PrivateNotInClass(Atom, #[label] Span);
|
|
return ctx.diagnostic(PrivateNotInClass(ident.name.clone(), ident.span));
|
|
};
|
|
|
|
// Check private identifier declarations in class.
|
|
// This implementations does a simple lookup for private identifier declarations inside a class.
|
|
// Performance can be improved by storing private identifiers for each class inside a lookup table,
|
|
// but there are not many private identifiers in the wild so we should be good fow now.
|
|
let found_private_ident = classes.iter().any(|class| {
|
|
class.body.body.iter().any(|def| {
|
|
// let key = match def {
|
|
// ClassElement::PropertyDefinition(def) => &def.key,
|
|
// ClassElement::MethodDefinition(def) => &def.key,
|
|
// _ => return false,
|
|
// };
|
|
if let Some(key) = def.property_key()
|
|
&& let PropertyKey::PrivateIdentifier(prop_ident) = key {
|
|
return prop_ident.name == ident.name;
|
|
}
|
|
false
|
|
})
|
|
});
|
|
|
|
if !found_private_ident {
|
|
#[derive(Debug, Error, Diagnostic)]
|
|
#[error("Private field '{0:?}' must be declared in an enclosing class")]
|
|
#[diagnostic()]
|
|
struct PrivateFieldUndeclared(Atom, #[label] Span);
|
|
ctx.diagnostic(PrivateFieldUndeclared(ident.name.clone(), ident.span));
|
|
}
|
|
}
|
|
|
|
#[derive(Debug, Error, Diagnostic)]
|
|
#[error("'0'-prefixed octal literals and octal escape sequences are deprecated")]
|
|
#[diagnostic(help("for octal literals use the '0o' prefix instead"))]
|
|
struct LegacyOctal(#[label] Span);
|
|
|
|
fn check_number_literal(lit: &NumberLiteral, node: &AstNode, ctx: &LintContext) {
|
|
// NumericLiteral :: LegacyOctalIntegerLiteral
|
|
// DecimalIntegerLiteral :: NonOctalDecimalIntegerLiteral
|
|
// * It is a Syntax Error if the source text matched by this production is strict mode code.
|
|
fn leading_zero(s: &str) -> bool {
|
|
let mut chars = s.bytes();
|
|
if let Some(first) = chars.next() {
|
|
if let Some(second) = chars.next() {
|
|
return first == b'0' && second.is_ascii_digit();
|
|
}
|
|
}
|
|
false
|
|
}
|
|
|
|
if ctx.strict_mode(node) {
|
|
match lit.base {
|
|
NumberBase::Octal if leading_zero(lit.raw) => {
|
|
ctx.diagnostic(LegacyOctal(lit.span));
|
|
}
|
|
NumberBase::Decimal if leading_zero(lit.raw) => {
|
|
#[derive(Debug, Error, Diagnostic)]
|
|
#[error("Decimals with leading zeros are not allowed in strict mode")]
|
|
#[diagnostic(help("remove the leading zero"))]
|
|
struct LeadingZeroDecimal(#[label] Span);
|
|
ctx.diagnostic(LeadingZeroDecimal(lit.span));
|
|
}
|
|
_ => {}
|
|
}
|
|
}
|
|
}
|
|
|
|
fn check_string_literal<'a>(lit: &StringLiteral, node: &AstNode<'a>, ctx: &LintContext<'a>) {
|
|
// 12.9.4.1 Static Semantics: Early Errors
|
|
// EscapeSequence ::
|
|
// LegacyOctalEscapeSequence
|
|
// NonOctalDecimalEscapeSequence
|
|
// It is a Syntax Error if the source text matched by this production is strict mode code.
|
|
let raw = lit.span.source_text(ctx.source_text());
|
|
if ctx.strict_mode(node) && raw.len() != lit.value.len() {
|
|
let mut chars = raw.chars().peekable();
|
|
while let Some(c) = chars.next() {
|
|
if c == '\\' {
|
|
match chars.next() {
|
|
Some('0') => {
|
|
if chars.peek().is_some_and(|c| ('1'..='9').contains(c)) {
|
|
return ctx.diagnostic(LegacyOctal(lit.span));
|
|
}
|
|
}
|
|
Some('1'..='7') => {
|
|
return ctx.diagnostic(LegacyOctal(lit.span));
|
|
}
|
|
Some('8'..='9') => {
|
|
#[derive(Debug, Error, Diagnostic)]
|
|
#[error("Invalid escape sequence")]
|
|
#[diagnostic(help("\\8 and \\9 are not allowed in strict mode"))]
|
|
struct NonOctalDecimalEscapeSequence(#[label] Span);
|
|
return ctx.diagnostic(NonOctalDecimalEscapeSequence(lit.span));
|
|
}
|
|
_ => {}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
fn check_regexp_literal(lit: &RegExpLiteral, ctx: &LintContext) {
|
|
#[derive(Debug, Error, Diagnostic)]
|
|
#[error("The 'u' and 'v' regular expression flags cannot be enabled at the same time")]
|
|
#[diagnostic()]
|
|
struct RegExpFlagUAndV(#[label] Span);
|
|
|
|
let flags = lit.regex.flags;
|
|
if flags.contains(RegExpFlags::U | RegExpFlags::V) {
|
|
ctx.diagnostic(RegExpFlagUAndV(lit.span));
|
|
}
|
|
}
|
|
|
|
#[derive(Debug, Error, Diagnostic)]
|
|
#[error("Jump target cannot cross function boundary.")]
|
|
#[diagnostic()]
|
|
struct InvalidLabelJumpTarget(#[label] Span);
|
|
|
|
#[derive(Debug, Error, Diagnostic)]
|
|
#[error("Use of undefined label")]
|
|
#[diagnostic()]
|
|
struct InvalidLabelTarget(#[label("This label is used, but not defined")] Span);
|
|
|
|
fn check_break_statement<'a>(stmt: &BreakStatement, node: &AstNode<'a>, ctx: &LintContext<'a>) {
|
|
#[derive(Debug, Error, Diagnostic)]
|
|
#[error("Illegal break statement")]
|
|
#[diagnostic(help(
|
|
"A `break` statement can only be used within an enclosing iteration or switch statement."
|
|
))]
|
|
struct InvalidBreak(#[label] Span);
|
|
|
|
// It is a Syntax Error if this BreakStatement is not nested, directly or indirectly (but not crossing function or static initialization block boundaries), within an IterationStatement or a SwitchStatement.
|
|
for node_id in ctx.ancestors(node).skip(1) {
|
|
match ctx.kind(node_id) {
|
|
AstKind::Program(_) => {
|
|
return stmt.label.as_ref().map_or_else(
|
|
|| ctx.diagnostic(InvalidBreak(stmt.span)),
|
|
|label| ctx.diagnostic(InvalidLabelTarget(label.span)),
|
|
);
|
|
}
|
|
AstKind::Function(_) | AstKind::StaticBlock(_) => {
|
|
return stmt.label.as_ref().map_or_else(
|
|
|| ctx.diagnostic(InvalidBreak(stmt.span)),
|
|
|label| ctx.diagnostic(InvalidLabelJumpTarget(label.span)),
|
|
);
|
|
}
|
|
AstKind::LabeledStatement(labeled_statement) => {
|
|
if let Some(label) = &stmt.label
|
|
&& label.name == labeled_statement.label.name {
|
|
break;
|
|
}
|
|
}
|
|
kind if (kind.is_iteration_statement()
|
|
|| matches!(kind, AstKind::SwitchStatement(_)))
|
|
&& stmt.label.is_none() =>
|
|
{
|
|
break;
|
|
}
|
|
_ => {}
|
|
}
|
|
}
|
|
}
|
|
|
|
fn check_continue_statement<'a>(
|
|
stmt: &ContinueStatement,
|
|
node: &AstNode<'a>,
|
|
ctx: &LintContext<'a>,
|
|
) {
|
|
#[derive(Debug, Error, Diagnostic)]
|
|
#[error("Illegal continue statement: no surrounding iteration statement")]
|
|
#[diagnostic(help(
|
|
"A `continue` statement can only be used within an enclosing `for`, `while` or `do while` "
|
|
))]
|
|
struct InvalidContinue(#[label] Span);
|
|
|
|
#[derive(Debug, Error, Diagnostic)]
|
|
#[error(
|
|
"A `{0:?}` statement can only jump to a label of an enclosing `for`, `while` or `do while` statement."
|
|
)]
|
|
#[diagnostic()]
|
|
struct InvalidLabelNonIteration(
|
|
&'static str,
|
|
#[label("This is an non-iteration statement")] Span,
|
|
#[label("for this label")] Span,
|
|
);
|
|
|
|
// It is a Syntax Error if this ContinueStatement is not nested, directly or indirectly (but not crossing function or static initialization block boundaries), within an IterationStatement.
|
|
for node_id in ctx.ancestors(node).skip(1) {
|
|
match ctx.kind(node_id) {
|
|
AstKind::Program(_) => {
|
|
return stmt.label.as_ref().map_or_else(
|
|
|| ctx.diagnostic(InvalidContinue(stmt.span)),
|
|
|label| ctx.diagnostic(InvalidLabelTarget(label.span)),
|
|
);
|
|
}
|
|
AstKind::Function(_) | AstKind::StaticBlock(_) => {
|
|
return stmt.label.as_ref().map_or_else(
|
|
|| ctx.diagnostic(InvalidContinue(stmt.span)),
|
|
|label| ctx.diagnostic(InvalidLabelJumpTarget(label.span)),
|
|
);
|
|
}
|
|
AstKind::LabeledStatement(labeled_statement) => {
|
|
if let Some(label) = &stmt.label
|
|
&& label.name == labeled_statement.label.name {
|
|
if matches!(
|
|
labeled_statement.body,
|
|
Statement::LabeledStatement(_)
|
|
| Statement::DoWhileStatement(_)
|
|
| Statement::WhileStatement(_)
|
|
| Statement::ForStatement(_)
|
|
| Statement::ForInStatement(_)
|
|
| Statement::ForOfStatement(_)
|
|
) {
|
|
break;
|
|
}
|
|
return ctx.diagnostic(InvalidLabelNonIteration(
|
|
"continue",
|
|
labeled_statement.label.span,
|
|
label.span,
|
|
));
|
|
}
|
|
}
|
|
kind if kind.is_iteration_statement() && stmt.label.is_none() => break,
|
|
_ => {}
|
|
}
|
|
}
|
|
}
|
|
|
|
fn check_labeled_statement<'a>(stmt: &LabeledStatement, node: &AstNode<'a>, ctx: &LintContext<'a>) {
|
|
for node_id in ctx.ancestors(node).skip(1) {
|
|
match ctx.kind(node_id) {
|
|
// label cannot cross boundary on function or static block
|
|
AstKind::Function(_) | AstKind::StaticBlock(_) | AstKind::Program(_) => break,
|
|
// check label name redeclaration
|
|
AstKind::LabeledStatement(label_stmt) if stmt.label.name == label_stmt.label.name => {
|
|
return ctx.diagnostic(Redeclaration(
|
|
stmt.label.name.clone(),
|
|
label_stmt.label.span,
|
|
stmt.label.span,
|
|
));
|
|
}
|
|
_ => {}
|
|
}
|
|
}
|
|
}
|