Burlin
f88970bc79
refactor(ast)!: Change order of fields in CallExpression ( #4859 )
...
fix : #4821
---------
Co-authored-by: Dunqing <dengqing0821@gmail.com>
2024-08-20 09:47:12 +08:00
Boshen
0df1a94a1b
test(semantic): add more symbol and reference checks to PostTransformChecker
2024-08-19 15:44:17 +08:00
Boshen
3f6014a042
chore(semantic): add PostTransformChecker ( #4967 )
2024-08-19 05:38:27 +00:00
overlookmotel
d677b8e0ab
refactor(semantic): do not reserve space in resolved_references ( #4962 )
...
While resolving references in `SemanticBuilder`, there is little benefit to reserving space in advance in `resolved_references` as it is not possible to avoid growing the `Vec`. The comment here says "Reserve space for all references to avoid reallocations", but `reserve()` itself may cause a reallocation.
2024-08-19 01:32:05 +00:00
overlookmotel
a7ef30dcf9
refactor(semantic): UnresolvedReferencesStack contain only ReferenceId ( #4960 )
...
Remove `ReferenceFlag` from `UnresolvedReferencesStack` to align with `root_unresolved_references`.
2024-08-19 01:32:04 +00:00
overlookmotel
59d15c7086
refactor(semantic): root_unresolved_references contain only ReferenceId ( #4959 )
...
`ScopeTree::root_unresolved_references` does not need to record `ReferenceFlag` as well as `ReferenceId` - it's never read.
2024-08-19 01:32:04 +00:00
oxc-bot
5d0fb979cb
Release crates v0.24.3 ( #4950 )
...
## [0.24.3] - 2024-08-18
### Features
- d49fb16#4898 )
(IWANABETHATGUY)
- 80d0d1f#4928 )
(DonIsaac)
- 48821c0#4946 )
(DonIsaac)
- f1fcdde#4587 ) (Dunqing)
- 0d79122#4890 ) (Dunqing)
- ab1d08c#4885 )
(Dunqing)
- 69da9fd#4884 ) (Dunqing)
- 3a66e58#4876 )
(Dunqing)
- f88cbcd#4903 ) (overlookmotel)
- 1e6d0fe#4897 )
(overlookmotel)
- fd34640#4940 ) (Dunqing)
- 72a37fc#4880 ) (Dunqing)
### Bug Fixes
- c0b26f4#4858 )
(overlookmotel)
- bbf9ec0#4937 )
(Boshen)
- f210cf7#4936 ) (Boshen)
- 21f5762#4889 ) (Boshen)
- e8de4bd#4886 ) (Boshen)
- a226962#4869 ) (Boshen)
- 3da33d3#4865 )
(Boshen)
- 1808529#4862 )
(IWANABETHATGUY)
- d3bbc62#4941 ) (Dunqing)
- 8e80f59#4934 ) (michaelm)
- b3ec9e5#4919 ) (michaelm)
- 0fb0b71#4911 )
(michaelm)
- 4a16916#4910 )
(michaelm)
- 508644a#4932 ) (mysteryven)
- 46cb1c1#4933 ) (Boshen)
- 81fd637#4878 ) (Boshen)
- 879a271#4875 ) (Boshen)
- 1bdde2c#4861 ) (Boshen)
- 2476dce#4913 ) (overlookmotel)
- 248a757#4920 ) (Dunqing)
### Documentation
- 47c9552#4856 ) (rzvxa)
- 0a01a47#4850 ) (DonIsaac)
- 9c700ed#4899 )
(overlookmotel)
### Refactor
- a6967b3#4904 ) (overlookmotel)
- 90d0b2b#4900 ) (overlookmotel)
- 1eb59d2#4907 ) (overlookmotel)
- 8e8fcd0#4846 ) (rzvxa)
- 786bf07#4905 )
(overlookmotel)
- ea1e64a#4851 ) (DonIsaac)
- 5fd1701#4873 ) (rzvxa)
- 48a1c32#4877 )
(overlookmotel)
- 452187a#4902 ) (overlookmotel)
- 707a01f#4896 )
(overlookmotel)
- 117dff2#4895 ) (overlookmotel)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-08-18 14:16:25 +08:00
DonIsaac
48821c0110
feat(semantic,syntax): add SymbolFlags::ArrowFunction ( #4946 )
...
There are many cases in lint rules where we want to see if a symbol is a
function by checking its SymbolFlags. This is currently not fully possible,
since variables assigned to arrow functions are not distinguished from any other
kind of variable. This PR adds `SymbolFlags::ArrowFunction` for variables that
are initialized to arrow functions. Symbols that are re-assigned to arrow
functions will not have this flag, but this is acceptable for lint rules.
2024-08-18 05:54:23 +00:00
DonIsaac
80d0d1f0c4
feat(semantic): check for invalid interface heritage clauses ( #4928 )
2024-08-16 02:30:09 +00:00
DonIsaac
ea1e64a1f3
refactor(semantic): make SemanticBuilder opaque ( #4851 )
...
change visibility of building-related methods and properties of SemanticBuilder
from `pub` to `pub(crate)`.
2024-08-14 08:15:20 +00:00
DonIsaac
0a01a4729a
docs(semantic): improve documentation ( #4850 )
2024-08-13 02:14:07 +00:00
oxc-bot
977b74af2d
Release crates v0.24.2 ( #4841 )
...
## [0.24.2] - 2024-08-12
### Features
- 8e10e25#4810 ) (overlookmotel)
### Bug Fixes
- 62f759c#4808 ) (Dunqing)
### Performance
- 504ac0b#4803 ) (overlookmotel)
- 35f2742#4802 ) (overlookmotel)
### Documentation
- 8827659#4830 ) (DonIsaac)
- 559baa50ea697b#4819 ) (rzvxa)
- ecfa124#4829 )
(overlookmotel)
- 096ac7b#4831 ) (DonIsaac)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-08-12 16:02:07 +08:00
oxc-bot
857bc73302
Release crates v0.24.1 ( #4798 )
...
## [0.24.1] - 2024-08-10
### Features
- b3c3125#4791 ) (DonIsaac)
- c519295#4759 ) (Boshen)
### Bug Fixes
- fff9da3#4747 ) (rzvxa)
- f5eeebd#4766 ) (rzvxa)
- 4d0b40adaa0b2e#4773 ) (overlookmotel)
- d4a3be8#4781 ) (overlookmotel)
- dbb5f4c#4774 ) (overlookmotel)
- 7ea058d#4769 ) (overlookmotel)
- 2dea0ca#4761 ) (overlookmotel)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-08-10 15:26:40 +08:00
oxc-bot
69dc6c9cb1
Release crates v0.24.0 ( #4749 )
...
## [0.24.0] - 2024-08-08
- 75f2207#4693 ) (overlookmotel)
- 506709f#4692 ) (overlookmotel)
### Features
- 23b0040#4726 ) (rzvxa)
- 51c1ca0#4732 ) (rzvxa)
- e12bd1e#4711 ) (DonIsaac)
- fd2d9da#4553 ) (DonIsaac)
- b3b7028#4552 ) (DonIsaac)
- 54047e0#4609 ) (overlookmotel)
- eae401c#4373 ) (rzvxa)
- ec0b4cb#4731 ) (rzvxa)
- 2e91ad6#4728 )
(rzvxa)
- 82e2f6b#4694 )
(rzvxa)
- 0c52c0d#4615 ) (rzvxa)
- 07607d3#4703 )
(overlookmotel)
- 125c5fd#4696 ) (rzvxa)
- eaddc8f#4714 ) (DonIsaac)
- 229a0e9#3959 )
(camc314)
- 33f1312#4717 ) (DonIsaac)
- e42ac3a#4639 ) (overlookmotel)
- 2e63618#4729 )
(rzvxa)
- 6a36616#4730 )
(rzvxa)
### Bug Fixes
- 4a56954#4676 )
(Boshen)
- 94d3c31#4722 ) (Boshen)
- bf43148bf48c7f#4680 ) (Boshen)
- 9be29af#4678 ) (Boshen)
- e8b662a#4667 )
(Boshen)
- 01d85def290191a40a217#4610 )
(Boshen)
- 03c643a#4659 ) (Dunqing)
- 6c612d1#4642 ) (leaysgur)
- 0d2c41a#4632 )
(rzvxa)
- 9f8f299#4675 )
(overlookmotel)
- 4797eaa#4686 ) (overlookmotel)
- 5327acd#4658 ) (Dunqing)
- 3987665#4660 ) (Dunqing)
- 4efd54b#4549 ) (Dunqing)
### Performance
- 8dd76e4#4643 )
(overlookmotel)
- b8e6753#4641 ) (overlookmotel)
- 6ff200d#4603 ) (DonIsaac)
- 0f5e982#4677 ) (Boshen)
- ff43dff#4633 ) (overlookmotel)
- a330773#4638 ) (overlookmotel)
- 372316b#4634 ) (overlookmotel)
- c7f1d48#4596 ) (overlookmotel)
- 590d795#4586 )
(overlookmotel)
### Documentation
- c69ada4#4051 ) (Rintaro Itokawa)
### Refactor
- 579b797#4738 ) (rzvxa)
- 475266d#4712 )
(DonIsaac)
- 83b6ca9#4689 ) (rzvxa)
- ba70001#4621 )
(rzvxa)
- 3f53b6f#4614 ) (rzvxa)
- 452e0ee#4599 ) (overlookmotel)
- 2218340#4735 ) (rzvxa)
- fbfd852#4734 ) (Boshen)
- e0832f8#4725 ) (Boshen)
- 17602db3289477#4724 ) (Boshen)
- e78cba6#4625 ) (Boshen)
- d25dea7#4612 ) (rzvxa)
- 09d9822#4674 ) (overlookmotel)
- 6e453db#4664 ) (Dunqing)
- e1429e5#4702 )
(overlookmotel)
- e24fb5b#4691 ) (rzvxa)
- 3f3cb62#4698 ) (overlookmotel)
- 54f9897#4685 ) (overlookmotel)
- 83546d3#4684 )
(overlookmotel)- 9b51e04#4592 )
(DonIsaac)
### Testing
- 49d5196#4620 ) (rzvxa)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-08-08 14:00:57 +08:00
DonIsaac
33f1312a8c
feat(semantic): impl GetSpan for AstNode ( #4717 )
2024-08-07 03:59:38 +00:00
oxc-bot
61337613da
Release crates v0.23.1 ( #4681 )
...
## [0.23.1] - 2024-08-06
### Features
- fd2d9da#4553 ) (DonIsaac)
- b3b7028#4552 ) (DonIsaac)
- 54047e0#4609 ) (overlookmotel)
- eae401c#4373 ) (rzvxa)
- 0c52c0d#4615 ) (rzvxa)
- 229a0e9#3959 )
(camc314)
- e42ac3a#4639 ) (overlookmotel)
### Bug Fixes
- 4a56954#4676 )
(Boshen)
- bf48c7f#4680 ) (Boshen)
- 9be29af#4678 ) (Boshen)
- e8b662a#4667 )
(Boshen)
- a40a217#4610 )
(Boshen)
- 03c643a#4659 ) (Dunqing)
- 6c612d1#4642 ) (leaysgur)
- 0d2c41a#4632 )
(rzvxa)
- 9f8f299#4675 )
(overlookmotel)
- 5327acd#4658 ) (Dunqing)
- 3987665#4660 ) (Dunqing)
- 4efd54b#4549 ) (Dunqing)
### Performance
- 8dd76e4#4643 )
(overlookmotel)
- b8e6753#4641 ) (overlookmotel)
- 6ff200d#4603 ) (DonIsaac)
- 0f5e982#4677 ) (Boshen)
- ff43dff#4633 ) (overlookmotel)
- a330773#4638 ) (overlookmotel)
- 372316b#4634 ) (overlookmotel)
- c7f1d48#4596 ) (overlookmotel)
- 590d795#4586 )
(overlookmotel)
### Documentation
- c69ada4#4051 ) (Rintaro Itokawa)
### Refactor
- ba70001#4621 )
(rzvxa)
- 3f53b6f#4614 ) (rzvxa)
- 452e0ee#4599 ) (overlookmotel)
- e78cba6#4625 ) (Boshen)
- d25dea7#4612 ) (rzvxa)
- 09d9822#4674 ) (overlookmotel)
- 6e453db#4664 ) (Dunqing)- 9b51e04#4592 )
(DonIsaac)
### Testing
- 49d5196#4620 ) (rzvxa)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-08-06 16:37:29 +08:00
Dunqing
03c643a8af
fix(semantic): incorrect scope_id for catch parameter symbols ( #4659 )
...
When we move all the bindings in the CatchClause scope to its child scope (BlockStatement), we also need to replace the scope_id in the symbol with the scope_id of the new scope.
2024-08-06 02:57:18 +00:00
overlookmotel
09d982224f
refactor(semantic): simplify setting scope flags ( #4674 )
2024-08-06 06:47:43 +08:00
Dunqing
6e453db3f7
refactor(semantic): simplify inherit scope flags from parent scope ( #4664 )
...
close : #3862
This is reaming last part of close #3862
2024-08-05 22:27:07 +00:00
leaysgur
6c612d141c
fix(semantic/jsdoc): Handle whitespace absence ( #4642 )
...
Follow up for #4632
2024-08-05 02:25:13 +00:00
rzvxa
0d2c41a2cb
fix(semantic/jsdoc): panic on parsing type_name_comment. ( #4632 )
...
fixes #4627
2024-08-05 01:17:53 +00:00
DonIsaac
fd2d9dafcd
feat(ast): improve AstKind::debug_name ( #4553 )
...
> Part of #4445
Improve `debug_name` to show identifier names for more AST kinds.
2024-08-03 21:22:05 +00:00
oxc-bot
e02bac357a
Release crates v0.23.0 ( #4595 )
...
## [0.23.0] - 2024-08-01
- 27fd062#4541 )
(overlookmotel)
### Features
- a558492#4548 ) (Boshen)
- 7446e98#4510 ) (Boshen)
- 35654e6#4509 )
(Boshen)
- b952942⭐ attempt 3.2) (#4445 )
(DonIsaac)
- 85e8418#3949 ) (Don Isaac)
- cf1854b#4511 ) (Dunqing)
### Bug Fixes
- b58ed80#4585 ) (Boshen)
- 6a94e3f#4503 ) (Boshen)
- d5c4b19#4543 ) (DonIsaac)
### Performance
- 4c6d19d#4584 ) (Luca Bruno)
- 7585e16#4570 )
(DonIsaac)
- 55a8763#4579 )
(overlookmotel)
- ae1d38f#4577 ) (overlookmotel)
- 56ae615#4576 ) (overlookmotel)
- 25679e6#4572 ) (overlookmotel)
- bb33bcc#4571 )
(overlookmotel)
- ab8509e#4561 ) (overlookmotel)
- c9c38a1#4304 ) (lucab)
- 0870ee1#4534 ) (lucab)
- d00014e#4583 )
(overlookmotel)
- 1fd9dd0#4487 )
(Brooooooklyn)
### Documentation
- 0914e47#4551 ) (DonIsaac)
- c6a11be#4471 )
(DonIsaac)
### Refactor
- e68ed62#4575 ) (overlookmotel)
- bba824b#4574 )
(overlookmotel)
- ef5418a#4573 ) (overlookmotel)
- 9e5be78#4569 ) (overlookmotel)
- 649913e#4568 ) (overlookmotel)
- 59f00c0#4566 ) (overlookmotel)
- 8e3e910#4565 ) (overlookmotel)
- 0c0601f#4564 ) (overlookmotel)
- 0acc4a7#4563 )
(overlookmotel)
- 565eccf#4562 ) (overlookmotel)
- 148bdb5#4530 ) (overlookmotel)
- 16c7b98#4505 ) (Dunqing)
- d6974d4#4533 )
(overlookmotel)
- d914b14#4529 ) (Dunqing)
- 7b5e1f5#4532 )
(overlookmotel)
- 9db4259#4531 ) (overlookmotel)
- 7c42ffc#4535 ) (overlookmotel)
- 96602bf#4513 ) (Dunqing)
- e6a8af6#4538 ) (overlookmotel)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-08-01 16:55:41 +08:00
Dunqing
16c7b98962
refactor(semantic): move CatchClause scope binding logic to visit_block_statement ( #4505 )
...
This logic only needs to run in the BlockStatement
2024-07-31 03:52:22 +00:00
DonIsaac
b952942993
feat(linter): add eslint/no-unused-vars ( ⭐ attempt 3.2) ( #4445 )
...
> Re-creation of #4427 due to rebasing issues. Original attempt: #642
-----
Third time's the charm?
Each time I attempt this rule, I find a bunch of bugs in `Semantic`, and I expect this attempt to be no different. Expect sidecar issues+PRs stemming from this PR here.
## Not Supported
These are cases supported in the original eslint rule, but that I'm intentionally deciding not to support
- export comments in scripts
```js
/* exported a */ var a;
```
- global comments
```js
/* global a */ var a;
```
## Behavior Changes
These are intentional deviations from the original rule's behavior:
- logical re-assignments are not considered usages
```js
// passes in eslint/no-unused-vars, fails in this implementation
let a = 0; a ||= 1;
let b = 0; b &&= 2;
let c = undefined; c ??= []
```
## Known Limitations
- Lint rules do not have babel or tsconfig information, meaning we can't determine if `React` imports are being used or not. The relevant tsconfig settings here are `jsx`, `jsxPragma`, and `jsxFragmentName`. To accommodate this, all imports to symbols named `React` or `h` are ignored in JSX files.
- References to symbols used in JSDoc `{@link}` tags are not created, so symbols that are only used in doc comments will be reported as unused. See: #4443
- `.vue` files are skipped completely, since variables can be used in templates in ways we cannot detect
> note: `.d.ts` files are skipped as well.
## Todo
- [x] Skip unused TS enum members on used enums
- [x] Skip unused parameters followed by used variables in object/array spreads
- [x] Re-assignments to array/object spreads do not respect `destructuredArrayIgnorePattern` (related to: https://github.com/oxc-project/oxc/issues/4435 )
- [x] #4493
- [x] References inside a nested scope are not considered usages (#4447 )
- [x] Port over typescript-eslint test cases _(wip, they've been copied and I'm slowly enabling them)_
- [x] Handle constructor properties
```ts
class Foo {
constructor(public a) {} // `a` should be allowed
}
```
- [x] Read references in sequence expressions (that are not in the last position) should not count as a usage
```js
let a = 0; let b = (a++, 0); console.log(b)
```
> Honestly, is anyone even writing code like this?
- [x] function overload signatures should not be reported
- [x] Named functions returned from other functions get incorrectly reported as unused (found by @camc314)
```js
function foo() {
return function bar() { }
}
Foo()()
```
- [x] false positive for TS modules within ambient modules
```ts
declare global {
// incorrectly marked as unused
namespace jest { }
}
```
## Blockers
- https://github.com/oxc-project/oxc/issues/4436
- https://github.com/oxc-project/oxc/issues/4437
- #4446
- #4447
- #4494
- #4495
## Non-Blocking Issues
- #4443
- #4475 (prevents checks on exported symbols from namespaces)
2024-07-31 03:22:16 +00:00
DonIsaac
d5c4b190aa
fix(parser): fix enum member parsing ( #4543 )
...
Closes #4449
2024-07-30 10:43:09 +00:00
overlookmotel
d6974d4ff7
refactor(semantic): AstNodeParentIter fetch nodes lazily ( #4533 )
...
Refactor `AstNodeParentIter`, which is used to iterate down node ancestry chain. Fetch `AstNode` objects lazily, only when they're required by a `next()` call. If caller doesn't iterate all the way down the chain, likely this will result in 1 less array lookup.
2024-07-29 18:27:38 +00:00
Dunqing
d914b14275
refactor(semantic): reusing the same reference ( #4529 )
...
A minor improvement
2024-07-29 16:16:27 +00:00
overlookmotel
7b5e1f5ac8
refactor(semantic): use is_empty() instead of len() == 0 ( #4532 )
...
It's preferred to use `is_empty` where possible. `is_empty` is sometimes slightly more optimized than `len() == 0`.
2024-07-29 15:42:05 +00:00
overlookmotel
9db42592af
refactor(semantic): inline trivial methods ( #4531 )
...
Add `#[inline]` to trivial methods `ScopeTree` etc. Hopefully compiler is already inlining them all, but just to make sure.
2024-07-29 15:42:03 +00:00
Dunqing
cf1854be7c
feat(semantic): remove ReferenceFlags::Value from non-type-only exports that referenced type binding ( #4511 )
...
```ts
type T = 0;
export { T }
^ ReferenceFlags::Type | ReferenceFlags::Read
```
The export `T` only referenced type binding. We should remove `ReferenceFlags::Read` for it.
2024-07-29 03:39:18 +00:00
oxc-bot
80118cbf3b
Release crates v0.22.1 ( #4508 )
...
## [0.22.1] - 2024-07-27
### Features
- 2477330#4501 ) (Dunqing)
- aaee07e#4456 ) (Dunqing)
- fd363d1#4450 ) (DonIsaac)
- e2735ca#4491 ) (DonIsaac)
### Bug Fixes
- 368112c#4497 )
(Dunqing)
- 36bb680#4502 ) (Dunqing)
- cb2fa49#4500 ) (Dunqing)
- ef0e953#4499 ) (Dunqing)
- 40cafb8#4480 ) (Dunqing)
- 2e01a45#4493 ) (Don Isaac)
- e4ca06a#4458 ) (Dunqing)
- 77bd5f1#4448 ) (Don
Isaac)
- 5db7bed#4490 ) (overlookmotel)
- 1667491#4484 ) (Ethan Goh)
- 82ba2a0#4466 )
(overlookmotel)
- c04b9aa#4460 ) (overlookmotel)
- ecdee88#4507 ) (Dunqing)
### Performance
- 963a2d1#4498 ) (Dunqing)
- 868fc87#4298 )
(lucab)
- 24beaeb#4469 ) (overlookmotel)
- 348c1ad#4464 )
(overlookmotel)
- 6a9f4db#4463 ) (overlookmotel)
- 705e19f#4489 )
(overlookmotel)
- 4d10c6c#4476 )
(Brooooooklyn)
### Documentation
- f5f0ba8#4413 ) (Don Isaac)
- 871b3d6#4433 ) (DonIsaac)
### Refactor
- 9c5d2f9#4428 )
(overlookmotel)
- ccb1835#4470 )
(overlookmotel)
- f17254a#4461 ) (overlookmotel)
- a49f491#4459 )
(overlookmotel)
- 7cd53f3#4379 ) (Dunqing)
- 4f5a7cb#4430 ) (DonIsaac)
- c958a55#4486 )
(overlookmotel)
- c99b3eb#4468 ) (overlookmotel)
- 96fc94f#4467 ) (overlookmotel)
### Testing
- 4b274a8#4429 )
(DonIsaac)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-07-28 09:58:29 +08:00
Dunqing
36bb6805c6
fix(semantic): TSExportAssignment cannot reference type binding ( #4502 )
...
close : #4488
2024-07-27 04:55:03 +00:00
Dunqing
2477330440
feat(ast): add AstKind::TSExportAssignment ( #4501 )
...
part of #4488
2024-07-27 04:55:02 +00:00
Dunqing
cb2fa4924e
fix(semantic): typeof operator cannot reference type-only import ( #4500 )
2024-07-27 00:21:06 -04:00
Dunqing
ef0e953702
fix(semantic): generic passed to typeof not counted as a reference ( #4499 )
2024-07-27 00:16:25 -04:00
Dunqing
40cafb8c61
fix(semantic): params in export default (function() {}) flagged as SymbolFlags::Export ( #4480 )
...
The code changes in `builder.rs` optimize the export flag check in the `SemanticBuilder` implementation. Instead of setting the export flag to `true` for all cases except `ExportDefaultDeclarationKind::ClassDeclaration(ref class)`, the flag is now set to `true` only for `ExportDefaultDeclarationKind::ClassDeclaration` and `false` for all other cases. This change improves the efficiency of the export flag check.
2024-07-27 02:42:24 +00:00
Don Isaac
2e01a45b2b
fix(semantic): non-exported namespace member symbols flagged as exported ( #4493 )
...
> Part of #4445
Fixes a bug where non-exported functions and variables inside of
exported TS namespaces were being flagged with `SymbolFlags::Export`
```ts
export namespace Foo {
// incorrectly flagged as exported
function foo() { }
}
```
2024-07-27 08:46:21 +08:00
overlookmotel
ccb1835a45
refactor(semantic): methods take Span as param, not &Span ( #4470 )
...
`Span` is `Copy` and 8 bytes. So better to pass `Span` to functions, rather than `&Span` (which is also 8 bytes, but involves the indirection of a reference).
2024-07-26 00:14:56 +00:00
overlookmotel
c99b3eb464
refactor(syntax): give ScopeId a niche ( #4468 )
...
Make `ScopeId` a type with a niche, like `SymbolId` and `ReferenceId`. This makes `Option<ScopeId>` 4 bytes instead of 8, and shrinks various AST types e.g. `ArrowFunctionExpression` by 8 bytes, and halves the size of the `Vec` in `ScopeTree::parent_ids`.
The snapshot change on `prefer-hooks-in-order` lint rule appears incidental - it doesn't alter what errors are reported, only the order they're reported in. This appears to be because it changes the order of keys in a hashmap keyed by `ScopeId` that [the rule uses](a49f4915de/crates/oxc_linter/src/rules/jest/prefer_hooks_in_order.rs (L143)
2024-07-26 00:14:50 +00:00
overlookmotel
348c1ade96
perf(semantic): remove span field from Reference ( #4464 )
...
Remove `span` field from `Reference`. Span can instead be got via looking up span on `AstKind` via `reference.node_id`.
This shrinks `Reference` from 20 bytes to 12 bytes.
It does make getting span of a `Reference` a bit slower, as there's an extra table lookup involved, but the only places this is needed is in linter, and almost always when generating a diagnostic (i.e. cold path).
2024-07-26 00:14:38 +00:00
overlookmotel
6a9f4db609
perf(semantic): reduce storage size for symbol redeclarations ( #4463 )
...
Most symbols don't have redeclarations.
So instead of storing `Vec<Span>` directly in `redeclare_variables` (24 bytes per symbol), store `Option<RedeclarationId>` (4 bytes).
`RedeclarationId` indexes into `redeclarations` where the actual `Vec<Span>` is stored. But for symbols with no redeclarations (the vast majority), it takes 4 bytes per symbol only.
2024-07-26 00:14:35 +00:00
overlookmotel
f17254ae2a
refactor(semantic): populate declarations field in SymbolTable::create_symbol ( #4461 )
...
`declarations` field of `SymbolTable` is part of SoA group, where all `Vec`s in the group are indexed by `SymbolId`. Populate `declarations` field along with the rest in `create_symbol`, to prevent them getting out of sync. This will prevent bugs like the one fixed in #4460 .
2024-07-26 00:14:32 +00:00
overlookmotel
a49f4915de
refactor(semantic): re-order SymbolTable fields ( #4459 )
...
Group the fields which are SoA indexed by `ScopeId` together.
2024-07-25 14:38:36 +00:00
Dunqing
e4ca06ae8c
fix(semantic): incorrect symbol’s scope_id after var hoisting ( #4458 )
...
Bug found in https://github.com/rolldown/rolldown/pull/1726
2024-07-25 21:12:26 +08:00
Dunqing
aaee07e170
feat(ast): add AstKind::AssignmentTargetPattern, AstKind::ArrayAssignmentTarget and AstKind::ObjectAssignmentTarget ( #4456 )
...
close : #4435
2024-07-25 09:32:33 +00:00
Don Isaac
77bd5f102c
fix(semantic): use correct span for namespace symbols ( #4448 )
...
Before:
```ts
namespace N {}
// ---------------
```
After:
```ts
namespace N {}
// -
```
Found while working on #4427
2024-07-25 09:43:06 +08:00
Dunqing
7cd53f3897
refactor(semantic): var hoisting ( #4379 )
...
close : #4323
This PR refactors the var hoisting logic to avoid inserting the same symbol into every scope that can be hosted.
2024-07-25 00:55:02 +00:00
DonIsaac
871b3d6135
docs(semantic): add doc comments for SymbolTester and SemanticTester ( #4433 )
2024-07-24 16:58:13 +00:00
DonIsaac
4f5a7cbf3c
refactor(semantic): mark SemanticTester and SymbolTester as must_use ( #4430 )
2024-07-24 16:58:11 +00:00
