overlookmotel
b57d5a5277
refactor(transformer/async-to-generator): remove unused &self function param ( #7166 )
...
Follow-on after stack up to #7148 . Remove unused `&self` function param. This makes calling this function slightly cheaper, as unused data doesn't get passed to the function.
2024-11-06 14:08:09 +00:00
overlookmotel
217d433eb8
refactor(transformer/arrow-functions): remove unused &mut self function param ( #7165 )
...
Follow-on after stack up to #7148 . Remove unused `&mut self` function params. This makes calling these functions slightly cheaper, as unused data doesn't get passed to the function.
2024-11-06 14:08:08 +00:00
overlookmotel
426df71c13
refactor(transformer/arrow-functions): use scope_id method ( #7164 )
...
Follow-on after #7125 . Use `scope_id` method introduced in #7127 .
2024-11-06 14:08:06 +00:00
overlookmotel
11c5e1209a
refactor(transformer/arrow-functions): correct comments ( #7163 )
...
Follow-on after #7113 . This comment was outdated after the changes in that PR.
2024-11-06 14:08:04 +00:00
overlookmotel
e2241e6376
refactor(transformer/jsx-self): remove unused &self function params ( #7159 )
...
Small nit. Removing the unused `&self` param makes these function calls slightly cheaper.
2024-11-06 13:11:31 +00:00
Boshen
0e1f12c303
refactor(transformer): remove unimplemented EnvOptions::bugfixes ( #7162 )
2024-11-06 12:54:10 +00:00
Boshen
a981cafd1f
refactor(transformer): add Engine enum for EngineTargets ( #7161 )
2024-11-06 12:40:31 +00:00
overlookmotel
fd9b44cf13
refactor(transformer/typescript): remove inactive #[allow(clippy::unused_self)] attr ( #7160 )
2024-11-06 12:16:08 +00:00
overlookmotel
1dfd241125
refactor(transformer/optional-catch-binding): remove inactive #[allow(clippy::unused_self)] attr ( #7158 )
2024-11-06 12:02:09 +00:00
Boshen
8c0a362b8b
refactor(linter): use ctx.source_range(comment.content_span()) API ( #7155 )
2024-11-06 06:25:05 +00:00
renovate
3da9443b0e
chore(deps): update dependency @types/node to v22.9.0 ( #7145 )
...
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@types/node](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node ) ([source](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node )) | [`22.8.4` -> `22.9.0`](https://renovatebot.com/diffs/npm/@types%2fnode/22.8.4/22.9.0 ) | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) |
---
### Configuration
📅 **Schedule**: Branch creation - "before 10am on monday" in timezone Asia/Shanghai, Automerge - At any time (no schedule defined).
🚦 **Automerge**: Enabled.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR was generated by [Mend Renovate](https://mend.io/renovate/ ). View the [repository job log](https://developer.mend.io/github/oxc-project/oxc ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xNDIuNyIsInVwZGF0ZWRJblZlciI6IjM4LjE0Mi43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
2024-11-06 06:17:36 +00:00
Dunqing
b2a888df0d
fix(transformer/async-generator-functions): incorrect transformation for for await if it's not placed in a block ( #7148 )
...
Found in https://github.com/oxc-project/monitor-oxc/actions/runs/11681867380/job/32527898715
2024-11-06 05:51:01 +00:00
Boshen
d1d187417b
feat(ast)!: change comment.span to real position that contain // and /* ( #7154 )
...
closes #7150
2024-11-06 05:10:33 +00:00
Dunqing
19892ede40
fix(transformer/async-generator-functions): transform incorrectly for for await if it's in LabeledStatement ( #7147 )
...
Found in https://github.com/oxc-project/monitor-oxc/actions/runs/11681867380/job/32527898715
2024-11-06 03:27:14 +00:00
Dunqing
8573f79c6d
feat(transformer): turn on async_to_generator and async_generator_functions plugins in enable_all ( #7135 )
2024-11-06 03:27:13 +00:00
Dunqing
ffa8604556
feat(transformer/async-to-generator): do not transform await expression if is not inside async function ( #7138 )
2024-11-06 03:27:13 +00:00
Dunqing
cd1006fec1
refactor(transformer/async-generator-functions): do not transform yield expression where inside generator function ( #7134 )
2024-11-06 03:27:13 +00:00
Dunqing
2c5734d49b
refactor(transformer/async-generator-functions): do not transform await expression where inside ArrowFunctionExpression ( #7132 )
...
The `await expr` should be transformed in AsyncToGenerator rather than AsyncGeneratorFunctions
2024-11-06 03:27:12 +00:00
Dunqing
5ce83bddc6
refactor(transformer/async-generator-functions): remove dead code for handle await expression ( #7131 )
...
I thought wrong previously, this should be transformed in the async-to-generator rather than async-generator-functions
2024-11-06 03:27:12 +00:00
Dunqing
b6a575009a
feat(transformer/arrow-function-converter): move scope to changed scope for this_var if scope have changed ( #7125 )
...
The scope can be moved or deleted, we need to check whether the scope id is the same as the container's scope id, if not, we need to move the `this_var` to the target scope id.
2024-11-06 03:02:36 +00:00
Dunqing
df772411ea
feat(transformer): enable ArrowFunctionConverter in async-to-generator and async-generator-functions plugins ( #7113 )
...
Part of https://github.com/oxc-project/oxc/pull/7074
In async-to-generator and async-generator-functions plugins, we may need to transform the async arrow function to a regular generator function, now we can reuse the ability of the ArrowFunction plugin by enabling `ArrowFunctionConverter`.
I will fix semantic errors in the follow-up PR
2024-11-06 03:02:36 +00:00
Boshen
0b32951637
chore(deps): update rust crate criterion2 to v2 ( #7144 )
2024-11-05 14:01:09 +00:00
Boshen
8340243543
refactor(transformer): rename Query to BrowserslistQuery ( #7143 )
2024-11-05 13:45:12 +00:00
Boshen
481f7e603e
refactor(transformer): change Targets to EngineTargets ( #7142 )
2024-11-05 13:32:11 +00:00
Boshen
55e6989830
refactor(transformer): deserialize engine target strings to specific keys ( #7139 )
2024-11-05 09:27:01 +00:00
Boshen
9aa34b4896
chore(transformer): remove unused core_js_compat data
2024-11-05 14:25:41 +08:00
Boshen
9386435efb
feat(transform_conformance): use node instead of bun for exec tests ( #7121 )
2024-11-05 14:20:48 +08:00
overlookmotel
fac5042afa
refactor(ast): use scope_id etc methods ( #7130 )
...
Utilize the methods added in #7127 in `oxc_ast`.
2024-11-05 02:25:28 +00:00
overlookmotel
cacfb9b326
refactor(traverse): use symbol_id etc methods ( #7129 )
...
Utilize the methods added in #7127 in `oxc_traverse`.
2024-11-05 02:25:28 +00:00
overlookmotel
fdfd9a4378
refactor(transformer): use scope_id etc methods ( #7128 )
...
Utilize the methods added in #7127 in transformer.
2024-11-05 02:25:27 +00:00
overlookmotel
cc8a1917e5
feat(ast): methods on AST nodes to get scope_id etc ( #7127 )
...
Add getter and setter methods to all AST types which have a `ScopeId`, `SymbolId` or `ReferenceId` field to get the contents of that field.
Before:
```rs
let symbol_id = ident.symbol_id.get().unwrap();
```
After:
```rs
let symbol_id = ident.symbol_id();
```
This allows removing boilerplate code from the transformer, and discouraging the anti-pattern of treating these fields as if they may contain either `Some` or `None` (after semantic, they will always be `Some`).
2024-11-05 02:25:27 +00:00
overlookmotel
843bce4d92
refactor(ast)!: IdentifierReference::reference_id return ReferenceId ( #7126 )
...
Alter `IdentifierReference::reference_id` to return `ReferenceId`, instead of `Option<ReferenceId>`.
This method is only useful on a post-semantic AST, where it will never return `None`. Returning `ReferenceId` discourages the anti-pattern of treating the result as if it could be either `Some` or `None`, and shortens code.
2024-11-05 02:25:27 +00:00
Dunqing
ff8bd50d38
refactor(transformer): move implementation of ArrowFunction to common/ArrowFunctionConverter ( #7107 )
...
Part of #7074
In order can reuse the ability of the `ArrowFunction` plugin, we moved out the implementation to common, then we can use use in other plugins
2024-11-04 16:32:50 +00:00
Dunqing
e04ee97870
refactor(transformer/async-generator-functions): move handling of MethodDefinition's value to exit_function ( #7106 )
...
Part of #7074
I have mentioned the reason why I need to move this in https://github.com/oxc-project/oxc/pull/7105
2024-11-04 16:27:21 +00:00
overlookmotel
ae692d70df
fix(transformer/async_to_generator): fix checking if function is class method ( #7117 )
...
Follow-on after #7105 .
Correctly identify when a function is a method definition. `ctx.parent().is_method_definition()` would return `true` for this weird case where the function is the property key of the method, not the method itself:
```js
class C {
[async function() {}]() {}
}
```
`matches!(ctx.parent(), Ancestor::MethodDefinitionValue(_))` only returns `true` if the function *is* a method definition. Of course, no-one would write such ridiculous code, but we may as well handle whatever is thrown at us.
It's also slightly more performant to check for one specific ancestor type, rather than:
c2802e63fc/crates/oxc_traverse/src/generated/ancestor.rs (L1319-L1326)
2024-11-04 15:46:12 +00:00
renovate[bot]
8e90790a60
chore(deps): update rust crates ( #7115 )
2024-11-04 23:34:51 +08:00
Boshen
fc6dc52b72
ci(clippy): install ast-grep via npm ( #7119 )
2024-11-04 23:34:06 +08:00
Boshen
c2802e63fc
feat(transform_conformance): add babel runtime to exec tests ( #7114 )
2024-11-04 14:38:15 +00:00
Dunqing
f80085c683
refactor(transformer/async-to-generator): move handling of MethodDefinition's value to exit_function ( #7105 )
...
Part of #7074
We need to handle this before the `arrow_function` plugin inserts `_this = this` because, in the `async-to-generator` plugin, we will move the body to an inner generator function. However, we don't want `_this = this` moved to the inner generator function as well. So as long as we move first, and then insert, we can fix this problem.
The new semantic error is related to another tricky problem, I will fix it in another PR
2024-11-04 14:32:42 +00:00
Boshen
50646a49ea
refactor(tasks/website): remove scraper dependency ( #7116 )
2024-11-04 14:16:11 +00:00
oxc-bot
12a6952782
release(crates): v0.35.0 ( #7110 )
...
## [0.35.0] - 2024-11-04
- f543a8d#7073 ) (overlookmotel)
- b8daab3#7020 )
(Boshen)
- 9a6a2f9#6955 ) (Boshen)
### Features
- 854870e#6987 ) (ottomated)
- ce5b609#6915 )
(ottomated)
- 9725e3c#6935 )
(ottomated)
- fbc297e#6934 ) (ottomated)
- 169fa22#6933 )
(ottomated)
- caa4b1f#7108 ) (Boshen)
- 001058a#7089 )
(Boshen)
- 413973d#7059 )
(Boshen)
- ee27b92#7058 ) (Boshen)
- 6516f9e#7054 ) (Boshen)
- 1e2f012#6751 ) (DonIsaac)
- 6d97af4#6938 ) (Boshen)
- bfdbcf1#7098 ) (Boshen)
- 21b8e49#7091 ) (Boshen)
- fcaba4a#7037 ) (Boshen)
- 1d906c6#7038 )
(overlookmotel)
- 934cb5e#6573 )
(Dunqing)
### Bug Fixes
- 0601271#6969 )
(tomoya yanagibashi)
- da199c7#6967 )
(camchenry)
- f5a7134#6907 ) (DonIsaac)
- 9ed9501#7103 )
(Boshen)
- d15e408#7012 ) (Boshen)
- dcdb9eacaaf00e#7016 )
(Boshen)
- b188b4a#7100 ) (Boshen)
- a2244ff#7052 ) (Dunqing)
- 7d12669#6909 )
(ottomated)
### Performance
- 6ca01b9#6921 ) (overlookmotel)
- c58ec89#7021 )
(overlookmotel)
- fa9a4ec#6979 ) (Boshen)
### Refactor
- b0211a1#7065 ) (overlookmotel)
- fc07458#6931 ) (overlookmotel)
- c41c013#6922 ) (overlookmotel)
- 335eb38#6972 ) (overlookmotel)
- 4cf0085#6926 )
(overlookmotel)
- dd79c1b#7064 ) (Boshen)
- 0bb1aa4#7053 ) (Boshen)
- b021147#7024 ) (overlookmotel)
- fb1710a#7023 ) (overlookmotel)
- f1fc8db#7022 )
(overlookmotel)
- cea0e6b#7071 ) (overlookmotel)
- 97caae1#7072 )
(overlookmotel)
- 2c7ac29#6912 )
(Boshen)
- 9926990#6930 )
(overlookmotel)
- 23157bd#6929 )
(overlookmotel)
- 953b051#7109 ) (Boshen)
- fdd480d#7068 )
(overlookmotel)
- 9e85b10#7063 ) (overlookmotel)
- 17a938e#7018 )
(Boshen)
- aa1b29c#7017 ) (Boshen)
- 7f1d1fe#7051 )
(Boshen)
- 76947e2#7026 ) (Boshen)
- d03e622#7070 )
(overlookmotel)
- 9d384ad#7056 ) (overlookmotel)
- 4688a06#7055 ) (overlookmotel)
- 7122e00#7066 ) (overlookmotel)
- a3b68b4#7049 ) (Boshen)
- 6d92f36#7048 ) (Boshen)
- f83a760#7047 )
(Boshen)
- 52c20d6#7045 )
(Boshen)
- e921df6#7036 )
(Boshen)
- af5140f#7034 ) (Boshen)
- 12aa910#7033 ) (Boshen)
- 3d174bb#7029 ) (Boshen)
- 6284f84#7028 ) (Boshen)
- 5b11cdf#7005 ) (Boshen)
- f0c87d4#7004 )
(Boshen)
- d9edef6#7002 ) (Boshen)
- c945fe7#6999 )
(overlookmotel)
- fc1af2e#6998 )
(overlookmotel)
- 63e8bfe#6997 )
(overlookmotel)
- 562bb9a#6992 ) (Dunqing)
- e23f7e6#7043 ) (overlookmotel)
- e5ecbb9#7001 ) (overlookmotel)
- 9e66c29#6973 )
(overlookmotel)
- 1ca8cd2#6937 ) (Dunqing)
- 5f153ac#6884 ) (Dunqing)
- df3b089#6881 ) (Dunqing)
- ae22671#7000 ) (overlookmotel)
- 938ee87#7069 )
(overlookmotel)
### Styling
- 86ab091#7042 ) (overlookmotel)
### Testing
- 64e2499#7097 ) (Boshen)
- 6133a50#7099 ) (Boshen)
---------
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-11-04 17:40:05 +08:00
Boshen
40d8acfbd1
feat(codegen): improvement printing of legal comments ( #7111 )
2024-11-04 08:56:00 +00:00
Boshen
03a30856c4
chore(transformer): disable snapshot test in miri
2024-11-04 16:54:52 +08:00
Boshen
953b0516e8
refactor(parser): remove oxc_ecmascript crate ( #7109 )
2024-11-04 16:29:26 +08:00
Boshen
caa4b1fd2a
feat(codegen): improve printing of comments ( #7108 )
2024-11-04 05:12:59 +00:00
tbashiyy
b73cfd992e
fix(linter): fix is_method_call with parentheses and chain expression ( #7095 )
...
I fixed `is_method_call` behavior in specific case below.
For example, when we use `is_method_call(call_expr, None,
Some(&["apply"]), Some(1), Some(1))` for
[`(a?.b.apply)(args)`](https://playground.oxc.rs/#eNpFjkEKg0AMRe+SVQviAdx057alN4gaZWBMJJmxFfHunVG0q+Qnn//fCi1UcMNH2ZQ4TX6531AHu0MBAtUKGjkPWzjgF6qgkQrwjsO5WysTXWIZG/GnCopsvegIVY/eaCtgQjXSnIjey+dNISo/YzDXUR25DU5S3+5OZqVknumFSmxHasrI7XtG2q+K89BKRwNl5iRGx653/xcHFV+n3gwwkzZiCf1g27YfdH1fTA== ),
we cannot check correctly.
This is because we don't consider `call_expr` has parentheses and chain
expression.
2024-11-04 11:12:37 +08:00
overlookmotel
25d7554ec4
refactor(ast_tools): rename visitable to is_visitable ( #7104 )
...
Pure refactor. Just rename fields and vars from `visitable` to `is_visitable`, to be more descriptive.
2024-11-03 17:20:25 +00:00
Boshen
9ed9501bcd
fix(module_lexer): add missing export * from 'foo'; case ( #7103 )
...
fixes #7039
2024-11-03 16:31:19 +00:00
Boshen
9f611a18cf
chore(transformer): fix typos s/browerslist/browserslist/
2024-11-03 21:54:54 +08:00
Boshen
b8104a2dc4
chore : bump oxc-miette to v1.0.2
2024-11-03 21:06:43 +08:00
