overlookmotel
9e5be78af5
refactor(parser): add Lexer::consume_2_chars ( #4569 )
...
Add `Lexer::consume_2_chars` to replace `lexer.consume_char(); lexer.consume_char();`. Mostly this is just neater code, but *may* also help compiler to elide bounds checks when it's preceded by `lexer.peek_2_bytes()`.
2024-07-31 00:28:58 +00:00
overlookmotel
649913e6cd
refactor(parser): extract u8 not &u8 when iterating over bytes ( #4568 )
...
Iterating over `str.as_bytes()` produces `&u8`s. Dereference to `u8` in `for` statement. Should make no difference to generated assembly, purely making this change for neater code style.
2024-07-31 00:28:57 +00:00
overlookmotel
59f00c0a44
refactor(parser): rename function ( #4566 )
...
Rename `matches_number_char` function to `matches_number_byte` as it takes a `u8` byte, not a `char`.
2024-07-31 00:28:55 +00:00
overlookmotel
8e3e9104e5
refactor(parser): rename vars ( #4565 )
...
Use `b` everywhere in lexer for a `u8` byte, keeping the name `c` for a vars containing a `char`.
2024-07-31 00:28:53 +00:00
overlookmotel
0c0601f9a4
refactor(parser): rename function ( #4564 )
...
Rename `Lexer::next_ascii_char_eq` to `next_ascii_byte_eq`, for consistency with other method names which operate on bytes.
2024-07-31 00:28:51 +00:00
overlookmotel
0acc4a726e
refactor(parser): fetch 2 bytes in ? byte handler ( #4563 )
...
Lexer's `?` byte handler needs to fetch next 2 bytes, so do that in one shot, rather than bounds-checking twice.
2024-07-31 00:28:50 +00:00
overlookmotel
565eccf631
refactor(parser): shorten lexer code ( #4562 )
...
Use `lexer.peek_byte()` instead of `lexer.source.peek_byte()`.
2024-07-31 00:28:48 +00:00
overlookmotel
ab8509edaa
perf(parser): use - not saturating_sub ( #4561 )
...
Follow-on after #4304 . Avoid using `saturating_sub` when plain `-` will do. `-` is cheaper - it's a single assembly instruction, whereas `saturating_sub` is usually 3 instructions.
https://godbolt.org/z/fo8Tcx6bK
2024-07-31 00:28:46 +00:00
lucab
c9c38a187c
perf(parser): support peeking over bytes ( #4304 )
...
Closes https://github.com/oxc-project/oxc/issues/3291
2024-07-30 17:53:13 +00:00
DonIsaac
d5c4b190aa
fix(parser): fix enum member parsing ( #4543 )
...
Closes #4449
2024-07-30 10:43:09 +00:00
lucab
0870ee1f9f
perf(parser): get and check lookahead token ( #4534 )
2024-07-29 16:45:39 +00:00
overlookmotel
148bdb5585
refactor(parser): adjust function inlining ( #4530 )
...
These 2 `#[inline(always)]` were introduced by accident by me just playing around in #4298 . One should be kept, but the other one we should leave to compiler to decide.
2024-07-29 15:38:02 +00:00
Boshen
7446e986c3
feat(codegen): align more esbuild implementations ( #4510 )
2024-07-28 13:35:37 +00:00
Boshen
35654e665c
feat(codegen): align operator precedence with esbuild ( #4509 )
...
closes #4339
2024-07-28 11:48:51 +00:00
oxc-bot
80118cbf3b
Release crates v0.22.1 ( #4508 )
...
## [0.22.1] - 2024-07-27
### Features
- 2477330#4501 ) (Dunqing)
- aaee07e#4456 ) (Dunqing)
- fd363d1#4450 ) (DonIsaac)
- e2735ca#4491 ) (DonIsaac)
### Bug Fixes
- 368112c#4497 )
(Dunqing)
- 36bb680#4502 ) (Dunqing)
- cb2fa49#4500 ) (Dunqing)
- ef0e953#4499 ) (Dunqing)
- 40cafb8#4480 ) (Dunqing)
- 2e01a45#4493 ) (Don Isaac)
- e4ca06a#4458 ) (Dunqing)
- 77bd5f1#4448 ) (Don
Isaac)
- 5db7bed#4490 ) (overlookmotel)
- 1667491#4484 ) (Ethan Goh)
- 82ba2a0#4466 )
(overlookmotel)
- c04b9aa#4460 ) (overlookmotel)
- ecdee88#4507 ) (Dunqing)
### Performance
- 963a2d1#4498 ) (Dunqing)
- 868fc87#4298 )
(lucab)
- 24beaeb#4469 ) (overlookmotel)
- 348c1ad#4464 )
(overlookmotel)
- 6a9f4db#4463 ) (overlookmotel)
- 705e19f#4489 )
(overlookmotel)
- 4d10c6c#4476 )
(Brooooooklyn)
### Documentation
- f5f0ba8#4413 ) (Don Isaac)
- 871b3d6#4433 ) (DonIsaac)
### Refactor
- 9c5d2f9#4428 )
(overlookmotel)
- ccb1835#4470 )
(overlookmotel)
- f17254a#4461 ) (overlookmotel)
- a49f491#4459 )
(overlookmotel)
- 7cd53f3#4379 ) (Dunqing)
- 4f5a7cb#4430 ) (DonIsaac)
- c958a55#4486 )
(overlookmotel)
- c99b3eb#4468 ) (overlookmotel)
- 96fc94f#4467 ) (overlookmotel)
### Testing
- 4b274a8#4429 )
(DonIsaac)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-07-28 09:58:29 +08:00
lucab
868fc87885
perf(parser): optimize conditional advance on ASCII values ( #4298 )
...
Part of https://github.com/oxc-project/oxc/issues/3291 .
2024-07-27 01:17:25 +00:00
oxc-bot
aa56eb4d1d
Release crates v0.22.0 ( #4434 )
...
## [0.22.0] - 2024-07-23
- 85a7cea#4329 )
(Dunqing)
- f68b659#4364 ) (Dunqing)
### Features
- d345b84#4309 )
(rzvxa)
- 3c0c709#4357 )
(Jaden Rodriguez)
- 68efcd4#4396 ) (DonIsaac)
- 0deb027#4407 )
(Boshen)
- e33ec18#4412 ) (Boshen)- 6068e6b#4334 ) (DonIsaac)
### Bug Fixes
- aece1df#4368 )
(overlookmotel)
- 44a10c4#4391 ) (Boshen)
- 3d88f20#4374 )
(Boshen)
- e624dff#4350 ) (Boshen)
- ac08de8#4395 ) (DonIsaac)
- 267f7c4#4409 ) (Boshen)
- bc8d4e5#4410 ) (overlookmotel)
- 6ffce86#4366 ) (Dunqing)
- 4cd5df0#4348 ) (underfin)
- f8565ae#4351 ) (Dunqing)- ea33f94#4352 ) (DonIsaac)
### Performance
- 1b51511#4401 ) (Dunqing)
- 40f9356#4367 ) (Dunqing)
- da13d93#4390 ) (overlookmotel)
- e70c67b#4384 )
(overlookmotel)
- 402006f#4383 ) (overlookmotel)
- 7469e01#4361 )
(overlookmotel)
- 7eb2864#4356 )
(overlookmotel)- a207923#4377 ) (DonIsaac)
### Refactor
- 504daed#4431 )
(overlookmotel)
- d213773#4376 )
(overlookmotel)
- abfccbd#4375 )
(overlookmotel)
- 5f1c7ec#4289 )
(rzvxa)
- 58f6ec2#4347 ) (Dunqing)
- 59aea73#4346 )
(Dunqing)
- 7a3e925#4371 ) (rzvxa)
- 0e1ea90#4420 )
(Dunqing)
- 7a75e0f#4349 ) (DonIsaac)
- a2eabe1#4335 ) (DonIsaac)
- 5d77b36#4370 )
(overlookmotel)
- f7b9ada#4369 )
(overlookmotel)
- 729b288#4358 ) (overlookmotel)
- 21d0eee#4336 )
(DonIsaac)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-07-24 08:23:27 +08:00
Dunqing
426016d1d6
Revert "Release crates v0.22.0" ( #4418 )
...
Still release failed. Reverts oxc-project/oxc#4417
2024-07-23 15:51:01 +08:00
github-actions[bot]
f76113cd8f
Release crates v0.22.0 ( #4417 )
...
## [0.22.0] - 2024-07-23
- 85a7cea#4329 )
(Dunqing)
- f68b659#4364 ) (Dunqing)
### Features
- d345b84#4309 )
(rzvxa)
- 3c0c709#4357 )
(Jaden Rodriguez)
- 68efcd4#4396 ) (DonIsaac)
- 0deb027#4407 )
(Boshen)
- e33ec18#4412 ) (Boshen)- 6068e6b#4334 ) (DonIsaac)
### Bug Fixes
- aece1df#4368 )
(overlookmotel)
- 44a10c4#4391 ) (Boshen)
- 3d88f20#4374 )
(Boshen)
- e624dff#4350 ) (Boshen)
- ac08de8#4395 ) (DonIsaac)
- 267f7c4#4409 ) (Boshen)
- bc8d4e5#4410 ) (overlookmotel)
- 6ffce86#4366 ) (Dunqing)
- 4cd5df0#4348 ) (underfin)
- f8565ae#4351 ) (Dunqing)- ea33f94#4352 ) (DonIsaac)
### Performance
- 1b51511#4401 ) (Dunqing)
- 40f9356#4367 ) (Dunqing)
- da13d93#4390 ) (overlookmotel)
- e70c67b#4384 )
(overlookmotel)
- 402006f#4383 ) (overlookmotel)
- 7469e01#4361 )
(overlookmotel)
- 7eb2864#4356 )
(overlookmotel)- a207923#4377 ) (DonIsaac)
### Refactor
- d213773#4376 )
(overlookmotel)
- abfccbd#4375 )
(overlookmotel)
- 5f1c7ec#4289 )
(rzvxa)
- 58f6ec2#4347 ) (Dunqing)
- 59aea73#4346 )
(Dunqing)
- 7a3e925#4371 ) (rzvxa)
- 7a75e0f#4349 ) (DonIsaac)
- a2eabe1#4335 ) (DonIsaac)
- 5d77b36#4370 )
(overlookmotel)
- f7b9ada#4369 )
(overlookmotel)
- 729b288#4358 ) (overlookmotel)
- 21d0eee#4336 )
(DonIsaac)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-23 13:24:08 +08:00
Dunqing
c1cf0e6dd9
Revert "Release crates v0.22.0" ( #4415 )
...
Reverts oxc-project/oxc#4414
2024-07-23 09:59:38 +08:00
github-actions[bot]
00c7b7dad4
Release crates v0.22.0 ( #4414 )
...
## [0.22.0] - 2024-07-22
- 85a7cea#4329 )
(Dunqing)
- f68b659#4364 ) (Dunqing)
### Features
- d345b84#4309 )
(rzvxa)
- 3c0c709#4357 )
(Jaden Rodriguez)
- 0deb027#4407 )
(Boshen)
- e33ec18#4412 ) (Boshen)- 6068e6b#4334 ) (DonIsaac)
### Bug Fixes
- aece1df#4368 )
(overlookmotel)
- 44a10c4#4391 ) (Boshen)
- 3d88f20#4374 )
(Boshen)
- e624dff#4350 ) (Boshen)
- 267f7c4#4409 ) (Boshen)
- bc8d4e5#4410 ) (overlookmotel)
- 6ffce86#4366 ) (Dunqing)
- 4cd5df0#4348 ) (underfin)
- f8565ae#4351 ) (Dunqing)- ea33f94#4352 ) (DonIsaac)
### Performance
- 1b51511#4401 ) (Dunqing)
- 40f9356#4367 ) (Dunqing)
- da13d93#4390 ) (overlookmotel)
- e70c67b#4384 )
(overlookmotel)
- 402006f#4383 ) (overlookmotel)
- 7469e01#4361 )
(overlookmotel)
- 7eb2864#4356 )
(overlookmotel)- a207923#4377 ) (DonIsaac)
### Refactor
- d213773#4376 )
(overlookmotel)
- abfccbd#4375 )
(overlookmotel)
- 5f1c7ec#4289 )
(rzvxa)
- 58f6ec2#4347 ) (Dunqing)
- 59aea73#4346 )
(Dunqing)
- 7a3e925#4371 ) (rzvxa)
- 7a75e0f#4349 ) (DonIsaac)
- a2eabe1#4335 ) (DonIsaac)
- 5d77b36#4370 )
(overlookmotel)
- f7b9ada#4369 )
(overlookmotel)
- 729b288#4358 ) (overlookmotel)
- 21d0eee#4336 )
(DonIsaac)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-23 09:38:03 +08:00
overlookmotel
aece1df561
fix(ast): visit Programs hashbang field first ( #4368 )
...
Visit `hashbang` before `directives` for `Program`.
2024-07-19 16:27:51 +00:00
Dunqing
f68b659713
refactor(ast)!: reorder fields of ArrowFunctionExpression ( #4364 )
...
Found in #4328
Same as #4248
2024-07-19 14:12:05 +00:00
DonIsaac
a2eabe1f4b
refactor(parser): use error codes for ts diagnostics ( #4335 )
...
Part of #4333
2024-07-18 16:09:25 +00:00
github-actions[bot]
7d751898b3
Release crates v0.21.0 ( #4344 )
...
## [0.21.0] - 2024-07-18
- d7ab0b8#4226 )
(lucab)
### Features
- af4dc01#4253 ) (Dunqing)
- 83c2c62#4219 ) (Boshen)
- 5d17675#4314 ) (Boshen)
- e3e663b#4197 )
(Boshen)
- c818472#4190 )
(Boshen)
- 8a190eb20cdb1f#4195 ) (Dunqing)
- 92ee774#4205 ) (Dunqing)
- 205c259#4220 )
(underfin)
- 7eb960d#4235 ) (Boshen)
### Bug Fixes
- bf3d8d3#4290 ) (Boshen)
- 084ab76e167ef7#4245 ) (Boshen)
- c65198f#4236 ) (Boshen)
- be82c28#4231 ) (Boshen)
- 3df9e69#4319 ) (Boshen)
- f144082#4268 ) (underfin)
- 66b455a#4230 ) (IWANABETHATGUY)
- 9a87e41#4267 )
(lucab)
- 641a78b#4254 ) (overlookmotel)
- 9badac0#4337 ) (Dunqing)
- 95e15b6#4320 ) (Dunqing)
- c362bf7#4311 ) (Dunqing)
- 351ecf2#4310 ) (Dunqing)
- 1108f2a#4280 )
(Dunqing)
- 22d56bd#4241 ) (overlookmotel)- 1c117eb#4199 ) (IWANABETHATGUY)
### Performance
- a8dc4f3#4259 )
(overlookmotel)
- b94540d#4258 )
(overlookmotel)
- a7b328c#4257 ) (overlookmotel)
- f9d3f2e#4272 ) (overlookmotel)
- 8fad7db#4264 ) (overlookmotel)
- 23743db#4263 ) (overlookmotel)
- da69076#4262 )
(overlookmotel)
- cb15303#4216 ) (overlookmotel)
- ef4c1f4#4214 ) (overlookmotel)
- f23e54f#4213 )
(overlookmotel)
- 2602ce2#4206 )
(lucab)
### Refactor
- 2c7bb9f#4283 )
(overlookmotel)
- 3e099fe#4246 ) (Dunqing)
- aab7aaa#4203 )
(rzvxa)
- d1c4be006197b8aa22073#4196 ) (Boshen)
- c5731a5#4286 )
(overlookmotel)
- 16698bc#4278 ) (overlookmotel)
- ee16668#4277 ) (overlookmotel)
- 25f0771#4275 )
(overlookmotel)
- 639fd48#4274 )
(overlookmotel)
- c418bf5#4265 ) (Dunqing)
- ace4f1f#4248 ) (Dunqing)
- 8bfeabf#4249 )
(Dunqing)
- dc2b3c4#4156 ) (Dunqing)
- 81ed588#4208 ) (lucab)
- bbe5ded#4193 ) (Dunqing)
- 7f1addd#4192 ) (Dunqing)
- fc0b17d#4308 ) (rzvxa)
- a197e01#4321 )
(Dunqing)
- 1458d81#4330 )
(overlookmotel)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-18 14:39:07 +08:00
Dunqing
fc39ffa009
Revert "Release crates v0.21.0" ( #4342 )
...
Reverts oxc-project/oxc#4338
https://github.com/oxc-project/oxc/actions/runs/9986290706/job/27598542089
Release failed
2024-07-18 14:11:42 +08:00
github-actions[bot]
0abcf499b7
Release crates v0.21.0 ( #4338 )
...
## [0.21.0] - 2024-07-18
- d7ab0b8#4226 )
(lucab)
### Features
- af4dc01#4253 ) (Dunqing)
- 83c2c62#4219 ) (Boshen)
- 5d17675#4314 ) (Boshen)
- e3e663b#4197 )
(Boshen)
- c818472#4190 )
(Boshen)
- 8a190eb20cdb1f#4195 ) (Dunqing)
- 92ee774#4205 ) (Dunqing)
- 205c259#4220 )
(underfin)
- 7eb960d#4235 ) (Boshen)
### Bug Fixes
- bf3d8d3#4290 ) (Boshen)
- 084ab76e167ef7#4245 ) (Boshen)
- c65198f#4236 ) (Boshen)
- be82c28#4231 ) (Boshen)
- 3df9e69#4319 ) (Boshen)
- f144082#4268 ) (underfin)
- 66b455a#4230 ) (IWANABETHATGUY)
- 9a87e41#4267 )
(lucab)
- 641a78b#4254 ) (overlookmotel)
- 9badac0#4337 ) (Dunqing)
- 95e15b6#4320 ) (Dunqing)
- c362bf7#4311 ) (Dunqing)
- 351ecf2#4310 ) (Dunqing)
- 1108f2a#4280 )
(Dunqing)
- 22d56bd#4241 ) (overlookmotel)- 1c117eb#4199 ) (IWANABETHATGUY)
### Performance
- a8dc4f3#4259 )
(overlookmotel)
- b94540d#4258 )
(overlookmotel)
- a7b328c#4257 ) (overlookmotel)
- f9d3f2e#4272 ) (overlookmotel)
- 8fad7db#4264 ) (overlookmotel)
- 23743db#4263 ) (overlookmotel)
- da69076#4262 )
(overlookmotel)
- cb15303#4216 ) (overlookmotel)
- ef4c1f4#4214 ) (overlookmotel)
- f23e54f#4213 )
(overlookmotel)
- 2602ce2#4206 )
(lucab)
### Refactor
- 2c7bb9f#4283 )
(overlookmotel)
- 3e099fe#4246 ) (Dunqing)
- aab7aaa#4203 )
(rzvxa)
- d1c4be006197b8aa22073#4196 ) (Boshen)
- c5731a5#4286 )
(overlookmotel)
- 16698bc#4278 ) (overlookmotel)
- ee16668#4277 ) (overlookmotel)
- 25f0771#4275 )
(overlookmotel)
- 639fd48#4274 )
(overlookmotel)
- c418bf5#4265 ) (Dunqing)
- ace4f1f#4248 ) (Dunqing)
- 8bfeabf#4249 )
(Dunqing)
- dc2b3c4#4156 ) (Dunqing)
- 81ed588#4208 ) (lucab)
- bbe5ded#4193 ) (Dunqing)
- 7f1addd#4192 ) (Dunqing)
- fc0b17d#4308 ) (rzvxa)
- a197e01#4321 )
(Dunqing)
- 1458d81#4330 )
(overlookmotel)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-18 13:56:35 +08:00
overlookmotel
2c7bb9f6c8
refactor(ast): pass final ScopeFlags into visit_function ( #4283 )
...
We have a strange workaround for `visit_function` where we pass in `ScopeFlags`, to support creating the scope inside `Function`, but setting different flags for `MethodDefinition`s.
Previously `visit_function` took `Option<ScopeFlags>` and then did `flags.unwrap_or(ScopeFlags::empty()) | ScopeFlags::Function` to it. Personally, I found this confusing. When I was looking at `MethodDefinition`, I was wondering "It's a function, why doesn't it set Function flag too?"
This changes makes it more explicit and clear what `ScopeFlags` everything has.
2024-07-16 07:22:07 +00:00
lucab
9a87e41332
fix(parser): avoid crashing on invalid const modifier ( #4267 )
...
Followup on https://github.com/oxc-project/oxc/pull/3977 , fixing one of the crashes at https://github.com/oxc-project/oxc/pull/3977 .
2024-07-15 11:37:31 +00:00
overlookmotel
a8dc4f34b2
perf(parser): speed up parsing numbers with _ separators ( #4259 )
...
When parsing a number which contains `_` separators, rather than looping
through the string once to remove separators, and then again to convert
to an `f64`, do it all in a single loop.
Co-authored-by: overlookmotel <557937+overlookmotel@users.noreply.github.com>
2024-07-15 12:27:47 +08:00
overlookmotel
b94540d0fb
perf(parser): speed up parsing octal literals ( #4258 )
...
Micro-optimization to parsing octal numbers. This removes usage of `char`, so removes a surprising amount of instructions.
2024-07-15 03:42:47 +00:00
overlookmotel
a7b328c4f5
perf(parser): faster parsing decimal numbers ( #4257 )
...
Closes #3288 .
Speed up parsing decimal literals (e.g. `123`), using same techniques as `parse_octal` etc.
2024-07-15 03:38:09 +00:00
Boshen
a71787572e
chore: remove unsafe_code = "warn" rust lint
...
Feels too verbose as we already have unsafe comment turned on
2024-07-15 10:39:08 +08:00
overlookmotel
641a78bc2b
fix(parser): fix tests for number parsing ( #4254 )
...
Fix tests for parsing large numbers.
* Tests for imprecision decimals and octals weren't using numbers larger than `u64::MAX`, so were not testing what they were meant to be - that parser can handle larger numbers.
* Tests for decimals (e.g. `123.5`) were calling `parse_int` which isn't meant to handle that (`parse_float` does that).
* Tests were calling `parse_int` with negative numbers, which it's not meant to handle.
Also, re-order the const assertions in same order as the code above.
2024-07-15 01:26:13 +00:00
Dunqing
ace4f1ff77
refactor(semantic): update the order of visit_function and Visit fields in the builder to be consistent ( #4248 )
...
Same as #4195
2024-07-14 11:39:15 +00:00
Dunqing
20cdb1fe0a
feat(semantic): align class scope with typescript ( #4195 )
...
```ts
class Klass <T> extends Root <R> {}
// ^^^^^ ^^^ ^^^^ ^^^ ^^
// id type_paramter super_class super_type_parameters body
```
I reorder fields according to the order above
The class scope is not defined in the spec. But we need to create a scope for `class` to store `TypeParamters`
2024-07-14 03:19:30 +00:00
github-actions[bot]
2a169d1969
Release crates v0.20.0 ( #4189 )
...
## [0.20.0] - 2024-07-11
- 5731e39#4132 ) (Luca Bruno)
### Features
- 67fe75e#4168 ) (rzvxa)
- 54cd04a#4160 ) (Boshen)
- 44a894a#4155 ) (Boshen)
- 725571a#4133 ) (Boshen)
### Bug Fixes
- 48947a2#4143 ) (rzvxa)
- 7a059ab#4177 ) (rzvxa)
- 4a656c3#4072 ) (DonIsaac)
- 28eeee0#4163 ) (Boshen)
### Performance
- ddfa343#4175 )
(DonIsaac)
- 2203143#4162 ) (lucab)
- fca9706#4140 ) (Boshen)
### Documentation
- bdcc298#4149 ) (rzvxa)
### Refactor
- 03ad1e3#4157 ) (lucab)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-11 11:05:49 +08:00
DonIsaac
4a656c3a18
fix(lexer): incorrect lexing of large hex/octal/binary literals ( #4072 )
...
Closes #3347 . Implementation follows the approach described by @overlookmotel [here](https://github.com/oxc-project/oxc/issues/3347#issuecomment-2119004288 ).
2024-07-10 16:39:10 +00:00
Boshen
28eeee0f71
fix(parser): fix asi error diagnostic pointing at invalid text causing crash ( #4163 )
2024-07-10 14:45:10 +00:00
rzvxa
48947a26d2
fix(ast): put decorators before everything else. ( #4143 )
...
Won't fix #4142
It is similar to #3994 but for those types that weren't relying on this order. It seems to be the right order.
technically speaking it is a breaking change but I know as a fact that it won't have a big difference on our downstream. If you want it to be chronically correct feel free to merge as a breaking change.
2024-07-10 02:03:05 +00:00
Luca Bruno
5731e3957f
refactor(ast)!: store span details inside comment struct ( #4132 )
...
This tweaks `Comment` definition in order to internally store the start
and end position of its span.
Closes: https://github.com/oxc-project/oxc/issues/4069
2024-07-09 23:23:43 +08:00
github-actions[bot]
714bf1dd7f
Release crates v0.19.0 ( #4137 )
...
## [0.19.0] - 2024-07-09
- b936162#4122 ) (rzvxa)
### Features
- 485c871#4124 ) (rzvxa)
### Refactor
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-09 20:32:06 +08:00
rzvxa
b936162093
refactor(ast/ast_builder)!: shorter allocator utility method names. ( #4122 )
...
This PR serves two purposes, First off it would lower the amount of characters we have to type in for a simple operation such as wrapping an expression in a vector. Secondly, it would follow the generated names more closely since nowhere else in the builder we do have `new_xxx`, We always say `xxx` since a builder always constructs something.
```
new_vec -> vec
new_vec_single -> vec1*
new_vec_from_iter -> vec_from_iter
new_vec_with_capacity -> vec_with_capacity
new_str -> str
new_atom -> atom
```
`*` This one is the main motivation behind this PR, It saves 10 characters!
2024-07-09 12:16:38 +00:00
github-actions[bot]
e29cdbfe40
Release crates v0.18.0 ( #4136 )
...
## [0.18.0] - 2024-07-09
- d347aed#3890 ) (rzvxa)
### Features
- c6c16a5#4135 ) (Boshen)
- 365d9ba#4119 ) (IWANABETHATGUY)
- 3a0f2aa#4126 ) (DonIsaac)
- 2f53bdf#4127 ) (DonIsaac)
- c4ee9f8#4125 ) (Don Isaac)
- 44c7fe3#4090 ) (rzvxa)
### Bug Fixes
- cb1af04#4130 ) (Dunqing)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-09 19:56:10 +08:00
DonIsaac
3a0f2aa7ef
feat(parser): check for illegal modifiers in modules and namespaces ( #4126 )
2024-07-09 02:54:06 +00:00
rzvxa
d347aedfda
feat(ast)!: generate ast_builder.rs. ( #3890 )
...
### Every structure has 2 builder methods:
1. `xxx` e.g. `block_statement`
```rust
#[inline]
pub fn block_statement(self, span: Span, body: Vec<'a, Statement<'a>>) -> BlockStatement<'a> {
BlockStatement { span, body, scope_id: Default::default() }
}
```
2. `alloc_xxx` e.g. `alloc_block_statement`
```rust
#[inline]
pub fn alloc_block_statement(
self,
span: Span,
body: Vec<'a, Statement<'a>>,
) -> Box<'a, BlockStatement<'a>> {
self.block_statement(span, body).into_in(self.allocator)
}
```
### We generate 3 types of methods for enums:
1. `yyy_xxx` e.g. `statement_block`
```rust
#[inline]
pub fn statement_block(self, span: Span, body: Vec<'a, Statement<'a>>) -> Statement<'a> {
Statement::BlockStatement(self.alloc(self.block_statement(span, body)))
}
```
2. `yyy_from_xxx` e.g. `statement_from_block`
```rust
#[inline]
pub fn statement_from_block<T>(self, inner: T) -> Statement<'a>
where
T: IntoIn<'a, Box<'a, BlockStatement<'a>>>,
{
Statement::BlockStatement(inner.into_in(self.allocator))
}
```
3. `yyy_xxx` where `xxx` is inherited e.g. `statement_declaration`
```rust
#[inline]
pub fn statement_declaration(self, inner: Declaration<'a>) -> Statement<'a> {
Statement::from(inner)
}
```
------------
### Generic parameters:
We no longer accept `Box<'a, ADT>`, `Atom` or `&'a str`, Instead we use `IntoIn<'a, Box<'a, ADT>>`, `IntoIn<'a, Atom<'a>>` and `IntoIn<'a, &'a str>` respectively.
It allows us to rewrite things like this:
```rust
let ident = IdentifierReference::new(SPAN, Atom::from("require"));
let number_literal_expr = self.ast.expression_numeric_literal(
right_expr.span(),
num,
raw,
self.ast.new_str(num.to_string().as_str()),
NumberBase::Decimal,
);
```
As this:
```rust
let ident = IdentifierReference::new(SPAN, "require");
let number_literal_expr = self.ast.expression_numeric_literal(
right_expr.span(),
num,
raw,
num.to_string(),
NumberBase::Decimal,
);
```
2024-07-09 00:57:26 +00:00
github-actions[bot]
c3f08ce8e0
Release crates v0.17.2 ( #4115 )
...
## [0.17.2] - 2024-07-08
### Features
- 115ac3b#4088 )
(rzvxa)
- 720983a#4113 ) (Boshen)
- e386b62#4097 )
(DonIsaac)
### Bug Fixes
- 5472b7c5c31236#4106 ) (Dunqing)
- e67c7d1#4105 ) (Dunqing)
- 3fcad5e#4077 ) (michaelm)
- f8d77e4#4068 ) (michaelm)
- 0f02608#4100 ) (Don
Isaac)
- 4413e2d#4103 ) (Don Isaac)
### Performance
- 7ed27b7#4074 ) (Dunqing)
- 9114c8e#4107 )
(Luca Bruno)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-08 19:16:33 +08:00
github-actions[bot]
51d56d37ff
Release crates v0.17.1 ( #4075 )
...
## [0.17.1] - 2024-07-06
### Bug Fixes
- aa585d3#4061 ) (rzvxa)
- 564a75a#4063 ) (michaelm)
- adee728#4065 )
(michaelm)
- 1b8f208#4064 ) (michaelm)
- 719fb96#4073 ) (Boshen)
- 150f4d97fe2a2f#4067 ) (overlookmotel)
### Refactor
- 8fa98e0#4066 )
(overlookmotel)
- 65aee19#4070 ) (Luca
Bruno)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-07 01:29:52 +08:00
overlookmotel
7fe2a2f681
perf(parser): do not copy comments ( #4067 )
...
Follow-on from #4045 . `.from_iter()` copies the `Vec` of comments into another `Vec` before converting to a boxed slice. This copy is unnecessary - just convert direct.
2024-07-06 09:56:41 +00:00
github-actions[bot]
224f5ef2cc
Release crates v0.17.0 ( #4059 )
...
## [0.17.0] - 2024-07-05
- e32b4bc#4045 ) (Luca Bruno)
- 1df6ac0#4000 ) (rzvxa)
- 4a0eaa0#3998 ) (rzvxa)
- c98d8aa#3995 ) (rzvxa)
### Features
- 1854a52#4012 ) (rzvxa)
- 7538af1#3954 ) (rzvxa)
- 7768d23#4035 )
(Egor Blinov)
- 0da9dfb#4058 )
(Boshen)
### Bug Fixes
- aaac2d8#4055 ) (Boshen)
- 5e5b1b1#4042 ) (Egor Blinov)
- 7844734#4022 )
(Dunqing)
- 6254a41#4021 )
(Dunqing)
- 3d29e9c#4043 ) (Dunqing)
- 02ea19a#4026 ) (Dunqing)
- 7c915f4#4025 ) (Dunqing)
- 05a047c#4024 ) (Dunqing)
- c043bec#4037 ) (Egor Blinov)
- b007553#4030 ) (Egor Blinov)
- da62839#4027 ) (Egor Blinov)
### Refactor
- b51f75b#4008 ) (rzvxa)
- edb557c#4057 )
(Boshen)
- 243c9f3#4028 ) (Boshen)
- 1dacb1f#4014 ) (Boshen)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-05 15:46:50 +08:00
Luca Bruno
e32b4bc57c
refactor(ast)!: store trivia comments in a sorted slice ( #4045 )
...
This gets rid of `TriviasMap`, introducing `SortedComments` in order to
store trivia comments in a sorted slice.
Closes: https://github.com/oxc-project/backlog/issues/38
2024-07-04 01:57:36 +08:00
Boshen
243c9f35b0
refactor(parser): use function instead of trait to parse list with rest element ( #4028 )
...
closes #3887
2024-07-02 13:43:14 +00:00
Boshen
1dacb1fc5b
refactor(parser): use function instead of trait to parse delimited lists ( #4014 )
...
relates #3887
The rest of the list parsing trait implementations involves ... parsing
`rest`, which I'll refactor in another PR.
2024-07-02 14:47:56 +08:00
github-actions[bot]
e2c9015ef6
Release crates v0.16.3 ( #4013 )
...
## [0.16.3] - 2024-07-02
### Features
- b257d53#3895 ) (mysteryven)
### Bug Fixes
- 23038ad#3999 ) (Boshen)
- d995f94#4004 ) (Dunqing)
- bdee156#3997 ) (Dunqing)
- a50ce3d#3996 )
(Dunqing)
### Refactor
- 0fe22a8#3994 )
(rzvxa)
- d0eac46#4003 ) (Boshen)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-02 12:47:29 +08:00
Boshen
d0eac46fc8
refactor(parser): use function instead of trait to parse normal lists ( #4003 )
...
To reduce boilerplate and code noise.
relates #3887
2024-07-01 15:57:36 +00:00
github-actions[bot]
3870ed5a24
Release crates v0.16.2 ( #3983 )
...
## [0.16.2] - 2024-06-30
### Features
- dc6d45e#3979 ) (Boshen)
- 63f36da#3977 ) (DonIsaac)
### Bug Fixes
- dac617d#3980 )
(Boshen)
- bd1141d#3982 ) (Dunqing)
### Performance
- b234ddd1eac3d2#3972 ) (Don Isaac)
- 0c81fbe#3970 ) (Boshen)
### Refactor
- 5845057#3978 ) (Boshen)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-06-30 19:59:15 +08:00
Boshen
dc6d45e2e6
feat(ast,codegen): add TSParenthesizedType and print type parentheses correctly ( #3979 )
...
closes #3916
2024-06-30 07:57:48 +00:00
DonIsaac
63f36daae0
feat(parser): parse modifiers with parse_modifiers (take 2) ( #3977 )
...
Same as #3948 , with fixes for bugs found by @Boshen.
2024-06-30 03:46:34 +00:00
github-actions[bot]
fa50e9737e
Release crates v0.16.1 ( #3968 )
...
## [0.16.1] - 2024-06-29
### Features
- 7b38bde#3948 )
(DonIsaac)
- f64ad4b#3955 ) (Boshen)
### Bug Fixes
- 51e54f9#3957 ) (Dunqing)
- 31e4c3b#3956 ) (Dunqing)
### Refactor
- 2705df9#3960 ) (DonIsaac)
- 15ec254
2024-06-29 16:53:09 +08:00
Boshen
14bc31ee74
Revert "feat(parser): parse modifiers with parse_modifiers ( #3948 )"
...
This reverts commit 7b38bde073
2024-06-29 14:16:26 +08:00
DonIsaac
7b38bde073
feat(parser): parse modifiers with parse_modifiers ( #3948 )
...
Closes #3929
2024-06-29 05:29:47 +00:00
DonIsaac
2705df93b3
refactor(linter): improve diagnostic labeling ( #3960 )
2024-06-29 05:19:22 +00:00
github-actions[bot]
4e3e1a39eb
Release crates v0.16.0 ( #3930 )
...
## [0.16.0] - 2024-06-26
- 6796891#3898 ) (rzvxa)
- 1f85f1a#3899 ) (rzvxa)
- ae09a97#3846 )
(Boshen)
- 1af5ed3#3845 ) (Boshen)
- 0673677#3844 ) (Boshen)
- ee6ec4e#3841 ) (Boshen)
- 9b38119#3839 ) (Boshen)
- cfcef24#3830 ) (Boshen)
- 4456034#3820 ) (Boshen)
### Features
- 497769c#3785 ) (Dunqing)
- 4b06dc7#3775 )
(Dunqing)
- 5847e16#3767 ) (Boshen)
- 2e026e1#3888 ) (rzvxa)
- 09f4d3c#3852 ) (rzvxa)
- 3e78f98#3771 ) (rzvxa)
- 01da2f7#3792 ) (Dunqing)
- 2821e0e#3791 )
(Dunqing)
- 97575d8#3786 )
(Dunqing)
- 5e2baf3#3872 ) (Dunqing)
- 2cdb34f#3811 ) (Dunqing)
- 231b8f0#3809 ) (Dunqing)
- a37138f#3797 ) (Dunqing)
- b0d7355#3793 ) (Dunqing)
- b38c34d#3769 ) (Dunqing)
- 4134de8#3755 ) (Dunqing)
- 94202de#3754 )
(Dunqing)
- e95d8e3#3752 ) (Dunqing)
- df9971d#3750 ) (Dunqing)
- 4aea2b1#3749 ) (Dunqing)
- 9ea30c4#3748 ) (Dunqing)
- dd540c8#3803 ) (Boshen)
- f3c3970#3802 )
(Boshen)
- 4fb90eb#3765 ) (Boshen)
- d5f6aeb#3838 ) (Don
Isaac)
- 01572f0#3902 )
(DonIsaac)
- 5501d5c#3866 ) (Dunqing)
- 2a16ce0#3794 ) (Boshen)- d3cd3ea#3896 ) (underfin)
### Bug Fixes
- 063cfde#3858 )
(overlookmotel)
- 66f404c#3856 )
(overlookmotel)
- 2766594#3922 )
(Dunqing)
- 27f0531#3921 ) (Dunqing)
- 59ce38b#3920 ) (Dunqing)
- 58e54f4#3810 )
(Dunqing)
- cb8a272#3807 )
(Dunqing)
- d8ecce5#3806 ) (Dunqing)
- 4e241fc#3805 ) (Dunqing)
- 683c7b0#3804 ) (Dunqing)
- 7d47fc3#3790 ) (Dunqing)
- 8ce794d#3768 ) (Dunqing)
- d29316a#3753 ) (Dunqing)
- bf1c250#3751 ) (Dunqing)
- 275349a#3926 )
(Boshen)
- ef82c78#3885 ) (Dunqing)
- 13754cb#3853 ) (Boshen)
- 8c9fc63#3861 ) (overlookmotel)
- 99a40ce#3823 ) (Boshen)
- 08fcfb3#3911 )
(overlookmotel)
- 17ad8f7#3908 ) (overlookmotel)
- d76f34b#3837 )
(overlookmotel)
- e470731#3833 ) (overlookmotel)
- d774e54#3832 ) (overlookmotel)
- ff1da27#3831 )
(overlookmotel)
- 6dcc3f4#3816 )
(overlookmotel)
- aea3e9a#3782 ) (overlookmotel)
### Performance
- 92c21b2#3897 )
(Luca Bruno)
- 4bf405d#3894 ) (Boshen)
- 10d1de5#3867 )
(DonIsaac)- 4f7ff7e#3818 )
(overlookmotel)
### Refactor
- 6f26087#3905 ) (overlookmotel)
- 442aca3#3891 )
(overlookmotel)
- acf69fa#3859 ) (overlookmotel)
- 9e148e9#3860 ) (overlookmotel)
- 363d3d5#3855 )
(rzvxa)
- a648748#3835 ) (overlookmotel)
- 1206967#3834 ) (overlookmotel)
- 2f5d50e#3847 ) (Boshen)
- 8027b1e#3801 )
(Boshen)
- a471e62#3925 ) (Boshen)
- 3db2553#3923 )
(Boshen)
- 4cf3c76#3903 ) (Boshen)
- 187f078#3892 ) (Boshen)
- 97d59fc#3849 )
(Boshen)
- 5ef28b7#3912 ) (overlookmotel)
- d9f268d#3836 ) (overlookmotel)
- 21b0d01#3781 ) (overlookmotel)
- 7c44703#3774 ) (overlookmotel)
- 22c56d7#3764 ) (overlookmotel)
- cd56aa9#3762 )
(overlookmotel)
- 512740d#3760 ) (overlookmotel)
- 1061baa#3901 ) (overlookmotel)
- fcd21a6#3882 ) (overlookmotel)
- 24979c9#3880 )
(overlookmotel)
- 2045c92#3879 )
(overlookmotel)- d6437fe#3854 )
(Boshen)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-06-27 20:38:31 +08:00
Boshen
275349a9fe
fix(parser): parse function type parameter name accessor ( #3926 )
...
fixes #3910
2024-06-26 13:34:24 +00:00
Boshen
a471e62e2d
refactor(parser): clean up try_parse ( #3925 )
2024-06-26 11:18:02 +00:00
Boshen
3db2553dc2
refactor(parser): improve parsing of TypeScript type arguments ( #3923 )
2024-06-26 07:16:18 +00:00
Boshen
4cf3c7645f
refactor(parser): improve parsing of TypeScript types ( #3903 )
...
- [x] fix everything
2024-06-26 05:58:16 +00:00
rzvxa
6796891e2e
fix(ast)!: rename all instances of BigintLiteral to BigIntLiteral. ( #3898 )
...
Notice the casing! Just for the sake of consistency.
2024-06-25 14:39:42 +00:00
rzvxa
1f85f1a5f7
refactor(ast)!: revert adding span field to the BindingPattern type. ( #3899 )
...
Since this is a temporary solution in the time that we are waiting for the `#[span]` hint, And there are already other workarounds used in our `ast_codegen` I propose removing it right away - sorry in my opinion adding it in the first place was a mistake - in favor of adding an edge case in the codegen. It is better to do the refactoring in the codegen instead of the production code which people may depend on.
2024-06-25 09:43:48 +00:00
Boshen
4bf405ddfc
perf(parser): add a few more inline hints to cursor functions ( #3894 )
2024-06-25 06:00:46 +00:00
Boshen
187f0782c1
refactor(parser): improve parsing of parse_function_or_constructor_type ( #3892 )
...
part of #3502
2024-06-25 03:43:02 +00:00
Dunqing
ef82c78a72
fix(parser): trailing comma is not allowed in ParenthesizedExpression ( #3885 )
...
close : #3878
The implementation is copied from `SeparatedList`'s `print_list`.
```diff
fn parse_list(&mut self, p: &mut ParserImpl<'a>) -> Result<()> {
p.expect(self.open())?;
let mut first = true;
while !p.at(self.close()) && !p.at(Kind::Eof) {
if first {
first = false;
} else {
p.expect(self.separator())?;
- if p.at(self.close()) {
- break;
- }
}
self.parse_element(p)?;
}
p.expect(self.close())?;
Ok(())
}
```
2024-06-24 14:56:32 +00:00
rzvxa
363d3d57d7
refactor(ast): add span field to the BindingPattern type. ( #3855 )
...
So we don't have to introduce a special case while generating `GetSpan` implementations for all of our Ast types.
2024-06-23 16:00:40 +00:00
Boshen
d6437fec0b
refactor: clean up some usages of with_labels ( #3854 )
2024-06-23 15:24:37 +00:00
Boshen
13754cbd3d
fix(parser): change diagnostic to "modifier cannot be used here" ( #3853 )
2024-06-23 15:14:27 +00:00
Boshen
97d59fc2f3
refactor(parser): move code around for parsing Modifiers ( #3849 )
2024-06-23 12:46:42 +00:00
Boshen
ae09a97a09
refactor(ast)!: remove Modifiers from ts nodes ( #3846 )
2024-06-23 19:44:35 +08:00
Boshen
1af5ed3d89
refactor(ast)!: replace Modifiers with declare and const on EnumDeclaration ( #3845 )
2024-06-23 10:34:55 +00:00
Boshen
0673677317
refactor(ast)!: replace Modifiers with declare on Function ( #3844 )
2024-06-23 10:34:54 +00:00
Boshen
ee6ec4ee57
refactor(ast)!: replace Modifiers with declare and abstract on Class ( #3841 )
2024-06-23 10:34:53 +00:00
Boshen
9b38119ec9
refactor(ast)!: replace Modifiers with declare on VariableDeclaration ( #3839 )
...
part of #2958
2024-06-23 10:34:52 +00:00
Boshen
cfcef241db
feat(ast)!: add directives field to TSModuleBlock ( #3830 )
...
closes #3564
2024-06-22 18:14:08 +00:00
Boshen
445603444f
feat(ast)!: add IdentifierReference to ExportSpecifier ( #3820 )
...
closes #3795
closes #3796
2024-06-22 11:43:41 +00:00
overlookmotel
4f7ff7e3ad
perf: do not pass &Atom to functions ( #3818 )
...
`Atom` is just a wrapper around `&str`, so better not to pass `&Atom` to functions, as that's a double-reference. Prefer `Atom` or `&str` instead to avoid indirection.
2024-06-22 04:48:00 +00:00
Boshen
dd540c8f0f
feat(minifier): add skeleton for ReplaceGlobalDefines ast pass ( #3803 )
2024-06-21 13:53:59 +00:00
Boshen
5847e16a15
feat(ast,parser): add intrinsic keyword ( #3767 )
...
closes #3759
2024-06-19 14:52:05 +00:00
github-actions[bot]
1b3cd6c24d
Release crates v0.15.0 ( #3743 )
...
## [0.15.0] - 2024-06-18
- 0537d29#3728 ) (rzvxa)
- 5c38a0f#3740 ) (Boshen)
- 4bce59d#3722 ) (rzvxa)
- 534242a#3674 ) (Boshen)
- 0578ece#3666 ) (Dunqing)
### Features
- 5a99d30#3735 ) (Boshen)
- bf9b38a#3731 ) (Boshen)
- 4a004e2#3695 ) (Dunqing)
- a56cb1b#3690 )
(Dunqing)
- 38a75e5#3729 ) (Boshen)
- 750a534#3691 ) (Boshen)
- ee627c3#3730 ) (Dunqing)
- 81e9526#3725 ) (Dunqing)
- 77d5533#3720 ) (Dunqing)
- 8f5655d#3594 ) (Don Isaac)
- 046ff3f#3238 ) (rzvxa)
- 0b8098a#3718 ) (Boshen)
- 527bfc8d65c652#3696 )
(Boshen)
- 9c31ed9#3648 ) (rzvxa)
- d9c5b33#3567 ) (Ali
Rezvani)
- f2dfd66#3566 ) (rzvxa)
- 910193e#3711 )
(Dunqing)
- 413d7be#3710 ) (Dunqing)
- 35c382e#3689 ) (Dunqing)
- 0e6d3ce#3688 ) (Dunqing)
- b22b59a#3683 ) (Dunqing)
- 4f2db46#3664 ) (Dunqing)
### Bug Fixes
- 2158268#3681 ) (Dunqing)
- da1e2d0#3708 ) (Boshen)
- f1b793f#3739 ) (Dunqing)
- 0fbecdc#3726 ) (Dunqing)
- 8f64d99#3724 )
(mysteryven)
- 70fc69b#3651 ) (Yuji Sugiura)
- 7a58fec#3678 ) (rzvxa)
- abd6ac8#3671 ) (rzvxa)
- e148a32#3667 ) (Ali Rezvani)
- 59666e0#3623 ) (Dunqing)
- 90743e2#3685 )
(overlookmotel)
### Performance
- 2717a1a#3676 ) (rzvxa)
### Refactor
- fa7a6ba#3687 ) (Boshen)
- 09b92b6#3680 ) (Boshen)
- 3c59735#3719 )
(Boshen)
- 815260e#3715 ) (Boshen)
- 7ec44f8#3742 )
(rzvxa)
- d8ad321#3737 )
(rzvxa)
- a94a72d#3694 )
(Boshen)
- bd8d115#3677 ) (rzvxa)
- f702fb9#3650 )
(rzvxa)
- 4f16664#3679 )
(Boshen)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-06-19 01:15:55 +08:00
Boshen
051ceb6539
chore: improve some format by running cargo +nightly fmt
2024-06-19 00:48:30 +08:00
Boshen
982e6f08df
chore: make println and eprintln opt-in ( #3712 )
...
I noticed accidental `println` can be merged, which isn't really nice.
2024-06-17 10:40:34 +00:00
Boshen
da1e2d0e9b
fix(codegen): improve typescript codegen ( #3708 )
...
Remaining issues are tracked in https://github.com/oxc-project/oxc/issues/3692
2024-06-17 09:34:54 +00:00
Boshen
d65c652700
feat(parser): display jsx mismatch error, e.g. <Foo></Bar> ( #3696 )
...
relates #3548
I'll remove the closing name in a follow up PR.
The snapshot is incorrect, so I created a follow up issue:
https://github.com/oxc-project/oxc/issues/3697
2024-06-16 01:05:28 +08:00
Boshen
1edcd87203
chore: change all usages of static_assertions to dev-dependencies ( #3654 )
2024-06-13 13:18:53 +08:00
github-actions[bot]
95e0571c2e
Release crates v0.14.0 ( #3643 )
...
## [0.14.0] - 2024-06-12
### Breaking
* fix(codegen)!: remove the unecessary 4th argument from `Codegen::new`
(#3640 )
* feat(ast)!: make `Trivias` clonable by adding `Arc` (#3638 )
### Features
- f6d9ca6#3568 ) (Wang Wenzhe)
- 129f91e#3592 ) (Don
Isaac)
### Bug Fixes
- f8f6d33#3635 ) (overlookmotel)
- e6ad3fb#3624 )
(Boshen)
- d65202d#3608 ) (overlookmotel)
- 35e267b#3634 ) (overlookmotel)
- 39bdebc#3633 )
(overlookmotel)
- 5cb7e6a#3630 )
(overlookmotel)
- 0c4ccb4#3627 )
(overlookmotel)
- 8d237c4#3615 ) (overlookmotel)
- 9e8f4d6#3614 )
(overlookmotel)
- 0fb4c35#3612 )
(overlookmotel)
### Performance
- 3a59294#3616 ) (overlookmotel)
- f4c1389#3613 )
(overlookmotel)
### Refactor
- 0f92521#3626 ) (overlookmotel)
- 08f1010#3602 ) (overlookmotel)
- 84304b4#3637 ) (Boshen)
- f98f777#3589 ) (Don Isaac)
- e90e6a2#3603 ) (overlookmotel)
- 7d61832#3586 ) (overlookmotel)
- 89bcbd5#3610 )
(overlookmotel)
- 5793ff1#3580 )
(Dunqing)
- 509871f#3618 ) (overlookmotel)
- 4b2e3a7#3617 ) (overlookmotel)
- 3467e3d#3606 ) (overlookmotel)
- a799225#3604 ) (overlookmotel)
- 70f31a8#3596 )
(overlookmotel)
- 3ae567d#3588 ) (overlookmotel)
- 60cbdec#3611 )
(overlookmotel)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-06-12 17:52:41 +08:00
github-actions[bot]
6bdd74c476
Release crates v0.13.5 ( #3584 )
...
## [0.13.5] - 2024-06-08
### Bug Fixes
- 48bb97e
2024-06-08 16:44:50 +08:00
Boshen
060819894d
chore: crates should only publish src and examples directory
2024-06-08 16:35:16 +08:00
github-actions[bot]
d215e3d906
Release crates v0.13.4 ( #3582 )
...
## [0.13.4] - 2024-06-07
### Features
- 5c8e16c#3561 ) (Dunqing)
- 646b993#3553 ) (Dunqing)
- a939ddd#3563 ) (Dunqing)
- e8a20f8#3559 )
(Dunqing)
- ee9a215#3532 ) (Dunqing)
### Bug Fixes
- affb2c8#3512 ) (Dunqing)
- f6939cb#3551 ) (overlookmotel)
- 7982b93#3549 )
(overlookmotel)
- c00598b#3524 )
(overlookmotel)
### Performance
- 37cdc13#3577 )
(overlookmotel)
- 9f467b8#3535 )
(overlookmotel)
- ac394f0#3534 )
(overlookmotel)
### Documentation
- 1d3c0d7#3543 ) (Don Isaac)
### Refactor
- f2113ae#3576 )
(overlookmotel)
- 0948124#3550 ) (overlookmotel)
- e4d74ac#3541 ) (overlookmotel)
- 73b7864#3540 )
(overlookmotel)
- 6978269#3533 ) (Dunqing)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-06-07 17:41:11 +08:00
Boshen
1dbc23417d
chore: regenerate changelogs with commit id and author
2024-06-07 01:22:28 +08:00
Boshen
769227b7b4
chore: regenerate changelogs
2024-06-06 15:51:53 +08:00
Boshen
509ed2bcf3
ci: update prepare release crates; regenerate the changelogs
2024-06-06 14:28:51 +08:00
Boshen
0674604d7a
chore: regenerate changelog
2024-06-06 01:29:38 +08:00
github-actions[bot]
d48e62aca4
Publish crates v0.13.3 ( #3527 )
...
Automated Release
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-06-04 18:02:40 +08:00
github-actions[bot]
079d42f68b
Release crates v0.13.2 ( #3513 )
...
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-06-03 12:40:53 +08:00
Dunqing
350cd9158a
fix(parser): should parser error when function declaration has no name ( #3461 )
...
https://oxc-project.github.io/oxc/playground/?code=3YCAAICNgICAgICAgICzncl%2FKeF7k4Y7upgY2l43c79%2FYxaAgA%3D%3D
2024-05-30 19:58:50 +08:00
overlookmotel
15734f5c4b
chore(parser): code comment for cold trampoline function ( #3467 )
...
Add a comment to explain the "cold trampoline function" used in lexer.
2024-05-30 01:11:00 +01:00
Dunqing
cf41513d28
fix(parser): parse const extends in arrow functions correctly ( #3450 )
...
close : #3443
2024-05-28 21:34:52 +08:00
Boshen
6078a6d292
fix(parser): fix lexer error while parsing parenthesized arrow expressions ( #3400 )
...
closes #3399
2024-05-24 09:59:17 +00:00
Boshen
86beca5379
Release crates v0.13.1
2024-05-22 16:50:30 +08:00
Boshen
1e84644220
chore: update toml format
2024-05-21 22:15:47 +08:00
overlookmotel
fdb31c39c9
perf(parser): more efficient number parsing ( #3342 )
...
Follow-on after #3296 .
Make parsing binary/octal/hex numeric literals a little more efficient.
These changes all rely on that we know more than the compiler does -
that strings passed to these `parse_*` functions can only contain a
certain set of characters.
2024-05-21 10:53:52 +08:00
Boshen
89a1f97320
refactor(parser): improve expression parsing ( #3352 )
2024-05-19 21:28:16 +08:00
Boshen
e818fba21c
refactor(parser): improve parse_simple_arrow_function_expression ( #3349 )
2024-05-19 06:05:39 +00:00
Boshen
1e802c71d5
refactor(parser): clean up ParserState ( #3345 )
2024-05-19 01:30:16 +08:00
Boshen
46cb5f97a0
perf(parser): use FxHashSet for not_parenthesized_arrow ( #3344 )
2024-05-19 01:13:56 +08:00
Boshen
0742081921
refactor(parser): improve is_parenthesized_arrow_function_expression ( #3343 )
2024-05-18 16:39:51 +00:00
Boshen
6b3d019631
refactor(paresr): move some structs to js module ( #3341 )
2024-05-18 14:41:32 +00:00
Boshen
9ced605487
refactor(parser): start porting arrow function parsing from tsc ( #3340 )
...
relates #3320
2024-05-18 22:35:29 +08:00
Don Isaac
27030b9eb4
perf(lexer): use bitshifting when parsing known integers ( #3296 )
...
## What This PR Does
- perf(lexer): use bit shifting when parsing hex, octal, and binary
integers instead of `mul_add`-ing on `f64`s. Check out the difference in
assembly generated [here](https://godbolt.org/z/zMEKaeYzh )
- perf(lexer): skip redundant utf8 check when parsing BigInts
- refactor(lexer): remove `unsafe` usage (as per @overlookmotel's
request
[here](https://github.com/oxc-project/oxc/pull/3283#issuecomment-2111814598 ))
- test(lexer): add numeric parsing unit tests
I don't expect this PR to have a large performance improvement, since
the most common case (`Kind::Decimal`) is not affected. We could do
this, however, by splitting `Kind::Decimal` into `Kind::DecimalFloat`
and `Kind::DecimalInt` when the lexer encounters a `.`
2024-05-17 09:39:10 +08:00
Don Isaac
508dae6f8f
perf(lexer): dedupe numeric separator check ( #3283 )
...
## What This PR Does
Updates numeric literal token lexing to record when separator characters
(`_`) are found in a new `Token` flag. This then gets passed to
`parse_int` and `parse_float`, removing the need for a second `_` check
in those two functions.
When run locally, I see no change to lexer benchmarks and minor
improvements to codegen benchmarks. For some reason, semantic and source
map benches seem to be doing slightly worse.
Note that I attempted to implement this with `bitflags!` (making
`escaped` and `is_on_newline` flags as well) and this caused performance
degradation. My best guess is that it turned reads on these flags from a
`mov` to a `mov` + a binary and.
---------
Co-authored-by: Boshen <boshenc@gmail.com>
2024-05-15 01:48:21 +00:00
Boshen
c395f8641e
Release crates v0.13.0
2024-05-14 23:14:15 +08:00
Boshen
b27a905958
refactor(parser): simplify Context passing ( #3266 )
2024-05-14 12:22:27 +08:00
Boshen
c4ccf9f4d8
fix(parser): parse DecoratorCallExpression when Arguments contains MemberExpression ( #3265 )
...
closes #3261
closes #3262
```
DecoratorCallExpression[Yield, Await] :
DecoratorMemberExpression[?Yield, ?Await] Arguments[?Yield, ?Await]
```
2024-05-14 03:18:41 +00:00
Dunqing
eefb66f750
feat(ast): add type to AccessorProperty to support TSAbractAccessorProperty ( #3256 )
2024-05-13 12:35:58 +00:00
Boshen
1b4ebb3166
refactor: run fmt
2024-05-12 01:20:41 +08:00
Boshen
312f74bb63
refactor(diagnostics): s/OxcDiagnostic::new/OxcDiagnostic::error
2024-05-12 01:08:54 +08:00
Boshen
2064ae9e0a
refactor(parser,diagnostic): one diagnostic struct to eliminate monomorphization of generic types ( #3214 )
...
part of #3213
We should only have one diagnostic struct instead 353 copies of them, so we don't end up choking LLVM with 50k lines of the same code due to monomorphization.
If the proposed approach is good, then I'll start writing a codemod to turn all the existing structs to plain functions.
---
Background:
Using `--timings`, we see `oxc_linter` is slow on codegen (the purple part).
The crate currently contains 353 miette errors. [cargo-llvm-lines](https://github.com/dtolnay/cargo-llvm-lines ) displays
```
cargo llvm-lines -p oxc_linter --lib --release
Lines Copies Function name
----- ------ -------------
830350 33438 (TOTAL)
29252 (3.5%, 3.5%) 808 (2.4%, 2.4%) <alloc::boxed::Box<T,A> as core::ops::drop::Drop>::drop
23298 (2.8%, 6.3%) 353 (1.1%, 3.5%) miette::eyreish::error::object_downcast
19062 (2.3%, 8.6%) 706 (2.1%, 5.6%) core::error::Error::type_id
12610 (1.5%, 10.1%) 65 (0.2%, 5.8%) alloc::raw_vec::RawVec<T,A>::grow_amortized
12002 (1.4%, 11.6%) 706 (2.1%, 7.9%) miette::eyreish::ptr::Own<T>::boxed
9215 (1.1%, 12.7%) 115 (0.3%, 8.2%) core::iter::traits::iterator::Iterator::try_fold
9150 (1.1%, 13.8%) 1 (0.0%, 8.2%) oxc_linter::rules::RuleEnum::read_json
8825 (1.1%, 14.9%) 353 (1.1%, 9.3%) <miette::eyreish::error::ErrorImpl<E> as core::error::Error>::source
8822 (1.1%, 15.9%) 353 (1.1%, 10.3%) miette::eyreish::error::<impl miette::eyreish::Report>::construct
8119 (1.0%, 16.9%) 353 (1.1%, 11.4%) miette::eyreish::error::object_ref
8119 (1.0%, 17.9%) 353 (1.1%, 12.5%) miette::eyreish::error::object_ref_stderr
7413 (0.9%, 18.8%) 353 (1.1%, 13.5%) <miette::eyreish::error::ErrorImpl<E> as core::fmt::Display>::fmt
7413 (0.9%, 19.7%) 353 (1.1%, 14.6%) miette::eyreish::ptr::Own<T>::new
6669 (0.8%, 20.5%) 39 (0.1%, 14.7%) alloc::raw_vec::RawVec<T,A>::try_allocate_in
6173 (0.7%, 21.2%) 353 (1.1%, 15.7%) miette::eyreish::error::<impl miette::eyreish::Report>::from_std
6027 (0.7%, 21.9%) 70 (0.2%, 16.0%) <alloc::vec::Vec<T> as alloc::vec::spec_from_iter_nested::SpecFromIterNested<T,I>>::from_iter
6001 (0.7%, 22.7%) 353 (1.1%, 17.0%) miette::eyreish::error::object_drop
6001 (0.7%, 23.4%) 353 (1.1%, 18.1%) miette::eyreish::error::object_drop_front
5648 (0.7%, 24.1%) 353 (1.1%, 19.1%) <miette::eyreish::error::ErrorImpl<E> as core::fmt::Debug>::fmt
```
It's totalling more than 50k llvm lines, and is putting pressure on rustc codegen (the purple part on `oxc_linter` in the image above.
---
It's pretty obvious by looking at https://github.com/zkat/miette/blob/main/src/eyreish/error.rs , the generics can expand out to lots of code.
2024-05-11 04:56:22 +00:00
Dunqing
0ba7778e5e
fix(parser): correctly parse cls.fn<C> = x ( #3208 )
...
close : #3206
2024-05-09 10:23:45 +08:00
Boshen
7338364219
perf(lexer): improve comment building performance by using a vec instead of btreemap ( #3186 )
...
closes #2693
2024-05-07 16:43:27 +08:00
Boshen
a8af5de8f5
refactor(syntax): move number related functions to number module ( #3130 )
2024-04-29 18:54:35 +08:00
overlookmotel
7e1fe36c68
refactor(ast): squash nested enums ( #3115 )
...
OK, this is a big one...
I have done this as part of work on Traversable AST, but I believe it
has wider benefits, so thought better to spin it off into its own PR.
## What this PR does
This PR squashes all nested AST enum types (#2685 ).
e.g.: Previously:
```rs
pub enum Statement<'a> {
BlockStatement(Box<'a, BlockStatement<'a>>),
/* ...other Statement variants... */
Declaration(Declaration<'a>),
}
pub enum Declaration<'a> {
VariableDeclaration(Box<'a, VariableDeclaration<'a>>),
/* ...other Declaration variants... */
}
```
After this PR:
```rs
#[repr(C, u8)]
pub enum Statement<'a> {
BlockStatement(Box<'a, BlockStatement<'a>>) = 0,
/* ...other Statement variants... */
VariableDeclaration(Box<'a, VariableDeclaration<'a>>) = 32,
/* ...other Declaration variants... */
}
#[repr(C, u8)]
pub enum Declaration<'a> {
VariableDeclaration(Box<'a, VariableDeclaration<'a>>) = 32,
/* ...other Declaration variants... */
}
```
All `Declaration`'s variants are combined into `Statement`, but
`Declaration` type still exists.
As both types are `#[repr(C, u8)]`, and the discriminants are aligned, a
`Declaration` can be transmuted to a `Statement` at zero cost.
This is the same thing as #2847 , but here applied to *all* nested enums
in the AST, and with improved helper methods.
No enums increase in size, and a few get smaller. Indirection is reduced
for some types (this removes multiple levels of boxing).
## Why?
1. It is a prerequisite for Traversable AST (#2987 ).
2. It would help a lot with AST Transfer (#2409 ) - it solves the only
remaining blocker for this.
3. It is a step closer to making the whole AST `#[repr(C)]`.
## Why is it a good thing for the AST to be `#[repr(C)]`?
Oxc's direction appears to be increasingly to build up control over the
fundamental primitives we use, in order to unlock performance and
features. We have our own allocator, our own custom implementations for
`Box` and `Vec`, our own `IndexVec` (TBC). The AST is the central
building block of Oxc, and taking control of its memory layout feels
like a step in this same direction.
Oxc has a major advantage over other similar libraries in that it keeps
all the AST data in an arena. This opens the door to treating the AST
either as Rust types or as *pure data* (just bytes). That data can be
moved around and manipulated beyond what Rust natively allows.
However, to enable that, the types need to be well-specified, with
completely stable layouts. `#[repr(C)]` is the only tool Rust provides
to do this.
Once the types are `#[repr(C)]`, various features become possible:
1. Cheap transfer of the AST across boundaries without ser/deser - the
property used by AST Transfer.
2. Having multiple versions of the AST (standard, read-only,
traversable), and these AST representations can be converted to one
other at zero cost via transmute - the property used by Traversable AST
scheme.
3. Caching AST data on disk (#3079 ) or transferring across network.
4. Stuff we haven't thought of yet!
Allowing the AST to be treated as pure data will likely unlock other
"next level" features further down the track (caching for "edge
bundling" comes to mind).
## The problem with `#[repr(C)]`
It's not *required* to squash nested enums to make the AST `#[repr(C)]`.
But the problem with `#[repr(C)]` is that it disables some compiler
optimizations. Without `#[repr(C)]`, the compiler squashes enums itself
in some cases (which is how `Statement` is currently 16 bytes). But
making the types `#[repr(C)]` as they are currently disables this
optimization.
So this PR essentially makes explicit what the compiler is already doing
- and in fact goes a bit further with the optimization than the compiler
is able to, in squashing 3 or 4 layers of nested enums (the compiler
only does up to 2 layers).
## Implementation
One enum "inheriting" variants from another is implemented with
`inherit_variants!` macro.
```rs
inherit_variants! {
#[repr(C, u8)]
pub enum Statement<'a> {
BlockStatement(Box<'a, BlockStatement<'a>>),
/* ...other Statement variants... */
// `Declaration` variants added here by `inherit_variants!` macro
@inherit Declaration
// `ModuleDeclaration` variants added here by `inherit_variants!` macro
@inherit ModuleDeclaration
}
}
```
The macro is *fairly* lightweight, and I think the above is quite easy
to understand. No proc macros.
The macro also implements utility methods for converting between enums
e.g. `Statement::as_declaration`. These methods are all zero-cost
(essentially transmutes).
New patterns for dealing with nested enums are introduced:
Creation:
```rs
// Old
let stmt = Statement::Declaration(Declaration::VariableDeclaration(var_decl));
// New
let stmt = Statement::VariableDeclaration(var_decl);
```
Conversion:
```rs
// Old
let stmt = Statement::Declaration(decl);
// New
let stmt = Statement::from(decl);
```
Testing:
```rs
// Old
if matches!(stmt, Statement::Declaration(_)) { }
if matches!(stmt, Statement::ModuleDeclaration(m) if m.is_import()) { }
// New
if stmt.is_declaration() { }
if matches!(stmt, Statement::ImportDeclaration(_)) { }
```
Branching:
```rs
// Old
if let Statement::Declaration(decl) = &stmt { decl.do_stuff() };
// New
if let Some(decl) = stmt.as_declaration() { decl.do_stuff() };
```
Matching:
```rs
// Old
match stmt {
Statement::Declaration(decl) => visitor.visit(decl),
}
// New (exhaustive match)
match stmt {
match_declaration!(Statement) => visitor.visit(stmt.to_declaration()),
}
// New (alternative)
match stmt {
_ if stmt.is_declaration() => visitor.visit(stmt.to_declaration()),
}
```
New syntax has pluses and minuses vs the old. `match` syntax is worse,
but when working with a deeply nested enum, the code is much nicer -
it's shorter and easier to read.
This PR removes 200 lines from the linter with changes like this:
https://github.com/oxc-project/oxc/pull/3115/files#diff-dc417ff57352da6727a760ec6dee22de6816f8231fb69dbef1bf05d478699103L92-R95
```diff
- let AssignmentTarget::SimpleAssignmentTarget(simple_assignment_target) =
- &assignment_expr.left
- else {
- return;
- };
- let SimpleAssignmentTarget::AssignmentTargetIdentifier(ident) =
- simple_assignment_target
+ let AssignmentTarget::AssignmentTargetIdentifier(ident) = &assignment_expr.left
else {
return;
};
```
2024-04-28 20:40:37 +08:00
overlookmotel
0185eb2edc
refactor(ast): remove duplicate TSNamedTupleMember representation ( #3101 )
...
Removes duplicate representation of a `TSTupleElement` which is a
`TSNamedTupleMember`.
Closes #3100 .
2024-04-25 19:16:24 +08:00
Ali Rezvani
ac72d08592
chore: cleanup the dependencies on static_assertions and oxc_index. ( #3095 )
...
We used to export `static_assertions` as part of the `oxc_index`. It
would've made sense back when it was only a vessel for exporting other
crates - although even then it wouldn't make much sense other than being
convenient - Now with it turning into a port of `index_vec` and
potentially getting bigger as the result of specific needs of the
project; It makes much more sense to stop exporting it from `oxc_index`
and use the crate directly in places that used to use what `oxc_index`
were exporting.
PS: we may want to follow up this with an `oxc_asset` crate containing
our own set of assertion tools which would also export
`static_assertions`.
2024-04-25 16:56:23 +08:00
overlookmotel
942b2ba084
refactor(ast): add array element Elision type ( #3074 )
...
Pure refactor. This change does nothing except makes it more consistent
with other types which are also just a wrapper around `Span` e.g.
`NullLiteral` and `TSThisType`.
2024-04-23 02:05:11 +08:00
Boshen
559bca86c5
Release crates v0.12.5
2024-04-22 12:52:17 +08:00
Ali Rezvani
6c8296164e
perf(ast): box typescript enum variants. ( #3065 )
...
Similar to #3058 and #3061 it is a continuation of #3047 .
Handles these enum types:
> TSEnumMemberName
> Variant sizes: 16, 24, 24, 40
> Unboxed variants: IdentifierName (struct), StringLiteral (struct),
NumericLiteral (struct)
> Dependents: TSEnumMember (struct)
> => Box all variants.
>
> TSModuleReference
> Variant sizes: 16, 32
> Unboxed variants: TSExternalModuleReference (struct)
> Dependents: Box<TSModuleReference> in TSImportEqualsDeclaration
> => Box all variants. Replace Box<TSModuleReference> with
TSModuleReference in TSImportEqualsDeclaration.
>
> TSTypePredicateName
> Variant sizes: 8, 24
> Unboxed variants: IdentifierName (struct), TSThisType (struct)
> Dependents: TSTypePredicate (struct)
> => Box Identifier variant. Do not box This variant as only 8 bytes
(just contains Span).
>
> TSTypeQueryExprName
> Variant sizes: 16, 88
> Unboxed variants: TSImportType (struct)
> Dependents: TSTypeQuery (struct)
> => Box TSImportType variant. Do not box TSTypeName variant, as is
another enum.
2024-04-22 09:54:53 +08:00
overlookmotel
48e20880d4
perf(ast): box enum variants ( #3058 )
...
Box all enum variants for JSX types (`JSXAttributeName`,
`JSXAttributeValue`, `JSXChild`, `JSXElementName`,
`JSXMemberExpressionObject`). Part of #3047 .
I'm not sure how to interpret the benchmark results. As I said on #3047 :
> I imagine it may cost a little in performance in the parser due to
extra calls to `alloc`, but in return traversing the AST should be
cheaper, as the data is more compact, so less cache misses.
Sure enough, there is a small impact (1%) on the 2 parser benchmarks for
JSX files. However, the other benchmarks have too much noise in them to
see whether this is repaid in a speed up on transformer etc, especially
as the transformer benchmarks also include parsing.
What do you think @Boshen?
2024-04-22 09:09:30 +08:00
overlookmotel
383b449d4e
perf(ast): box ImportDeclarationSpecifier enum variants ( #3061 )
...
Part of #3047 .
As with #3058 , it's hard to interpret the benchmark results here. But in
this case I think it's easier to see from "first principles" that this
should be an improvement - `ImportSpecifier` is pretty massive (80
bytes) vs `ImportDefaultSpecifier` (40 bytes), and the latter (e.g.
`import React from 'react'`) is common in JS code.
2024-04-22 09:06:39 +08:00
overlookmotel
2804e7dbf6
perf(ast): reduce indirection in AST types ( #3051 )
...
Fixes #3048 .
No apparent change on benchmarks. Likely these TS features are not much
used in the benchmark fixtures.
2024-04-22 09:05:25 +08:00
Boshen
92d709bf21
feat(ast): add CatchParameter node ( #3049 )
2024-04-21 23:43:39 +08:00
overlookmotel
d44301c871
fix(parser): fix comment typos ( #3036 )
...
Fix 2 typos in comments.
2024-04-20 13:13:25 +03:30
Boshen
a05c4e39b8
Release crates v0.12.4
2024-04-19 16:40:05 +08:00
Boshen
93ce5a919a
chore: fix internal doc warnings
2024-04-13 15:59:24 +08:00
branchseer
f159f60084
Make ast types covariant over the allocator lifetime. ( #2943 )
...
## Why
Due to the usage of `&'alloc mut T` in `oxc_allocator::Box`, and
`bumpalo::collections::Vec` in `oxc_allocator::Vec`, ast types are
currently invariant over their allocator lifetime `'a`. This prevents
`ouroboros` from generating `borrow_*` on ast type fields, leading to
the unfriendly `with_*` api:
c250b288ef/crates/oxc_parser/examples/multi-thread.rs (L82-L84)
2024-04-12 18:12:18 +08:00
Boshen
614f73b66c
Release crates v0.12.3
2024-04-11 16:18:17 +08:00
Boshen
59748199da
refactor(ast): clean up the ts type visit methods
2024-04-11 15:26:24 +08:00
Boshen
09452659e2
Release crates v0.12.2
2024-04-08 11:13:13 +08:00
Boshen
fb2ebf462e
chore: fix clippy on unsafe comment
2024-04-03 19:57:21 +08:00
Boshen
feb3c90098
chore(parser): allow unsafe in examples
2024-04-03 19:40:02 +08:00
Boshen
366a7fb0d4
Release crates v0.11.2
2024-04-03 19:36:54 +08:00
Boshen
504698ab4a
chore: guard against unsafe code as much as possible.
2024-04-03 19:35:07 +08:00
Boshen
54f7cd3978
Release crates v0.11.1
2024-04-03 16:57:52 +08:00
Boshen
23d3c4e0a4
chore: add changelogs via git cliff ( #2878 )
...
This is generated alongside https://github.com/oxc-project/release-oxc
2024-04-01 20:04:48 +08:00
Boshen
31ed532b79
Release crates v0.11.0
2024-03-30 13:54:53 +08:00
Ali Rezvani
b76b02d019
fix(parser): add support for empty module declaration ( #2834 )
...
Should be merged after #2829 , Tried a few times to get it done with
graphite stacking but found no success. I guess it either doesn't work
with forks or It is just a skill issue since I'm not familiar with it.
closes : #2829
closes : #2830
---------
Co-authored-by: Dmytro Maretskyi <maretskii@gmail.com>
2024-03-27 13:48:03 +08:00
Boshen
95fc28168c
chore: apply cargo autoinherit ( #2826 )
...
See https://github.com/mainmatter/cargo-autoinherit
2024-03-26 23:57:50 +08:00
Ali Rezvani
fc3878350f
refactor(ast): add walk_mut functions ( #2776 )
...
* move `visit` and `visit_mut` modules to a super module called `visit`
* add `walk_mut` module containing walk functions
* update `enter_node` and `leave_node` events to not pass a reference in the `VisitMut` trait
* add `AstType`, a non-referencing version of `AstKind` to use with `VisitMut` trait
* update the `VisitMut` trait's usages.
2024-03-25 20:40:13 +03:30
Boshen
e32a3b3783
ci: use cargo-shear ( #2810 )
2024-03-26 00:43:10 +08:00
Ali Rezvani
198eea0bce
refactor(ast): add walk functions to Visit trait. ( #2791 )
...
closes #2442
2024-03-25 10:44:29 +08:00
Boshen
ef1108a749
chore: Rust v1.77.0 ( #2781 )
2024-03-21 17:21:57 +00:00
overlookmotel
e793063f75
perf(parser): faster lexing JSX identifiers ( #2557 )
...
Speed up lexing JSX identifier continuations (i.e. after `-`), by
searching for end of identifier byte-by-byte.
Change does not register on benchmarks, only because benchmarks don't
contain any `<Foo-Bar />` identifiers, so don't exercise this code path.
2024-03-18 12:06:27 +00:00
Boshen
798a1fde09
fix(parser): fix failed to parse JSXChild after JSXEmptyExpression ( #2726 )
...
fixes #2723
2024-03-15 13:39:20 +08:00
Boshen
a5ddb5b452
Release crates v0.10.0
2024-03-14 18:23:34 +08:00
Boshen
697b6b70c0
feat: merge features serde and wasm to serialize ( #2716 )
...
This PR merges the previous confusing features `serde` and `wasm` into a
single `serialize` feature.
We'll eventually do serialize + type information for both wasm and napi
targets.
`oxc_macros` is removed from `oxc_ast`'s dependency because it requires
`syn` and friends, which goes against our policy ["Third-party
dependencies should be
minimal."](https://oxc-project.github.io/docs/contribute/rules.html#development-policy )
2024-03-14 17:13:12 +08:00
Boshen
0f86333437
refactor(ast): refactor Trivias API - have less noise around it ( #2692 )
2024-03-12 20:16:36 +08:00
Boshen
86ee074678
fix(parser): remove all duplicated comments in trivia builder ( #2689 )
2024-03-12 17:51:22 +08:00
Boshen
cda9c93436
fix(parser): improve lexing of jsx identifier to fix duplicated comments after jsx name ( #2687 )
2024-03-12 15:51:51 +08:00
Boshen
6c6adb46d1
fix(ast): parse rest parameter with the correct optional and type annotation syntax ( #2686 )
...
closes #2653
2024-03-12 15:47:22 +08:00
Boshen
8a73d18fcf
chore(parser): make sure all span.end >= span.start ( #2681 )
...
closes #2679
2024-03-11 19:49:51 +08:00
Arnaud Barré
b378e7ecc9
fix(parser): fix span for JSXEmptyExpression with comment ( #2673 )
...
[playground](https://oxc-project.github.io/oxc/playground/?code=3YCAAICVgICAgICAgICejwtjmCpbllbPawdM2eEFKwhGb62iFlQWu39yrLCA )
---------
Co-authored-by: Boshen <boshenc@gmail.com>
2024-03-11 10:50:33 +00:00
Arnaud Barré
82260318a9
fix(parser): fix span start for return type in function type ( #2660 )
...
This matter for code like. This matches the behavior of both Babel and
TSESLint.
```ts
export type Plugin = (
a: string
) => // Comment
number
```
[TSESLint](https://ast.sxzz.moe/#eNo9jMEKwjAMQH8l5KQw2X0wL/6AB/HUS61hVNq0pKkoY/9u52C35L3kzRhwwJd92+LEZ8UOcwP6zbSBE5XgeeWucfrkJAqrhmuok2cY4WAYwA5QVDxPho8wnqHv4ZJiJFbDXOODpCVSS8zrtcGSqji6tZDBoe0xPWtoc7dpctHeSYpPvPlglYruXixP/0+VSoYXXH53+0Kk )
[OXC](https://oxc-project.github.io/oxc/playground/?code=3YCAAIC5gICAgICAgICyHorESipoTp3admelrvvzLVu5WllVkMM9n7p1s27YYhddDchOGSC6foF%2BGw%2B1Mfo7DYhiNueGpuc27%2F3gf2tToIA%3D )
2024-03-10 13:32:25 +08:00
Arnaud Barré
c3477de64e
fix(ast)!: rename BigintLiteral to BigIntLiteral ( #2659 )
...
This matches the case for the name in Babel. (in ESTree everything is a
`Literal`)
2024-03-10 13:31:51 +08:00
Arnaud Barré
b453a072cc
fix(parser): parse named rest element in type tuple ( #2655 )
...
This is fixing the parser for `type X = [...args: string[]];`
In TSESLint TSNamedTupleMember in part of the TSType union, so I did the
same.
2024-03-10 13:25:15 +08:00
Arnaud Barré
776812315d
fix(parser)!: drop TSImportEqualsDeclaration.is_export ( #2654 )
...
This is one point where Babel and TSESLint diverge. For linter purposes
TSESLint structure makes more sense and that the reason of
https://github.com/typescript-eslint/typescript-eslint/issues/4130
The remaining `is_export` was creating redundant information and made
prettier (and the WIP oxc/prettier) print the AST of `export import X =
Y` as `export export import X = Y`.
2024-03-10 13:22:18 +08:00
Boshen
32303b20fb
New tool: oxc_module_lexer ( #2650 )
...
# Oxc Module Lexer
This is not a lexer. The name "lexer" is used for easier recognition.
## [es-module-lexer](https://github.com/guybedford/es-module-lexer )
Outputs the list of exports and locations of import specifiers,
including dynamic import and import meta handling.
Does not have any
[limitations](https://github.com/guybedford/es-module-lexer?tab=readme-ov-file#limitations )
mentioned in `es-module-lexer`.
I'll also work on the following cases to make this feature complete.
- [ ] get imported variables
https://github.com/guybedford/es-module-lexer/issues/163
- [ ] track star exports as imports as well
https://github.com/guybedford/es-module-lexer/issues/76
- [ ] TypeScript specific syntax
- [ ] TypeScript `type` import / export keyword
## [cjs-module-lexer](https://github.com/nodejs/cjs-module-lexer )
- [ ] TODO
## Benchmark
This is 2 times slower than `es-module-lexer`, but will be significantly
faster when TypeScript is processed.
The difference is around 10ms vs 20ms on a large file (700k).
2024-03-09 23:23:55 +08:00
Boshen
265b2fb640
feat: miette v7 ( #2465 )
2024-03-08 15:50:00 +08:00
magic-akari
2a235d3b8c
fix(ast): parse with_clause in re-export declaration ( #2634 )
2024-03-07 14:09:31 +08:00
Boshen
240ff19675
refactor(parser): improve parsing of BindingPattern in TypeScript ( #2624 )
...
closes #2622
2024-03-06 16:16:03 +08:00
overlookmotel
0646bf34fa
refactor: rename CompactString to CompactStr ( #2619 )
...
Preparatory step for #2620 .
This PR purely changes names of types and methods:
* `CompactString` -> `CompactStr`
* `Atom::to_compact_string` -> `to_compact_str`
* `Atom::into_compact_string` -> `into_compact_str`
Have split this into a separate PR as the diff is large, but it does absolutely nothing but renaming (I've checked the whole diff twice, so feel free not to check it again!). This should make it easier to see the content of the substantive change in #2620 .
2024-03-06 12:24:23 +08:00
Boshen
cca6eb073c
Release crates v0.9.0
2024-03-05 15:57:31 +08:00
Boshen
bf42158ad7
perf(parser): inline end_span and parse_identifier_kind which are on the hot path ( #2612 )
2024-03-05 15:39:53 +08:00
Arnaud Barré
97aa9cfd54
fix(parser): fix span end for TSEmptyBodyFunctionExpression ( #2606 )
...
https://oxc-project.github.io/oxc/playground/?code=3YCAAICXgICAgICAgICxG4jI43W9aqTWr3WzyAs1pNu4fnf%2FXXEB3Yt%2FfiBIgA%3D%3D
The conformance test are going back to initial state. I think the `.asi`
should be smarter, i can rethink that later
---------
Co-authored-by: Boshen <boshenc@gmail.com>
2024-03-05 12:45:11 +08:00
Boshen
e2d2ce3369
feat(parser): parse decorators properly ( #2603 )
...
closes #2562
2024-03-04 19:30:41 +08:00
Boshen
20c7bf7835
feat(ast): add AssignmentTargetRest ( #2601 )
...
closes #2598
2024-03-04 14:31:22 +08:00
Boshen
9cc960e591
fix(parser): fix duplicated comments during parser rewind ( #2600 )
...
closes #2592
2024-03-04 14:07:33 +08:00
Arnaud Barré
24d46bccb5
fix(parser): fix span start for TSModuleDeclaration ( #2593 )
...
[playground](https://oxc-project.github.io/oxc/playground/?code=3YCAAICZgICAgICAgICymcgR7351T2PErukD7UXVyom%2F90VSbC7jSaCgoj9%2BqCyA )
---------
Co-authored-by: Boshen <boshenc@gmail.com>
2024-03-04 04:29:32 +00:00
Arnaud Barré
f66059e91b
fix(ast)!: align TSImportType with ESTree ( #2578 )
...
Implements
https://github.com/typescript-eslint/typescript-eslint/issues/2998
The copy of props feels wrong, but could not get it working otherwise
with the box and borrow things 😅
Also I found that TSImportType was missing some entries for visitors and
codegen.
In the case of codegen I'm not really understand the need as all the
types seems to be dismissed?
2024-03-04 12:28:18 +08:00
Arnaud Barré
ac520d01a9
fix(parser): fix span start for TSExportAssignment ( #2594 )
...
[playground](https://oxc-project.github.io/oxc/playground/?code=3YCAAIDRgICAgICAgICymcgR7351T2PErukD7UXVyom%2F90V9gN2l18vERCm6ABJAvuZFDanGfdTjE8wAVsdwZMQHIswA2DgraPxXUAF2ua%2F8b0XoyRw%2FfyXZIIA%3D )
2024-03-04 11:41:23 +08:00
Arnaud Barré
d9cc429d4a
fix(parser): parse empty method declaration as TSEmptyBodyFunctionExpression ( #2574 )
...
That a tricky one, because it's time to decide what does ESTree
compliant means in the TS world (re #2463 )
This code:
```ts
export declare class ByteBuffer {
clear(): void;
// ^^
}
```
- Is parsed by
[Babel](d38530204e4ea4e2feb5https://github.com/typescript-eslint/typescript-eslint/pull/1289 )
- By
[OXC](https://oxc-project.github.io/oxc/playground/?code=3YCAAIC1gICAgICAgICyHorESipoTXPdvBaE9wxzlOraoWs19SUxDvdcwSVU0kbBO2b7ppX3x2P5IhQlpGHOYEHNCEfLf38HUICA )
as `TSDeclareFunction`
I'm going the easy way to fix this to the Babel way, but I think
following TS-ESLint would make sense. There is an [open babel
issue](https://github.com/babel/babel/issues/13878 ) about that.
Edit: Ok that not so easy and require updating some logic.
---------
Co-authored-by: Boshen <boshenc@gmail.com>
2024-03-03 13:59:17 +00:00
Boshen
9479865d9b
feat(napi/parser): expose preserveParans option ( #2582 )
...
closes #2576
2024-03-03 15:18:47 +08:00
Arnaud Barré
637cd1dea4
fix(ast): support TSIndexSignature.readonly ( #2579 )
...
[playground](https://oxc-project.github.io/oxc/playground/?code=3YCAAIDKgICAgICAgIC0GwpuZs97oWDqPM4xvCuoRB73mPOSrYb%2BTQEZf3b8RF0G%2B60jF5tYXUE9Me2%2FmMqVEwVy%2FiBIlyIMX6PqBpqsSmIXTJcsRqi4f3%2Bj6ICA )
2024-03-03 14:58:57 +08:00
Arnaud Barré
258b9b1c14
fix(ast): support FormalParameter.override ( #2577 )
...
This
[code](https://oxc-project.github.io/oxc/playground/?code=3YCAAIC1gICAgICAgICxG4jI43W9aqTWr3WzyA0TqSOjtB34F78iblvTQruFcqR6BUbbiLtWhj5rEL0NnFkDs4pF3dHiw39X7YCA )
can't be represented in the current OXC AST:
```ts
class Foo {
constructor(override bar: string) {}
}
```
2024-03-03 14:41:42 +08:00
Arnaud Barré
78f30bc2db
fix(ast): change TSMappedType.type_annotation from TSTypeAnnotation to TSType ( #2571 )
...
Is ESTree, in that special case, there is no TSTypeAnnotation wrapper:
(See `type X` in each)
- [oxc
playground](https://oxc-project.github.io/oxc/playground/?code=3YCAAIAWgICAgICAgICyHorESipoToAAwTlix58geR2%2Beeu9rZHQZOqK%2B%2BX85ZQ9ldchOoVw2oAm2qi9okF3bJ9o4l78ENP3f%2Bc%2B8cIK6Itp%2B3SIInU72Vk0%2FSqawy1VNV5zTgBr7gOpGtUZsvkc12Yp8MC2shel9fbpgDySpYsWdgDhf3jVlIA%3D )
- [astexplorer TSESLint
parser](9fc767f3a59a4b02fae1
2024-03-03 14:38:45 +08:00
Arnaud Barré
32028eb1c5
fix(parser): TSConditionalType span start ( #2570 )
...
Span start should be the checkType.start
(as all my PR, I try to make it work, don't hesitate to close and to it
in a better way)
[playground](https://oxc-project.github.io/oxc/playground/?code=3YCAAIDFgICAgICAgIC6nsrEgtelB%2FCnUFVHa8WBImPvKP4Ye3U5jBKASUfm8OtkXZASTLptdPlvM%2Fult4BgRbjIq3Yts9L2pZ%2FhVs8hMF%2Bwpqd%2FfdHggA%3D%3D )
2024-03-03 06:25:55 +00:00
Arnaud Barré
670081050f
fix(parser): set span end for TSEnumDeclaration ( #2573 )
...
[playground](https://oxc-project.github.io/oxc/playground/?code=3YCAAIDHgICAgICAgICyHorESipoTXPdvBaE9wxyPnC9nb7Q6xEpIf3AzkuhOU2arZOLF1u08q1G2hs5klxiUYA6%2BBkL693d0iAZC%2BUFyne3yIKPv32k8IA%3D )
(Tell me if you prefer that I group this kind of small fixes together)
2024-03-03 13:54:43 +08:00
Arnaud Barré
8a81851bf3
fix(parser): don't parse null as a literal type ( #2572 )
...
See playgrounds:
-
[oxc](https://oxc-project.github.io/oxc/playground/?code=3YCAAIDbgICAgICAgIC6nsrEgteLFrCnQnPuEizmC%2BDQ8C8bP9fXPj%2B7%2FjjmRZPvpAH3N7PfIPDu7RDOlrl79cHiork8WA08r39%2FqpCAgA%3D%3D )
-
[Babel](3a263be55b
2024-03-03 13:54:16 +08:00
overlookmotel
78f8c2ce7f
perf(parser): lex JSXText with memchr ( #2558 )
...
Lexing JSXText only requires searching for 2 possible characters (`<`
and `{`), so can use `memchr`.
2024-03-01 22:26:53 +08:00
overlookmotel
dd31c6453a
refactor(parser): byte_search macro evaluate to matched byte ( #2555 )
...
Change behavior of `byte_search!` macro, to make it easier to understand and use:
1. `handle_match` removed. Macro instead evaluates to the first matching byte.
2. `handle_eof` does not return from enclosing function.
3. Alter syntax to make clear that `continue_if` and `handle_eof` are not closures, so can use `return` statements in them.
These changes enabled by #2552 .
2024-03-01 21:28:39 +08:00
overlookmotel
c579620701
refactor(parser): small efficiencies in byte_search macro usage ( #2554 )
...
A few small efficiencies in usage of `byte_search` macro for lexing comments.
2024-03-01 21:23:34 +08:00
overlookmotel
18cff6aab8
refactor(parser): remove start params for byte_search macro arms ( #2553 )
...
Simplify `byte_search` macro a bit more.
2024-03-01 21:15:27 +08:00
overlookmotel
34ecdd58d8
refactor(parser): simplify byte_search macro ( #2552 )
...
This PR greatly simplifies the `byte_search!` macro.
Mainly removing `cold_branch()` from the "not enough bytes remaining for a batch" branch, which allows refactoring so that `handle_match` and `continue_if` don't need to be repeated twice.
Result for performance is inconsistent - a little better on some benchmarks, a little worse on others. But not by significant amounts either way. In my view, the benefit of making the macro simpler outweighs a small speed loss anyway.
2024-03-01 21:07:39 +08:00
overlookmotel
ddccaa1af9
refactor(parser): remove unsafe code in lexer ( #2549 )
...
Same as #2527 . Just remove some unnecessary unsafe code, no substantive
changes.
2024-02-29 15:00:08 +00:00
