overlookmotel
eb71a32ee7
refactor(ci): transform conformance snapshot include when output mismatch ( #5135 )
...
Include "Output mismatch" in transform conformance snapshots when a test also fails due to scopes/symbols mismatches.
At present, many of the tests are failing on scopes/symbols mismatches, so it's hard to see from snapshots which also have an output mismatch. In particular, when working to fix scope mismatches, it's hard to notice if changes you make cause the output to be wrong. These extra messages make that visible.
2024-08-24 04:52:14 +00:00
overlookmotel
be42b1c76b
fix(ci): transform conformance do not skip any errors ( #5134 )
...
Snapshots generated by transform conformance were missing a few errors (e.g. `declarations/const-enum/input.ts` at bottom of diff). Make sure all errors fail the test.
2024-08-24 04:52:11 +00:00
DonIsaac
36e4a2875c
fix(linter/no-unused-vars): panic in variable declarator usage checks ( #5160 )
...
Part of #5129
2024-08-24 04:49:30 +00:00
Dunqing
e3561127fe
chore(semantic): remove accidentally left comment ( #5162 )
2024-08-24 00:41:01 -04:00
Boshen
d5a494023e
refactor(semantic): rewrite handling of label statement errors ( #5138 )
...
This reverts the previous changes to handling labels so that all tests can pass.
This passes all false postivies found in `monitor-oxc` (node_modules/flow-parser/flow_parser.js)
As it turns out this requires less code and produces better diagnostics.
2024-08-24 02:37:49 +00:00
overlookmotel
960e1d5c60
refactor(ast): rename IdentifierReference::new_with_reference_id ( #5157 )
...
The old name `new_read` no longer makes sense as it doesn't set a read-only flag any more, since `flags` field was removed from `IdentifierReference`.
2024-08-24 02:34:18 +00:00
Cameron
22d57f9e5e
feat(linter/unicorn): add fixer to prefer-string-slice ( #5150 )
2024-08-23 21:37:35 -04:00
camc314
34bfaf6792
feat(linter/react): add fixer to jsx-props-no-spread-multi ( #5145 )
2024-08-23 23:43:53 +00:00
overlookmotel
5136f011d9
refactor(transformer): remove unnecessary type annotation ( #5131 )
...
Remove unnecessary type annotation introduced in #4925 .
2024-08-23 23:10:38 +00:00
overlookmotel
f63b568c48
refactor(ast): remove #[non_exhaustive] attr from AstBuilder ( #5130 )
...
Partially revert #4925 . That PR's description gave no explanation of why this attribute is desirable.
2024-08-23 23:04:28 +00:00
Cameron
2fe44153ac
feat(linter/unicorn): add fixer to no-redundant-roles ( #5146 )
2024-08-23 17:38:24 -04:00
Cameron
d35c6f5dfc
feat(linter/unicorn): add fixer to prefer-regexp-test ( #5151 )
2024-08-23 17:34:06 -04:00
Cameron
27db769b8a
feat(linter/unicorn): add fixer to text-encoding-identifier-case ( #5154 )
2024-08-23 17:29:19 -04:00
Cameron
7eb052e0d4
fix(linter): no-hex-escape fixer removing regex flags ( #5137 )
...
closes #5127
2024-08-23 20:32:34 +01:00
DonIsaac
1ce9630c72
feat(linter/config): implement FromIterator for LintPluginOptions ( #5102 )
...
Part of #5046
2024-08-23 18:55:58 +00:00
DonIsaac
33599b0064
refactor(linter): split options into multiple files ( #5101 )
2024-08-23 18:55:57 +00:00
camc314
56a68f542d
fix(linter) fix bug in fixer for func-name ( #5136 )
...
closes #5128
2024-08-23 18:46:04 +00:00
Boshen
7cc2bbd293
chore(semantic): print errors from examples/simple.rs
2024-08-23 22:57:26 +08:00
Boshen
4c88997727
comment just ast
2024-08-23 21:42:21 +08:00
DonIsaac
b894d3b33e
feat(linter)!: make no-unused-vars correctness ( #5081 )
...
closes #5080
2024-08-23 13:12:59 +00:00
Dunqing
47e69a8c94
fix(transformer-optional-catch-binding): the unused binding is not in the correct scope ( #5066 )
...
Blocked by #5008
In the SemanticBuilder, we insert all CatchClause parameters in the BlockStatement scope, a child-scope of CatchClause
858f510d59/crates/oxc_semantic/src/builder.rs (L709-L718)#5008 solved
2024-08-23 13:02:53 +00:00
overlookmotel
eba5033a58
refactor(traverse): codegen ChildScopeCollector ( #5119 )
...
Codegen `ChildScopeCollector`, so that if more types have scopes added, we don't forget to add them (like the problem #5118 fixed).
The methods are in different order in the generated version, but otherwise identical to before this PR.
`visit_finally_clause` has to be added manually, as `oxc_traverse` codegen does not read or understand `#[visit(as)]` attrs.
2024-08-23 12:49:33 +00:00
overlookmotel
25d6e20bba
fix(traverse): add missing visitors to ChildScopeCollector ( #5118 )
...
`ChildScopeCollector` was missing visitors for a few nodes which have recently had scopes added to them.
2024-08-23 12:49:33 +00:00
overlookmotel
f771d7c402
refactor(traverse): remove unnecessary imports ( #5116 )
...
`Atom`, `SourceType` and `Span` from `oxc_span`, and operators from `oxc_syntax` are now re-exported from `oxc_ast` crate. Remove unnecessary `use` statements by importing them all from `oxc_ast`.
2024-08-23 12:49:32 +00:00
overlookmotel
c6590aeee3
refactor(traverse): move generated files into separate folder ( #5115 )
...
Move generated files in `oxc_traverse` crate into separate folder, to match `ast_tools`.
Also amend the header on generated files to match files generated by `ast_tools`.
2024-08-23 12:49:31 +00:00
camc314
525d664aa9
fix(linter) false positive in jest/no-untyped-mock-factory ( #5123 )
...
part of https://github.com/oxc-project/oxc/issues/5103
2024-08-23 12:45:23 +00:00
camc314
b7ba9c01a1
fix(linter) fix bug in fixer for prefer-function-type when interface is exported ( #5122 )
...
part of https://github.com/oxc-project/oxc/issues/5103
2024-08-23 12:45:22 +00:00
Jelle van der Waa
f7958c4cc2
feat(linter/unicorn): add prefer-structured-clone ( #5095 )
2024-08-23 12:34:52 +01:00
Boshen
ff7fa987db
fix(diagnostics): improve "file is too long to fit on the screen" ( #5120 )
...
closes #4322
Setting the threshold to 1200 because graphical output may contain ansi escape codes and other decorations.
2024-08-23 11:17:12 +00:00
Boshen
76c66b4326
fix(linter/max-lines): point span to end of file for disable directive to work ( #5117 )
...
closes #4101
2024-08-23 10:20:17 +00:00
overlookmotel
fc2e9adeff
refactor(traverse): remove support for #[scope(if(...))] attr ( #5114 )
...
Closes #5008 .
There are no longer any nodes with conditional scopes. Remove support for `#[scope(if(...))]` attr from `oxc_traverse` codegen - it's no longer needed.
2024-08-23 09:28:18 +00:00
overlookmotel
8650d3e773
refactor(ast_tools): remove support for #[scope(if(...))] attr ( #5113 )
...
There are no longer any nodes with conditional scopes. Remove support for `#[scope(if(...))]` attr from `ast_tools` - it's no longer needed.
2024-08-23 09:28:17 +00:00
overlookmotel
1ba11a34ab
refactor(traverse): refactor ChildScopeCollector ( #5112 )
...
Refactor `ChildScopeCollector`. Now that all scopes are unconditional, can move shared logic into a common method.
2024-08-23 09:28:15 +00:00
overlookmotel
40e2f6e25c
refactor(traverse): remove unnecessary branch in ChildScopeCollector ( #5111 )
...
Fix a mistake in `ChildScopeCollector`. `Class` always has a scope. No need to check whether it does.
2024-08-23 09:28:14 +00:00
overlookmotel
c100826b42
refactor(semantic)!: always create a scope for for statements ( #5110 )
...
Part of #5008 . Make scopes for `ForStatement`, `ForInStatement` and `ForOfStatement` unconditional. i.e. always create a scope, even if there is no lexical binding (e.g. `for (i of a) {}`).
2024-08-23 09:28:13 +00:00
overlookmotel
d304d6f973
refactor(semantic)!: always create a scope for CatchClause ( #5109 )
...
Part of #5008 . Make scope for `CatchClause` unconditional. i.e. always create a scope, even if there is no catch parameter.
2024-08-23 08:30:27 +00:00
Boshen
dd3ad4d68e
chore(regular_expression): remove circular dependency
...
Error: Circular dependency detected: oxc_parser -> oxc_regular_expression
2024-08-23 16:16:10 +08:00
Boshen
fc4eba5096
chore: publish oxc_regular_expression
2024-08-23 16:16:10 +08:00
overlookmotel
91343913ca
fix(semantic): transform checker check unresolved references ( #5096 )
...
Transform checker check root unresolved references.
The transform checker is now checking pretty much everything it can.
Only fields of `ScopeTree` and `SymbolTable` that it's *not* checking are those which contain `AstNodeId`s, because transformer does not create node IDs at present:
* `ScopeTree::node_ids`
* `SymbolTable::declarations`
* `Reference::node_id`
Checking also only proceeds in "from AST" direction.
i.e. for each `SymbolId` which appears in the AST, we check everything about that symbol. But we *don't* go through all the "rows" in `SymbolTable` and check if there are any extra symbols in the table which aren't in the AST.
Presumably transformer will leave a lot of old symbols lying around in `SymbolTable` (ditto scopes and references). We'd need to add `ScopeFlags::Deleted`, `SymbolFlags::Deleted` and `ReferenceFlags::Deleted` for the transformer to be able to "delete" existing symbols.
2024-08-23 07:52:30 +00:00
Boshen
56cc4818b5
chore(website): remove textlint annotation
...
the website no longer uses textlint
2024-08-23 15:50:52 +08:00
overlookmotel
13c961c492
refactor(semantic): clean up transform checker ( #5094 )
...
Remove some defunct code and clean up a few bits in transform checker.
2024-08-23 08:37:48 +01:00
overlookmotel
c57e078c71
fix(semantic): transform checker check unbound references ( #5093 )
2024-08-23 08:37:48 +01:00
oxc-bot
0b900110a2
Release crates v0.25.0 ( #5107 )
...
## [0.25.0] - 2024-08-23
- 78f135d#5077 ) (Boshen)
- f2b8d82#5058 ) (overlookmotel)
- 5f4c9ab#5030 ) (overlookmotel)
- 58bf215#5025 ) (overlookmotel)
- c4c08a7#5024 ) (overlookmotel)
- d262a58#5023 ) (overlookmotel)
- c30e2e9#5019 ) (overlookmotel)
- ce4d469#5001 )
(Boshen)
- b2ff2df#5000 ) (Boshen)
- f88970b#4859 ) (Burlin)
### Features
- 714373d#5005 )
(overlookmotel)
- 6800e69#4954 ) (Boshen)
- 2b21be3#4979 )
(IWANABETHATGUY)
- afe728a#4998 )
(Boshen)
- 4b49cf8#5087 )
(Boshen)
- f51d3f9#4975 ) (Dunqing)
- f794870#4974 ) (Dunqing)
- 72ff2c6#4972 ) (Dunqing)
- 6b885fe#4965 )
(Dunqing)
### Bug Fixes
- 7f3129e#5004 ) (overlookmotel)
- 1bd9365#5035 ) (Boshen)
- 185eb20#4935 ) (michaelm)
- 2a5e15defbdced#5069 )
(Boshen)
- ad2be97#5041 ) (heygsc)
- d5de97d#5092 )
(overlookmotel)
- 90c74ee#5090 )
(overlookmotel)
- a8005b9#5089 ) (overlookmotel)
- 205bff7#5088 )
(overlookmotel)
- 4a57086#5078 )
(overlookmotel)
- ea7d216#5076 )
(overlookmotel)
- 1b6b27a#5074 )
(overlookmotel)
- 6d87b0f#5071 )
(Boshen)
- 05fff16#5057 )
(overlookmotel)
- f187b71#5056 )
(overlookmotel)
- b52c6a4#5055 )
(overlookmotel)
- da64014#5054 ) (overlookmotel)
- 67d1a96#5052 )
(overlookmotel)
- 863b9cb#5040 )
(overlookmotel)
- 47029c4#5038 ) (overlookmotel)
- 6ffbd78#4987 ) (overlookmotel)
- a8dfdda#4986 ) (overlookmotel)
- 1467eb3#4985 ) (overlookmotel)
- 1365feb#4984 ) (overlookmotel)
- edacf93#4983 )
(overlookmotel)
- 3b35332#5047 ) (Dunqing)- b7db235#5003 )
(IWANABETHATGUY)
### Documentation
- 178d1bd#5084 ) (Dunqing)
- d50eb72#5064 ) (Dunqing)
- 4425b17#5012 ) (Dunqing)
- 1bd5853#4993 )
(overlookmotel)
### Refactor
- a4247e9#5034 )
(overlookmotel)
- cca7440#4988 ) (overlookmotel)
- 4012260#4977 ) (overlookmotel)
- 96422b6#4925 ) (DonIsaac)
- ca70cc7#5028 ) (overlookmotel)
- 0f64d10#5007 ) (IWANABETHATGUY)
- cd9cf5eb4407c49da6a21#5091 ) (overlookmotel)
- fb46eaf#5082 )
(overlookmotel)
- a00bf18#5079 )
(overlookmotel)
- b14a302#5075 ) (overlookmotel)
- b8c6ce5#5072 )
(overlookmotel)
- 7156fd2#5053 )
(overlookmotel)
- 0ba6f50#5051 )
(overlookmotel)
- ee7ac8b#5050 ) (overlookmotel)
- 4e1f4ab#5048 )
(overlookmotel)
- c1da574#5045 )
(overlookmotel)
- 8cded08#5044 ) (overlookmotel)
- 602244f#5043 )
(overlookmotel)
- ae94b9a#5042 ) (overlookmotel)
- 586e15c#5039 )
(overlookmotel)
- d69e34e#5037 ) (overlookmotel)
- 4336a32#5032 ) (overlookmotel)
- 83dfb14#5031 )
(overlookmotel)
- 3b7de18#5027 ) (overlookmotel)
- 0bacdd8#5026 )
(overlookmotel)
- 896b92f#5009 ) (overlookmotel)
- d677b8e#4962 ) (overlookmotel)
- a7ef30d#4960 ) (overlookmotel)
- 59d15c7#4959 ) (overlookmotel)
- 7706523#4978 )
(overlookmotel)
- 4fdf26d#4969 ) (Boshen)
- 8d15e65#5006 )
(overlookmotel)
- 4796ece#4982 ) (overlookmotel)
- a9fcf29#5085 ) (Dunqing)
- deda6ac#5065 ) (Dunqing)
- 9df2f80#4973 ) (Dunqing)
- 3f9433c#5013 ) (Dunqing)
- c60a50d#5086 ) (Dunqing)
- bcc8da9#5014 ) (Dunqing)
- 38d4434#4996 ) (Dunqing)
### Testing
- 0df1a94
2024-08-23 15:37:36 +08:00
Dunqing
8cf8f7a58a
feat(traverse): add is_static method to TraverseCtx, which is moves out from SymbolTable ( #5067 )
...
The [scope.isStatic](419644f27c/packages/babel-traverse/src/scope/index.ts (L557)
2024-08-23 07:14:08 +00:00
leaysgur
c7b81f5762
chore(regular_expression): Update example to support RegExp constructor ( #5106 )
...
- Fix example to handle `new RegExp()` too
- Update NOTE comments
- - -
Until I tried interacting with the actual AST parsed by `oxc_parser`, I thought that the current `oxc_regular_expression` lacked support for the `RegExp` constructor due to escape sequences.
This was because `"\""` remained `"\""` after reading the source text from `.js` files.
However, once it was parsed by `oxc_parser`, I found that everything was [resolved](8ef85a43c0/crates/oxc_parser/src/lexer/string.rs👏🏻 )
Now there is nothing to worry about. 😌
2024-08-23 04:57:32 +00:00
Boshen
aa7718ab7b
feat(transform_conformance): show printed output alongside with errors ( #5105 )
...
closes #5098
```
cargo run -p oxc_transform_conformance -- --filter logical-assignment/arrow-functions-transform/input.js
Input:
var a;
a ||= () => {};
a &&= () => {};
a ??= () => {};
Expected:
var a;
a || (a = () => {});
a && (a = () => {});
a ?? (a = () => {});
Transformed:
var a;
a || (a = () => {});
a && (a = () => {});
a ?? (a = () => {});
Errors:
x Symbol reference IDs mismatch:
| after transform: SymbolId(0): [ReferenceId(0), ReferenceId(1),
| ReferenceId(2), ReferenceId(3), ReferenceId(4), ReferenceId(5),
| ReferenceId(6), ReferenceId(7), ReferenceId(8)]
| rebuilt : SymbolId(0): [ReferenceId(0), ReferenceId(1),
| ReferenceId(2), ReferenceId(3), ReferenceId(4), ReferenceId(5)]
x Reference flags mismatch:
| after transform: ReferenceId(4): ReferenceFlags(Write)
| rebuilt : ReferenceId(1): ReferenceFlags(Read | Write)
x Reference flags mismatch:
| after transform: ReferenceId(6): ReferenceFlags(Write)
| rebuilt : ReferenceId(3): ReferenceFlags(Read | Write)
x Reference flags mismatch:
| after transform: ReferenceId(8): ReferenceFlags(Write)
| rebuilt : ReferenceId(5): ReferenceFlags(Read | Write)
Passed: true
```
2024-08-23 04:00:45 +00:00
oxc-bot
8ef85a43c0
Release oxlint v0.8.0 ( #5104 )
...
## [0.8.0] - 2024-08-23
- 5f4c9ab#5030 ) (overlookmotel)
- ce4d469#5001 )
(Boshen)
- b2ff2df#5000 ) (Boshen)
- f88970b#4859 ) (Burlin)
### Features
- 2292606#5022 )
(camc314)
- a0effab#4990 )
(Don Isaac)
- cdbfcfb#4849 )
(DonIsaac)
- 915cb4d#4805 ) (camc314)
- 3f28c77#4943 ) (DonIsaac)
- e1582a5#4942 )
(DonIsaac)
- f1e4611#4971 ) (dalaoshu)
- 14bf5d5#4956 ) (dalaoshu)
- ed9a1c4#4951 ) (dalaoshu)
- 7859f58#4955 ) (dalaoshu)
- 841174f#5083 ) (Don Isaac)
### Bug Fixes
- 86d0c0c#5010 ) (DonIsaac)
- 7b99386#4994 )
(DonIsaac)
- 9c64b12#4793 ) (Burlin)
- c43945c#5011 ) (Don Isaac)
- 9354779#5018 ) (DonIsaac)
- 5a55dcf#5029 ) (DonIsaac)
- 4081293#4923 ) (Don Isaac)
- ddf83ff#4945 ) (Earl Chase)
- 508644a#4932 ) (mysteryven)
- e99836d#4944 ) (Don Isaac)
- 5f8a7c2#4949 ) (dalaoshu)
### Documentation
- e331ca0#4997 )
(DonIsaac)
- cd9f1cd#5015 ) (DonIsaac)
### Refactor
- eca6fdb#5100 )
(DonIsaac)
- 06f2d81#4963 ) (overlookmotel)
- 4cb8c37#4947 ) (Don Isaac)
- ca70cc7#5028 ) (overlookmotel)
- 59d15c7#4959 ) (overlookmotel)
### Testing
- c21d735#4922 ) (Don Isaac)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-08-23 11:09:14 +08:00
heygsc
ad2be97078
fix(semantic): incorrect semantic check for label has same name ( #5041 )
...
fix : #5036
---------
Co-authored-by: Boshen <boshenc@gmail.com>
2024-08-23 10:36:12 +08:00
overlookmotel
d5de97d6fe
fix(semantic): transform checker check reference flags ( #5092 )
2024-08-23 00:21:21 +00:00
DonIsaac
eca6fdbffe
refactor(linter): move plugin options into separate struct ( #5100 )
...
Part of #5046
2024-08-23 00:01:21 +00:00
